kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: clang-tools-extra/unittests/clangd/CodeCompleteTests.cpp:2322 +TEST(CompletionTest, CrashOnNullType) { + auto Results = completions(R"cpp( ---------------- nit: WorksWithNullType ? it doesn't seem like crashing CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57093/new/ https://reviews.llvm.org/D57093 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits