kadircet added inline comments.
================
Comment at: clangd/index/Background.cpp:52
+llvm::SmallString<128>
+getShardPathFromFilePath(llvm::SmallString<128> ShardRoot,
+ llvm::StringRef FilePath) {
----------------
sammccall wrote:
> nit: these micro-optimizations with SmallString seem unlikely to be
> worthwhile - maybe just take StringRef and return string?
It wasn't for optimization purposes actually, sys::path::append only accepts a
SmallString and there is no direct conversion between SmallString and
std::string(or stringref).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54269
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
