[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3233 + + ``QualifierAlignment`` COULD lead to incorrect code generation. + simon.giesecke wrote: > This is pretty unclear, for a number of reasons: > * First, this prob

[PATCH] D110833: [clang-format] Add ControlStatementsAndFunctionDefinitionsExceptControlMacros option to SpaceBeforeParens

HazardyKnusperkeks added a comment. In D110833#3033849 , @MyDeveloperDay wrote: > I feel this is going the way of BraceWrapping in that it should be: > > SpaceBeforeParens: > - BeforeMacro: false > - BeforeFunction: true So replace the enum

[PATCH] D110833: [clang-format] Add ControlStatementsAndFunctionDefinitionsExceptControlMacros option to SpaceBeforeParens

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3649 ``SBPO_ControlStatementsExceptForEachMacros`` remains an alias for backward compatibility. crayroud wrote: > MyDeveloperDay wrote: > > Now I look back he

[PATCH] D111000: [clang-format] allow clang-format to be passed a file of filenames so we can add a regression suite of "clean clang-formatted files" from LLVM

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Basically okay, I would have made 3 commits out of it: 1. Add the function to clang-format 2. The code clean up of the python script 3. The additional file generation

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

HazardyKnusperkeks added a comment. Apart from my comments, this looks good to me and I really wonder why it hasn't been pushed. (I would directly use it!) Comment at: clang/include/clang/Format/Format.h:2821 MaxEmptyLinesToKeep == R.MaxEmptyLinesToKeep && +

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks requested changes to this revision. HazardyKnusperkeks added a comment. This revision now requires changes to proceed. Have you rebased your change? It seems that your release notes are still for LLVM 12. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Although I would put it in one test, this is fine by me. Comment at: clang/unittests/Format/NamespaceEndCommentsFixerTest.cpp:1201-1206 +} + +TEST_F(ShortNamespaceLinesTest, + MultipleUnwrapped

[PATCH] D93844: [clang-format] Add possibility to be based on parent directory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25f753c51e7b: [clang-format] Add possibility to be based on parent directory (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo

[PATCH] D96744: clang-format IncludeBlocks: Regroup determination of "main" for framework-style includes fix

HazardyKnusperkeks added inline comments. Comment at: clang/unittests/Tooling/HeaderIncludesTest.cpp:106 +<< "for source file " << FileName; +EXPECT_EQ(Manager.getIncludePriority("", true), 0) +<< "for source file " << FileName; I would also a

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: njames93, MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is t

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:3342-3346 inline std::error_code parseConfiguration(StringRef Config, FormatStyle *Style, bool AllowUnknownOptions = false) { return parseConfi

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

HazardyKnusperkeks added a comment. In D96760#2565171 , @njames93 wrote: > I did have another plan for a different way to go about this, not sure if its > really any better though. > It involved building a vector of the edits the config would apply to its

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

HazardyKnusperkeks updated this revision to Diff 324407. HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added a comment. Added DiagHandlerCtxt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96760/new/ https://reviews.llvm.o

[PATCH] D96896: [clang-format] Respect spaces in line comment section without an active column limit

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before line comment

[PATCH] D96896: [clang-format] Respect spaces in line comment section without an active column limit

HazardyKnusperkeks planned changes to this revision. HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/ContinuationIndenter.cpp:2243 Reflow = true; if (ContentStartColumn + RemainingTokenColumns > ColumnLimit) { LLVM_DEBUG(l

[PATCH] D95017: [clang-format] Add case aware include sorting.

HazardyKnusperkeks added a comment. In D95017#2572578 , @PragmaNull wrote: > In D95017#2572238 , @curdeius wrote: > >> Do you have an idea for better names? >> I see that e.g. MS documentation uses ascending order a

[PATCH] D97137: Bug fix of https://bugs.llvm.org/show_bug.cgi?id=49175

HazardyKnusperkeks added a comment. Just out of curiosity, in which language is `Const` used? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97137/new/ https://reviews.llvm.org/D97137 ___ cfe-commits mail

[PATCH] D97137: Bug fix of clang-format, the AlignConsecutiveDeclarations option doesn't handle pointer properly

HazardyKnusperkeks added a comment. You should mark comments as done, if they are. Does your modification maybe add something to the alignment which is not a declaration? int a; double b; a * b; How is that formatted? Yeah unlikely that something like that is in code, but it could be if

[PATCH] D97137: Bug fix of clang-format, the AlignConsecutiveDeclarations option doesn't handle pointer properly

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. In D97137#2580664 , @darwin wrote: > In D97137#2579669 , > @HazardyKnusperkeks wrote:

[PATCH] D97137: Bug fix of clang-format, the AlignConsecutiveDeclarations option doesn't handle pointer properly

HazardyKnusperkeks added a comment. In D97137#2584417 , @darwin wrote: > Hi guys, thanks for accepting the change. But I don't have commit access of > LLVM. Can someone commit it for me? Can and will do. Need the name and email for the commit. But I wil

[PATCH] D103286: [clang-format] Add PPIndentWidth option

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:2674 + /// \endcode + signed PPIndentWidth; + I've replaced this with `int`, because `signed` results in an exception from `dump_format_style.py`. Repository: rG LLVM

[PATCH] D103245: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations

This revision was automatically updated to reflect the committed changes. Closed by commit rG3e333cc82e42: [clang-format] Fix PointerAlignmentRight with AlignConsecutiveDeclarations (authored by gergap, committed by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D103286: [clang-format] Add PPIndentWidth option

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f605b8d0bc1: [clang-format] Add PPIndentWidth option (authored by gergap, committed by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/D103286?vs=348955&id=349569#toc Repository

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Remains the issue with the alignment, I would like to know @MyDeveloperDay 's opinion on that. Should the values be right aligned, or left aligned? As far as I see all alignment in clang-format is left until now. =

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

HazardyKnusperkeks added a comment. In D104044#2810909 , @darwin wrote: > Sorry, I may need some help here. It shows "Context not available.", how do I > correct it? There are multiple ways: https://llvm.org/docs/Phabricator.html#requesting-a-review-vi

[PATCH] D90238: [clang-format] Added ReferenceAlignmentStyle option - (Update to D31635)

HazardyKnusperkeks added a comment. I think this would be a nice addition, and in the past I would have used it. I really like the option `Pointer`. If this will be pursued I will be happy to review it. Comment at: clang/unittests/Format/FormatTest.cpp:895 + verifyFormat("in

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. In D101868#2810452 , @feg208 wrote: > If I can get someone to submit this on my behalf I think we can call it a day. Please post the name and email for the commit. And if no o

[PATCH] D103678: [Format] Fix incorrect pointer/reference detection

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Do you need some one to commit this? If yes please state name and email, some one will chime in to commit it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103678/new/ https://reviews.llvm.org/D103678 _

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

HazardyKnusperkeks added a comment. In D102706#2787550 , @HazardyKnusperkeks wrote: > LGTM, but please wait for more responses. No one objected, so I declare it ready to commit. Do you need some one to do it? If yes please post name and email for the c

[PATCH] D91950: [clang-format] Add BreakBeforeInlineASMColon configuration

HazardyKnusperkeks added a comment. Then we can push it, do you need some one to do that? If yes please post name and email. Comment at: clang/unittests/Format/FormatTest.cpp:18475 +)", +Style); } I think the pre merge lint means this line. Please fix that an

[PATCH] D99840: [clang-format] Correctly attach enum braces with ShortEnums disabled

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. In D99840#2718959 , @curdeius wrote: > LGTM. I also consider it a bug. LLVM should not be affected as it uses > `AllowShortEnumsOnASingleLine: true` whereas this problem arises

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

HazardyKnusperkeks added a comment. Going the full way, to fix the number of empty lines after/before/between elements would be real nice. But even nicer would be if you can state a range. But I think all those proposed options should not be added in one go. In D104044#2812399

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

HazardyKnusperkeks added a comment. Can you also add tests with the alignment of declarations? We already have such for pointers. Comment at: clang/include/clang/Format/Format.h:2706 + /// references). + ReferenceAlignmentStyle ReferenceAlignment; + Please m

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. Thanks for the work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104096/new/ https://reviews.llvm.org/D104096 ___ cfe-comm

[PATCH] D104044: [clang-format] Fix the issue of no empty line after namespace

HazardyKnusperkeks added a comment. >> In D104044#2812399 , @darwin wrote: >> >>> About the issue, let me explain it. It isn't bound to the google style or >>> LLVM style either, since both of them keep the first brace at the same line >>> of the namespa

[PATCH] D101868: [clang-format] Adds a formatter for aligning arrays of structs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG673c5ba58497: [clang-format] Adds a formatter for aligning arrays of structs (authored by feg208, committed by HazardyKnusperkeks). Repository: rG

[PATCH] D104242: Removes an unused variable and alters a lit test to simplify and avoid a buildbot error

HazardyKnusperkeks added a comment. Could you split this into two diffs? Or are those two changes in any way related? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104242/new/ https://reviews.llvm.org/D104242 _

[PATCH] D104222: [clang-format] [PR50702] Lamdba processing does not respect AfterClass and AfterNamespace

HazardyKnusperkeks added a comment. Just asking: Would it be different if there is `auto`, `decltype(auto)`, `decltype(a+b)`, `typename` or `template` as trailing return type? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104222/new/ https://reviews.llvm.org/D104222 __

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

HazardyKnusperkeks added a comment. In D104096#2820206 , @skirkovski wrote: > Ping, > > I do not have commit access, can someone submit this as time permits ? Please state the name and email for the commit, I will commit it on the weekend. Repository:

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

HazardyKnusperkeks added a comment. In D102706#2823087 , @vlovich wrote: > I don't think I have permissions. Happy to do it if I'm given permissions > (I'm assuming the instructions are the general LLVM ones). Otherwise: > > Name: Vitali Lovich > E-mail:

[PATCH] D93528: [clang-format] Add basic support for formatting JSON

HazardyKnusperkeks added a reviewer: HazardyKnusperkeks. HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Nice trick! :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93528/new/ https://reviews.llvm.org/D9352

[PATCH] D102730: [clang-format] Support custom If macros

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Seems to be okay for me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102730/new/ https://reviews.llvm.org/D102730 ___

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

This revision was automatically updated to reflect the committed changes. Closed by commit rG64cf5eba06bd: [clang-format] Add new LambdaBodyIndentation option (authored by vlovich, committed by HazardyKnusperkeks). Changed prior to commit: https://reviews.llvm.org/D102706?vs=347152&id=353753#to

[PATCH] D104774: [clang-format] Fix a bug that indents else-comment-if incorrectly

HazardyKnusperkeks added a comment. That was fast. I personally like it better to give others a chance to look at. ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104774/new/ https://reviews.llvm.org/D104774 _

[PATCH] D104388: [clang-format] PR50727 C# Invoke Lamda Expression indentation incorrect

HazardyKnusperkeks added a comment. I have basically no idea about C#, thus not much to say. I think if the old tests pass and the new are as expected it is good. Comment at: clang/unittests/Format/FormatTestCSharp.cpp:647 + "Function(Val, (Action)(() => {\n"

[PATCH] D102706: [clang-format] Add new LambdaBodyIndentation option

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:2520 + /// readability to have the signature indented two levels and to use + /// ``OuterScope``. The KJ style guide requires ``OuterScope`. + /// `KJ style guide Here is

[PATCH] D104774: [clang-format] Fix a bug that indents else-comment-if incorrectly

HazardyKnusperkeks added a comment. In D104774#2838287 , @MyDeveloperDay wrote: > @HazardyKnusperkek Its probably my "bad" I should said "LGTM but maybe wait > for the others to comment", but I'm fundamentally ok I think with the change. > (we'll just

[PATCH] D104096: [Clang-Format] Add ReferenceAlignment directive

This revision was automatically updated to reflect the committed changes. Closed by commit rGa08fa8a50819: [Clang-Format] Add ReferenceAlignment directive (authored by Seraphime Kirkovski , committed by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D106349: [clang-format] respect AfterEnum for enums

HazardyKnusperkeks added a comment. In D106349#2914448 , @m1cha wrote: > I don't have commit access. How does that even work? The documentation is > very scarce about this but for security reasons I'd expect there to be a very > limited set of people wi

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

HazardyKnusperkeks added a comment. First off, I think it should be configured in a different way, to prepare the path for also formatting static, inline, etc. If this is kept there should be tests on what happens if there is const or volatile more than once in the string list, and when there a

[PATCH] D69764: [clang-format] Add Left/Right Const fixer capability

HazardyKnusperkeks added a comment. In D69764#2938973 , @MyDeveloperDay wrote: > With the introduction of `CVQualifierOrder` the need for > `CVQualifierAlignment:` doesn't make so much sense > > CVQualifierAlignment: Left > CVQualifierOrder: [ "inlin

[PATCH] D107961: [clang-format] Distinguish K&R C function definition and attribute

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:17 #include "FormatToken.h" -#include "clang/Basic/TokenKinds.h" #include "llvm/ADT/STLExtras.h" Why is this not needed anymore? Repository: rG LLVM Github Monore

[PATCH] D107961: [clang-format] Distinguish K&R C function definition and attribute

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/UnwrappedLineParser.cpp:17 #include "FormatToken.h" -#include "clang/Basic/TokenKinds.h" #include "llvm/ADT/STLExtras.h" owenpan wrote: > HazardyKnusperkeks wrote: > > Why is this not needed

[PATCH] D104900: [clang-format] PR50525 doesn't handle AlignConsecutiveAssignments correctly in some situations

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. Nice. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104900/new/ https://reviews.llvm.org/D104900 ___

[PATCH] D104900: [clang-format] PR50525 doesn't handle AlignConsecutiveAssignments correctly in some situations

HazardyKnusperkeks added a comment. In D104900#2842540 , @darwin wrote: > Sorry I haven't had a chance to look at this bug before it has closed. But I > do have a question: > > I observed that this code are formatted incorrectly by the same config: > >

[PATCH] D104044: [clang-format] Fix the issue that empty lines being removed at the beginning of namespace

HazardyKnusperkeks added a comment. In D104044#2842726 , @darwin wrote: > And can someone commit it for me? I don't have the right to push it yet. Or > let me know how to apply? Thank you very much. https://llvm.org/docs/DeveloperPolicy.html?highlight=c

[PATCH] D105087: [clang-format] PR49960 clang-format doesn't handle ASI after "return" on JavaScript

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. It's a strange language :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105087/new/ https://reviews.llvm.org/D105087 _

[PATCH] D105099: [clang-format] Add an option to put one constructor initializer per line

HazardyKnusperkeks added a comment. In D105099#2847328 , @MyDeveloperDay wrote: > Seem similar to D90232: [clang-format] Formatting constructor initializer > lists by putting them always on different lines (update to D14484) >

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

HazardyKnusperkeks added a comment. I already said I would like that in `clang-format` and would directly add that to my config. I also think that there should be no problem in having that in `clang-format`, include sorting has a bigger chance of breaking code, yeah only with poorly designed h

[PATCH] D105943: [clang-format++] Create a new variant of the clang-format tool to allow additional code mutating behaviour such as East/West Const Fixer

HazardyKnusperkeks added a comment. This could be a way, but I will also state here that I prefer adding it to plain `clang-format`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105943/new/ https://reviews.llvm.org/D105943 __

[PATCH] D69764: [clang-format] Add East/West Const fixer capability

HazardyKnusperkeks added a comment. In D69764#2876916 , @MyDeveloperDay wrote: >> So yes, I'm in favour of landing this patch (though not exactly in the >> current form, I'd prefer more future-proof options for instance, not only >> handling const) > >

[PATCH] D112572: [docs][clang-format] warn on \code block indentation error

HazardyKnusperkeks added a comment. Thanks for fixing my mistake. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112572/new/ https://reviews.llvm.org/D112572 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D112572: [docs][clang-format] warn on \code block indentation error

HazardyKnusperkeks added a comment. In D112572#3089373 , @FederAndInk wrote: > In D112572#3089318 , > @HazardyKnusperkeks wrote: > >> Thanks for fixing my mistake. :) > > You're welcome ;) > > Thanks for your re

[PATCH] D112664: [clang-format][docs] fix indentation of rst code block

HazardyKnusperkeks added a comment. Hi, thanks for you contribution. But the `rst` is generated by a script, the error is in `Format.h`. And we already have a review for an even broader fix: D112572 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D95168: [clang-format] Add InsertBraces option

HazardyKnusperkeks added a comment. In D95168#3099739 , @MyDeveloperDay wrote: > I'd like to carry the mantle for this, before making any further changes I'd > like to address some of the review comments > > 1. Add documentation warning about a modifying

[PATCH] D95168: [clang-format] Add InsertBraces option

HazardyKnusperkeks added a comment. In D95168#3099920 , @owenpan wrote: > In D95168#3099739 , @MyDeveloperDay > wrote: > >> - Look further into possible Removal (I have an idea for how this might be >> possible, a

[PATCH] D112664: [clang-format][docs] fix indentation of rst code block

HazardyKnusperkeks added a comment. In D112664#3101142 , @MyDeveloperDay wrote: > This should be Format.h, didn't we recently fix this? Yes we did, this is from before. :) So it is now obsolete. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D95168: [clang-format] Add InsertBraces option

HazardyKnusperkeks added a comment. In D95168#3102247 , @owenpan wrote: > In D95168#3100969 , @MyDeveloperDay > wrote: > >> In D95168#3099920 , @owenpan wrote: >> >>> In D95

[PATCH] D113000: [clang-format] NOT FOR COMMIT - Demo of AutomaticBraces: Remove

HazardyKnusperkeks added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3230 return false; - } else if (Style.isCSharp()) { -// Require spaces around '{' and before '}' unless they appear in -// interpolated strings. Interpolated strings are mer

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

HazardyKnusperkeks added a comment. Looks good, and I really need this to land, to expand it. ;) Comment at: clang/include/clang/Format/Format.h:3369 +/// \endcode +bool AfterForeachMacros; +/// If ``true``, put a space before opening parentheses only if the ---

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

HazardyKnusperkeks accepted this revision. HazardyKnusperkeks added a comment. This revision is now accepted and ready to land. To me this looks good, if the sorting is finalized. :) Do you need someone to push this for you? If yes please state name and email, if not please wait a few days for o

[PATCH] D95168: [clang-format] Add Insert/Remove Braces option

HazardyKnusperkeks added a comment. Not yet done reviewing everything. Comment at: clang/include/clang/Format/Format.h:946 +/// Remove if there is no comment +BIS_RemoveNoComment + }; Maybe differentiate between single line and multi line comments? =

[PATCH] D95168: [clang-format] Add Insert/Remove Braces option

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:946 +/// Remove if there is no comment +BIS_RemoveNoComment + }; MyDeveloperDay wrote: > HazardyKnusperkeks wrote: > > Maybe differentiate between single line and m

[PATCH] D113319: [clang-format] Improve require handling

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, krasimir, curdeius. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before th

[PATCH] D113319: [clang-format] Improve require handling

HazardyKnusperkeks added a comment. Or am I mistaken and we want to be able to control the line break? Also I would break before struct, class, union, but I would have needed to change the test, and I know that we at least need to talk about in in front. :) template require X class ...

[PATCH] D113320: [clang-format] Address fixme

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, djasper. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLV

[PATCH] D113320: [clang-format] Address fixme

HazardyKnusperkeks updated this revision to Diff 385248. HazardyKnusperkeks marked an inline comment as done. HazardyKnusperkeks added a reviewer: owenpan. HazardyKnusperkeks added a comment. Dropped braces. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D110833: [clang-format] Refactor SpaceBeforeParens to add options

HazardyKnusperkeks added a comment. In D110833#3111632 , @crayroud wrote: > I do not have commit access, could you please help with the push? > > Here are the commit details: C. Rayroud - rayro...@gmail.com Will push it on tuesday, if no one objects. I a

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, owenpan, crayroud. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We can now

[PATCH] D113319: [clang-format] Improve require handling

HazardyKnusperkeks planned changes to this revision. HazardyKnusperkeks added a comment. In D113319#3115202 , @MyDeveloperDay wrote: > I feel anything you do here would be an improvement. its probably worth > looking at recent issues logged around this

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks updated this revision to Diff 385588. HazardyKnusperkeks marked 2 inline comments as done. HazardyKnusperkeks added a comment. Addressed comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113369/new/ https://reviews.llvm.org

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:3756 + * ``bool AfterRequiresClause`` If ``true``, put space between requires keyword in a requires clause and +opening parentheses, if is are one. + curdeius wrote

[PATCH] D113369: [clang-format] Extend SpaceBeforeParens for requires

HazardyKnusperkeks updated this revision to Diff 385594. HazardyKnusperkeks added a comment. Now the new diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113369/new/ https://reviews.llvm.org/D113369 Files: clang/docs/ClangFormatStyleOptions.r

[PATCH] D113320: [clang-format] Address fixme

This revision was automatically updated to reflect the committed changes. Closed by commit rG66336056911e: [clang-format] Address fixme (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113320/new/ https://reviews.llvm.

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

HazardyKnusperkeks added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96760/new/ https://reviews.llvm.org/D96760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D97137: [clang-format] Fix AlignConsecutiveDeclarations handling of pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rGe0b1df924ae0: [clang-format] Fix AlignConsecutiveDeclarations handling of pointers (authored by darwin, committed by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks added a comment. Do you need someone to push this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/ https://reviews.llvm.org/D94500 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

HazardyKnusperkeks added a comment. Is this acceptable to the others? Do you need someone to push it? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87587/new/ https://reviews.llvm.org/D87587 ___ cfe-comm

[PATCH] D96896: [clang-format] Respect spaces in line comment section without an active column limit

HazardyKnusperkeks updated this revision to Diff 326928. HazardyKnusperkeks added a comment. - Work with `::max` instead of many checks for `== 0`. - Additional Testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96896/new/ https://reviews.llvm.

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

HazardyKnusperkeks added a comment. In D87587#2592605 , @kuzkry wrote: >> Do you need someone to push it? > > Yes, I need someone to do that. I don't have write permissions. I'm new here. Please state the name and mail for the commit. I will push it for y

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks added a comment. In D94500#2593229 , @timwoj wrote: > In D94500#2592448 , > @HazardyKnusperkeks wrote: > >> Do you need someone to push this? > > Yes I do. I don't have committer access. Please

[PATCH] D95017: [clang-format] Add case aware include sorting.

HazardyKnusperkeks added a comment. In D95017#2572578 , @PragmaNull wrote: > In D95017#2572238 , @curdeius wrote: > >> Do you have an idea for better names? >> I see that e.g. MS documentation uses ascending order a

[PATCH] D96896: [clang-format] Respect spaces in line comment section without an active column limit

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG418b4a7b3158: [clang-format] Respect spaces in line comment section... (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG6ca52815fb3c: [clang-format][PR47290] Add ShortNamespaceLines format option (authored by kuzkry, committed by HazardyKnus

[PATCH] D87587: [clang-format][PR47290] Add ShortNamespaceLines format option

HazardyKnusperkeks added a comment. In D87587#2597241 , @kuzkry wrote: > Thank you for delivering it, @HazardyKnusperkeks. > > One thing concerns me though. I'm not an author of changes done in > clang/docs/ClangFormatStyleOptions.rst in lines 2372, 3069-

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks added a comment. Could you please rebase your patch an reupload the diff, it doesn't apply anymore. (And doing it by hand is too much work for me.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94500/new/ https://reviews.llvm.or

[PATCH] D96760: [clang-format] Suppress diagnostics on second parse

HazardyKnusperkeks updated this revision to Diff 328075. HazardyKnusperkeks added a comment. Rebased. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96760/new/ https://reviews.llvm.org/D96760 Files: clang/include/clang/Format/Format.h clang/lib

[PATCH] D97927: [clang-format] Rename case sorting

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: kentsommer, curdeius, MyDeveloperDay, PragmaNull. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-comm

[PATCH] D97927: [clang-format] Rename case sorting

HazardyKnusperkeks added a comment. In D97927#2603089 , @curdeius wrote: > LGTM. It's indeed more logical this way. > Hopefully the original author will confirm. I'll give him one week, if he or nobody else comes along to object I'll push it. Repository

[PATCH] D94500: [clang-format] Rework Whitesmiths mode to use line-level values in UnwrappedLineParser

HazardyKnusperkeks added a comment. In D94500#2604754 , @timwoj wrote: > Rebase onto master again `master` or `main`? Please rebase on `main`. That is where the pushes land. (And as far as I can see `master` hasn't been updated in quite some time. Repo

<    1   2   3   4   5   6   7   8   9   10   >