HazardyKnusperkeks accepted this revision.
HazardyKnusperkeks added a comment.
This revision is now accepted and ready to land.
To me this looks good, if the sorting is finalized. :)
Do you need someone to push this for you? If yes please state name and email,
if not please wait a few days for other opinions.
================
Comment at: clang/include/clang/Format/Format.h:3348
+ /// \endcode
+ bool AfterIfMacros;
+ /// If ``true``, put space between foreach macros and opening parentheses.
----------------
Last: This comes just before the Before, I is after F.
================
Comment at: clang/unittests/Format/FormatTest.cpp:14275
+ verifyFormat("A::A() : a (1) {}", SomeSpace2);
+ verifyFormat("void f() __attribute__ ((asdf));", SomeSpace2);
+ verifyFormat("*(&a + 1);\n"
----------------
crayroud wrote:
> HazardyKnusperkeks wrote:
> > Is this really desired?
> It is allowed to have a space after `__attribute__` and the behaviour is the
> same with `SpaceBeforeParens: NonEmptyParentheses`.
Okay.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110833/new/
https://reviews.llvm.org/D110833
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
