HazardyKnusperkeks added a comment.

I have basically no idea about C#, thus not much to say. I think if the old 
tests pass and the new are as expected it is good.



================
Comment at: clang/unittests/Format/FormatTestCSharp.cpp:647
+               "    Function(Val, (Action)(() => {\n"
+               "                 lock (mylock)\n"
+               "                 {\n"
----------------
How is that indention calculated? Is this position fix? Or is it always one 
column less than the (presumably) start of the lambda?

Maybe add a test not with `Val`, but something else as first argument. Or is 
this not valid?

As said, basically no idea about C#.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104388/new/

https://reviews.llvm.org/D104388

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to