alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Comment at: clang-tidy/readability/MisleadingIndentationCheck.cpp:79
+ Finder->addMatcher(
+ compoundStmt(anyOf(has(ifStmt()), has(forStmt()), has(whileStmt(
+
alexfh added a comment.
Gábor, thank you for picking up this patch and finishing it!
https://reviews.llvm.org/D19586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
A few more nits.
Comment at: clang-tidy/modernize/ReturnBracedInitListCheck.cpp:66
+ auto Diag = diag(Loc, "to avoid repeating the return type from the "
+
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Awesome! LG with one nit.
Comment at: clang-tidy/ClangTidyDiagnosticConsumer.cpp:300
+ // Now skip any newlines.
+ // FIXME: We want to skip over exactly one line, not an a
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thank you!
https://reviews.llvm.org/D29928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D29957
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LGTM. Please wait for Aaron as well.
Repository:
rL LLVM
https://reviews.llvm.org/D28768
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
alexfh added inline comments.
Comment at: clang-tidy/misc/ThrowWithNoexceptCheck.cpp:54
+// FIXME use DiagnosticIDs::Level::Note
+diag(NoExceptRange.getBegin(), "in a function declared no-throw here:",
DiagnosticIDs::Note)
+<< FixItHint::CreateRemoval(NoExceptRan
alexfh added a comment.
> it may introduce true positives
True positives is all we need from clang-tidy checks ;) I guess, you meant
"false negatives"
(https://en.wikipedia.org/wiki/False_positives_and_false_negatives).
The main question here is whether we should extend the AST instead of ha
alexfh added a comment.
Richard, it seems like the AST could be improved here by adding nodes for the
explicit instantiation declarations and definitions or using existing nodes, if
there are suitable ones. What do you think?
https://reviews.llvm.org/D30034
_
alexfh added a comment.
In https://reviews.llvm.org/D29806#673489, @ehsan wrote:
> In https://reviews.llvm.org/D29806#673329, @alexfh wrote:
>
> > What's your use case? Can it be addressed by just forwarding the -p flag to
> > clang-tidy?
>
>
> I just need to pass the full path to the compilatio
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D30002
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D29806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thank you for the fix!
https://reviews.llvm.org/D30191
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/
alexfh added a comment.
Ping ;)
Do you have time to finish this?
https://reviews.llvm.org/D21815
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thanks for tracking this down!
https://reviews.llvm.org/D30412
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296598: [clang-tidy] Fix handling of methods with
try-statement as a body in modernize… (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D30002?vs=88582&id=90136#toc
Repository:
alexfh added a comment.
This patch is superseded by https://reviews.llvm.org/D26137.
https://reviews.llvm.org/D16183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
I think, we decided to extend the AST instead of working around its
incompleteness.
https://reviews.llvm.org/D30034
___
cfe-commits ma
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG unless Etienne has any concerns.
https://reviews.llvm.org/D29858
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
alexfh added a comment.
Do you need someone to commit the patch for you?
https://reviews.llvm.org/D29858
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh created this revision.
Herald added a subscriber: JDevlieghere.
Add -format option (disabled by default for now) to trigger formatting
of replacements.
https://reviews.llvm.org/D30564
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/tool/ClangTidyMain.cpp
docs/Re
alexfh updated this revision to Diff 90442.
alexfh added a comment.
Pacify llvm::Expected<> debug checks.
https://reviews.llvm.org/D30564
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/tool/ClangTidyMain.cpp
docs/ReleaseNotes.rst
docs/clang-tidy/index.rst
test/cla
alexfh added inline comments.
Comment at: test/clang-tidy/readability-braces-around-statements-format.cpp:1
+// RUN: %check_clang_tidy %s readability-braces-around-statements %t --
-format --
+
malcolm.parsons wrote:
> Will clang-tidy look for a .clang-format fi
alexfh marked an inline comment as done.
alexfh added inline comments.
Comment at: docs/clang-tidy/index.rst:184
-p= - Build path
+-quiet -
+ Run clang-tidy in quiet mode. This
suppresses
-
alexfh updated this revision to Diff 90445.
alexfh marked an inline comment as done.
alexfh added a comment.
Replace the separate -format and -style options with -format-style (default is
'none', which means no formatting).
https://reviews.llvm.org/D30564
Files:
clang-tidy/ClangTidy.cpp
cla
alexfh updated this revision to Diff 90447.
alexfh added a comment.
Expanded -format-style option description. Run cleanup tests with different
format styles, just in case.
https://reviews.llvm.org/D30564
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/tool/ClangTidyMain.cpp
docs/ReleaseNotes
alexfh added a comment.
In https://reviews.llvm.org/D30564#691446, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D30564#691441, @alexfh wrote:
>
> > Replace the separate -format and -style options with -format-style (default
> > is
> > 'none', which means no formatting).
>
>
> Is there
alexfh updated this revision to Diff 90448.
alexfh added a comment.
Clarify the 'file' option a bit.
https://reviews.llvm.org/D30564
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/tool/ClangTidyMain.cpp
docs/ReleaseNotes.rst
docs/clang-tidy/index.rst
test/clang-tidy/clean-up-code.cpp
te
alexfh added a comment.
PTAL
https://reviews.llvm.org/D30564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh updated this revision to Diff 90452.
alexfh added a comment.
Apply changes even when formatting fails.
https://reviews.llvm.org/D30564
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/tool/ClangTidyMain.cpp
docs/ReleaseNotes.rst
docs/clang-tidy/index.rst
test/clang-tidy/clean-up-code
This revision was automatically updated to reflect the committed changes.
Closed by commit rL296864: [clang-tidy] Format code around applied fixes
(authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D30564?vs=90452&id=90453#toc
Repository:
rL LLVM
https://reviews.llvm.or
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thanks!
Comment at: test/clang-tidy/misc-use-after-move.cpp:285
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: 'a' used after it was moved
- // CHECK-MESSAGES: [[@LINE-3]
alexfh added a comment.
What's the practical use of newlines and tab characters in the glob list?
https://reviews.llvm.org/D30567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added inline comments.
Comment at: test/clang-tidy/misc-use-after-move.cpp:285
// CHECK-MESSAGES: [[@LINE-1]]:3: warning: 'a' used after it was moved
- // CHECK-MESSAGES: [[@LINE-3]]:6: note: move occurred here
+ // CHECK-MESSAGES: [[@LINE-3]]:7: note: move occurred h
alexfh added a comment.
https://docs.python.org/2/howto/regex.html#introduction says "The regex module
was removed completely in Python 2.5.". Why would we want to switch to it?
https://reviews.llvm.org/D30607
___
cfe-commits mailing list
cfe-commi
alexfh added a comment.
Actually, I'm not sure why we need groups in that regex. We can instead try
replacing `re.compile('(' + ')|('.join(args.files) + ')')` with
`re.compile('|'.join(args.files))`.
https://reviews.llvm.org/D30607
___
cfe-commits
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
https://reviews.llvm.org/D30639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. So you won the flappy column game? ;)
https://reviews.llvm.org/D30650
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.ll
alexfh added inline comments.
Comment at:
clang-tools-extra/trunk/test/clang-tidy/modernize-use-nullptr.cpp:254
+
+ void h(T *default_value = 0) {}
+
xazax.hun wrote:
> Maybe as a separate patch, but I think it might be worth to warn here. WDYT?
> (Sorry for t
alexfh added a comment.
In https://reviews.llvm.org/D30650#693165, @Eugene.Zelenko wrote:
> I think we should refactor this check as part of Static Analyzer, since it's
> path-sensitive.
We can think about trying this as a SA checker, but it's irrelevant to this
patch.
https://reviews.llvm.
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Lex/Lexer.cpp:457
+static bool isNewLineEscaped(const char *BufferStart, const char *Str) {
+ while (Str > BufferStart && isWhitespace(*Str))
+
alexfh added inline comments.
Comment at: clang-tidy/cppcoreguidelines/SpecialMemberFunctionsCheck.cpp:184
+ if (!MissingMembers.empty())
+diag(ID.first, "class '%0' defines %1 but does not define %2")
+<< ID.second << join(DefinedMembers, " and ")
A
alexfh added a comment.
BTW, next time please add cfe-commits to subscribers when you create the patch
to get it sent properly to the mailing list.
https://reviews.llvm.org/D30931
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
alexfh added a comment.
I'll try to get back to this code review soon. Sorry for the delay.
Repository:
rL LLVM
https://reviews.llvm.org/D26137
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
alexfh added inline comments.
Comment at: clang-tidy/utils/DeclRefExprUtils.cpp:127
+ match(findAll(declRefExpr(equalsNode(&DeclRef),
+unless(hasAncestor(stmt(anyOf(
+forStmt(), cxxForRangeStmt(), whileStmt(
alexfh added inline comments.
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:173-177
+/// Matches the type that was substituted for the template parameter.
+AST_MATCHER_P(SubstTemplateTypeParmType, hasReplacementType,
+ ast_matchers::internal::Matcher, InnerMatche
alexfh added inline comments.
Comment at: clang-tidy/utils/DeclRefExprUtils.cpp:127
+ match(findAll(declRefExpr(equalsNode(&DeclRef),
+unless(hasAncestor(stmt(anyOf(
+forStmt(), cxxForRangeStmt(), whileStmt(
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thanks!
Repository:
rL LLVM
https://reviews.llvm.org/D27142
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Looks mostly good. A few more nits.
Comment at: include/clang/Tooling/Core/Diagnostic.h:68-71
+ /// A freeform chunk of text to describe the context of the replace
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a comment.
Comment at: include/clang/Tooling/DiagnosticsYaml.h:79
+ for (auto &Diagnostic : Doc.Diagnostics) {
+if (Diagnostic.Fix.size() > 0) {
+
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Thank you for the new check! A few comments.
Comment at:
clang-tools-extra/clang-tidy/performance/TypePromotionInMathFnCheck.cpp:22
+AST_MATCHER_P(Type, isBuiltinT
alexfh added inline comments.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:58
"modernize-use-bool-literals");
-CheckFactories.registerCheck("modernize-use-default");
+
CheckFactories.registerCheck("modernize-use-equals-default");
CheckFactories.r
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/misc/StringCompareCheck.cpp:29
+
+ // First and second case: cast str.compare(str) to boolean
+ Finder->addMatcher(
Pl
alexfh added a comment.
Do you have commit access? If you need me to commit the patch for you, please
rebase it on top of HEAD.
Repository:
rL LLVM
https://reviews.llvm.org/D26137
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
alexfh accepted this revision.
alexfh added a comment.
LG. Looks like a strict improvement.
https://reviews.llvm.org/D27248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
Sorry for the delay. I'll try to get back to this patch soon.
https://reviews.llvm.org/D26418
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added inline comments.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:58
"modernize-use-bool-literals");
-CheckFactories.registerCheck("modernize-use-default");
+
CheckFactories.registerCheck("modernize-use-equals-default");
CheckFactories.r
alexfh added inline comments.
Comment at: clang-tidy/modernize/ModernizeTidyModule.cpp:58
"modernize-use-bool-literals");
-CheckFactories.registerCheck("modernize-use-default");
+
CheckFactories.registerCheck("modernize-use-equals-default");
CheckFactories.r
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG. Thanks!
https://reviews.llvm.org/D26511
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at:
clang-tools-extra/clang-tidy/performance/TypePromotionInMathFnCheck.cpp:62-67
+ Finder->addMatcher(
+ callExpr(callee(functionDecl(TwoDoubleA
alexfh added a comment.
The patch spans two repos, so I couldn't apply it using arcanist. Just made it
"manually" (patch -p0 -i ...); now running tests...
Repository:
rL LLVM
https://reviews.llvm.org/D26137
___
cfe-commits mailing list
cfe-commi
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
Looks like compiler has found a couple of bugs:
In file included from
llvm.git/tools/clang/tools/extra/clang-tidy/ClangTidy.cpp:38:
llvm.git/tools/clang/include/clang/Tooling/Dia
alexfh added a comment.
Have you run the tests? I see a number of failures:
$ ninja check-clang-tools
...
Failing Tests (6):
Clang Tools :: clang-apply-replacements/basic.cpp
Clang Tools :: clang-apply-replacements/conflict.cpp
Clang Tools :: clang-apply-replacements/crlf.
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/cppcoreguidelines/NoMallocCheck.cpp:54
+
+void NoMallocCheck::handleAquisition(const CallExpr *AquisitionCall) {
+ diag(AquisitionCall->
alexfh requested changes to this revision.
alexfh added a comment.
This revision now requires changes to proceed.
One important thing is missing. Please run this check on a large enough
codebase (LLVM + Clang is a good choice for testing most of kinds of checks
usually) and include a summary of
alexfh added inline comments.
Comment at: clang-tidy/utils/ExprSequence.cpp:154
+return SyntheticStmtSourceMap.lookup(S);
+ else
+return S;
nit: No `else` after return, please.
https://reviews.llvm.org/D27700
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG, but please wait until Malcolm
> Whats not nice is, that there is no underlining (in test neither), but i
> could not find out what is wrong,
> since i supply a SourceRange in the diag()-c
alexfh added a comment.
Hit "submit" too early.
LG, but please wait until Malcolm is happy with the change as well.
Repository:
rL LLVM
https://reviews.llvm.org/D26167
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with one nit.
Comment at:
clang-tools-extra/clang-tidy/performance/TypePromotionInMathFnCheck.cpp:145-153
+ bool StdFnRequresCpp11 =
+ llvm::StringSwitch(OldFnName)
alexfh added a comment.
LG with one nit. Feel free to ping earlier next time.
Comment at: clang-tidy/misc/SuspiciousEnumUsageCheck.cpp:170-171
+ if (const auto *EnumExpr = Result.Nodes.getNodeAs("enumExpr")) {
+if (!StrictMode)
+ return;
+const auto *EnumDec = Res
alexfh added inline comments.
Comment at: clang-tidy/misc/SuspiciousEnumUsageCheck.cpp:155
+
+if (EnumDec->enumerator_begin() == EnumDec->enumerator_end() ||
+OtherEnumDec->enumerator_begin() == OtherEnumDec->enumerator_end())
szepet wrote:
> alexfh w
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/readability/DeleteNullPointerCheck.cpp:52
+
+ auto D = diag(
+ IfWithDelete->getLocStart(),
Rename `D` to `Diag`,
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/misc/StringCompareCheck.cpp:48
+diag(Matched->getLocStart(),
+ "do not use compare to test equality of strings; "
+ "
alexfh added inline comments.
Comment at: clang-tidy/utils/ExprSequence.cpp:154
+return SyntheticStmtSourceMap.lookup(S);
+ else
+return S;
Prazek wrote:
> alexfh wrote:
> > nit: No `else` after return, please.
> Not sure if he should change it in this p
alexfh added inline comments.
Comment at: clang-tidy/modernize/UseDefaultMemberInitCheck.cpp:21
+
+static StringRef getValueInit(const CXXCtorInitializer *Init) {
+ switch (Init->getInit()->getType()->getScalarTypeKind()) {
The function name doesn't make it clea
alexfh added a comment.
Jonas, do you need someone to commit the patch for you?
Repository:
rL LLVM
https://reviews.llvm.org/D26167
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG modulo comment.
Comment at: clang-tidy/utils/DeclRefExprUtils.cpp:127
+ match(findAll(declRefExpr(equalsNode(&DeclRef),
+unless(hasAnc
alexfh added a comment.
Committed in r289546.
Repository:
rL LLVM
https://reviews.llvm.org/D26167
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added inline comments.
This revision is now accepted and ready to land.
Comment at:
clang-tools-extra/clang-tidy/performance/TypePromotionInMathFnCheck.cpp:187
- diag(Call->getExprLoc(), "call to '%0' promotes float to double")
- <<
alexfh added a comment.
LG with a couple of nits.
https://reviews.llvm.org/D27748
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/tool/run-clang-tidy.py:99-101
+ except:
+print >>sys.stderr, "Unable to run clang-apply-replacements."
+sys.exit(1)
alexfh added a comment.
In https://reviews.llvm.org/D24892#723536, @malcolm.parsons wrote:
> The `modernize-use-default-member-init` check now has an option with the same
> effect, but it is called `UseAssignment`.
> We should use consistent option names.
> Is there any way for multiple checks
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
SGTM provided this continues to work with python 2.
https://reviews.llvm.org/D32294
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http:
alexfh added a comment.
In https://reviews.llvm.org/D32294#732986, @Prazek wrote:
> In https://reviews.llvm.org/D32294#732861, @kuhar wrote:
>
> > After thinking about Piotr's comment, I think that a better way to perform
> > the check would be te invoking clang-apply-replacements with `--versio
alexfh added inline comments.
Comment at: clang-tidy/tool/run-clang-tidy.py:226
+print('Applying fixes ...')
+successfully_applied = True
+
` = False` here and ` = True` after `apply_fixes()` inside `try`.
https://reviews.llvm.org/D32294
alexfh added a comment.
In https://reviews.llvm.org/D24892#732243, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D24892#732217, @alexfh wrote:
>
> > In https://reviews.llvm.org/D24892#723536, @malcolm.parsons wrote:
> >
> > > Is there any way for multiple checks to share an option?
> >
>
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a nit.
Comment at: clang-tidy/readability/IdentifierNamingCheck.cpp:378
+ StringRef Mid = StringRef(Fixed).trim("_");
+ if (Mid.size() == 0)
+Mid = "_";
-
alexfh added a comment.
Cool! A few nits.
Comment at: clang-tidy/performance/InefficientVectorOperationCheck.cpp:56
+ast_matchers::internal::Matcher supportedContainerTypesMatcher() {
+ const auto types = cxxRecordDecl(hasAnyName(
+ "::std::vector", "::std::set", "::std::
alexfh added a comment.
In https://reviews.llvm.org/D32333#738266, @jtbandes wrote:
> Done, thanks for the review!
>
> What is the procedure for merging patches in? I'm sure I don't have
> permissions to do it myself.
I'll commit the patch for you.
Thank you for working on this!
https://rev
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG
Comment at: clang-tidy/performance/InefficientVectorOperationCheck.cpp:152
+
+ const Stmt * LoopStmt = nullptr;
+ if (ForLoop)
hokein wrote:
> alexfh wr
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301431: [clang-tidy] Update IdentifierNamingCheck to remove
extra leading/trailing… (authored by alexfh).
Changed prior to commit:
https://reviews.llvm.org/D32333?vs=96762&id=96771#toc
Repository:
rL
alexfh accepted this revision.
alexfh added a comment.
LG
https://reviews.llvm.org/D32395
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
LG
https://reviews.llvm.org/D32678
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh added a comment.
Thank you! One comment inline.
Comment at: clang-tidy/modernize/UseEmplaceCheck.cpp:23
+AST_MATCHER(CXXStdInitializerListExpr, cxxStdInitializerListExpr) {
+ return true;
This should be a node matcher rather than a narrowing matcher,
alexfh added a comment.
Please add a test.
Repository:
rL LLVM
https://reviews.llvm.org/D32810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
LG
Repository:
rL LLVM
https://reviews.llvm.org/D32810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
LG
Repository:
rL LLVM
https://reviews.llvm.org/D32767
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
I'm not sure I understand all implications, but from a cursory glance this
seems reasonable.
Repository:
rL LLVM
https://reviews.llvm.org/D32815
alexfh added inline comments.
Comment at: clang-tidy/cert/PostfixOperatorCheck.cpp:27
+hasOverloadedOperatorName("--")))
+ .bind("decl"),
+ this);
JonasToth wrote:
> could the `,t
1001 - 1100 of 1152 matches
Mail list logo
