alexfh added a comment.

In https://reviews.llvm.org/D24892#732243, @malcolm.parsons wrote:

> In https://reviews.llvm.org/D24892#732217, @alexfh wrote:
>
> > In https://reviews.llvm.org/D24892#723536, @malcolm.parsons wrote:
> >
> > > Is there any way for multiple checks to share an option?
> >
> >
> > There's OptionsView::getLocalOrGlobal. See how StrictMode option is read in 
> > ArgumentCommentCheck, for example.
>
>
> ArgumentCommentCheck uses getLocalOrGlobal, but 
> InefficientStringConcatenationCheck and SuspiciousEnumUsageCheck don't.
>  6 checks have an IncludeStyle option that isn't shared.
>  4 checks share a HeaderFileExtensions option, but with different defaults.


The right thing would be to fix these. I might get around to this, if nobody 
does this before me.


https://reviews.llvm.org/D24892



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to