alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed.
================ Comment at: clang-tidy/tool/run-clang-tidy.py:99-101 + except: + print >>sys.stderr, "Unable to run clang-apply-replacements." + sys.exit(1) ---------------- I'd place try/except in main around the call to apply_fixes() and also move `shutil.rmtree(tmpdir)` out of the `apply_fixes()` function. ================ Comment at: clang-tidy/tool/run-clang-tidy.py:100 + except: + print >>sys.stderr, "Unable to run clang-apply-replacements." + sys.exit(1) ---------------- "Unable to run clang-apply-replacements" without any details seems to be far worse than just a default stack trace from an unhandled exception. At the very least add the message from the exception. https://reviews.llvm.org/D32294 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
