[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-trap.ll:135 +; CHECK: # %bb.0: +; CHECK-NEXT:twnei 3, 0 +; CHECK-NEXT:blr nemanjai wrote: > Where are the aliases `twnei` and `tdnei` coming from? You don't s

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap updated this revision to Diff 357127. Conanap added a comment. Removed inst aliases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103668/new/ https://reviews.llvm.org/D103668 Files: clang/include/clang/Basic/BuiltinsPPC.def clang/lib/B

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-trap-64bit-only.ll:41 +; CHECK: # %bb.0: +; CHECK-NEXT:td 5, 3, 4 +; CHECK-NEXT:blr NeHuang wrote: > seems the InstAlias defined for `td` and `tw` not workin

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap updated this revision to Diff 357270. Conanap added a comment. Removed some incorrect patterns Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103668/new/ https://reviews.llvm.org/D103668 Files: clang/include/clang/Basic/BuiltinsPPC.def

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap marked an inline comment as done. Conanap added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:1733 +// as XL produces a tweq , . +def : Pat<(int_ppc_tdw g8rc:$A, g8rc:$B, 31), + (TD 4, $A, $B)>; nemanjai wrote: > This is s

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

Conanap updated this revision to Diff 357334. Conanap added a comment. Removed TWNE pattern as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103668/new/ https://reviews.llvm.org/D103668 Files: clang/include/clang/Basic/BuiltinsPPC.def cla

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. Conanap requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. LDARX and LWARX sometimes gets optimized out by the compiler when it i

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap updated this revision to Diff 357680. Conanap added a comment. Update test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105754/new/ https://reviews.llvm.org/D105754 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/built

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap updated this revision to Diff 357681. Conanap added a comment. Added modifier to $1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105754/new/ https://reviews.llvm.org/D105754 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/bu

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap updated this revision to Diff 357684. Conanap added a comment. Fixed more test cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105754/new/ https://reviews.llvm.org/D105754 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/b

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap added a comment. looking at the failing test cases, for example `./clang/test/CodeGen/RISCV/rvv-intrinsics-overloaded/vadd.c`, which are not test cases compiled for `PPC`, I'm seeing this following error: clang: /home/conanap/llvm/ccom/llvm-project/llvm/lib/IR/Instructions.cpp:494: v

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap updated this revision to Diff 357832. Conanap marked 6 inline comments as done. Conanap added a comment. Herald added subscribers: frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay, jr

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap updated this revision to Diff 357833. Conanap added a comment. Removed unintended change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105754/new/ https://reviews.llvm.org/D105754 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeG

[PATCH] D103668: [PowerPC] Implement trap and conversion builtins for XL compatibility

This revision was automatically updated to reflect the committed changes. Closed by commit rGef49d925e2a7: [PowerPC] Implement trap and conversion builtins for XL compatibility (authored by Conanap). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1036

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-LoadReserve-StoreCond-64bit-only.ll:18 entry: - %0 = bitcast i64* %a to i8* - %1 = tail call i64 @llvm.ppc.ldarx(i8* %0) - ret i64 %1 + %0 = call i64 asm sideeffect "ldarx $0, $1", "=

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap added inline comments. Comment at: llvm/test/CodeGen/PowerPC/builtins-ppc-xlcompat-LoadReserve-StoreCond-64bit-only.ll:18 entry: - %0 = bitcast i64* %a to i8* - %1 = tail call i64 @llvm.ppc.ldarx(i8* %0) - ret i64 %1 + %0 = call i64 asm sideeffect "ldarx $0, $1", "=

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap updated this revision to Diff 358028. Conanap added a comment. Updated a test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105754/new/ https://reviews.llvm.org/D105754 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/bui

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

Conanap updated this revision to Diff 358032. Conanap added a comment. Updated lwarx test case with modifier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105754/new/ https://reviews.llvm.org/D105754 Files: clang/lib/CodeGen/CGBuiltin.cpp clan

[PATCH] D105926: [PowerPC] Extra test case for LDARX

Conanap created this revision. Herald added subscribers: shchenz, kbarton, nemanjai. Conanap requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. An extra test case added for the builtin __LDARX. Repository: rG LLVM Github Monorepo https://

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

Conanap created this revision. Herald added subscribers: shchenz, kbarton, hiraditya, nemanjai. Conanap requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch implements store, load, move from and to registers relate

[PATCH] D105754: [PowerPC] Fix L[D|W]ARX Implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1aca5ac96eb: [PowerPC] Fix L[D|W]ARX Implementation (authored by Conanap). Changed prior to commit: https://reviews.llvm.org/D105754?vs=358032&id=358289#toc Repository: rG LLVM Github Monorepo CHAN

[PATCH] D105946: [PowerPC] Store, load, move from and to registers related builtins

Conanap updated this revision to Diff 358738. Conanap marked an inline comment as done. Conanap added a comment. Added more sema checking, test case update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105946/new/ https://reviews.llvm.org/D105946

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

Conanap added a comment. Hello, looks like this commit might be causing some failures on PowerPC buildbots, would you be able to take a quick look? Failing test case is `Clang :: OpenMP/nvptx_target_printf_codegen.c`. Buildbot link: https://lab.llvm.org/buildbot/#/builders/105/builds/17248/st

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

Conanap added a comment. thanks for reverting! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112680/new/ https://reviews.llvm.org/D112680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

Conanap updated this revision to Diff 327537. Conanap added a comment. Addressed Stefan's comments, converted the check to a mirror of the original function for XXSPLTIDP except non-destructive. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95458/new/ https://reviews.llvm.org/D95458 F

[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

Conanap marked 2 inline comments as done. Conanap added inline comments. Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:8593 + return !convertToNonDenormSingle(ArgAPFloat); +} + stefanp wrote: > I'm wondering if it would not be better to just inline thi

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs

Conanap updated this revision to Diff 327839. Conanap added a comment. Updated 2 test cases and some nits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94627/new/ https://reviews.llvm.org/D94627 Files: lld/ELF/Config.h lld/ELF/Driver.cpp lld/ELF/Options.td lld/ELF/Thunks.cpp

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG36192790d84b: [PowerPC][PC Rel] Implement option to omit Power10 instructions from stubs (authored by Conanap). Repository: rG LLVM Github Monorep

[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

Conanap updated this revision to Diff 329015. Conanap marked 3 inline comments as done. Conanap added a comment. Updated some comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95458/new/ https://reviews.llvm.org/D95458 Files: llvm/lib/Target/PowerPC/PPCISelLowering.cpp llvm/l

[PATCH] D100782: [PowerPC] Improve f32 to i32 bitcast code gen

Conanap updated this revision to Diff 340141. Conanap added a comment. Updated to remove uncessary `xrsp` and other `xxsldwi` as well CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100782/new/ https://reviews.llvm.org/D100782 Files: llvm/lib/Target/PowerPC/PPCInstrVSX.td llvm/test/C

[PATCH] D100782: [PowerPC] Improve f32 to i32 bitcast code gen

Conanap updated this revision to Diff 343115. Conanap marked 2 inline comments as done. Conanap added a comment. Updated `COPY_TO_REGCLASS` to `SUBREG_TO_REG`, added a test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100782/new/ https://reviews.llvm.org/D100782 Files: llvm/li

[PATCH] D100604: [PowerPC] Improve codegen for int-to-fp conversion of subword vector extract

Conanap updated this revision to Diff 343193. Conanap added a comment. Rebased and fixed indentations CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100604/new/ https://reviews.llvm.org/D100604 Files: llvm/lib/Target/PowerPC/PPCInstrVSX.td llvm/test/CodeGen/PowerPC/uint-to-fp-v4i32.

[PATCH] D100782: [PowerPC] Improve f32 to i32 bitcast code gen

Conanap updated this revision to Diff 343969. Conanap marked 2 inline comments as done. Conanap added a comment. Added big-endian pattern CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100782/new/ https://reviews.llvm.org/D100782 Files: llvm/lib/Target/PowerPC/PPCInstrVSX.td llvm/te

[PATCH] D95458: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars

This revision was automatically updated to reflect the committed changes. Closed by commit rGe29bb074c62c: [PowerPC] Exploit xxsplti32dx (constant materialization) for scalars (authored by Conanap). Changed prior to commit: https://reviews.llvm.org/D95458?vs=329015&id=333101#toc Repository:

[PATCH] D100604: [PowerPC] Improve codegen for int-to-fp conversion of subword vector extract

Conanap created this revision. Conanap added reviewers: nemanjai, saghir, PowerPC. Conanap added projects: LLVM, PowerPC, clang. Herald added a subscriber: kbarton. Conanap requested review of this revision. The following example generates code that can be completed in two instructions instead:

[PATCH] D100604: [PowerPC] Improve codegen for int-to-fp conversion of subword vector extract

Conanap updated this revision to Diff 337924. Conanap added a comment. Added test file CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100604/new/ https://reviews.llvm.org/D100604 Files: llvm/lib/Target/PowerPC/PPCInstrVSX.td llvm/test/CodeGen/PowerPC/uint-to-fp-v4i32.ll llvm/test/

[PATCH] D100782: [PowerPC] Improve f32 to i32 bitcast code gen

Conanap created this revision. Conanap added reviewers: saghir, nemanjai, PowerPC. Conanap added projects: PowerPC, clang, LLVM. Herald added a subscriber: kbarton. Conanap requested review of this revision. The code gen for f32 to i32 bitcast is not currently the most efficient. For example:

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap updated this revision to Diff 314431. Conanap marked 4 inline comments as done. Conanap added a comment. Addressed some comments for formatting and style CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 Files: llvm/lib/Target/PowerPC/PP

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap marked an inline comment as done. Conanap added a comment. initialize as a form of undef instead CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap updated this revision to Diff 314439. Conanap added a comment. Removed unecessary ternary CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 Files: llvm/lib/Target/PowerPC/PPCISelLowering.cpp llvm/lib/Target/PowerPC/PPCInstrPrefix.td

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap updated this revision to Diff 314443. Conanap added a comment. Fixed a typo that prevented successful builds CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 Files: llvm/lib/Target/PowerPC/PPCISelLowering.cpp llvm/lib/Target/PowerPC/P

[PATCH] D94627: [PowerPC][PC Rel] Implement option to omit P10 instructions from stubs

Conanap created this revision. Conanap added reviewers: stefanp, nemanjai, PowerPC. Conanap added projects: LLVM, clang, PowerPC. Herald added subscribers: dang, kbarton, arichardson, emaste. Herald added a reviewer: espindola. Herald added a reviewer: MaskRay. Conanap requested review of this revi

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap updated this revision to Diff 317355. Conanap marked 2 inline comments as done. Conanap added a comment. Loads Hi before Lo now; removed implicit cast. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 Files: llvm/lib/Target/PowerPC/PPCI

[PATCH] D90173: [PowerPC] Exploit splat instruction xxsplti32dx in Power10

Conanap closed this revision. Conanap added a comment. Pushed; differential revision link accidentally had an extra `https://` so it did not automatically close. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90173/new/ https://reviews.llvm.org/D90173 __

[PATCH] D110858: [PowerPC] Implement vector float and vector double version for vec_orc builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rG13d3cd37e278: [PowerPC] Implement vector float and vector double version for vec_orc builtin (authored by Conanap). Changed prior to commit: https://reviews.llvm.org/D110858?vs=376273&id=377453#toc Rep

[PATCH] D111258: [PowerPC] Emit dcbt and dcbtst in place of their extended mnemonics on AIX

Conanap created this revision. Conanap added reviewers: nemanjai, jsji, PowerPC. Conanap added projects: clang, LLVM, PowerPC. Herald added subscribers: kbarton, hiraditya. Conanap requested review of this revision. On AIX, the system assembler does not support the extended mnemonics `dcbtt` and `

[PATCH] D111258: [PowerPC] Emit dcbt and dcbtst in place of their extended mnemonics on AIX

Conanap updated this revision to Diff 378015. Conanap marked 2 inline comments as done. Conanap added a comment. Added mordern assembler check CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111258/new/ https://reviews.llvm.org/D111258 Files: llvm/lib/Target/PowerPC/MCTargetDesc/PPCIns

[PATCH] D111258: [PowerPC] Emit dcbt and dcbtst in place of their extended mnemonics on AIX

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4b9f9b4b3cf: [PowerPC] Emit dcbt and dcbtst in place of their extended mnemonics on AIX (authored by Conanap). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D107138: [PowerPC] Implement cmplxl builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d4faa8ac3e7: [PowerPC] Implement cmplxl builtins (authored by Conanap). Changed prior to commit: https://reviews.llvm.org/D107138?vs=365596&id=36

<    1   2   3