[compiler-rt] [libcxxabi] [libunwind] [runtimes][PAC] Harden unwinding when possible (#138571) (PR #143230)

2025-06-17 Thread Daniil Kovalev via cfe-commits
@@ -83,7 +83,13 @@ __llvm_profile_iterate_data(const __llvm_profile_data *Data) { /* This method is only used in value profiler mock testing. */ COMPILER_RT_VISIBILITY void * __llvm_get_function_addr(const __llvm_profile_data *Data) { - return Data->FunctionPointer; + void

[compiler-rt] [libcxxabi] [libunwind] [runtimes][PAC] Harden unwinding when possible (#138571) (PR #143230)

2025-06-17 Thread Daniil Kovalev via cfe-commits
@@ -1877,6 +1946,32 @@ inline Registers_arm64::Registers_arm64(const void *registers) { memcpy(_vectorHalfRegisters, static_cast(registers) + sizeof(GPRs), sizeof(_vectorHalfRegisters)); +#if __has_feature(ptrauth_calls) kovdan01 wrote: It

[compiler-rt] [libcxxabi] [libunwind] [runtimes][PAC] Harden unwinding when possible (#138571) (PR #143230)

2025-06-17 Thread Daniil Kovalev via cfe-commits
@@ -1877,6 +1946,32 @@ inline Registers_arm64::Registers_arm64(const void *registers) { memcpy(_vectorHalfRegisters, static_cast(registers) + sizeof(GPRs), sizeof(_vectorHalfRegisters)); +#if __has_feature(ptrauth_calls) + uint64_t pcRegister = 0; + memcp

[compiler-rt] [libcxxabi] [libunwind] [runtimes][PAC] Harden unwinding when possible (#138571) (PR #143230)

2025-06-17 Thread Daniil Kovalev via cfe-commits
@@ -1845,10 +1871,53 @@ class _LIBUNWIND_HIDDEN Registers_arm64 { uint64_t getSP() const { return _registers.__sp; } void setSP(uint64_t value) { _registers.__sp = value; } - uint64_t getIP() const { return _registers.__pc; } - void setIP(uint

[compiler-rt] [libcxxabi] [libunwind] [runtimes][PAC] Harden unwinding when possible (#138571) (PR #143230)

2025-06-17 Thread Daniil Kovalev via cfe-commits
@@ -1845,10 +1871,53 @@ class _LIBUNWIND_HIDDEN Registers_arm64 { uint64_t getSP() const { return _registers.__sp; } void setSP(uint64_t value) { _registers.__sp = value; } - uint64_t getIP() const { return _registers.__pc; } - void setIP(uint

[compiler-rt] [libcxxabi] [libunwind] [runtimes][PAC] Harden unwinding when possible (#138571) (PR #143230)

2025-06-17 Thread Daniil Kovalev via cfe-commits
@@ -1845,10 +1871,53 @@ class _LIBUNWIND_HIDDEN Registers_arm64 { uint64_t getSP() const { return _registers.__sp; } void setSP(uint64_t value) { _registers.__sp = value; } - uint64_t getIP() const { return _registers.__pc; } - void setIP(uint

[compiler-rt] [libcxxabi] [libunwind] [runtimes][PAC] Harden unwinding when possible (#138571) (PR #143230)

2025-06-17 Thread Daniil Kovalev via cfe-commits
@@ -126,6 +130,36 @@ _LIBUNWIND_HIDDEN int __unw_set_reg(unw_cursor_t *cursor, unw_regnum_t regNum, // First, get the FDE for the old location and then update it. co->getInfo(&info); co->setInfoBasedOnIPRegister(false); + +#if __has_feature(ptrauth_calls) +

[clang] [Sema][ObjC] Loosen restrictions on reinterpret_cast involving indirect ARC-managed pointers (PR #144458)

2025-06-17 Thread John McCall via cfe-commits
https://github.com/rjmccall commented: Could you also test that casts which preserve qualifiers work as expected? https://github.com/llvm/llvm-project/pull/144458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [clang-tools-extra] [clang-tidy] Warn about misuse of sizeof operator in loops. (PR #143205)

2025-06-17 Thread Malavika Samak via cfe-commits
https://github.com/malavikasamak updated https://github.com/llvm/llvm-project/pull/143205 >From 52e4413ea1e701dfe0b24cf957a26bb72732f066 Mon Sep 17 00:00:00 2001 From: MalavikaSamak Date: Wed, 21 May 2025 16:06:44 -0700 Subject: [PATCH 1/6] Place holder message for sizeof operator in loops. --

[clang] [clang-tools-extra] [clang-tidy] Warn about misuse of sizeof operator in loops. (PR #143205)

2025-06-17 Thread via cfe-commits
@@ -219,6 +219,11 @@ Changes in existing checks tolerating fix-it breaking compilation when functions is used as pointers to avoid matching usage of functions within the current compilation unit. +- Improved :doc: `bugprone-sizeof-expression + ` check. + Introduced WarnOnS

[clang] b876b3f - Add missing intrinsics to cuda headers (#143664)

2025-06-17 Thread via cfe-commits
Author: vitor1001 Date: 2025-06-17T10:52:56-07:00 New Revision: b876b3fa98cffd5b8755398f9a8218f667464d76 URL: https://github.com/llvm/llvm-project/commit/b876b3fa98cffd5b8755398f9a8218f667464d76 DIFF: https://github.com/llvm/llvm-project/commit/b876b3fa98cffd5b8755398f9a8218f667464d76.diff LOG

[clang] Add missing intrinsics to cuda headers (PR #143664)

2025-06-17 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B closed https://github.com/llvm/llvm-project/pull/143664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DebugInfo] Place local ODR-uniqued types in decl DISubprograms (PR #142166)

2025-06-17 Thread David Blaikie via cfe-commits
dwblaikie wrote: > (Transparency, I wrote some of the code in the PR so dunno if I should review > it,) > > > I /think/ function-local types need to go in definitions - in /abstract/ > > definitions if they exist (not in the inlined instances or concrete out of > > line instances). > > I thi

[clang] Add missing intrinsics to cuda headers (PR #143664)

2025-06-17 Thread via cfe-commits
github-actions[bot] wrote: @vitor1001 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a buil

[clang] [CUDA][HIP] add options `--[no-]offload-inc` (PR #140106)

2025-06-17 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B edited https://github.com/llvm/llvm-project/pull/140106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CUDA][HIP] add options `--[no-]offload-inc` (PR #140106)

2025-06-17 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B approved this pull request. https://github.com/llvm/llvm-project/pull/140106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Thread Safety Analysis: Very basic capability alias-analysis (PR #142955)

2025-06-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-analysis Author: Marco Elver (melver) Changes Add a simple form of alias analysis for capabilities by substituting local pointer variables with their initializers if they are `const` or never reassigned. For example, t

[clang] Thread Safety Analysis: Very basic capability alias-analysis (PR #142955)

2025-06-17 Thread Marco Elver via cfe-commits
https://github.com/melver ready_for_review https://github.com/llvm/llvm-project/pull/142955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Thread Safety Analysis: Very basic capability alias-analysis (PR #142955)

2025-06-17 Thread Marco Elver via cfe-commits
melver wrote: Cleaned it up some more. https://github.com/llvm/llvm-project/pull/142955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][diagnostics] Update note_constexpr_invalid_cast to use enum_select and adjust its uses (PR #130868)

2025-06-17 Thread Ayokunle Amodu via cfe-commits
ayokunle321 wrote: Hey @erichkeane, I'm back! So I'd thought to generalize a bit with the replacements. I saw one with magic numbers in the switch statement just before the diag call and tried to use an enum select there as well. The variable DiagSelect is one-indexed so the default value in t

[clang] [Clang] Add standalone AMDGPU SPIR-V toolchain (PR #144576)

2025-06-17 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/144576 Summary: The AMDGPU toolchain uses a different set of tools than the standard SPIR-V toolchain. The linker wrapper prefers to invoke a linker via a clang toolchain. To make that work we introduce `--target=spirv6

[clang] [Clang] Add standalone AMDGPU SPIR-V toolchain (PR #144576)

2025-06-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: The AMDGPU toolchain uses a different set of tools than the standard SPIR-V toolchain. The linker wrapper prefers to invoke a linker via a clang toolchain. To make that work we introduce `--target=spi

[clang] [CIR] Add side effect attribute to call operations (PR #144201)

2025-06-17 Thread Bruno Cardoso Lopes via cfe-commits
@@ -1858,6 +1858,40 @@ def FuncOp : CIR_Op<"func", [ // CallOp //===--===// +def SE_All : I32EnumAttrCase<"All", 1, "all">; +def SE_Pure : I32EnumAttrCase<"Pure", 2, "pure">; +def SE_Const : I32EnumAttrCase<"

[clang] clang/utils/TableGen/ClangOptionDocEmitter.cpp:220: Pointless string copy ? (#94373) (PR #94413)

2025-06-17 Thread Akshay Kumar Shiva Kumar via cfe-commits
https://github.com/akshaykumars614 closed https://github.com/llvm/llvm-project/pull/94413 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SROA] Vector promote some memsets (PR #133301)

2025-06-17 Thread via cfe-commits
https://github.com/ronlieb approved this pull request. LGTM, probably needs a rebase https://github.com/llvm/llvm-project/pull/133301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang/utils/TableGen/NeonEmitter.cpp:1058: pointless string copy ? (#94375) (PR #94408)

2025-06-17 Thread Akshay Kumar Shiva Kumar via cfe-commits
https://github.com/akshaykumars614 closed https://github.com/llvm/llvm-project/pull/94408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Allocate IntegralAP and Floating types using an allocator (PR #144246)

2025-06-17 Thread David Spickett via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: DavidSpickett wrote: I see you reverted due to https://lab.llvm.org/buildbot/#/builders/154/builds/17549. In case you don't know, that builder is Armv8 32-bit. Unless you get reports from our other, 64-bit builders, it

[clang-tools-extra] [clang-tidy] Added bugprone-unsequenced-global-accesses check (PR #130421)

2025-06-17 Thread Áron Hárnási via cfe-commits
https://github.com/ConcreteCactus closed https://github.com/llvm/llvm-project/pull/130421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Added bugprone-unsequenced-global-accesses check (PR #130421)

2025-06-17 Thread Áron Hárnási via cfe-commits
ConcreteCactus wrote: > To keep everything organized, I'd suggest creating a new branch for CSA > checker and close this PR (you can always reopen it later). > > For the CSA part, you can start by reading [this developer > guide](https://clang-analyzer.llvm.org/checker_dev_manual.html) (probab

[clang] [llvm] [DebugInfo] Place local ODR-uniqued types in decl DISubprograms (PR #142166)

2025-06-17 Thread Vladislav Dzhidzhoev via cfe-commits
dzhidzhoev wrote: > > > How does this work for LTO? (we'd want all inlined instances to refer to > > > a singular abstract definition) Yeah, looks like that's broken (the > > > abstract origins are not shared - they're duplicated in every translation > > > unit). > > > > > > But the notion o

[clang] [Clang] Fix '-Wformat-overflow' FP when floats had field-width and plus prefix (PR #144274)

2025-06-17 Thread Shafik Yaghmour via cfe-commits
@@ -43,6 +43,11 @@ void call_snprintf(double d, int n, int *ptr) { __builtin_snprintf(node_name, sizeof(node_name), "%pOFn", ptr); // nonkprintf-warning {{'snprintf' will always be truncated; specified size is 6, but format string expands to at least 7}} __builtin_snprintf

[clang] 667c786 - [CIR] Handle global string literals as char array initializer (#144384)

2025-06-17 Thread via cfe-commits
Author: Andy Kaylor Date: 2025-06-17T12:25:20-07:00 New Revision: 667c7860ef5cc67a94c5233ff1be9c0e113ac514 URL: https://github.com/llvm/llvm-project/commit/667c7860ef5cc67a94c5233ff1be9c0e113ac514 DIFF: https://github.com/llvm/llvm-project/commit/667c7860ef5cc67a94c5233ff1be9c0e113ac514.diff L

[clang] [CIR] Handle global string literals as char array initializer (PR #144384)

2025-06-17 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/144384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Add support for GCC installation detection in Baremetal toolchain (PR #121829)

2025-06-17 Thread Daniel Thornburgh via cfe-commits
mysterymath wrote: This is consistently breaking the Fuchsia builders as seen in the above buildbot. Accordingly, I'm issuing a rollback. https://github.com/llvm/llvm-project/pull/121829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [llvm] [Reland] [PowerPC] frontend get target feature from backend with cpu name (PR #144594)

2025-06-17 Thread Reid Kleckner via cfe-commits
@@ -0,0 +1,191 @@ +//===- EmitTargetFeature.cpp - Generate CPU Targer feature ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH

[clang] [Driver] Fix Arm/AArch64 Link Argument tests (PR #144582)

2025-06-17 Thread via cfe-commits
Kewen12 wrote: Thanks again for your help @lenary https://github.com/llvm/llvm-project/pull/144582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Reland] [PowerPC] frontend get target feature from backend with cpu name (PR #144594)

2025-06-17 Thread Reid Kleckner via cfe-commits
@@ -0,0 +1,191 @@ +//===- EmitTargetFeature.cpp - Generate CPU Targer feature ===// rnk wrote: typo https://github.com/llvm/llvm-project/pull/144594 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang-tools-extra] 3c7df98 - [clang-tidy] Add missing colon in the docs of performance-enum-size (#144525)

2025-06-17 Thread via cfe-commits
Author: Piotr Idzik Date: 2025-06-17T21:59:53+01:00 New Revision: 3c7df98c7b2a203e49a74b229bbf535c2ef6274b URL: https://github.com/llvm/llvm-project/commit/3c7df98c7b2a203e49a74b229bbf535c2ef6274b DIFF: https://github.com/llvm/llvm-project/commit/3c7df98c7b2a203e49a74b229bbf535c2ef6274b.diff L

[clang-tools-extra] [clang-tidy] Add missing colon in the docs of performance-enum-size (PR #144525)

2025-06-17 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin closed https://github.com/llvm/llvm-project/pull/144525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add missing colon in the docs of performance-enum-size (PR #144525)

2025-06-17 Thread via cfe-commits
github-actions[bot] wrote: @vil02 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build, y

[clang] [C++][Modules] A module directive may only appear as the first preprocessing tokens in a file (PR #144233)

2025-06-17 Thread Michael Spencer via cfe-commits
Bigcheese wrote: Yes, I'll be able to review it sometime this week. https://github.com/llvm/llvm-project/pull/144233 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ecfb8fe - Revert stack "[Driver] Add support for GCC installation detection in … (#144603)

2025-06-17 Thread via cfe-commits
Author: Daniel Thornburgh Date: 2025-06-17T14:07:07-07:00 New Revision: ecfb8fe5c1870091b095ae6ca1ad4cfc7158e619 URL: https://github.com/llvm/llvm-project/commit/ecfb8fe5c1870091b095ae6ca1ad4cfc7158e619 DIFF: https://github.com/llvm/llvm-project/commit/ecfb8fe5c1870091b095ae6ca1ad4cfc7158e619.d

[clang] Revert stack "[Driver] Add support for GCC installation detection in … (PR #144603)

2025-06-17 Thread Daniel Thornburgh via cfe-commits
https://github.com/mysterymath created https://github.com/llvm/llvm-project/pull/144603 …Baremetal toolchain (#121829)" This reverts the following stack of commits, due to them breaking the Fuchsia toolchain and corresponding LLVM buildbot. Revert "[Driver] Fix Arm/AArch64 Link Argument tests

[clang] Revert stack "[Driver] Add support for GCC installation detection in … (PR #144603)

2025-06-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Daniel Thornburgh (mysterymath) Changes …Baremetal toolchain (#121829)" This reverts the following stack of commits, due to them breaking the Fuchsia toolchain and corresponding LLVM buildbot. Revert "[Driver] Fix Arm/AArch64 Link Argume

[clang] Revert stack "[Driver] Add support for GCC installation detection in … (PR #144603)

2025-06-17 Thread Daniel Thornburgh via cfe-commits
https://github.com/mysterymath closed https://github.com/llvm/llvm-project/pull/144603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert stack "[Driver] Add support for GCC installation detection in … (PR #144603)

2025-06-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Daniel Thornburgh (mysterymath) Changes …Baremetal toolchain (#121829)" This reverts the following stack of commits, due to them breaking the Fuchsia toolchain and corresponding LLVM buildbot. Revert "[Driver] Fix Arm/AArch64 Li

[clang] [LinkerWrapper] Fix 'save-temps' when targeting SPIR-V (PR #144605)

2025-06-17 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/144605 Summary: The logic here is flawed, it was only intended to apply to the CPU case where we use the linker passed in on the command line. This was falsely applying to SPIR-V which caused issues. >From a0a041b7904

[clang] [LinkerWrapper] Fix 'save-temps' when targeting SPIR-V (PR #144605)

2025-06-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: The logic here is flawed, it was only intended to apply to the CPU case where we use the linker passed in on the command line. This was falsely applying to SPIR-V which caused issues. --- Full diff:

[clang] cb011d3 - [CUDA][HIP] Add a __device__ version of std::__glibcxx_assert_fail() (#136133)

2025-06-17 Thread via cfe-commits
Author: Juan Manuel Martinez Caamaño Date: 2025-06-17T14:32:05+02:00 New Revision: cb011d3199e1160ad2706cb5b1d43692fa4784d8 URL: https://github.com/llvm/llvm-project/commit/cb011d3199e1160ad2706cb5b1d43692fa4784d8 DIFF: https://github.com/llvm/llvm-project/commit/cb011d3199e1160ad2706cb5b1d4369

[clang] ce96fdd - [clang][bytecode] Keep the last chunk in InterpStack::clear() (#144487)

2025-06-17 Thread via cfe-commits
Author: Timm Baeder Date: 2025-06-17T12:38:02+02:00 New Revision: ce96fdde54c379fa3893f3f07d8233df9e16b9e2 URL: https://github.com/llvm/llvm-project/commit/ce96fdde54c379fa3893f3f07d8233df9e16b9e2 DIFF: https://github.com/llvm/llvm-project/commit/ce96fdde54c379fa3893f3f07d8233df9e16b9e2.diff L

[clang] 977d8a4 - [clang][Sema] Fixed Compound Literal is not Constant Expression (#143852)

2025-06-17 Thread via cfe-commits
Author: Vincent Date: 2025-06-17T09:20:41-04:00 New Revision: 977d8a4bcd83797217433709201922b9deb97ae2 URL: https://github.com/llvm/llvm-project/commit/977d8a4bcd83797217433709201922b9deb97ae2 DIFF: https://github.com/llvm/llvm-project/commit/977d8a4bcd83797217433709201922b9deb97ae2.diff LOG:

[clang] 3377b56 - Revert "[clang] Add managarm support" (#144514)

2025-06-17 Thread via cfe-commits
Author: Aaron Ballman Date: 2025-06-17T08:39:15-04:00 New Revision: 3377b56338d93760507e1707ebde48536e28ee1c URL: https://github.com/llvm/llvm-project/commit/3377b56338d93760507e1707ebde48536e28ee1c DIFF: https://github.com/llvm/llvm-project/commit/3377b56338d93760507e1707ebde48536e28ee1c.diff

[clang] [CIR] Add side effect attribute to call operations (PR #144201)

2025-06-17 Thread Sirui Mu via cfe-commits
@@ -24,16 +24,17 @@ let cppNamespace = "::cir" in { def CIRCallOpInterface : OpInterface<"CIRCallOpInterface", [CallOpInterface]> { // Currently we don't have any methods defined in CIRCallOpInterface. We'll // add more methods as the upstreaming proceeds. -let m

[clang] [llvm] [openmp] [clang][OpenMP] New OpenMP 6.0 threadset clause (PR #135807)

2025-06-17 Thread via cfe-commits
https://github.com/Ritanya-B-Bharadwaj updated https://github.com/llvm/llvm-project/pull/135807 >From 9c56e59ba9984c14c15a8d5a95a02e7192a64e8f Mon Sep 17 00:00:00 2001 From: Ritanya B Bharadwaj Date: Sun, 6 Apr 2025 09:33:06 -0500 Subject: [PATCH 1/7] [OpenMP] Parsing Support of ThreadSets in T

[clang] [CIR] Add side effect attribute to call operations (PR #144201)

2025-06-17 Thread Sirui Mu via cfe-commits
https://github.com/Lancern updated https://github.com/llvm/llvm-project/pull/144201 >From 77d093f1a9c6c6fc742e788f8b05aa9c601480de Mon Sep 17 00:00:00 2001 From: Sirui Mu Date: Tue, 17 Jun 2025 22:35:50 +0800 Subject: [PATCH] [CIR] Add support for __builtin_assume This patch adds support for t

[clang] [CIR] Add side effect attribute to call operations (PR #144201)

2025-06-17 Thread Sirui Mu via cfe-commits
@@ -1858,6 +1858,40 @@ def FuncOp : CIR_Op<"func", [ // CallOp //===--===// +def SE_All : I32EnumAttrCase<"All", 1, "all">; Lancern wrote: Done. https://github.com/llvm/llvm-project/pull/14

[clang] [CIR] Add side effect attribute to call operations (PR #144201)

2025-06-17 Thread Sirui Mu via cfe-commits
@@ -1940,22 +1975,30 @@ def CallOp : CIR_CallOpBase<"call", [NoRegionArguments]> { let arguments = commonArgs; let builders = [ -// Build a call op for a direct call -OpBuilder<(ins "mlir::SymbolRefAttr":$callee, "mlir::Type":$resType, - "mlir::V

[clang] [llvm] [openmp] [clang][OpenMP] New OpenMP 6.0 threadset clause (PR #135807)

2025-06-17 Thread via cfe-commits
@@ -364,7 +364,7 @@ implementation. +=+===+===+==+ | free-agent threads

[clang] [NFC][C++][Modules] Mark P2788R0(DR) as implemented and added more test (PR #144214)

2025-06-17 Thread via cfe-commits
yronglin wrote: > Test changes LG. Thanks for the review! https://github.com/llvm/llvm-project/pull/144214 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR][NFCI] Represent Complex RValues As Single Value (PR #144519)

2025-06-17 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. Looks good to me! https://github.com/llvm/llvm-project/pull/144519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ec230aa - [Driver] Add support for crtbegin.o, crtend.o and libgloss lib to BareMetal toolchain object (#121830)

2025-06-17 Thread via cfe-commits
Author: Garvit Gupta Date: 2025-06-17T22:49:55+05:30 New Revision: ec230aa7a7d13c222c0b34b87c3c16937383b4a0 URL: https://github.com/llvm/llvm-project/commit/ec230aa7a7d13c222c0b34b87c3c16937383b4a0 DIFF: https://github.com/llvm/llvm-project/commit/ec230aa7a7d13c222c0b34b87c3c16937383b4a0.diff

[clang] [Driver] Add support for crtbegin.o, crtend.o and libgloss lib to BareMetal toolchain object (PR #121830)

2025-06-17 Thread Garvit Gupta via cfe-commits
https://github.com/quic-garvgupt closed https://github.com/llvm/llvm-project/pull/121830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix link order of BareMetal toolchain object (PR #132806)

2025-06-17 Thread Garvit Gupta via cfe-commits
https://github.com/quic-garvgupt edited https://github.com/llvm/llvm-project/pull/132806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][HLSL] Move Sema work from `ParseMicrosoftRootSignatureAttributeArgs` (PR #143184)

2025-06-17 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/143184 >From f8b165eecd613a4e9dc1576f5087e37ec74034e5 Mon Sep 17 00:00:00 2001 From: Finn Plummer Date: Fri, 6 Jun 2025 17:37:12 + Subject: [PATCH 1/7] define ActOnStartRootSignatureDecl --- clang/include/clang/S

[clang] [NFC][HLSL] Move Sema work from `ParseMicrosoftRootSignatureAttributeArgs` (PR #143184)

2025-06-17 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/143184 >From f8b165eecd613a4e9dc1576f5087e37ec74034e5 Mon Sep 17 00:00:00 2001 From: Finn Plummer Date: Fri, 6 Jun 2025 17:37:12 + Subject: [PATCH 1/7] define ActOnStartRootSignatureDecl --- clang/include/clang/S

[clang] [HIP] Emit the CUID value in the module with the new driver (PR #144570)

2025-06-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: This is a weird point of divergence, which is also apparently critical for SPIR-V compilation not failing? Somehow if we don't emit this global than the `llvm.compiler.used` global uses AS(0) which ma

[clang] [llvm] Dump auto (c++11) type Inferences (Issue #17) (PR #144478)

2025-06-17 Thread Yanzuo Liu via cfe-commits
zwuis wrote: Is it necessary to have this feature? Clangd already [supports it](https://clangd.llvm.org/config.html#inlayhints). https://github.com/llvm/llvm-project/pull/144478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang-tools-extra] 8513066 - [clangd] Implement LSP 3.17 positionEncoding (#142903)

2025-06-17 Thread via cfe-commits
Author: someoneinjd Date: 2025-06-17T19:23:14+02:00 New Revision: 8513066f2c49457f5d1f63e275403330f854041c URL: https://github.com/llvm/llvm-project/commit/8513066f2c49457f5d1f63e275403330f854041c DIFF: https://github.com/llvm/llvm-project/commit/8513066f2c49457f5d1f63e275403330f854041c.diff L

[clang-tools-extra] [clangd] Implement LSP 3.17 positionEncoding (PR #142903)

2025-06-17 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet closed https://github.com/llvm/llvm-project/pull/142903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Implement LSP 3.17 positionEncoding (PR #142903)

2025-06-17 Thread via cfe-commits
github-actions[bot] wrote: @someoneinjd Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bu

[clang] [CIR] Upstream ComplexType builtin_complex (PR #144225)

2025-06-17 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/144225 >From 118f922e28117e31fb584bbaa2d5b9b68a78d009 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 14 Jun 2025 16:21:20 +0200 Subject: [PATCH 1/4] [CIR] Upstream ComplexType builtin_complex --- clang/l

[clang] [HIP] Emit the CUID value in the module with the new driver (PR #144570)

2025-06-17 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/144570 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [DebugInfo] Place local ODR-uniqued types in decl DISubprograms (PR #142166)

2025-06-17 Thread David Blaikie via cfe-commits
dwblaikie wrote: > > How does this work for LTO? (we'd want all inlined instances to refer to a > > singular abstract definition) Yeah, looks like that's broken (the abstract > > origins are not shared - they're duplicated in every translation unit). > > But the notion of "abstract" subprogram

[clang] [CIR] Upstream ComplexType builtin_complex (PR #144225)

2025-06-17 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- clang/lib/CIR/CodeGen/CIRGenBuiltin.cpp clang/lib/

[clang] [Driver] Add option to force undefined symbols during linking in BareMetal toolchain object. (PR #132807)

2025-06-17 Thread Garvit Gupta via cfe-commits
https://github.com/quic-garvgupt closed https://github.com/llvm/llvm-project/pull/132807 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Forward sysroot from Driver to linker in BareMetal ToolChain Object (PR #132808)

2025-06-17 Thread Garvit Gupta via cfe-commits
https://github.com/quic-garvgupt edited https://github.com/llvm/llvm-project/pull/132808 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9cb7545 - [Driver] Add option to force undefined symbols during linking in BareMetal toolchain object. (#132807)

2025-06-17 Thread via cfe-commits
Author: Garvit Gupta Date: 2025-06-18T00:28:23+05:30 New Revision: 9cb754509608b9d9143fa17f775631bbfcce0848 URL: https://github.com/llvm/llvm-project/commit/9cb754509608b9d9143fa17f775631bbfcce0848 DIFF: https://github.com/llvm/llvm-project/commit/9cb754509608b9d9143fa17f775631bbfcce0848.diff

[clang] [Driver] Add support for crtbegin.o, crtend.o and libgloss lib to BareMetal toolchain object (PR #121830)

2025-06-17 Thread Sam Elliott via cfe-commits
lenary wrote: The answer is yes, this builder does set a different unwindlib. https://github.com/llvm/llvm-project/pull/121830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Forward sysroot from Driver to linker in BareMetal ToolChain Object (PR #132808)

2025-06-17 Thread Garvit Gupta via cfe-commits
https://github.com/quic-garvgupt updated https://github.com/llvm/llvm-project/pull/132808 >From f4a5757a8abf6ff7ba3e064533f3993a0ed0198e Mon Sep 17 00:00:00 2001 From: Garvit Gupta Date: Mon, 24 Mar 2025 07:04:59 -0700 Subject: [PATCH] [Driver] Forward sysroot from Driver to linker in BareMetal

[clang] [Driver] Add support for crtbegin.o, crtend.o and libgloss lib to BareMetal toolchain object (PR #121830)

2025-06-17 Thread Petr Hosek via cfe-commits
petrhosek wrote: > The answer is yes, this builder does set a different unwindlib. That shouldn't have any effect on tests, if it does, it likely implies an issue with the test. https://github.com/llvm/llvm-project/pull/121830 ___ cfe-commits mailing

[clang] [Driver] Add support for crtbegin.o, crtend.o and libgloss lib to BareMetal toolchain object (PR #121830)

2025-06-17 Thread Sam Elliott via cfe-commits
lenary wrote: My plan is to modify the tests to accept that there might be unwindlib arguments between `clang_rt.builtins.a` and `-lc`, which is where the breakage is right now. https://github.com/llvm/llvm-project/pull/121830 ___ cfe-commits mailing

[clang] [Driver] Fix Arm/AArch64 Link Argument tests (PR #144582)

2025-06-17 Thread Sam Elliott via cfe-commits
https://github.com/lenary edited https://github.com/llvm/llvm-project/pull/144582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix Arm/AArch64 Link Argument tests (PR #144582)

2025-06-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Sam Elliott (lenary) Changes The openmp-offload-amdgpu-runtime-2 bot specifies default rtlib of compiler-rt, but default unwindlib of libgcc. Change the tests to accept that there may be `"--as-needed" "-

[clang] [Driver] Add option to force undefined symbols during linking in BareMetal toolchain object. (PR #132807)

2025-06-17 Thread Garvit Gupta via cfe-commits
quic-garvgupt wrote: `ToolChain::UnwindLibType ToolChain::GetUnwindLibType( const ArgList &Args) const { if (unwindLibType) return *unwindLibType; const Arg *A = Args.getLastArg(options::OPT_unwindlib_EQ); StringRef LibName = A ? A->getValue() : CLANG_DEFAULT_UNWINDLIB;` If the

[clang] [Driver] Fix Tests when specifying unwindlib (PR #144582)

2025-06-17 Thread Sam Elliott via cfe-commits
https://github.com/lenary created https://github.com/llvm/llvm-project/pull/144582 The openmp-offload-amdgpu-runtime-2 bot specifies default rtlib of compiler-rt, but default unwindlib of libgcc. Change the tests to accept that there may be `"--as-needed" "-lgcc_s" "--no-as-needed"` between `l

[clang] [CIR] Add support for member initialization from constructors (PR #144583)

2025-06-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Andy Kaylor (andykaylor) Changes Upstream the code to handle member variable initialization in a constructor. At this point only simple scalar values (including members of anonymous unions) are handled. --- Patch is 20.13 KiB, truncated

[clang] [Driver] Fix Arm/AArch64 Link Argument tests (PR #144582)

2025-06-17 Thread Garvit Gupta via cfe-commits
quic-garvgupt wrote: `ToolChain::UnwindLibType ToolChain::GetUnwindLibType( const ArgList &Args) const { if (unwindLibType) return *unwindLibType; const Arg *A = Args.getLastArg(options::OPT_unwindlib_EQ); StringRef LibName = A ? A->getValue() : CLANG_DEFAULT_UNWINDLIB;` I

[clang] [CIR] Add support for member initialization from constructors (PR #144583)

2025-06-17 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor created https://github.com/llvm/llvm-project/pull/144583 Upstream the code to handle member variable initialization in a constructor. At this point only simple scalar values (including members of anonymous unions) are handled. >From 389f3d95239c28415a95696cc7645e

[clang] [CIR] Add support for member initialization from constructors (PR #144583)

2025-06-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clangir Author: Andy Kaylor (andykaylor) Changes Upstream the code to handle member variable initialization in a constructor. At this point only simple scalar values (including members of anonymous unions) are handled. --- Patch is 20.13 KiB, truncat

[clang] 57828fe - Revert "[clang][bytecode] Allocate IntegralAP and Floating types using an allocator (#144246)"

2025-06-17 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2025-06-17T21:08:23+02:00 New Revision: 57828fec760f086b334ce0cb1c465fc559dcaea4 URL: https://github.com/llvm/llvm-project/commit/57828fec760f086b334ce0cb1c465fc559dcaea4 DIFF: https://github.com/llvm/llvm-project/commit/57828fec760f086b334ce0cb1c465fc559dcaea4.diff LO

[clang] [llvm] [DebugInfo] Place local ODR-uniqued types in decl DISubprograms (PR #142166)

2025-06-17 Thread David Blaikie via cfe-commits
dwblaikie wrote: > > So maybe the solution is as simple as removing the "unique" from > > DISubprogram definitions, and the existing infrastructure will handle it? > > (maybe have to expand it to allow it to work for things with > > DISPFlagDefinition... ) > > If I understand the idea behind

[clang] [Driver] Fix Arm/AArch64 Link Argument tests (PR #144582)

2025-06-17 Thread via cfe-commits
Kewen12 wrote: Thanks for this quick fix! Hi @quic-garvgupt, could you please help approve this PR if it looks good to you. It would be helpful to unblock our bots and downstream. Thanks! https://github.com/llvm/llvm-project/pull/144582 ___ cfe-com

[clang] 73f307a - [HLSL] Use ExtVector for firstbit intrinsics (#142679)

2025-06-17 Thread via cfe-commits
Author: Ashley Coleman Date: 2025-06-17T14:32:11-06:00 New Revision: 73f307a5ca308d356c557734765742c26bf7ed03 URL: https://github.com/llvm/llvm-project/commit/73f307a5ca308d356c557734765742c26bf7ed03 DIFF: https://github.com/llvm/llvm-project/commit/73f307a5ca308d356c557734765742c26bf7ed03.diff

[clang-tools-extra] [clang-tidy] Add missing colon in the docs of performance-enum-size (PR #144525)

2025-06-17 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. https://github.com/llvm/llvm-project/pull/144525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Use ExtVector for firstbit intrinsics (PR #142679)

2025-06-17 Thread Ashley Coleman via cfe-commits
https://github.com/V-FEXrt closed https://github.com/llvm/llvm-project/pull/142679 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-reorder-fields] Prevent rewriting unsupported cases (PR #142149)

2025-06-17 Thread Alexander Shaposhnikov via cfe-commits
@@ -50,6 +51,63 @@ static const RecordDecl *findDefinition(StringRef RecordName, return selectFirst("recordDecl", Results); } +static bool isSafeToRewrite(const RecordDecl *Decl, const ASTContext &Context) { + // All following checks expect at least one field declaration.

[clang] [Driver] Fix Arm/AArch64 Link Argument tests (PR #144582)

2025-06-17 Thread Sam Elliott via cfe-commits
lenary wrote: I'm going to land this, as I'm taking "I'm aligned with this fix" as approval from garvit (I know he's in a different time zone, which may mean he's logged off for the night) https://github.com/llvm/llvm-project/pull/144582 ___ cfe-comm

[clang] a79186c - [Driver] Fix Arm/AArch64 Link Argument tests (#144582)

2025-06-17 Thread via cfe-commits
Author: Sam Elliott Date: 2025-06-17T13:36:15-07:00 New Revision: a79186c1ea62bbe0579e0b1eed4ad507966cca41 URL: https://github.com/llvm/llvm-project/commit/a79186c1ea62bbe0579e0b1eed4ad507966cca41 DIFF: https://github.com/llvm/llvm-project/commit/a79186c1ea62bbe0579e0b1eed4ad507966cca41.diff L

[clang-tools-extra] [clang-reorder-fields] Prevent rewriting unsupported cases (PR #142149)

2025-06-17 Thread Alexander Shaposhnikov via cfe-commits
@@ -50,6 +51,63 @@ static const RecordDecl *findDefinition(StringRef RecordName, return selectFirst("recordDecl", Results); } +static bool isSafeToRewrite(const RecordDecl *Decl, const ASTContext &Context) { + // All following checks expect at least one field declaration.

[clang] [Driver] Fix Arm/AArch64 Link Argument tests (PR #144582)

2025-06-17 Thread Sam Elliott via cfe-commits
https://github.com/lenary closed https://github.com/llvm/llvm-project/pull/144582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   >