https://github.com/jhuber6 created
https://github.com/llvm/llvm-project/pull/144605
Summary:
The logic here is flawed, it was only intended to apply to the CPU case
where we use the linker passed in on the command line. This was falsely
applying to SPIR-V which caused issues.
>From a0a041b790453f8140f8949a00a974e554bd320b Mon Sep 17 00:00:00 2001
From: Joseph Huber <hube...@outlook.com>
Date: Tue, 17 Jun 2025 16:09:26 -0500
Subject: [PATCH] [LinkerWrapper] Fix 'save-temps' when targeting SPIR-V
Summary:
The logic here is flawed, it was only intended to apply to the CPU case
where we use the linker passed in on the command line. This was falsely
applying to SPIR-V which caused issues.
---
clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
b/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
index 7a1007d03737e..0f1fa8b329fd6 100644
--- a/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
+++ b/clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp
@@ -268,7 +268,8 @@ Expected<std::string> findProgram(StringRef Name,
ArrayRef<StringRef> Paths) {
bool linkerSupportsLTO(const ArgList &Args) {
llvm::Triple Triple(Args.getLastArgValue(OPT_triple_EQ));
return Triple.isNVPTX() || Triple.isAMDGPU() ||
- Args.getLastArgValue(OPT_linker_path_EQ).ends_with("lld");
+ (!Triple.isGPU() &&
+ Args.getLastArgValue(OPT_linker_path_EQ).ends_with("lld"));
}
/// Returns the hashed value for a constant string.
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
