https://github.com/lenary created https://github.com/llvm/llvm-project/pull/144582
The openmp-offload-amdgpu-runtime-2 bot specifies default rtlib of compiler-rt, but default unwindlib of libgcc. Change the tests to accept that there may be `"--as-needed" "-lgcc_s" "--no-as-needed"` between `libclang_rt.builtins.a` and `-lc`. Relates to #121830 >From 64572521dbcbf7d7c9ccf482bd76b8b2620a14d4 Mon Sep 17 00:00:00 2001 From: Sam Elliott <quic_aelli...@quicinc.com> Date: Tue, 17 Jun 2025 12:00:04 -0700 Subject: [PATCH] [Driver] Fix Tests when specifying unwindlib The openmp-offload-amdgpu-runtime-2 bot specifies default rtlib of compiler-rt, but default unwindlib of libgcc. Change the tests to accept that there may be `"--as-needed" "-lgcc_s" "--no-as-needed"` between `libclang_rt.builtins.a` and `-lc`. Relates to #121830 --- clang/test/Driver/aarch64-toolchain.c | 3 ++- clang/test/Driver/arm-toolchain.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/clang/test/Driver/aarch64-toolchain.c b/clang/test/Driver/aarch64-toolchain.c index e12107fa2c506..327161b81d9f6 100644 --- a/clang/test/Driver/aarch64-toolchain.c +++ b/clang/test/Driver/aarch64-toolchain.c @@ -135,7 +135,8 @@ // AARCH64-BAREMETAL-COMPILER-RT: "{{.*}}crt0.o" // AARCH64-BAREMETAL-COMPILER-RT: "{{.*}}clang_rt.crtbegin.o" -// AARCH64-BAREMETAL-COMPILER-RT: "--start-group" "{{.*}}libclang_rt.builtins.a" "-lc" "-lgloss" "--end-group" +// AARCH64-BAREMETAL-COMPILER-RT: "--start-group" "{{.*}}libclang_rt.builtins.a" +// AARCH64-BAREMETAL-COMPILER-RT: "-lc" "-lgloss" "--end-group" // AARCH64-BAREMETAL-COMPILER-RT: "{{.*}}clang_rt.crtend.o" // RUN: %clang -### %s -fuse-ld= \ diff --git a/clang/test/Driver/arm-toolchain.c b/clang/test/Driver/arm-toolchain.c index d4f9bf2aaf3d5..5368158cdeeda 100644 --- a/clang/test/Driver/arm-toolchain.c +++ b/clang/test/Driver/arm-toolchain.c @@ -136,7 +136,8 @@ // ARM-BAREMETAL-COMPILER-RT: "{{.*}}crt0.o" // ARM-BAREMETAL-COMPILER-RT: "{{.*}}clang_rt.crtbegin.o" -// ARM-BAREMETAL-COMPILER-RT: "--start-group" "{{.*}}libclang_rt.builtins.a" "-lc" "-lgloss" "--end-group" +// ARM-BAREMETAL-COMPILER-RT: "--start-group" "{{.*}}libclang_rt.builtins.a" +// ARM-BAREMETAL-COMPILER-RT: "-lc" "-lgloss" "--end-group" // ARM-BAREMETAL-COMPILER-RT: "{{.*}}clang_rt.crtend.o" // RUN: %clang -### %s -fuse-ld= \ _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits