[clang] [openmp] [OpenMP 6.0 ]Codegen for Reduction over private variables with reduction clause (PR #134709)

2025-05-09 Thread CHANDRA GHALE via cfe-commits
@@ -530,6 +530,12 @@ OpenMP Support - Added support 'no_openmp_constructs' assumption clause. - Added support for 'self_maps' in map and requirement clause. - Added support for 'omp stripe' directive. +- Fixed a crashing bug with ``omp unroll partial`` if the argument to + ``p

[clang] [Preprocessor] Do not expand macros if the input is already preprocessed (PR #137665)

2025-05-09 Thread Jacob Lambert via cfe-commits
Juan Manuel Martinez =?utf-8?q?Caamaño?= Message-ID: In-Reply-To: lamb-j wrote: > module maps don't get preprocessed, so I don't think it matters what that is > set to. For normal module.modulemap files `Preprocessed` is `false`. I think > it's fine to remove the true and see if anything bre

[clang] [llvm] [win][x64] Unwind v2 3/n: Add support for emitting unwind v2 information (equivalent to MSVC /d2epilogunwind) (PR #129142)

2025-05-09 Thread Daniel Paoliello via cfe-commits
https://github.com/dpaoliello closed https://github.com/llvm/llvm-project/pull/129142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Reland: Diagnose invalid function types in dependent contexts (PR #139246)

2025-05-09 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/139246 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-

[clang] 52b18b4 - [Clang] Reland: Diagnose invalid function types in dependent contexts (#139246)

2025-05-09 Thread via cfe-commits
Author: cor3ntin Date: 2025-05-09T19:59:20+02:00 New Revision: 52b18b4e82d412a7d755e89591c6ebcc41c257a1 URL: https://github.com/llvm/llvm-project/commit/52b18b4e82d412a7d755e89591c6ebcc41c257a1 DIFF: https://github.com/llvm/llvm-project/commit/52b18b4e82d412a7d755e89591c6ebcc41c257a1.diff LOG:

[clang] [Clang] Diagnose invalid function types in dependent contexts (PR #138731)

2025-05-09 Thread via cfe-commits
cor3ntin wrote: Sorry about that, folks. And thanks for the minimal repro, it's greatly appreciated. I relanded the PR here https://github.com/llvm/llvm-project/pull/139246 I hope that resolves the issue you found https://github.com/llvm/llvm-project/pull/138731

[clang] [Clang] Reland: Diagnose invalid function types in dependent contexts (PR #139246)

2025-05-09 Thread via cfe-commits
@@ -60,3 +61,98 @@ void f3() { f2(0); f2(0); // expected-error {{no matching function for call to 'f2'}} } + +#if __cplusplus >= 202002L +namespace GH138657 { +template // #gh138657-template-head +class meta {}; +template +class meta {}; // expected-error {{called object t

[clang] [Clang] Reland: Diagnose invalid function types in dependent contexts (PR #139246)

2025-05-09 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/139246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CLANG] Allow parsing arbitrary order of attributes for declarations (PR #133107)

2025-05-09 Thread via cfe-commits
https://github.com/DenisGZM updated https://github.com/llvm/llvm-project/pull/133107 >From c46eda67cd7434dcce5c1f29125a940dc4ff64ba Mon Sep 17 00:00:00 2001 From: Denis Gerasimov Date: Wed, 26 Mar 2025 18:29:38 +0300 Subject: [PATCH 1/8] [CLANG] Enable alignas after GNU attributes --- clang/l

[clang] [CIR][NFC] Remove ABI handling from CIRGen call handling (PR #139159)

2025-05-09 Thread Sirui Mu via cfe-commits
https://github.com/Lancern approved this pull request. https://github.com/llvm/llvm-project/pull/139159 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Reland: Diagnose invalid function types in dependent contexts (PR #139246)

2025-05-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: cor3ntin (cor3ntin) Changes When forming an invalid function type, we were not diagnosing it if the call was dependent. However, we later rely on the function type to be sensible during argument deduction. We now diagnose anything that

[clang] [Clang] Fix handling of pack indexing types in constraints of redeclaration (PR #139057)

2025-05-09 Thread Younan Zhang via cfe-commits
@@ -1476,8 +1478,8 @@ namespace { } } -TemplateArgument -getTemplateArgumentPackPatternForRewrite(const TemplateArgument &TA) { +TemplateArgument getTemplateArgumentorUnsubstitutedExpansionPattern( zyn0217 wrote: ```suggestion Templa

[clang] [Clang] Fix handling of pack indexing types in constraints of redeclaration (PR #139057)

2025-05-09 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. one nit, else LG! https://github.com/llvm/llvm-project/pull/139057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] UEFI do not mangle main (PR #139179)

2025-05-09 Thread Prabhu Rajasekaran via cfe-commits
https://github.com/Prabhuk closed https://github.com/llvm/llvm-project/pull/139179 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C] Add new -Wimplicit-int-enum-cast to -Wc++-compat (PR #137658)

2025-05-09 Thread via cfe-commits
asmok-g wrote: @AaronBallman I met another case, giving the same error even after the fix. Sorry I only noticed it now: ``` const char *p; const char *pend; ... return (free (compile_stack.stack), p == pend ? REG_EBRACE : REG_BADBR)); ``` Both REG_EBRACE, REG_BADBR are `reg_errcode_t ` https:/

[clang] [openmp] [OpenMP 6.0 ]Codegen for Reduction over private variables with reduction clause (PR #134709)

2025-05-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- clang/test/OpenMP/for_private_reduction_codegen.cpp

[clang] clang: Remove dest LangAS argument from performAddrSpaceCast (PR #138866)

2025-05-09 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm updated https://github.com/llvm/llvm-project/pull/138866 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-se

[clang] [flang] [llvm] [flang][OpenMP] Pass OpenMP version to getOpenMPDirectiveName (PR #139131)

2025-05-09 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `amdgpu-offload-rhel-8-cmake-build-only` running on `rocm-docker-rhel-8` while building `flang` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/204/builds/8855 Here is the releva

[clang] [Clang] Fix pack indexing profiling (PR #139276)

2025-05-09 Thread via cfe-commits
https://github.com/cor3ntin created https://github.com/llvm/llvm-project/pull/139276 When profiling a pack indexing that has been partially substituted, we should profile the expansions, rather than the pattern itseld This is a better approach to #139057 This mirrors the fix done for SizeOfPa

[clang] [Clang] Fix pack indexing profiling (PR #139276)

2025-05-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules Author: cor3ntin (cor3ntin) Changes When profiling a pack indexing that has been partially substituted, we should profile the expansions, rather than the pattern itseld This is a better approach to #139057 This mirrors the fix done for S

[clang] [Clang] Fix pack indexing profiling (PR #139276)

2025-05-09 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- clang/include/clang/AST/ASTContext.h clang/include/

[clang] [Clang] Fix pack indexing profiling (PR #139276)

2025-05-09 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. Thanks for the iteration! https://github.com/llvm/llvm-project/pull/139276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix pack indexing profiling (PR #139276)

2025-05-09 Thread Younan Zhang via cfe-commits
@@ -4549,6 +4549,10 @@ class PackIndexingExpr final bool isFullySubstituted() const { return FullySubstituted; } + bool isPartiallySubstituted() const { +return isValueDependent() && TransformedExpressions; + }; zyn0217 wrote: Trailing semicolon htt

[clang] [Clang] Fix pack indexing profiling (PR #139276)

2025-05-09 Thread Younan Zhang via cfe-commits
@@ -4549,6 +4549,10 @@ class PackIndexingExpr final bool isFullySubstituted() const { return FullySubstituted; } + bool isPartiallySubstituted() const { zyn0217 wrote: Please document the difference with FullySubstituted https://github.com/llvm/llvm-proj

[clang] [Clang] Improve ``-Wtautological-overlap-compare`` diagnostics flag (PR #133653)

2025-05-09 Thread Yutong Zhu via cfe-commits
https://github.com/YutongZhuu edited https://github.com/llvm/llvm-project/pull/133653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix handling of pack indexing types in constraints of redeclaration (PR #139057)

2025-05-09 Thread via cfe-commits
cor3ntin wrote: After chatting with @zyn0217, we realized there was a better approach. #139276 https://github.com/llvm/llvm-project/pull/139057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] [OpenMP] Fix crash when diagnosing dist_schedule (PR #139277)

2025-05-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes We were failing to pass a required argument when emitting the diagnostic, so the source range was being used in place of an index. This caused a failed assertion due to the incorrect index. Fixes #139

[clang] [OpenMP] Fix crash when diagnosing dist_schedule (PR #139277)

2025-05-09 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/139277 We were failing to pass a required argument when emitting the diagnostic, so the source range was being used in place of an index. This caused a failed assertion due to the incorrect index. Fixes #139266

[clang] [Clang] Fix pack indexing profiling (PR #139276)

2025-05-09 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. I like this better too. https://github.com/llvm/llvm-project/pull/139276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [cfi][NFCI] Pre-commit -fsanitize-annotate-debug-info tests for CFI (PR #139149)

2025-05-09 Thread Thurston Dang via cfe-commits
https://github.com/thurstond updated https://github.com/llvm/llvm-project/pull/139149 >From c2a5ecf9d89b4942fb1e95c7a7713585155099d0 Mon Sep 17 00:00:00 2001 From: Thurston Dang Date: Thu, 8 May 2025 20:18:22 + Subject: [PATCH 1/4] [cfi][NFCI] Pre-commit -fsanitize-annotate-debug-info test

[clang] [openmp] [OpenMP 6.0 ]Codegen for Reduction over private variables with reduction clause (PR #134709)

2025-05-09 Thread CHANDRA GHALE via cfe-commits
https://github.com/chandraghale updated https://github.com/llvm/llvm-project/pull/134709 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,s

[clang] [openmp] [OpenMP 6.0 ]Codegen for Reduction over private variables with reduction clause (PR #134709)

2025-05-09 Thread CHANDRA GHALE via cfe-commits
@@ -0,0 +1,93 @@ +//RUN: %libomp-cxx-compile -fopenmp-version=60 && %libomp-run +#include +#include +#include "omp_testsuite.h" + +#define N 10 +class Sum { + int val; + +public: + Sum(int v = 0) : val(v) {} + Sum operator+(const Sum &rhs) const { return Sum(val + rhs.val);

[clang] [openmp] [OpenMP 6.0 ]Codegen for Reduction over private variables with reduction clause (PR #134709)

2025-05-09 Thread CHANDRA GHALE via cfe-commits
@@ -0,0 +1,93 @@ +//RUN: %libomp-cxx-compile -fopenmp-version=60 && %libomp-run +#include +#include +#include "omp_testsuite.h" + +#define N 10 +class Sum { + int val; + +public: + Sum(int v = 0) : val(v) {} + Sum operator+(const Sum &rhs) const { return Sum(val + rhs.val);

[clang] [OpenMP] Fix crash when diagnosing dist_schedule (PR #139277)

2025-05-09 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. https://github.com/llvm/llvm-project/pull/139277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b249b49 - [OpenMP] Fix crash when diagnosing dist_schedule (#139277)

2025-05-09 Thread via cfe-commits
Author: Aaron Ballman Date: 2025-05-09T11:12:19-04:00 New Revision: b249b49c133d0b4e1e2505dfd0a53f4da50d2a7a URL: https://github.com/llvm/llvm-project/commit/b249b49c133d0b4e1e2505dfd0a53f4da50d2a7a DIFF: https://github.com/llvm/llvm-project/commit/b249b49c133d0b4e1e2505dfd0a53f4da50d2a7a.diff

[clang] [Clang] Improve ``-Wtautological-overlap-compare`` diagnostics flag (PR #133653)

2025-05-09 Thread Yutong Zhu via cfe-commits
https://github.com/YutongZhuu updated https://github.com/llvm/llvm-project/pull/133653 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,san

[clang] Thread Safety Analysis: Support reentrant capabilities (PR #137133)

2025-05-09 Thread Marco Elver via cfe-commits
@@ -1011,6 +979,30 @@ void SExprBuilder::exitCFG(const CFGBlock *Last) { IncompleteArgs.clear(); } +static CapabilityExpr makeCapabilityExpr(const til::SExpr *E, QualType VDT, + bool Neg) { + // We need to look at the declaration of t

[clang-tools-extra] Add check 'modernize-use-enum-class' (PR #138282)

2025-05-09 Thread Baranov Victor via cfe-commits
@@ -0,0 +1,31 @@ +.. title:: clang-tidy - cppcoreguidelines-use-enum-class + +cppcoreguidelines-use-enum-class += vbvictor wrote: ```suggestion cppcoreguidelines-use-enum-class ``` https://github.com/l

[clang] [libcxx] [llvm] [Clang] Add warnings when mixing different charN_t types (PR #138708)

2025-05-09 Thread Aaron Ballman via cfe-commits
@@ -111,6 +111,7 @@ def EnumConversion : DiagGroup<"enum-conversion", ImplicitEnumEnumCast, EnumFloatConversion, EnumCompareConditional]>; +def ImplicitUnicodeConversion : DiagGroup<

[clang] [Clang] Improve ``-Wtautological-overlap-compare`` diagnostics flag (PR #133653)

2025-05-09 Thread Yutong Zhu via cfe-commits
https://github.com/YutongZhuu updated https://github.com/llvm/llvm-project/pull/133653 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,san

[clang] [llvm] [clang][DebugInfo] Add symbol for debugger with VTable information. (PR #130255)

2025-05-09 Thread Carlos Alberto Enciso via cfe-commits
CarlosAlbertoEnciso wrote: Uploaded a patch that eliminates the global variable and it moves the vtable information into the static member; in that way, a consumer always will have access to the vtable information, just by having an object instance or the object definition. The patch has been

[clang] clang: Remove dest LangAS argument from performAddrSpaceCast (PR #138866)

2025-05-09 Thread John McCall via cfe-commits
rjmccall wrote: Merging this was fine because it was just removing the redundant LangAS argument, not removing the abstract handling of address-space conversions in IRGen. I just wanted to note my opposition to the idea of taking that second step, since it had come up in the review. https://g

[clang-tools-extra] Add check 'modernize-use-enum-class' (PR #138282)

2025-05-09 Thread Baranov Victor via cfe-commits
@@ -59,6 +60,8 @@ class CppCoreGuidelinesModule : public ClangTidyModule { void addCheckFactories(ClangTidyCheckFactories &CheckFactories) override { CheckFactories.registerCheck( "cppcoreguidelines-avoid-capturing-lambda-coroutines"); +CheckFactories.register

[clang] [flang] [llvm] [openmp] [Clang][OpenMP][LoopTransformations] Add support for "#pragma omp fuse" and clause LoopRange (PR #139293)

2025-05-09 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [StaticAnalyzer] Handle `__builtin_bit_cast` (PR #139188)

2025-05-09 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/139188 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [openmp] [Clang][OpenMP][LoopTransformations] Add support for "#pragma omp fuse" and clause LoopRange (PR #139293)

2025-05-09 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-flang-openmp @llvm/pr-subscribers-clang Author: Walter J.T.V (eZWALT) Changes This pull request introduces full support for the #pragma omp fuse directive, as specified in the OpenMP 6.0 specification, along with initial support for the looprange claus

[clang] [flang] [llvm] [openmp] [Clang][OpenMP][LoopTransformations] Add support for "#pragma omp fuse" loop transformation direcrive and "looprange" clause (PR #139293)

2025-05-09 Thread Walter J.T.V via cfe-commits
https://github.com/eZWALT edited https://github.com/llvm/llvm-project/pull/139293 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [openmp] [OpenMP 6.0 ]Codegen for Reduction over private variables with reduction clause (PR #134709)

2025-05-09 Thread CHANDRA GHALE via cfe-commits
https://github.com/chandraghale updated https://github.com/llvm/llvm-project/pull/134709 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,s

[clang-tools-extra] Add check 'modernize-use-enum-class' (PR #138282)

2025-05-09 Thread Philipp Jung via cfe-commits
@@ -0,0 +1,26 @@ +.. title:: clang-tidy - modernize-use-enum-class + +modernize-use-enum-class += + +Scoped enums (enum class) should be preferred over unscoped enums: +https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Renum-class + +Unscoped

[clang] [Clang][Driver] Fix condition in combineBackendCompile when using -no-integrated-cpp (PR #136853)

2025-05-09 Thread Jacob Lambert via cfe-commits
Juan Manuel Martinez =?utf-8?q?Caamaño?= Message-ID: In-Reply-To: https://github.com/lamb-j approved this pull request. lgtm. Seems more aligned with the intended behavior, and updates to use types::isLLVMIR() API instead of individually checking getType() https://github.com/llvm/llvm-projec

[clang] Thread Safety Analysis: Support reentrant capabilities (PR #137133)

2025-05-09 Thread Marco Elver via cfe-commits
@@ -271,26 +272,34 @@ class CFGWalker { // translateAttrExpr needs it, but that should be moved too. class CapabilityExpr { private: - /// The capability expression and whether it's negated. - llvm::PointerIntPair CapExpr; + static constexpr unsigned FlagNegative = 1u << 0;

[clang] 9be4d64 - [HLSL][RootSignature] Add optional parameters for RootConstants (#138007)

2025-05-09 Thread via cfe-commits
Author: Finn Plummer Date: 2025-05-09T10:46:37-07:00 New Revision: 9be4d64ba0a241bfa36c7c81bca2e12b337ebccc URL: https://github.com/llvm/llvm-project/commit/9be4d64ba0a241bfa36c7c81bca2e12b337ebccc DIFF: https://github.com/llvm/llvm-project/commit/9be4d64ba0a241bfa36c7c81bca2e12b337ebccc.diff

[clang] [llvm] [HLSL][RootSignature] Add optional parameters for RootConstants (PR #138007)

2025-05-09 Thread Finn Plummer via cfe-commits
https://github.com/inbelic closed https://github.com/llvm/llvm-project/pull/138007 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix handling of pack indexing types in constraints of redeclaration (PR #139057)

2025-05-09 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/139057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [openmp] [Clang][OpenMP][LoopTransformations] Add support for "#pragma omp fuse" loop transformation direcrive and "looprange" clause (PR #139293)

2025-05-09 Thread Alexey Bataev via cfe-commits
@@ -962,6 +962,9 @@ class OMPLoopTransformationDirective : public OMPLoopBasedDirective { /// Number of loops generated by this loop transformation. unsigned NumGeneratedLoops = 0; + /// Number of top level canonical loop nests generated by this loop + /// transformatio

[clang] Better diagnostics when assertion fails in `consteval` (PR #130458)

2025-05-09 Thread JJ Marr via cfe-commits
https://github.com/jj-marr ready_for_review https://github.com/llvm/llvm-project/pull/130458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Better diagnostics when assertion fails in `consteval` (PR #130458)

2025-05-09 Thread JJ Marr via cfe-commits
https://github.com/jj-marr updated https://github.com/llvm/llvm-project/pull/130458 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-s

[clang] [Clang][Sema] Handle invalid variable template specialization whose type depends on itself (PR #134522)

2025-05-09 Thread Shafik Yaghmour via cfe-commits
shafik wrote: This was flagged in the following issue: https://github.com/llvm/llvm-project/issues/139067#issuecomment-2865530760 https://github.com/llvm/llvm-project/pull/134522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [OpenMP] Fix crash with invalid argument to simd collapse (PR #139313)

2025-05-09 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. https://github.com/llvm/llvm-project/pull/139313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Better diagnostics when assertion fails in `consteval` (PR #130458)

2025-05-09 Thread JJ Marr via cfe-commits
https://github.com/jj-marr updated https://github.com/llvm/llvm-project/pull/130458 >From 3b6d28e4f74c1fda73abe3b5972d5ac2a43576de Mon Sep 17 00:00:00 2001 From: JJ Marr Date: Sat, 8 Mar 2025 22:00:45 -0500 Subject: [PATCH] Explain which assertion failed during consteval --- clang/docs/Releas

[clang] Better diagnostics when assertion fails in `consteval` (PR #130458)

2025-05-09 Thread JJ Marr via cfe-commits
https://github.com/jj-marr updated https://github.com/llvm/llvm-project/pull/130458 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-s

[clang] [llvm] [HLSL][RootSignature] Add parsing for RootFlags (PR #138055)

2025-05-09 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-aarch64-darwin` running on `doug-worker-4` while building `clang,llvm` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/190/builds/19748 Here

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

2025-05-09 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: This one is still broken https://lab.llvm.org/buildbot/#/builders/55/builds/11054/steps/11/logs/stdio https://github.com/llvm/llvm-project/pull/138234 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [flang] [llvm] [openmp] [Clang][OpenMP][LoopTransformations] Add support for "#pragma omp fuse" loop transformation direcrive and "looprange" clause (PR #139293)

2025-05-09 Thread Alexey Bataev via cfe-commits
@@ -14145,6 +14152,46 @@ StmtResult SemaOpenMP::ActOnOpenMPTargetTeamsDistributeSimdDirective( getASTContext(), StartLoc, EndLoc, NestedLoopCount, Clauses, AStmt, B); } +// Overloaded base case function +template static bool tryHandleAs(T *t, F &&) { + return false; +

[clang] [llvm] [HLSL][RootSignature] Define and integrate rootsig clang attr and decl (PR #137690)

2025-05-09 Thread Finn Plummer via cfe-commits
https://github.com/inbelic updated https://github.com/llvm/llvm-project/pull/137690 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-s

[clang] [flang] [llvm] [openmp] [Clang][OpenMP][LoopTransformations] Add support for "#pragma omp fuse" loop transformation direcrive and "looprange" clause (PR #139293)

2025-05-09 Thread Alexey Bataev via cfe-commits
@@ -14145,6 +14152,46 @@ StmtResult SemaOpenMP::ActOnOpenMPTargetTeamsDistributeSimdDirective( getASTContext(), StartLoc, EndLoc, NestedLoopCount, Clauses, AStmt, B); } +// Overloaded base case function alexey-bataev wrote: ```suggestion /// Overloaded

[clang] [HLSL] Update Sema Checking Diagnostics for builtins (PR #138429)

2025-05-09 Thread Helena Kotas via cfe-commits
@@ -2164,30 +2085,49 @@ static bool CheckModifiableLValue(Sema *S, CallExpr *TheCall, return true; } -static bool CheckNoDoubleVectors(Sema *S, CallExpr *TheCall) { - auto checkDoubleVector = [](clang::QualType PassedType) -> bool { -if (const auto *VecTy = PassedType-

[clang] [HLSL] Update Sema Checking Diagnostics for builtins (PR #138429)

2025-05-09 Thread Helena Kotas via cfe-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/138429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Update Sema Checking Diagnostics for builtins (PR #138429)

2025-05-09 Thread Helena Kotas via cfe-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/138429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Update Sema Checking Diagnostics for builtins (PR #138429)

2025-05-09 Thread Helena Kotas via cfe-commits
@@ -42,47 +42,47 @@ float2 test_mad_element_type_mismatch(half2 p0, float2 p1) { float2 test_builtin_mad_float2_splat(float p0, float2 p1) { return __builtin_hlsl_mad(p0, p1, p1); - // expected-error@-1 {{all arguments to '__builtin_hlsl_mad' must be vectors}} + // expect

[clang] [HLSL] Update Sema Checking Diagnostics for builtins (PR #138429)

2025-05-09 Thread Helena Kotas via cfe-commits
https://github.com/hekota commented: Look good! One suggestion and a one question why the diag message uses has `double` when the argument is `float`. https://github.com/llvm/llvm-project/pull/138429 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [clang][Darwin] Remove legacy framework search path logic in the frontend (PR #138234)

2025-05-09 Thread Ian Anderson via cfe-commits
ian-twilightcoder wrote: > This one is still broken > https://lab.llvm.org/buildbot/#/builders/55/builds/11054/steps/11/logs/stdio I can't figure how this change would affect that, but let me give BuildSyntaxTreeTest a try. https://github.com/llvm/llvm-project/pull/138234

[clang] df053d6 - [HLSL][NFC] Test cleanup - remove function attributes (#139302)

2025-05-09 Thread via cfe-commits
Author: Helena Kotas Date: 2025-05-09T14:14:52-07:00 New Revision: df053d68ca5d59e48a2751188423e7c95c348dc1 URL: https://github.com/llvm/llvm-project/commit/df053d68ca5d59e48a2751188423e7c95c348dc1 DIFF: https://github.com/llvm/llvm-project/commit/df053d68ca5d59e48a2751188423e7c95c348dc1.diff

[clang] [HLSL][NFC] Test cleanup - remove function attributes (PR #139302)

2025-05-09 Thread Helena Kotas via cfe-commits
https://github.com/hekota closed https://github.com/llvm/llvm-project/pull/139302 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP] implementation set controls elision for begin declare variant (PR #139287)

2025-05-09 Thread Johannes Doerfert via cfe-commits
https://github.com/jdoerfert updated https://github.com/llvm/llvm-project/pull/139287 >From 4ae732bc3cb75a694e0c527a323459dfe048ea2e Mon Sep 17 00:00:00 2001 From: Johannes Doerfert Date: Fri, 9 May 2025 09:10:39 -0700 Subject: [PATCH] [OpenMP] implementation set triggers elision for begin dec

[clang] b1c7801 - [Clang][NFC] Adding note on details that are not immediately obvious (#138349)

2025-05-09 Thread via cfe-commits
Author: Shafik Yaghmour Date: 2025-05-09T14:23:45-07:00 New Revision: b1c7801069aac6c3dcaf47d15a2d723b0389cfde URL: https://github.com/llvm/llvm-project/commit/b1c7801069aac6c3dcaf47d15a2d723b0389cfde DIFF: https://github.com/llvm/llvm-project/commit/b1c7801069aac6c3dcaf47d15a2d723b0389cfde.dif

[clang] [clang] Warn about deprecated volatile-qualified return types (PR #137899)

2025-05-09 Thread via cfe-commits
halbi2 wrote: @cor3ntin yes, please. https://github.com/llvm/llvm-project/pull/137899 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-09 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,85 @@ +//===-- HTMLMustacheGenerator.cpp - HTML Mustache Generator -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [Clang][NFC] Adding note on details that are not immediately obvious (PR #138349)

2025-05-09 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik closed https://github.com/llvm/llvm-project/pull/138349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c9d8ff0 - [OpenACC][CIR] Implement 'num_gangs' lowering for combined constructs

2025-05-09 Thread via cfe-commits
Author: erichkeane Date: 2025-05-09T14:42:48-07:00 New Revision: c9d8ff081e765bad484deaf0d211e9929319d111 URL: https://github.com/llvm/llvm-project/commit/c9d8ff081e765bad484deaf0d211e9929319d111 DIFF: https://github.com/llvm/llvm-project/commit/c9d8ff081e765bad484deaf0d211e9929319d111.diff LO

[clang] [SystemZ][z/OS] Add visibility features for z/OS (eg. _Export, pragma export) (PR #111035)

2025-05-09 Thread Hubert Tong via cfe-commits
@@ -4504,6 +4504,11 @@ void Parser::ParseDeclarationSpecifiers( isInvalid = DS.setFunctionSpecNoreturn(Loc, PrevSpec, DiagID); break; +case tok::kw__Export: + // We're done with the declaration-specifiers. + goto DoneWithDeclSpec; hub

[clang] 8293955 - [OpenACC][CIR] Lower 'num_workers' for combined constructs

2025-05-09 Thread via cfe-commits
Author: erichkeane Date: 2025-05-09T14:54:16-07:00 New Revision: 829395591ebf248a9fb57dbed6a8383db4ba6e00 URL: https://github.com/llvm/llvm-project/commit/829395591ebf248a9fb57dbed6a8383db4ba6e00 DIFF: https://github.com/llvm/llvm-project/commit/829395591ebf248a9fb57dbed6a8383db4ba6e00.diff LO

[clang] [Clang] Improve ``-Wtautological-overlap-compare`` diagnostics flag (PR #133653)

2025-05-09 Thread Yutong Zhu via cfe-commits
YutongZhuu wrote: I believe this is ready :) https://github.com/llvm/llvm-project/pull/133653 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP] implementation set controls elision for begin declare variant (PR #139287)

2025-05-09 Thread Johannes Doerfert via cfe-commits
https://github.com/jdoerfert updated https://github.com/llvm/llvm-project/pull/139287 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans

[clang-tools-extra] [clang-doc] Add HTMLMustacheGenerator.cpp (PR #138060)

2025-05-09 Thread Paul Kirth via cfe-commits
@@ -0,0 +1,85 @@ +//===-- HTMLMustacheGenerator.cpp - HTML Mustache Generator -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] 716062d - [OpenACC][CIR] Lowering for vector_length on combined constructs

2025-05-09 Thread via cfe-commits
Author: erichkeane Date: 2025-05-09T15:05:29-07:00 New Revision: 716062d943211bf8841a57d8211714fb33bf9858 URL: https://github.com/llvm/llvm-project/commit/716062d943211bf8841a57d8211714fb33bf9858 DIFF: https://github.com/llvm/llvm-project/commit/716062d943211bf8841a57d8211714fb33bf9858.diff LO

[clang] [llvm] [mlir] [AMDGPU] Add a new amdgcn.load.to.lds intrinsic (PR #137425)

2025-05-09 Thread Krzysztof Drewniak via cfe-commits
krzysz00 wrote: Ping https://github.com/llvm/llvm-project/pull/137425 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang/OpenCL: Fix special casing OpenCL in call emission (PR #138864)

2025-05-09 Thread Matt Arsenault via cfe-commits
arsenm wrote: ### Merge activity * **May 9, 8:13 AM EDT**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/138864). https://github.com/llvm/llvm-project/pull/138864 __

[clang] Reland "Reland [Modules] Remove unnecessary check when generating name lookup table in ASTWriter" (PR #139253)

2025-05-09 Thread Haojian Wu via cfe-commits
https://github.com/hokein created https://github.com/llvm/llvm-project/pull/139253 This relands the patch https://github.com/llvm/llvm-project/commit/67b298f6d82e0b4bb648ac0dabe895e816a77ef1 >From 47211ed01154f9b53395b1c4c33014c7d3bf3c25 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Fri, 9

[clang] Reland "Reland [Modules] Remove unnecessary check when generating name lookup table in ASTWriter" (PR #139253)

2025-05-09 Thread Haojian Wu via cfe-commits
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/139253 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SystemZ][z/OS] Add visibility features for z/OS (eg. _Export, pragma export) (PR #111035)

2025-05-09 Thread Erich Keane via cfe-commits
@@ -7552,6 +7552,27 @@ attribute requires a string literal argument to identify the handle being releas }]; } +def zOSExportDocs : Documentation { + let Category = DocCatFunction; + let Content = [{ +Use the ``_Export`` keyword on a function or external variable to declar

[clang] [SystemZ][z/OS] Add visibility features for z/OS (eg. _Export, pragma export) (PR #111035)

2025-05-09 Thread Erich Keane via cfe-commits
https://github.com/erichkeane commented: There seems to be a LOT of added complexity for the `#pragma export`, to the point that I'm not sure of the value compared to the keyword, and if we're going to keep it, we need to spend quite a bit more time on it. As far as the keyword itself, I think

[clang] [SystemZ][z/OS] Add visibility features for z/OS (eg. _Export, pragma export) (PR #111035)

2025-05-09 Thread Erich Keane via cfe-commits
https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/111035 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SystemZ][z/OS] Add visibility features for z/OS (eg. _Export, pragma export) (PR #111035)

2025-05-09 Thread Erich Keane via cfe-commits
@@ -4504,6 +4504,11 @@ void Parser::ParseDeclarationSpecifiers( isInvalid = DS.setFunctionSpecNoreturn(Loc, PrevSpec, DiagID); break; +case tok::kw__Export: + // We're done with the declaration-specifiers. + goto DoneWithDeclSpec; eri

[clang] [SystemZ][z/OS] Add visibility features for z/OS (eg. _Export, pragma export) (PR #111035)

2025-05-09 Thread Erich Keane via cfe-commits
@@ -7552,6 +7552,27 @@ attribute requires a string literal argument to identify the handle being releas }]; } +def zOSExportDocs : Documentation { + let Category = DocCatFunction; + let Content = [{ +Use the ``_Export`` keyword on a function or external variable to declar

[clang] [SystemZ][z/OS] Add visibility features for z/OS (eg. _Export, pragma export) (PR #111035)

2025-05-09 Thread Erich Keane via cfe-commits
@@ -1400,6 +1416,171 @@ bool Parser::HandlePragmaMSAllocText(StringRef PragmaName, return true; } +NestedNameSpecifier * +Parser::zOSParseIdentifier(StringRef PragmaName, + const IdentifierInfo *IdentName) { + NestedNameSpecifier *NestedId = nullp

[clang] [Sema] Refactor IsFunctionConversion (PR #139172)

2025-05-09 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/139172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC][CIR] Impl default/seq lowering for combined constructs (PR #139263)

2025-05-09 Thread Erich Keane via cfe-commits
https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/139263 This adds two clauses plus the infrastructure for emitting the clauses on combined constructs. Combined constructs require two operations, so this makes sure we emit on the 'correct' one. It DOES require t

[clang] [StaticAnalyzer] Handle `__builtin_bit_cast` (PR #139188)

2025-05-09 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat commented: Overall LGTM, thanks for fixing this crash! I dropped one (somewhat paranoid) inline question. Moreover, I would suggest following the [coding standard](https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly)

[clang] [Clang] Fix handling of pack indexing types in constraints of redeclaration (PR #139057)

2025-05-09 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/139057 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-

<    1   2   3   4   5   6   >