Juan Manuel Martinez =?utf-8?q?Caamaño?= <juama...@amd.com> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/137...@github.com>
lamb-j wrote: > module maps don't get preprocessed, so I don't think it matters what that is > set to. For normal module.modulemap files `Preprocessed` is `false`. I think > it's fine to remove the true and see if anything breaks, the preprocessor > just skips over that section anyway. Thanks for the pointer. @Bigcheese who should we solicit an approving review from? I'm not familiar enough with the implications of the change to feel confident approving https://github.com/llvm/llvm-project/pull/137665 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits