[clang] bc9aa0f - [C] Add -Wtentative-definition-compat (#137967)

2025-05-01 Thread via cfe-commits
Author: Aaron Ballman Date: 2025-05-01T07:31:48-04:00 New Revision: bc9aa0f4c4c6ad9dd6207097478f4e461a8fe5cb URL: https://github.com/llvm/llvm-project/commit/bc9aa0f4c4c6ad9dd6207097478f4e461a8fe5cb DIFF: https://github.com/llvm/llvm-project/commit/bc9aa0f4c4c6ad9dd6207097478f4e461a8fe5cb.diff

[clang] [C] Add -Wtentative-definition-compat (PR #137967)

2025-05-01 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/137967 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 212f245 - [include-cleaner] rename enabled flags to `disable-*` (#132991)

2025-05-01 Thread via cfe-commits
Author: Mohamed Emad Date: 2025-05-01T07:21:50-04:00 New Revision: 212f2456fcde822fad37bfa4e69ced1a51a4c19d URL: https://github.com/llvm/llvm-project/commit/212f2456fcde822fad37bfa4e69ced1a51a4c19d DIFF: https://github.com/llvm/llvm-project/commit/212f2456fcde822fad37bfa4e69ced1a51a4c19d.diff

[clang] [OpenMP 6.0 ]Codegen for Reduction over private variables with reduction clause (PR #134709)

2025-05-01 Thread CHANDRA GHALE via cfe-commits
chandraghale wrote: Refactored code to look up the expression and handle UDR, emitting it as is. updated the lit test. https://github.com/llvm/llvm-project/pull/134709 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang-tools-extra] [include-cleaner] rename enabled flags to `disable-*` (PR #132991)

2025-05-01 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/132991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM][Clang][Cygwin] Fix building Clang for Cygwin (PR #134494)

2025-05-01 Thread Mateusz Mikuła via cfe-commits
https://github.com/mati865 updated https://github.com/llvm/llvm-project/pull/134494 From b7a5fab29b810f72f2ffa65fb0945abd302c2411 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateusz=20Miku=C5=82a?= Date: Sat, 5 Apr 2025 13:18:35 +0200 Subject: [PATCH 1/4] [LLVM][Cygwin] Fix Signals compatibility w

[clang] 75d1cce - Add missing RUN lines to test

2025-05-01 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2025-05-01T07:25:28-04:00 New Revision: 75d1cceb948666af9b2cb26fc3933d4176a2806d URL: https://github.com/llvm/llvm-project/commit/75d1cceb948666af9b2cb26fc3933d4176a2806d DIFF: https://github.com/llvm/llvm-project/commit/75d1cceb948666af9b2cb26fc3933d4176a2806d.diff

[clang] [llvm] [LLVM][Clang][Cygwin] Fix building Clang for Cygwin (PR #134494)

2025-05-01 Thread Mateusz Mikuła via cfe-commits
https://github.com/mati865 converted_to_draft https://github.com/llvm/llvm-project/pull/134494 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libclc] Support the generic address space (PR #137183)

2025-05-01 Thread Matt Arsenault via cfe-commits
@@ -23,4 +23,20 @@ #define _CLC_DEF __attribute__((always_inline)) #endif +#if __OPENCL_C_VERSION__ == CL_VERSION_2_0 || \ +(__OPENCL_C_VERSION__ >= CL_VERSION_3_0 && \ + defined(__opencl_c_generic_addr

[clang] [Clang][Cygwin] Fix symbol visibility definition (PR #138118)

2025-05-01 Thread Mateusz Mikuła via cfe-commits
https://github.com/mati865 created https://github.com/llvm/llvm-project/pull/138118 Currently building for Cygwin hits this error: ``` In file included from /h/projects/llvm-project/clang/lib/Basic/Attributes.cpp:17: /h/projects/llvm-project/clang/include/clang/Basic/ParsedAttrInfo.h:180:73: e

[clang] [flang] [llvm] [TargetVerifier][AMDGPU] Add TargetVerifier. (PR #123609)

2025-05-01 Thread via cfe-commits
https://github.com/jofrn updated https://github.com/llvm/llvm-project/pull/123609 Rate limit · GitHub body { background-color: #f6f8fa; color: #24292e; font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Helvetica,Arial,sans-ser

[clang] [CIR] Upstream pointer arithmetic support (PR #138041)

2025-05-01 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko approved this pull request. lgtm, besides Erich's comments https://github.com/llvm/llvm-project/pull/138041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream pointer arithmetic support (PR #138041)

2025-05-01 Thread Henrich Lauko via cfe-commits
https://github.com/xlauko edited https://github.com/llvm/llvm-project/pull/138041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream pointer arithmetic support (PR #138041)

2025-05-01 Thread Henrich Lauko via cfe-commits
@@ -185,6 +185,15 @@ class CIRGenBuilderTy : public cir::CIRBaseBuilderTy { } bool isInt(mlir::Type i) { return mlir::isa(i); } + // + // Constant creation helpers + // - + // + cir::ConstantOp getSInt32(int32_t c, mlir::Location loc) { +au

[clang] [Clang] Do not warn for serialized builtin or command-line definitions (PR #137306)

2025-05-01 Thread Juan Manuel Martinez Caamaño via cfe-commits
https://github.com/jmmartinez closed https://github.com/llvm/llvm-project/pull/137306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Do not warn for serialized builtin or command-line definitions (PR #137306)

2025-05-01 Thread Juan Manuel Martinez Caamaño via cfe-commits
jmmartinez wrote: Thanks ! https://github.com/llvm/llvm-project/pull/137306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0d3d2f6 - [Clang] Do not warn for serialized builtin or command-line definitions (#137306)

2025-05-01 Thread via cfe-commits
Author: Juan Manuel Martinez Caamaño Date: 2025-05-01T09:55:46+02:00 New Revision: 0d3d2f639c42b22fc1b9453c7b834dbb0f16c0dc URL: https://github.com/llvm/llvm-project/commit/0d3d2f639c42b22fc1b9453c7b834dbb0f16c0dc DIFF: https://github.com/llvm/llvm-project/commit/0d3d2f639c42b22fc1b9453c7b834db

[clang] [Clang][NFC] Use std::move to avoid copy (PR #138073)

2025-05-01 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/138073 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Warning as error for fold expressions over comparison operators (PR #136836)

2025-05-01 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. Okay, let's go ahead as is. Though I feel it's unfortunate that the warnings for left fold and right fold are scattered - maybe we could clean them up in future Thanks for working on this. https://github.com/llvm/llvm-project/pull/136836

[clang] [libclang/python] Add some logical typing changes. (PR #138074)

2025-05-01 Thread Jannick Kremer via cfe-commits
DeinAlptraum wrote: Which parts do you mean? The `__eq__` operators for other objects? https://github.com/llvm/llvm-project/pull/138074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Cygwin] Fix symbol visibility definition (PR #138118)

2025-05-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mateusz Mikuła (mati865) Changes Currently building for Cygwin hits this error: ``` In file included from /h/projects/llvm-project/clang/lib/Basic/Attributes.cpp:17: /h/projects/llvm-project/clang/include/clang/Basic/ParsedAttrInfo.h:180:7

[clang] [C] Add -Wjump-bypasses-init (PR #138009)

2025-05-01 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. Please add a test for the new indirect goto diagnostic. Otherwise LGTM https://github.com/llvm/llvm-project/pull/138009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] [llvm] [clang][amdgpu] Add builtins for raw/struct buffer lds load (PR #137678)

2025-05-01 Thread Krzysztof Drewniak via cfe-commits
krzysz00 wrote: > It does, we should have a consistent set of buffer builtins To specify what I _think_ the proposed rewrite is, it's auto-upgrading or otherwise transforming ```llvm %r = call T llvm.amdgcn.{raw,struct}.buffer.*(<4 x i32> %rsrc, ...) ``` into ```llvm %rsrc.int = bitcast <4 x i3

[clang-tools-extra] [llvm] [clang-doc] Adds a mustache backend (PR #133161)

2025-05-01 Thread Paul Kirth via cfe-commits
ilovepi wrote: @PeterChou1 I've uploaded a patch set w/ the relevant changes from this patch. Some of the details were split into standalone patches, but I'd appreciate if you could help both review and test those patches. It would also be nice if you could share any testing corpus or lit test

[clang] [Clang][OpenCL][AMDGPU] OpenCL Kernel stubs should be assigned alwaysinline attribute (PR #137769)

2025-05-01 Thread Matt Arsenault via cfe-commits
arsenm wrote: Apparently the inliner has an arbitrary size threshold even for single uses. I don't see the point of that, we should probably remove that https://github.com/llvm/llvm-project/pull/137769 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] [llvm] [clang][amdgpu] Add builtins for raw/struct buffer lds load (PR #137678)

2025-05-01 Thread Krzysztof Drewniak via cfe-commits
krzysz00 wrote: Side note, if we're cleaning up the API, we really should add s.buffer.load.real that actually models the memory effects correctly https://github.com/llvm/llvm-project/pull/137678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [CUDA][HIP] Fix implicit attribute of builtin (PR #138162)

2025-05-01 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/138162 >From 7b139b3a06e45f7429e1e0f15eb16d0c3aed5718 Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Thu, 1 May 2025 12:08:05 -0400 Subject: [PATCH] [CUDA][HIP] Fix implicit attribute of builtin When a builti

[clang] [Clang][OpenCL][AMDGPU] OpenCL Kernel stubs should be assigned alwaysinline attribute (PR #137769)

2025-05-01 Thread Matt Arsenault via cfe-commits
@@ -6174,6 +6174,19 @@ void CodeGenModule::EmitGlobalFunctionDefinition(GlobalDecl GD, CodeGenFunction(*this).GenerateCode(GD, Fn, FI); setNonAliasAttributes(GD, Fn); + + bool ShouldAddOptNone = !CodeGenOpts.DisableO0ImplyOptNone && + (CodeGenOpt

[clang] [Clang][OpenCL][AMDGPU] OpenCL Kernel stubs should be assigned alwaysinline attribute (PR #137769)

2025-05-01 Thread Matt Arsenault via cfe-commits
@@ -6174,6 +6174,19 @@ void CodeGenModule::EmitGlobalFunctionDefinition(GlobalDecl GD, CodeGenFunction(*this).GenerateCode(GD, Fn, FI); setNonAliasAttributes(GD, Fn); + + bool ShouldAddOptNone = !CodeGenOpts.DisableO0ImplyOptNone && + (CodeGenOpt

[clang] [Clang][OpenCL][AMDGPU] OpenCL Kernel stubs should be assigned alwaysinline attribute (PR #137769)

2025-05-01 Thread Matt Arsenault via cfe-commits
@@ -6174,6 +6174,19 @@ void CodeGenModule::EmitGlobalFunctionDefinition(GlobalDecl GD, CodeGenFunction(*this).GenerateCode(GD, Fn, FI); setNonAliasAttributes(GD, Fn); + + bool ShouldAddOptNone = !CodeGenOpts.DisableO0ImplyOptNone && + (CodeGenOpt

[clang] [CIR] Refactor IntType constraints (PR #138106)

2025-05-01 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/138106 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Upstream cir.call with scalar arguments (PR #136810)

2025-05-01 Thread Sirui Mu via cfe-commits
https://github.com/Lancern updated https://github.com/llvm/llvm-project/pull/136810 >From e9334137d0d1b968ac4d0e59af9f1b04e6b639ac Mon Sep 17 00:00:00 2001 From: Sirui Mu Date: Fri, 2 May 2025 00:31:08 +0800 Subject: [PATCH] [CIR] Upstream cir.call with scalar arguments --- .../CIR/Dialect/Bu

[clang] [mlir] [OpenACC][CIR] Implement Loop lowering of seq/auto/independent (PR #138164)

2025-05-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Erich Keane (erichkeane) Changes These just add a standard 'device_type' flag to the acc.loop, so implement that lowering. This also modifies the dialect to add helpers for these as well, to be consistent with the previous ones. --- Full d

[clang] [mlir] [OpenACC][CIR] Implement Loop lowering of seq/auto/independent (PR #138164)

2025-05-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-openacc @llvm/pr-subscribers-clangir Author: Erich Keane (erichkeane) Changes These just add a standard 'device_type' flag to the acc.loop, so implement that lowering. This also modifies the dialect to add helpers for these as well, to be consistent with

[clang] [mlir] [OpenACC][CIR] Implement Loop lowering of seq/auto/independent (PR #138164)

2025-05-01 Thread Erich Keane via cfe-commits
https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/138164 These just add a standard 'device_type' flag to the acc.loop, so implement that lowering. This also modifies the dialect to add helpers for these as well, to be consistent with the previous ones. >From 2047e1

[clang] [mlir] [OpenACC][CIR] Implement Loop lowering of seq/auto/independent (PR #138164)

2025-05-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mlir-openacc Author: Erich Keane (erichkeane) Changes These just add a standard 'device_type' flag to the acc.loop, so implement that lowering. This also modifies the dialect to add helpers for these as well, to be consistent with the previous ones. ---

[clang] [CIR][NFC] Fix an unused variable warning (PR #138110)

2025-05-01 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/138110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][flang-driver] Support flag -finstrument-functions (PR #137996)

2025-05-01 Thread Anchu Rajendran S via cfe-commits
https://github.com/anchuraj updated https://github.com/llvm/llvm-project/pull/137996 >From bb486c5e7cbe7b1c4a87469e06ca51bf49ddd081 Mon Sep 17 00:00:00 2001 From: Anchu Rajendran Date: Tue, 29 Apr 2025 14:41:55 -0500 Subject: [PATCH 1/4] [flang] Support flag -finstrument-functions --- clang/

[clang] [clang][lex] fix lexing malformed pragma within include directive (PR #138165)

2025-05-01 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang][lex] fix lexing malformed pragma within include directive (PR #138165)

2025-05-01 Thread via cfe-commits
https://github.com/sweiglbosker created https://github.com/llvm/llvm-project/pull/138165 fixes: https://github.com/llvm/llvm-project/issues/138094 this patch fixes a crash triggered by Lexing past eof when emitting a diagnostic for a malformed `_Pragma` directive within an `include` directive.

[clang] [clang][lex] fix lexing malformed pragma within include directive (PR #138165)

2025-05-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Stefan (sweiglbosker) Changes fixes: https://github.com/llvm/llvm-project/issues/138094 this patch fixes a crash triggered by Lexing past eof when emitting a diagnostic for a malformed `_Pragma` directive within an `include` directive. Fix

[clang] [mlir] [OpenACC][CIR] Implement Loop lowering of seq/auto/independent (PR #138164)

2025-05-01 Thread Razvan Lupusoru via cfe-commits
https://github.com/razvanlupusoru approved this pull request. Awesome. Thank you for continuing to contribute the builders to the dialect. https://github.com/llvm/llvm-project/pull/138164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [clang][lex] fix lexing malformed pragma within include directive (PR #138165)

2025-05-01 Thread via cfe-commits
https://github.com/sweiglbosker edited https://github.com/llvm/llvm-project/pull/138165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang][flang-driver] Support flag -finstrument-functions (PR #137996)

2025-05-01 Thread Anchu Rajendran S via cfe-commits
@@ -81,6 +81,8 @@ class CodeGenOptions : public CodeGenOptionsBase { /// Options to add to the linker for the object file std::vector DependentLibs; + bool InstrumentFunctions{false}; anchuraj wrote: Thank you for the review @tblah . Updated. https://gi

[clang] [clang][lex] Fix lexing malformed pragma within include directive (PR #138165)

2025-05-01 Thread via cfe-commits
https://github.com/sweiglbosker edited https://github.com/llvm/llvm-project/pull/138165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][RootSignature] Add parsing for empty RootConstants (PR #137999)

2025-05-01 Thread via cfe-commits
@@ -252,6 +252,32 @@ TEST_F(ParseHLSLRootSignatureTest, ValidSamplerFlagsTest) { ASSERT_TRUE(Consumer->isSatisfied()); } +TEST_F(ParseHLSLRootSignatureTest, ValidParseRootConsantsTest) { joaosaffran wrote: ```suggestion TEST_F(ParseHLSLRootSignatureTest, Va

[clang] [llvm] [HLSL][RootSignature] Add parsing for empty RootConstants (PR #137999)

2025-05-01 Thread via cfe-commits
https://github.com/joaosaffran approved this pull request. LGTM, just a typo and a nit https://github.com/llvm/llvm-project/pull/137999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 93ff19c - [CIR] Upstream global initialization for VectorType (#137511)

2025-05-01 Thread via cfe-commits
Author: Amr Hesham Date: 2025-05-01T08:51:55+02:00 New Revision: 93ff19c27a0ad21068f431c0380f5a6dd5c4abc3 URL: https://github.com/llvm/llvm-project/commit/93ff19c27a0ad21068f431c0380f5a6dd5c4abc3 DIFF: https://github.com/llvm/llvm-project/commit/93ff19c27a0ad21068f431c0380f5a6dd5c4abc3.diff LO

[clang] [clang-format] Add AlignAfterOpenBracketOptions (PR #108332)

2025-05-01 Thread Owen Pan via cfe-commits
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/108332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-repl] Fix destructor for interpreter for the cuda negation case (PR #138091)

2025-05-01 Thread Anutosh Bhat via cfe-commits
anutosh491 wrote: The cuda tests for the negation case should now work (not segfault because libcudart.so is not found but simply get skipped). ``` 1: Test command: /build/anutosh491/CppInterOp/build1/unittests/CppInterOp/CppInterOpTests/unittests/bin/Release/CppInterOpTests 1: Working Director

[clang] [clang-repl] Fix destructor for interpreter for the cuda negation case (PR #138091)

2025-05-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Anutosh Bhat (anutosh491) Changes Check this error for more context (https://github.com/compiler-research/CppInterOp/actions/runs/14749797085/job/41407625681?pr=491#step:10:531) This fails with ``` * thread #1, name = 'CppInterOpTests',

[clang] [clang-repl] Fix destructor for interpreter for the cuda negation case (PR #138091)

2025-05-01 Thread Anutosh Bhat via cfe-commits
https://github.com/anutosh491 created https://github.com/llvm/llvm-project/pull/138091 Check this error for more context (https://github.com/compiler-research/CppInterOp/actions/runs/14749797085/job/41407625681?pr=491#step:10:531) This fails with ``` * thread #1, name = 'CppInterOpTests', sto

[clang] [clang-format] Add ApplyAlwaysOnePerLineToTemplateArguments option (PR #137544)

2025-05-01 Thread Owen Pan via cfe-commits
owenca wrote: I don't like new options for bug fixes. WDYT @mydeveloperday? https://github.com/llvm/llvm-project/pull/137544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] ac9e1df - [clangd] Add container field to remote index Refs grpc method (#71605)

2025-05-01 Thread via cfe-commits
Author: Thomas Du Plessis Date: 2025-05-01T03:11:30-04:00 New Revision: ac9e1df3efcaa80b8e0fc8a16a929c0f0dc2e161 URL: https://github.com/llvm/llvm-project/commit/ac9e1df3efcaa80b8e0fc8a16a929c0f0dc2e161 DIFF: https://github.com/llvm/llvm-project/commit/ac9e1df3efcaa80b8e0fc8a16a929c0f0dc2e161.d

[clang] clang-format: Sort includes by stem rather than full filename (PR #137840)

2025-05-01 Thread Owen Pan via cfe-commits
owenca wrote: IMO, unless it's a bug, we need a new option to ensure it's a non-breaking change. https://github.com/llvm/llvm-project/pull/137840 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [clang-format] Add AlignAfterOpenBracketOptions (PR #108332)

2025-05-01 Thread Owen Pan via cfe-commits
@@ -62,6 +62,22 @@ struct FormatStyle { /// \version 3.3 int AccessModifierOffset; + /// Different styles for breaking the parenthesis after a control statement + /// (``if/switch/while/for ...``). + /// \version 21 + enum BreakAfterControlStatementStyle : int8_t { +

[clang] [CIR] Upstream global initialization for VectorType (PR #137511)

2025-05-01 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/16971 Here is the relevant piece of the

[clang] [clang-repl] Fix destructor for interpreter for the cuda negation case (PR #138091)

2025-05-01 Thread Anutosh Bhat via cfe-commits
https://github.com/anutosh491 updated https://github.com/llvm/llvm-project/pull/138091 >From 8783ea05d2d7f4504978427764da7e78c088aa39 Mon Sep 17 00:00:00 2001 From: anutosh491 Date: Thu, 1 May 2025 12:16:06 +0530 Subject: [PATCH 1/2] Fix destructor for interpreter for the cuda negation case --

[clang] [clang-repl] Fix destructor for interpreter for the cuda negation case (PR #138091)

2025-05-01 Thread Anutosh Bhat via cfe-commits
https://github.com/anutosh491 updated https://github.com/llvm/llvm-project/pull/138091 >From aba1800393455fd99feeb9017a4ead4fd582 Mon Sep 17 00:00:00 2001 From: anutosh491 Date: Thu, 1 May 2025 12:16:06 +0530 Subject: [PATCH] Fix destructor for interpreter for the cuda negation case --- c

[clang] [clang-repl] Fix destructor for interpreter for the cuda negation case (PR #138091)

2025-05-01 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- clang/include/clang/Interpreter/Interpreter.h clan

[clang] [clang-format] Add AlignAfterOpenBracketOptions (PR #108332)

2025-05-01 Thread Owen Pan via cfe-commits
@@ -9694,6 +9694,304 @@ TEST_F(FormatTest, ParenthesesAndOperandAlignment) { Style); } +TEST_F(FormatTest, AlignAfterConditionalStatements) { owenca wrote: ```suggestion TEST_F(FormatTest, AlignAfterControlStatements) { ``` Can you move this to

[clang-tools-extra] [clangd] Add container field to remote index Refs grpc method (PR #71605)

2025-05-01 Thread Nathan Ridge via cfe-commits
HighCommander4 wrote: Thanks! I'll go ahead and merge. https://github.com/llvm/llvm-project/pull/71605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add AlignAfterOpenBracketOptions (PR #108332)

2025-05-01 Thread Owen Pan via cfe-commits
owenca wrote: > > > > I prefer that we limit this to breaking after the left parenthesis of a > > > > control statement, with true/false or Always, Never, Multiline, > > > > BlockIndent, etc. > > > > > > > > > if I understand you correctly, you would like a new style option added > > > for s

[clang] [git-clang-format] add fallback style argument option (PR #137609)

2025-05-01 Thread Owen Pan via cfe-commits
owenca wrote: Please add a description so that we'll understand why you need this new option. https://github.com/llvm/llvm-project/pull/137609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[clang-tools-extra] [clangd] Add container field to remote index Refs grpc method (PR #71605)

2025-05-01 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/71605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add AlignAfterOpenBracketOptions (PR #108332)

2025-05-01 Thread Owen Pan via cfe-commits
https://github.com/owenca commented: You need to run `ninja clang-format-style` to update the documentation. https://github.com/llvm/llvm-project/pull/108332 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang-tools-extra] [clangd] Add container field to remote index Refs grpc method (PR #71605)

2025-05-01 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-gcc-ubuntu` running on `sie-linux-worker3` while building `clang-tools-extra` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/174/builds

[clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-01 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul created https://github.com/llvm/llvm-project/pull/138174 None >From d6f69414e3ac5c1a22f6509149609258ef980c13 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Wed, 30 Apr 2025 23:47:37 -0700 Subject: [PATCH] [NFC][Support] Add llvm::uninitialized_copy --- clang/incl

[clang] [lldb] [llvm] [mlir] [NFC][Support] Add llvm::uninitialized_copy (PR #138174)

2025-05-01 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/138174 >From b34e9b6c708dfbe097504804a0a85e1169518911 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Wed, 30 Apr 2025 23:47:37 -0700 Subject: [PATCH] [NFC][Support] Add llvm::uninitialized_copy --- clang/include/cl

[clang] [CIR] Upstream support for switch statements case kinds (PR #138003)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -428,6 +429,52 @@ mlir::LogicalResult CIRGenFunction::emitBreakStmt(const clang::BreakStmt &s) { return mlir::success(); } +const CaseStmt *CIRGenFunction::foldCaseStmt(const clang::CaseStmt &s, + mlir::Type condType, +

[clang] [CIR] Upstream support for switch statements case kinds (PR #138003)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -215,17 +342,115 @@ void sw9(int a) { // OGCG: entry: // OGCG: %[[A_ADDR:.*]] = alloca i32, align 4 // OGCG: %[[A_VAL:.*]] = load i32, ptr %[[A_ADDR]], align 4 -// OGCG: switch i32 %[[A_VAL]], label %[[EPILOG:.*]] [ +// OGCG: switch i32 %[[A_VAL]], label %[[DEFAULT:.

[clang] [CIR] Upstream support for switch statements case kinds (PR #138003)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -91,12 +92,40 @@ void sw2(int a) { // OGCG: [[SW_EPILOG]]: // OGCG: ret void +void sw3(int a) { andykaylor wrote: Please add tests for the GNU range case, including one where it would be in the same group with other cases, like this: ``` void f(int x)

[clang] [CIR] Upstream support for switch statements case kinds (PR #138003)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -428,6 +429,52 @@ mlir::LogicalResult CIRGenFunction::emitBreakStmt(const clang::BreakStmt &s) { return mlir::success(); } +const CaseStmt *CIRGenFunction::foldCaseStmt(const clang::CaseStmt &s, + mlir::Type condType, +

[clang] 5209668 - [CIR] Upstream pointer arithmetic support (#138041)

2025-05-01 Thread via cfe-commits
Author: Andy Kaylor Date: 2025-05-01T11:11:02-07:00 New Revision: 5209668e357e0a1d295d9e9aa9dbca8f41132c0c URL: https://github.com/llvm/llvm-project/commit/5209668e357e0a1d295d9e9aa9dbca8f41132c0c DIFF: https://github.com/llvm/llvm-project/commit/5209668e357e0a1d295d9e9aa9dbca8f41132c0c.diff L

[clang] [CIR] Upstream pointer arithmetic support (PR #138041)

2025-05-01 Thread Andy Kaylor via cfe-commits
https://github.com/andykaylor closed https://github.com/llvm/llvm-project/pull/138041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Reland: [llvm][clang] Allocate a new stack instead of spawning a new thread to get more stack space (PR #136046)

2025-05-01 Thread Alan Phipps via cfe-commits
evodius96 wrote: Hello, I'm seeing ProgramStackTest fail when running on our downstream toolchain on Linux: ``` 2 |   | FAIL: llvm_regressions :: LLVM-Unit/Support/SupportTests/ProgramStackTest/runOnNewStack 3 |   | --

[clang] [CIR] Upstream support for switch statements case kinds (PR #138003)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -428,6 +429,52 @@ mlir::LogicalResult CIRGenFunction::emitBreakStmt(const clang::BreakStmt &s) { return mlir::success(); } +const CaseStmt *CIRGenFunction::foldCaseStmt(const clang::CaseStmt &s, + mlir::Type condType, +

[clang] [CIR] Upstream support for switch statements case kinds (PR #138003)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -428,6 +429,52 @@ mlir::LogicalResult CIRGenFunction::emitBreakStmt(const clang::BreakStmt &s) { return mlir::success(); } +const CaseStmt *CIRGenFunction::foldCaseStmt(const clang::CaseStmt &s, + mlir::Type condType, +

[clang] [CIR] Upstream support for switch statements case kinds (PR #138003)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -428,6 +429,52 @@ mlir::LogicalResult CIRGenFunction::emitBreakStmt(const clang::BreakStmt &s) { return mlir::success(); } +const CaseStmt *CIRGenFunction::foldCaseStmt(const clang::CaseStmt &s, + mlir::Type condType, +

[clang] [Clang][AArch64] Add pessimistic vscale_range when sve is in target-f… (PR #137624)

2025-05-01 Thread Eli Friedman via cfe-commits
@@ -794,12 +794,14 @@ AArch64TargetInfo::getTargetBuiltins() const { std::optional> AArch64TargetInfo::getVScaleRange(const LangOptions &LangOpts, - bool IsArmStreamingFunction) const { + bool IsArmStreamingFunc

[clang] [C] Warn on uninitialized const objects (PR #137166)

2025-05-01 Thread Dan Liew via cfe-commits
@@ -8197,6 +8197,16 @@ def err_address_space_qualified_new : Error< def err_address_space_qualified_delete : Error< "'delete' cannot delete objects of type %0 in address space '%1'">; +def note_default_init_const_member : Note< + "member %0 declared 'const' here">; +def war

[clang] [Clang][CodeGen] Check `isUnderlyingBasePointerConstantNull` in `emitPointerArithmetic` (PR #137849)

2025-05-01 Thread Eli Friedman via cfe-commits
@@ -4238,7 +4238,8 @@ static Value *emitPointerArithmetic(CodeGenFunction &CGF, else elemTy = CGF.ConvertTypeForMem(elementType); - if (CGF.getLangOpts().PointerOverflowDefined) + if (CGF.getLangOpts().PointerOverflowDefined || + CGF.isUnderlyingBasePointerConstan

[clang] [CIR] Upstream support for switch statements case kinds (PR #138003)

2025-05-01 Thread Andy Kaylor via cfe-commits
@@ -428,6 +429,52 @@ mlir::LogicalResult CIRGenFunction::emitBreakStmt(const clang::BreakStmt &s) { return mlir::success(); } +const CaseStmt *CIRGenFunction::foldCaseStmt(const clang::CaseStmt &s, + mlir::Type condType, +

[clang] [CUDA][HIP] Fix implicit attribute of builtin (PR #138162)

2025-05-01 Thread Artem Belevich via cfe-commits
@@ -0,0 +1,23 @@ +// expected-no-diagnostics + +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -aux-triple amdgcn-amd-amdhsa -fsyntax-only -verify -xhip %s +// RUN: %clang_cc1 -triple amdgcn-amd-amdhsa -fsyntax-only -fcuda-is-device -verify -xhip %s + +#include "Inputs/cuda

[clang] [ARM, AArch64] Fix ABI bugs with over-sized bitfields (PR #126774)

2025-05-01 Thread Florian Mayer via cfe-commits
fmayer wrote: Could we make sure this gets called out in the Release Notes? Even if it's a fix, this is a change of ABI which could break stuff. https://github.com/llvm/llvm-project/pull/126774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] [Clang] incorrect assertion when checking template template parameter of a lambda (PR #138121)

2025-05-01 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/138121 >From 34011def1ec643701a84424f0813484efa39a1d1 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Thu, 1 May 2025 13:32:00 +0200 Subject: [PATCH 1/2] [Clang] incorrect assertion when checking template templat

[clang] [llvm] Reland: [llvm][clang] Allocate a new stack instead of spawning a new thread to get more stack space (PR #136046)

2025-05-01 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lld-x86_64-win` running on `as-worker-93` while building `clang,llvm` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/2823 Here is the releva

[clang] [Clang] incorrect assertion when checking template template parameter of a lambda (PR #138121)

2025-05-01 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. I'm concerned about the static-invoker ending up just being an assert, but I guess that is no behavioral change (just 1 assert to another). https://github.com/llvm/llvm-project/pull/138121 ___

[clang] [llvm] Revert "[clang] Add scoped enum support to `StreamingDiagnostic`" (PR #138139)

2025-05-01 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: #138134 seems to stick. I'll close this PR later if everything goes well https://github.com/llvm/llvm-project/pull/138139 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][amdgpu] Add builtins for raw/struct buffer lds load (PR #137678)

2025-05-01 Thread Jon Chesterfield via cfe-commits
JonChesterfield wrote: There's some existing builtin stuff going on in this area, e.g. https://github.com/llvm/llvm-project/pull/138141/commits/96e94b5662c613fd80f712080751076254a73524 The use case in CK is behind a hip header file, so could become static inline functions renaming a builtin, o

[clang] [flang] [llvm] Add IR Profile-Guided Optimization (IR PGO) support to the Flang compiler (PR #136098)

2025-05-01 Thread via cfe-commits
@@ -0,0 +1,39 @@ +! Tests for -fprofile-generate and -fprofile-use flag compatibility. These two +! flags behave similarly to their GCC counterparts: +! +! -fprofile-generate Generates the profile file ./default.profraw +! -fprofile-use=/file Uses the profile file /file

[clang] [llvm] [clang] Add spir_kernel attribute (PR #137882)

2025-05-01 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > Do we need yet another calling convention or is there a way we can start to > > combine some of these for all the offloading languages? It seems we keep > > re-implementing the same concepts multiple times for each language and it > > would be nice to share as much of t

[clang] [lldb] [clang] Add `__ptrauth_restricted_intptr` qualifier (PR #137580)

2025-05-01 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > Perhaps silly initial question: why do we need a whole different qualifier > > for this? Why can you not write `__ptrauth uintptr_t foo`? > > Not a silly question, back when first implemented we spent time thinking > about this. > > The concern was basically `T* __ptra

[clang] [flang] [llvm] Add IR Profile-Guided Optimization (IR PGO) support to the Flang compiler (PR #136098)

2025-05-01 Thread via cfe-commits
@@ -13,6 +13,7 @@ #ifndef LLVM_FRONTEND_DRIVER_CODEGENOPTIONS_H #define LLVM_FRONTEND_DRIVER_CODEGENOPTIONS_H +#include fanju110 wrote: Ok,I have adjusted it as you suggested https://github.com/llvm/llvm-project/pull/136098 _

[clang] [flang] [llvm] Add IR Profile-Guided Optimization (IR PGO) support to the Flang compiler (PR #136098)

2025-05-01 Thread via cfe-commits
@@ -8,8 +8,14 @@ #include "llvm/Frontend/Driver/CodeGenOptions.h" #include "llvm/Analysis/TargetLibraryInfo.h" +#include "llvm/ProfileData/InstrProfCorrelator.h" #include "llvm/TargetParser/Triple.h" +namespace llvm { +extern llvm::cl::opt DebugInfoCorrelate; +extern llvm::

[clang] [llvm] [ADT] Remove `is_scoped_enum_v` (PR #138134)

2025-05-01 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux` running on `premerge-linux-1` while building `clang,llvm` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/30468 He

[clang] [llvm] [clang] Add spir_kernel attribute (PR #137882)

2025-05-01 Thread Nick Sarnie via cfe-commits
https://github.com/sarnex converted_to_draft https://github.com/llvm/llvm-project/pull/137882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang] Add spir_kernel attribute (PR #137882)

2025-05-01 Thread Nick Sarnie via cfe-commits
sarnex wrote: > I was thinking that orthogonal calling conventions could be combined so that > we need fewer of them. e.g., if spir_kernel cannot be mixed with nvptx_kernel > in the same TU, then there's no need for two distinct internal > representations for the attributes, just two distinct

[clang] [llvm] [mlir] [Sema] Fix bug in builtin AS override (PR #138141)

2025-05-01 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,60 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// RUN: %clang_cc1 -cl-std=CL2.0 -O0 -triple amdgcn-unknown-unknown -target-cpu gfx900 -emit-llvm -o - %s | FileCheck %s +// RUN: %clang_cc1 -cl-std=CL2.0 -O0 -triple amdgcn-unknown-u

[clang] [C] Add (new) -Wimplicit-void-ptr-cast to -Wc++-compat (PR #136855)

2025-05-01 Thread via cfe-commits
earnol wrote: Could you please take a look into the issue https://github.com/llvm/llvm-project/issues/138145 i created and provide an input from your side if possible. https://github.com/llvm/llvm-project/pull/136855 ___ cfe-commits mailing list cfe-

  1   2   3   4   5   6   >