llvmbot wrote:

<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Mateusz Mikuła (mati865)

<details>
<summary>Changes</summary>

Currently building for Cygwin hits this error:
```
In file included from 
/h/projects/llvm-project/clang/lib/Basic/Attributes.cpp:17:
/h/projects/llvm-project/clang/include/clang/Basic/ParsedAttrInfo.h:180:73: 
error: invalid declarator before ‘;’ token
  180 | extern template class CLANG_TEMPLATE_ABI 
Registry&lt;clang::ParsedAttrInfo&gt;;
```
That's because `CLANG_TEMPLATE_ABI` ends up not being defined. The solution 
here is to follow MinGW case.

Split out from https://github.com/llvm/llvm-project/pull/134494

---
Full diff: https://github.com/llvm/llvm-project/pull/138118.diff


1 Files Affected:

- (modified) clang/include/clang/Support/Compiler.h (+1-1) 


``````````diff
diff --git a/clang/include/clang/Support/Compiler.h 
b/clang/include/clang/Support/Compiler.h
index 5a74f8e3b6723..e1ae3eda4ccc2 100644
--- a/clang/include/clang/Support/Compiler.h
+++ b/clang/include/clang/Support/Compiler.h
@@ -50,7 +50,7 @@
 #define CLANG_EXPORT_TEMPLATE
 #endif
 #elif defined(__ELF__) || defined(__MINGW32__) || defined(_AIX) ||             
\
-    defined(__MVS__)
+    defined(__MVS__) || defined(__CYGWIN__)
 #define CLANG_ABI LLVM_ATTRIBUTE_VISIBILITY_DEFAULT
 #define CLANG_TEMPLATE_ABI LLVM_ATTRIBUTE_VISIBILITY_DEFAULT
 #define CLANG_EXPORT_TEMPLATE

``````````

</details>


https://github.com/llvm/llvm-project/pull/138118
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to