[clang] [llvm] [AMDGPU][True16][MC][CodeGen] true16 for v_alignbyte_b32 (PR #119750)

2025-01-30 Thread Joe Nash via cfe-commits
@@ -3802,6 +3802,26 @@ def : FPMinCanonMaxPat, fmaximum_oneuse>; } +let True16Predicate = UseFakeTrue16Insts in +def : GCNPat < +(i32 (int_amdgcn_alignbyte (i32 (VOP3OpSelMods i32:$src0, i32:$src0_modifiers)), + (i32 (VOP3OpSelMods i32:$src1, i32:$sr

[clang] [llvm] [AMDGPU][True16][MC][CodeGen] true16 for v_alignbyte_b32 (PR #119750)

2025-01-30 Thread Joe Nash via cfe-commits
@@ -3802,6 +3802,26 @@ def : FPMinCanonMaxPat, fmaximum_oneuse>; } +let True16Predicate = UseFakeTrue16Insts in +def : GCNPat < +(i32 (int_amdgcn_alignbyte (i32 (VOP3OpSelMods i32:$src0, i32:$src0_modifiers)), Sisyph wrote: Instead of this fake16 pattern, can

[clang] Warn when unique objects might be duplicated in shared libraries (PR #117622)

2025-01-30 Thread Devon Loehr via cfe-commits
https://github.com/DKLoehr updated https://github.com/llvm/llvm-project/pull/117622 >From 798b3f21593499194487c9877b8f4a3d9e44bb6e Mon Sep 17 00:00:00 2001 From: Devon Loehr Date: Thu, 21 Nov 2024 19:29:00 + Subject: [PATCH 1/5] Warn when unique objects might be duplicated in shared librar

[clang] [Clang] Add GCC's __builtin_stack_address() to Clang. (PR #121332)

2025-01-30 Thread via cfe-commits
aalhwc wrote: > Where is it ensured that this is actually unreachable? @tbaederr I now report a compile time error instead of crashing. Does that address your comment appropriately? Thanks! https://github.com/llvm/llvm-project/pull/121332 ___ cfe-co

[clang] [llvm] [NVPTX] Add tcgen05 alloc/dealloc intrinsics (PR #124961)

2025-01-30 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 59a9a8f2eadeadc2a1281fc7ae74054ca264abbb bfe728f879b5a20be2269c6d9e52c1feb0cce64b --e

[clang-tools-extra] [clang-tidy] Add bugprone-smartptr-reset-ambiguous-call check (PR #121291)

2025-01-30 Thread via cfe-commits
EugeneZelenko wrote: Please rebase from `main`. Release Notes were cleared after 20 branch creation. https://github.com/llvm/llvm-project/pull/121291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] [NFC] changes to AArch64 ACLE types definitions (PR #125063)

2025-01-30 Thread Tomas Matheson via cfe-commits
https://github.com/tmatheson-arm updated https://github.com/llvm/llvm-project/pull/125063 >From 87d539860c11d7e0f021410b5947b5c25c8870d7 Mon Sep 17 00:00:00 2001 From: Tomas Matheson Date: Thu, 30 Jan 2025 15:37:08 + Subject: [PATCH] [NFC] remove string literals from AArch64Types.def ---

[clang] [NFC] changes to AArch64 ACLE types definitions (PR #125063)

2025-01-30 Thread Tomas Matheson via cfe-commits
https://github.com/tmatheson-arm updated https://github.com/llvm/llvm-project/pull/125063 >From 87d539860c11d7e0f021410b5947b5c25c8870d7 Mon Sep 17 00:00:00 2001 From: Tomas Matheson Date: Thu, 30 Jan 2025 15:37:08 + Subject: [PATCH 1/2] [NFC] remove string literals from AArch64Types.def -

[clang] [NFC] remove string literals from AArch64SVEACLETypes.def (PR #125063)

2025-01-30 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/125063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix annotation of Java/JavaScript keyword extends (PR #125038)

2025-01-30 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. probably the same for "implements" in typescript too, but this change stand on its ok.. thank you. https://github.com/llvm/llvm-project/pull/125038 ___ cfe-commits mailing list cfe-commits@

[clang] [analyzer] Relax assertion in BugReporterVisitors.cpp isInitializationOfVar (PR #125044)

2025-01-30 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `flang-aarch64-dylib` running on `linaro-flang-aarch64-dylib` while building `clang` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/50/builds/9625 Here is the relevant

[clang] [Clang] Fix segmentation fault caused by `VarBypassDetector` stack overflow on deeply nested expressions (PR #124128)

2025-01-30 Thread Ilya Biryukov via cfe-commits
@@ -0,0 +1,30 @@ +// RUN: %clang_cc1 %s -emit-llvm -o - -Wstack-exhausted ilya-biryukov wrote: Flagging to remove this before merging since you say it's too slow. (You've mentioned that in the description too) PS we could probably add some build flag to optiona

[clang] [Clang] Fix segmentation fault caused by `VarBypassDetector` stack overflow on deeply nested expressions (PR #124128)

2025-01-30 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov approved this pull request. This LG, but I'd also ask for someone who owns this CodeGen to take a look before submitting. @cor3ntin can definitely vouch for that. The thing that gives me a pause is that we **might** be missing many more places that are recursiv

[clang] 9ebfee9 - [X86][AVX10] Disable m[no-]avx10.1 and switch m[no-]avx10.2 to alias of 512 bit options (#124511)

2025-01-30 Thread via cfe-commits
Author: Phoebe Wang Date: 2025-01-30T21:13:49+08:00 New Revision: 9ebfee9d686b41f789b47a6acc7dcdba808fb3f9 URL: https://github.com/llvm/llvm-project/commit/9ebfee9d686b41f789b47a6acc7dcdba808fb3f9 DIFF: https://github.com/llvm/llvm-project/commit/9ebfee9d686b41f789b47a6acc7dcdba808fb3f9.diff L

[clang] [X86][AVX10] Disable m[no-]avx10.1 and switch m[no-]avx10.2 to alias of 512 bit options (PR #124511)

2025-01-30 Thread Phoebe Wang via cfe-commits
phoebewang wrote: > > Let me know whether you are happy with this solution or not. > > Yes, thanks, I agree, this is better. Since we disable AVX10 version > completely with any of options 256 or 512 (some kind of duplication), it > means that we can't partially disable it, so these options do

[clang] [X86][AVX10] Disable m[no-]avx10.1 and switch m[no-]avx10.2 to alias of 512 bit options (PR #124511)

2025-01-30 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/124511 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang:frontend] Move helper functions to common location for SemaSPIRV (PR #125045)

2025-01-30 Thread Muhammad Bassiouni via cfe-commits
https://github.com/bassiounix updated https://github.com/llvm/llvm-project/pull/125045 >From d938f75b1a5638f013ae2f7fb4f0ac2f6e28c6a4 Mon Sep 17 00:00:00 2001 From: Muhammad Bassiouni Date: Thu, 30 Jan 2025 12:02:25 +0200 Subject: [PATCH 1/3] [clang:frontend] Move helper functions in SemaHLSL t

[clang] [Clang] Optimize -Wunsafe-buffer-usage. (PR #124554)

2025-01-30 Thread Ivana Ivanovska via cfe-commits
https://github.com/ivanaivanovska updated https://github.com/llvm/llvm-project/pull/124554 504 Gateway Time-out The server didn't respond in time. ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [clang][bytecode] Handle invalid temporary descriptors (PR #125033)

2025-01-30 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/125033 >From 02698239ff1e88d97e22ccf7a8ae8f89a4eb0262 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Thu, 30 Jan 2025 06:41:28 +0100 Subject: [PATCH] [clang][bytecode] Handle invalid temporary desc

[clang] [clang-format] Fix a crash on parsing requires clause (PR #125021)

2025-01-30 Thread Emilia Kond via cfe-commits
https://github.com/rymiel approved this pull request. https://github.com/llvm/llvm-project/pull/125021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PGO] Add a clang option -fprofile-continuous that enables PGO continuous mode (PR #124353)

2025-01-30 Thread Wael Yehia via cfe-commits
https://github.com/w2yehia edited https://github.com/llvm/llvm-project/pull/124353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 355d0b1 - Fix link to TySan issues page (#125052)

2025-01-30 Thread via cfe-commits
Author: gbMattN Date: 2025-01-30T12:10:51Z New Revision: 355d0b186f178668b103068537e517f3d52ad639 URL: https://github.com/llvm/llvm-project/commit/355d0b186f178668b103068537e517f3d52ad639 DIFF: https://github.com/llvm/llvm-project/commit/355d0b186f178668b103068537e517f3d52ad639.diff LOG: Fix l

[clang] Fix link to TySan issues page (PR #125052)

2025-01-30 Thread via cfe-commits
https://github.com/gbMattN closed https://github.com/llvm/llvm-project/pull/125052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Simplify MS mangling of bultin types (NFC) (PR #125051)

2025-01-30 Thread Benjamin Maxwell via cfe-commits
https://github.com/MacDue approved this pull request. LGTM (assuming pre-commit goes green) https://github.com/llvm/llvm-project/pull/125051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] Fix link to TySan issues page (PR #125052)

2025-01-30 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian` running on `lldb-x86_64-debian` while building `clang` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/15242 Here is the relevant piece of the build lo

[clang] [clang:frontend] Move helper functions to common location for SemaSPIRV (PR #125045)

2025-01-30 Thread Mats Jun Larsen via cfe-commits
https://github.com/junlarsen commented: Each file should have license headers, ref https://llvm.org/docs/CodingStandards.html#file-headers https://github.com/llvm/llvm-project/pull/125045 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [OpenMP][ASan] Enable ASan Instrumentation for AMDGPUOpenMPToolChain. (PR #124754)

2025-01-30 Thread Amit Kumar Pandey via cfe-commits
https://github.com/ampandey-1995 updated https://github.com/llvm/llvm-project/pull/124754 >From 741fcf90830c6a30be851c43924e9ab95c40b8a7 Mon Sep 17 00:00:00 2001 From: Amit Pandey Date: Tue, 28 Jan 2025 15:15:01 +0530 Subject: [PATCH 1/2] [OpenMP][ASan] Enable ASan Instrumentation for AMDGPUOp

[clang] [AArch64] Add MSVC mangling for the __mfp8 type (PR #124968)

2025-01-30 Thread Momchil Velikov via cfe-commits
momchil-velikov wrote: /cherry-pick 7939ce6295e7fc0214cd307f97dfccc0cabde381 https://github.com/llvm/llvm-project/pull/124968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #117437)

2025-01-30 Thread via cfe-commits
cor3ntin wrote: I think `HasRebuiltInit` is just `CXXDefaultArgExpr::getExpr() != CXXDefaultArgExpr::getParam()->getDefaultArg()` @yronglin Can you modify `hasRebuiltInit()` to be and see if anything breaks? (and if it works we don't need the bit) ```cpp bool hasRebuiltInit() const { return g

[clang] [AArch64] Add MSVC mangling for the __mfp8 type (PR #124968)

2025-01-30 Thread via cfe-commits
llvmbot wrote: >/cherry-pick 7939ce6295e7fc0214cd307f97dfccc0cabde381 Error: Command failed due to missing milestone. https://github.com/llvm/llvm-project/pull/124968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [Analyzer][CFG] Correctly handle rebuilt default arg and default init expression (PR #117437)

2025-01-30 Thread via cfe-commits
yronglin wrote: @cor3ntin @erichkeane Many thanks for the review! > @yronglin Can you modify hasRebuiltInit() as follow and see if anything > breaks? (and if it works we don't need the bit) Sure, let me give a try. > It seems to me the static analyzer should be responsible for this perhaps,

[clang] [OpenMP][ASan] Enable ASan Instrumentation for AMDGPUOpenMPToolChain. (PR #124754)

2025-01-30 Thread Amit Kumar Pandey via cfe-commits
https://github.com/ampandey-1995 edited https://github.com/llvm/llvm-project/pull/124754 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64] Add MSVC mangling for the __mfp8 type (PR #124968)

2025-01-30 Thread Benjamin Maxwell via cfe-commits
@@ -2808,6 +2812,7 @@ void MicrosoftCXXNameMangler::mangleType(const BuiltinType *T, Qualifiers, #define SVE_TYPE(Name, Id, SingletonId) \ case BuiltinType::Id: +#define SVE_SCALAR_TYPE(Name, MangledName, Id, SingletonId, Bits) MacDue wrote: You could defi

[clang] [clang][SME] Account for C++ lambdas in SME builtin diagnostics (PR #124750)

2025-01-30 Thread Benjamin Maxwell via cfe-commits
MacDue wrote: /cherry-pick https://github.com/llvm/llvm-project/commit/2b7509e9885c9a5656bb3c201421e146a21fb88e https://github.com/llvm/llvm-project/pull/124750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] [clang][SME] Account for C++ lambdas in SME builtin diagnostics (PR #124750)

2025-01-30 Thread Benjamin Maxwell via cfe-commits
https://github.com/MacDue milestoned https://github.com/llvm/llvm-project/pull/124750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Simplify MS mangling of bultin types (NFC) (PR #125051)

2025-01-30 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov created https://github.com/llvm/llvm-project/pull/125051 Saves including 4 files, reduces the number of switch cases, less error prone when adding new types, at the "cost" of adding a` default:`. >From 8719394b628da73a0f9ed7088d771f14fe238144 Mon Sep 17 00:00

[clang] [AArch64] Add MSVC mangling for the __mfp8 type (PR #124968)

2025-01-30 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov edited https://github.com/llvm/llvm-project/pull/124968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AArch64] Add MSVC mangling for the __mfp8 type (PR #124968)

2025-01-30 Thread Momchil Velikov via cfe-commits
@@ -2808,6 +2812,7 @@ void MicrosoftCXXNameMangler::mangleType(const BuiltinType *T, Qualifiers, #define SVE_TYPE(Name, Id, SingletonId) \ case BuiltinType::Id: +#define SVE_SCALAR_TYPE(Name, MangledName, Id, SingletonId, Bits) momchil-velikov wrote: > Wit

[clang] [analyzer] Relax assertion in BugReporterVisitors.cpp isInitializationOfVar (PR #125044)

2025-01-30 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/125044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][SME] Account for C++ lambdas in SME builtin diagnostics (PR #124750)

2025-01-30 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#125049 https://github.com/llvm/llvm-project/pull/124750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix segmentation fault caused by `VarBypassDetector` stack overflow on deeply nested expressions (PR #124128)

2025-01-30 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/124128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix link to TySan issues page (PR #125052)

2025-01-30 Thread Florian Hahn via cfe-commits
fhahn wrote: > ⚠️ We detected that you are using a GitHub private e-mail address to > contribute to the repo. Please turn off [Keep my email addresses > private](https://github.com/settings/emails) setting in your account. See > [LLVM > Discourse](https://discourse.llvm.org/t/hidden-emails-on

[clang] [Clang] Fix __{add, remove}_pointer in Objective-C++ (PR #123678)

2025-01-30 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: @AaronBallman is there anything blocking this? I'd really like to have this in the release branch as early as possible. https://github.com/llvm/llvm-project/pull/123678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [clang][dataflow] Fix smart pointer accessor caching to handle aliases (PR #124964)

2025-01-30 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/124964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix annotation of class name after requires clause (PR #125019)

2025-01-30 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/125019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][SME] Account for C++ lambdas in SME builtin diagnostics (PR #124750)

2025-01-30 Thread Benjamin Maxwell via cfe-commits
MacDue wrote: /cherry-pick https://github.com/llvm/llvm-project/commit/2b7509e9885c9a5656bb3c201421e146a21fb88e https://github.com/llvm/llvm-project/pull/124750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] [clang-format] Fix a crash on parsing requires clause (PR #125021)

2025-01-30 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/125021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 025541d - [analyzer] Relax assertion in BugReporterVisitors.cpp isInitializationOfVar (#125044)

2025-01-30 Thread via cfe-commits
Author: Balazs Benics Date: 2025-01-30T12:48:09+01:00 New Revision: 025541ddedd23e39d9394ea8a1e41a64dfbe4e94 URL: https://github.com/llvm/llvm-project/commit/025541ddedd23e39d9394ea8a1e41a64dfbe4e94 DIFF: https://github.com/llvm/llvm-project/commit/025541ddedd23e39d9394ea8a1e41a64dfbe4e94.diff

[clang] [analyzer] Relax assertion in BugReporterVisitors.cpp isInitializationOfVar (PR #125044)

2025-01-30 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/125044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix link to TySan issues page (PR #125052)

2025-01-30 Thread via cfe-commits
https://github.com/gbMattN created https://github.com/llvm/llvm-project/pull/125052 None >From 500a3bd7eff2a620b6d491098c9cca1b023a5b4f Mon Sep 17 00:00:00 2001 From: gbMattN <14674+gbma...@users.noreply.github.com> Date: Thu, 30 Jan 2025 12:07:08 + Subject: [PATCH] Fix link to TySan is

[clang] Fix link to TySan issues page (PR #125052)

2025-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (gbMattN) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/125052.diff 1 Files Affected: - (modified) clang/docs/TypeSanitizer.rst (+1-1) ``diff diff --git a/clang/docs/TypeSanitizer.rst b/clang/docs/Typ

[clang] Simplify MS mangling of bultin types (NFC) (PR #125051)

2025-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Momchil Velikov (momchil-velikov) Changes Saves including 4 files, reduces the number of switch cases, less error prone when adding new types, at the "cost" of adding a` default:`. --- Full diff: https://github.com/llvm/llvm-project/pull/

[clang] Fix link to TySan issues page (PR #125052)

2025-01-30 Thread via cfe-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-email

[clang] [flang] [llvm] [Clang] Remove ARCMigrate (PR #119269)

2025-01-30 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Thank you for this; this was a fantastic cleanup of tech debt! https://github.com/llvm/llvm-project/pull/119269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [NFC] changes to AArch64 ACLE types definitions (PR #125063)

2025-01-30 Thread Tomas Matheson via cfe-commits
https://github.com/tmatheson-arm created https://github.com/llvm/llvm-project/pull/125063 - Rename AArch64SVEACLETypes.def to AArch64Types.def - Remove string literals from the macro calls - Rename macros so that the hierarchy makes sense >From 63159e8e82b56850213fb0e2479bd708f008ea81 Mon Sep

[clang] [AArch64] Add MSVC mangling for the __mfp8 type (PR #124968)

2025-01-30 Thread Benjamin Maxwell via cfe-commits
https://github.com/MacDue milestoned https://github.com/llvm/llvm-project/pull/124968 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [NFC] changes to AArch64 ACLE types definitions (PR #125063)

2025-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Tomas Matheson (tmatheson-arm) Changes - Rename AArch64SVEACLETypes.def to AArch64Types.def - Remove string literals from the macro calls - Rename macros so that the hierarchy makes sense --- Patch is 47.44 KiB, truncated to 20.0

[clang] [lldb] [NFC] changes to AArch64 ACLE types definitions (PR #125063)

2025-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Tomas Matheson (tmatheson-arm) Changes - Rename AArch64SVEACLETypes.def to AArch64Types.def - Remove string literals from the macro calls - Rename macros so that the hierarchy makes sense --- Patch is 47.44 KiB, truncated to 20.00 KiB bel

[clang] [analyzer][NFC] Remove a redundant container lookup (PR #125064)

2025-01-30 Thread Balazs Benics via cfe-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/125064 I found this using my experimental checker present at: https://github.com/steakhal/llvm-project/tree/bb/add-redundant-lookup-checker The idea for looking for redundant container lookups was inspired by #123376

[clang] [analyzer][NFC] Remove a redundant container lookup (PR #125064)

2025-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Balazs Benics (steakhal) Changes I found this using my experimental checker present at: https://github.com/steakhal/llvm-project/tree/bb/add-redundant-lookup-checker The idea for looking for redundant container lookups was inspired by #12

[clang] [flang] [llvm] [Clang] Remove ARCMigrate (PR #119269)

2025-01-30 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-s390x-linux-lnt` running on `systemz-1` while building `clang,flang,llvm,utils` at step 7 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/136/builds/2593 Here is the relevant p

[clang] 59a9a8f - [clang][dataflow] Fix smart pointer accessor caching to handle aliases (#124964)

2025-01-30 Thread via cfe-commits
Author: Jan Voung Date: 2025-01-30T09:50:21-05:00 New Revision: 59a9a8f2eadeadc2a1281fc7ae74054ca264abbb URL: https://github.com/llvm/llvm-project/commit/59a9a8f2eadeadc2a1281fc7ae74054ca264abbb DIFF: https://github.com/llvm/llvm-project/commit/59a9a8f2eadeadc2a1281fc7ae74054ca264abbb.diff LOG

[clang] [clang][dataflow] Fix smart pointer accessor caching to handle aliases (PR #124964)

2025-01-30 Thread Jan Voung via cfe-commits
https://github.com/jvoung closed https://github.com/llvm/llvm-project/pull/124964 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [NFC] changes to AArch64 ACLE types definitions (PR #125063)

2025-01-30 Thread Tomas Matheson via cfe-commits
https://github.com/tmatheson-arm edited https://github.com/llvm/llvm-project/pull/125063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-30 Thread Aidan Goldfarb via cfe-commits
https://github.com/AidanGoldfarb updated https://github.com/llvm/llvm-project/pull/122754 >From b6c576fb90362640b2fd4e41bd7f13dfee95d04d Mon Sep 17 00:00:00 2001 From: Aidan Date: Mon, 13 Jan 2025 11:53:39 -0500 Subject: [PATCH 01/24] initial template arg fix push --- .../clang/Basic/Diagnost

[clang] Warn when unique objects might be duplicated in shared libraries (PR #117622)

2025-01-30 Thread Devon Loehr via cfe-commits
DKLoehr wrote: Addressed feedback, responded where appropriate. I've also done some digging into how the warning should work on Windows: it seems like it'll be very straightforward (just replace "has hidden visibility" with "doesn't have a dll import/export attribute"), but I'll leave that for

[clang] [Clang] Fix __{add, remove}_pointer in Objective-C++ (PR #123678)

2025-01-30 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/123678 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PGO] Add a clang option -fprofile-continuous that enables PGO continuous mode (PR #124353)

2025-01-30 Thread Wael Yehia via cfe-commits
https://github.com/w2yehia updated https://github.com/llvm/llvm-project/pull/124353 >From abef90fe8f46431a5fb8b7fe717c9fb65eb30266 Mon Sep 17 00:00:00 2001 From: Wael Yehia Date: Thu, 23 Jan 2025 00:03:15 + Subject: [PATCH 1/5] [PGO] Add a clang option -fprofile-continuous that enables PGO

[clang] [PGO] Add a clang option -fprofile-continuous that enables PGO continuous mode (PR #124353)

2025-01-30 Thread Wael Yehia via cfe-commits
@@ -0,0 +1,21 @@ +// 1) test on platforms that (do or do not) require runtime relocation +// +// RUN: %clang -target x86_64-darwin -fprofile-generate -fprofile-continuous -### -c %s 2>&1 | FileCheck %s --check-prefix=NO_RELOC +// NO_RELOC: "-cc1" {{.*}} "-fprofile-continuous" +//

[clang] [clang][Sema] Improve template argument deduction diagnostic (PR #122754)

2025-01-30 Thread Aidan Goldfarb via cfe-commits
@@ -11714,13 +11714,37 @@ static void DiagnoseBadDeduction(Sema &S, NamedDecl *Found, Decl *Templated, return; } - case TemplateDeductionResult::InvalidExplicitArguments: + case TemplateDeductionResult::InvalidExplicitArguments: { assert(ParamD && "no parameter f

[clang] [Clang] Clean up fetching the offloading toolchain (PR #125095)

2025-01-30 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/125095 Summary: This patch cleans up how we query the offloading toolchain. We create a single that is more similar to the existing `getToolChain` driver function and make all the offloading handlers use it. >From da7

[clang] Add clang atomic control options and attribute (PR #114841)

2025-01-30 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/114841 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add clang atomic control options and attribute (PR #114841)

2025-01-30 Thread Aaron Ballman via cfe-commits
@@ -4972,3 +4972,59 @@ def NoTrivialAutoVarInit: InheritableAttr { let Documentation = [NoTrivialAutoVarInitDocs]; let SimpleHandler = 1; } + +def Atomic : StmtAttr { + let Spellings = [Clang<"atomic">]; + let Args = [ +EnumArgument<"NoRemoteMemory", "NoRemoteMemoryTy

[clang] Add clang atomic control options and attribute (PR #114841)

2025-01-30 Thread Aaron Ballman via cfe-commits
@@ -3292,6 +3292,8 @@ def err_invalid_branch_protection_spec : Error< "invalid or misplaced branch protection specification '%0'">; def warn_unsupported_branch_protection_spec : Warning< "unsupported branch protection specification '%0'">, InGroup; +def err_attribute_inval

[clang] Add clang atomic control options and attribute (PR #114841)

2025-01-30 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: The changes should definitely come with a release note in `clang/docs/ReleaseNotes.rst`, but this also seems like it maybe should get wider documentation in the language extensions manual. I mentioned a need for attribute documentation, that could be

[clang] Add clang atomic control options and attribute (PR #114841)

2025-01-30 Thread Aaron Ballman via cfe-commits
@@ -305,6 +305,13 @@ def err_drv_invalid_int_value : Error<"invalid integral value '%1' in '%0'">; def err_drv_invalid_value_with_suggestion : Error< "invalid value '%1' in '%0', expected one of: %2">; def err_drv_alignment_not_power_of_two : Error<"alignment is not a powe

[clang] Add clang atomic control options and attribute (PR #114841)

2025-01-30 Thread Aaron Ballman via cfe-commits
@@ -623,6 +623,10 @@ class LangOptions : public LangOptionsBase { // WebAssembly target. bool NoWasmOpt = false; + /// The default atomic codegen options specified by command line in the + /// format of key:{on|off}. + std::vector AtomicOptionsAsWritten; ---

[clang] [ARM] Empty structs are 1-byte for C++ ABI (PR #124762)

2025-01-30 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/124762 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Clean up fetching the offloading toolchain (PR #125095)

2025-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Joseph Huber (jhuber6) Changes Summary: This patch cleans up how we query the offloading toolchain. We create a single that is more similar to the existing `getToolChain` driver function and make all the offloading handlers use it.

[libclc] [libclc] Remove use of symlinks (PR #125069)

2025-01-30 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/125069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Support member function poiners in Decl::getFunctionType() (PR #125077)

2025-01-30 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM... but I have a couple comments on things you mentioned in the commit message. > ``` > /// Looks through the Decl's underlying type to extract a FunctionType > /// when possible. Will return null if the type underlying the Decl d

[libclc] 0e2abe7 - [libclc] Remove use of symlinks (#125069)

2025-01-30 Thread via cfe-commits
Author: Fraser Cormack Date: 2025-01-30T17:44:07Z New Revision: 0e2abe7de3931daa1ecd13172e36fc6027ce45a8 URL: https://github.com/llvm/llvm-project/commit/0e2abe7de3931daa1ecd13172e36fc6027ce45a8 DIFF: https://github.com/llvm/llvm-project/commit/0e2abe7de3931daa1ecd13172e36fc6027ce45a8.diff LOG

[libclc] [libclc] Remove use of symlinks (PR #125069)

2025-01-30 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck closed https://github.com/llvm/llvm-project/pull/125069 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply 44c0719e77b37374c89b7fc1320664ebb404323d with fix; NFC (PR #125100)

2025-01-30 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes Silence MSVC warnings; NFC After the changes to DynamicRecursiveASTVisitor, we started getting several warnings from MSVC like: warning C4661: 'bool clang::DynamicRecursiveASTVisitorBase::WalkU

[clang] Reapply 44c0719e77b37374c89b7fc1320664ebb404323d with fix; NFC (PR #125100)

2025-01-30 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman created https://github.com/llvm/llvm-project/pull/125100 Silence MSVC warnings; NFC After the changes to DynamicRecursiveASTVisitor, we started getting several warnings from MSVC like: warning C4661: 'bool clang::DynamicRecursiveASTVisitorBase::WalkUpFromNamedD

[clang] [TBAA] Don't emit pointer-tbaa for void pointers. (PR #122116)

2025-01-30 Thread Florian Hahn via cfe-commits
@@ -2489,6 +2489,81 @@ are listed below. $ clang -fuse-ld=lld -Oz -Wl,--icf=safe -fcodegen-data-use code.cc +Strict Aliasing +--- + +The C and C++ standards require accesses to objects in memory to use l-values of +an appropriate type for the object. This is

[clang] [TBAA] Don't emit pointer-tbaa for void pointers. (PR #122116)

2025-01-30 Thread Florian Hahn via cfe-commits
@@ -2489,6 +2489,81 @@ are listed below. $ clang -fuse-ld=lld -Oz -Wl,--icf=safe -fcodegen-data-use code.cc +Strict Aliasing +--- + +The C and C++ standards require accesses to objects in memory to use l-values of +an appropriate type for the object. This is

[clang] [TBAA] Don't emit pointer-tbaa for void pointers. (PR #122116)

2025-01-30 Thread Florian Hahn via cfe-commits
@@ -2489,6 +2489,81 @@ are listed below. $ clang -fuse-ld=lld -Oz -Wl,--icf=safe -fcodegen-data-use code.cc +Strict Aliasing +--- + +The C and C++ standards require accesses to objects in memory to use l-values of +an appropriate type for the object. This is

[clang] Warn when unique objects might be duplicated in shared libraries (PR #117622)

2025-01-30 Thread Hans Wennborg via cfe-commits
@@ -13374,6 +13374,62 @@ void Sema::checkNonTrivialCUnion(QualType QT, SourceLocation Loc, .visit(QT, nullptr, false); } +bool Sema::GloballyUniqueObjectMightBeAccidentallyDuplicated( +const VarDecl *Dcl) { + if (!Dcl || !getLangOpts().CPlusPlus)

[clang] [TBAA] Don't emit pointer-tbaa for void pointers. (PR #122116)

2025-01-30 Thread Florian Hahn via cfe-commits
@@ -5272,6 +5296,8 @@ The Visual C++ Toolset has a slightly more elaborate mechanism for detection. Restrictions and Limitations compared to Clang -- +.. _clang_cl_strict_aliasing: + Strict Aliasing fhahn wrote: I

[clang] [llvm] [llvm] Enable TLSDESC by default on Fuchsia targets (PR #124990)

2025-01-30 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/124990 >From 94f3f4365a49f39ee8e4bd598355ad21d7de82ab Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Wed, 29 Jan 2025 19:12:17 + Subject: [PATCH] [llvm] Enable TLSDESC by default on Fuchsia targets Fuchsia uses T

[clang] [Clang] Fix __{add, remove}_pointer in Objective-C++ (PR #123678)

2025-01-30 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/123678 >From 2fe753b803a1067872a3d61ca04cdf49b7c023a6 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Tue, 21 Jan 2025 02:16:02 +0100 Subject: [PATCH] [Clang] Fix __{add,remove}_pointer in Objective-C++ --- c

[clang] [llvm] [llvm] Enable TLSDESC by default on Fuchsia targets (PR #124990)

2025-01-30 Thread Paul Kirth via cfe-commits
@@ -1119,7 +1119,9 @@ class Triple { /// True if the target supports both general-dynamic and TLSDESC, and TLSDESC ilovepi wrote: Yeah, the comment here is a bit inaccurate. I've updated it to reflect how it's used in practice. Our Aarch64 implementation do

[clang] [llvm] [llvm] Enable TLSDESC by default on Fuchsia targets (PR #124990)

2025-01-30 Thread Paul Kirth via cfe-commits
ilovepi wrote: ### Merge activity * **Jan 30, 1:23 PM EST**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/124990). https://github.com/llvm/llvm-project/pull/124990

[clang] Warn when unique objects might be duplicated in shared libraries (PR #117622)

2025-01-30 Thread Hans Wennborg via cfe-commits
@@ -6153,6 +6153,15 @@ def warn_static_local_in_extern_inline : Warning< def note_convert_inline_to_static : Note< "use 'static' to give inline function %0 internal linkage">; +def warn_possible_object_duplication_mutable : Warning< + "%0 is mutable, has hidden visibility,

[clang] [llvm] [llvm] Enable TLSDESC by default on Fuchsia targets (PR #124990)

2025-01-30 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/124990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

2025-01-30 Thread via cfe-commits
@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

[clang] [TBAA] Don't emit pointer-tbaa for void pointers. (PR #122116)

2025-01-30 Thread Florian Hahn via cfe-commits
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/122116 >From 04ae49a9c6680c6c9f2f9f482fc1f25fffd0d4d5 Mon Sep 17 00:00:00 2001 From: Florian Hahn Date: Wed, 8 Jan 2025 13:07:01 + Subject: [PATCH 1/8] [TBAA] Don't emit pointer-tbaa for void pointers. While there a

[clang] 08c7673 - [llvm] Enable TLSDESC by default on Fuchsia targets (#124990)

2025-01-30 Thread via cfe-commits
Author: Paul Kirth Date: 2025-01-30T10:25:25-08:00 New Revision: 08c76730f35e1dd3c9330b47fc304a35e6d9087e URL: https://github.com/llvm/llvm-project/commit/08c76730f35e1dd3c9330b47fc304a35e6d9087e DIFF: https://github.com/llvm/llvm-project/commit/08c76730f35e1dd3c9330b47fc304a35e6d9087e.diff LO

[clang] [Clang][Driver][Test] Created test for unsupported driver options (PR #120900)

2025-01-30 Thread via cfe-commits
@@ -0,0 +1,626 @@ +#!/usr/bin/env python3 + +""" generate_unsupported_in_drivermode.py + +usage: python generate_unsupported_in_drivermode.py /Options.td [/llvm-tblgen] + +This script generates a Lit regression test file that validates that options +are only exposed to intended d

<    1   2   3   4   5   >