[clang] [clang][SME] Emit error for OpenMP captured regions in SME functions (PR #124590)

2025-01-27 Thread Benjamin Maxwell via cfe-commits
https://github.com/MacDue edited https://github.com/llvm/llvm-project/pull/124590 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SveEmitter] Explicitly merge with `poison` instead of `undef` (PR #124596)

2025-01-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Pedro Lobo (pedroclobo) Changes Merge builtins with merge type `MergeAnyExp` with `poison` operands instead of `undef` operands. --- Patch is 270.55 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/p

[clang] [SveEmitter] Explicitly merge with `poison` instead of `undef` (PR #124596)

2025-01-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Pedro Lobo (pedroclobo) Changes Merge builtins with merge type `MergeAnyExp` with `poison` operands instead of `undef` operands. --- Patch is 270.55 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-p

[clang-tools-extra] [clang-tidy] Refactor: removed typos in 'AllowedTypes' option in various checks (PR #122957)

2025-01-27 Thread via cfe-commits
@@ -31,6 +31,6 @@ Options A semicolon-separated list of names of types allowed to be copied in each iteration. Regular expressions are accepted, e.g. `[Rr]ef(erence)?$` matches every type with suffix `Ref`, `ref`, `Reference` and `reference`. The default -

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-27 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/121394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fixed UnresolvedLookupExpr propagating into the codegen phase (PR #124609)

2025-01-27 Thread via cfe-commits
https://github.com/TilakChad edited https://github.com/llvm/llvm-project/pull/124609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [Clang] Make `-Wreturn-type` default to an error in all language modes (PR #123470)

2025-01-27 Thread Vitaly Buka via cfe-commits
@@ -2,10 +2,10 @@ // UNSUPPORTED: target=thumb{{.*}} // UNSUPPORTED: android -// RUN: %clangxx -fsanitize=return %gmlt -O2 -fno-omit-frame-pointer -fasynchronous-unwind-tables %s -o %t +// RUN: %clangxx -Wno-error=return-type -fsanitize=return %gmlt -O2 -fno-omit-frame-point

[clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-27 Thread Ilia Kuklin via cfe-commits
https://github.com/kuilpd updated https://github.com/llvm/llvm-project/pull/115005 >From 4d797371598960baf7729d05590aa1a8c7077694 Mon Sep 17 00:00:00 2001 From: Ilia Kuklin Date: Mon, 4 Nov 2024 14:33:45 +0500 Subject: [PATCH 1/8] [lldb] Analyze enum promotion type during parsing --- clang/in

[clang] [clang] improve print / dump of anonymous declarations (PR #124605)

2025-01-27 Thread Erich Keane via cfe-commits
@@ -875,7 +875,41 @@ void TextNodeDumper::dumpBareDeclRef(const Decl *D) { if (const NamedDecl *ND = dyn_cast(D)) { ColorScope Color(OS, ShowColors, DeclNameColor); -OS << " '" << ND->getDeclName() << '\''; +if (DeclarationName Name = ND->getDeclName()) + OS

[clang] [compiler-rt] [Clang] Make `-Wreturn-type` default to an error in all language modes (PR #123470)

2025-01-27 Thread via cfe-commits
@@ -2,10 +2,10 @@ // UNSUPPORTED: target=thumb{{.*}} // UNSUPPORTED: android -// RUN: %clangxx -fsanitize=return %gmlt -O2 -fno-omit-frame-pointer -fasynchronous-unwind-tables %s -o %t +// RUN: %clangxx -Wno-error=return-type -fsanitize=return %gmlt -O2 -fno-omit-frame-point

[clang] [compiler-rt] [Clang] Make `-Wreturn-type` default to an error in all language modes (PR #123470)

2025-01-27 Thread via cfe-commits
@@ -1,4 +1,4 @@ -// RUN: %clang_hwasan %s -o %t && %env_hwasan_opts=random_tags=1 %run %t +// RUN: %clang_hwasan -Wno-error=return-type %s -o %t && %env_hwasan_opts=random_tags=1 %run %t Sirraide wrote: I’m not really that familiar with the sanitizers, and I kno

[clang] [Clang] Fixed UnresolvedLookupExpr propagating into the codegen phase (PR #124609)

2025-01-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: TilakChad (TilakChad) Changes The `UnresolvedLookupExpr` doesn't get looked up and resolved again while it is in the non-dependent context. It propagates into the codegen phase and causing the assertion failure. We attempt to determine i

[clang] [compiler-rt] [Clang] Make `-Wreturn-type` default to an error in all language modes (PR #123470)

2025-01-27 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/123470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] improve print / dump of anonymous declarations (PR #124605)

2025-01-27 Thread Matheus Izvekov via cfe-commits
@@ -875,7 +875,41 @@ void TextNodeDumper::dumpBareDeclRef(const Decl *D) { if (const NamedDecl *ND = dyn_cast(D)) { ColorScope Color(OS, ShowColors, DeclNameColor); -OS << " '" << ND->getDeclName() << '\''; +if (DeclarationName Name = ND->getDeclName()) + OS

[clang] [clang-tools-extra] [lldb] [Clang] [NFC] Rename `isAnyPointerType()` and `getPointeeOrArrayElementType()`. (PR #122938)

2025-01-27 Thread via cfe-commits
Sirraide wrote: Aaron and I just talked about this a bit, and I agree it would be cleaner to just make a single function that can be used everywhere and whose behaviour is customised with an enum. I’ll experiment with that approach and see how it goes. Also, my plan was to try and remove `isPo

[clang] [clang][Sema][FMV] Add a note to the 'cannot become multiversioned' diagnostic (PR #124364)

2025-01-27 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/12500 Here is the r

[clang] [Clang] Fixed UnresolvedLookupExpr propagating into the codegen phase (PR #124609)

2025-01-27 Thread via cfe-commits
https://github.com/TilakChad created https://github.com/llvm/llvm-project/pull/124609 The `UnresolvedLookupExpr` doesn't get looked up and resolved again while it is in the non-dependent context. It propagates into the codegen phase and causing the assertion failure. We attempt to determine i

[clang-tools-extra] [clang-tidy] Replace /* ... */ single-line comments with // ... comments (PR #124319)

2025-01-27 Thread via cfe-commits
@@ -0,0 +1,39 @@ +.. title:: clang-tidy - use-cpp-style-comments + +readability-use-cpp-style-comments +== + +Replace C-style comments with C++-style comments. +C-style comments (``/* ... */``) are inherited from C, while C++ introduces +``//`` as

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-27 Thread Djordje Todorovic via cfe-commits
@@ -1228,6 +1228,21 @@ def HasVendorXCVbi : Predicate<"Subtarget->hasVendorXCVbi()">, AssemblerPredicate<(all_of FeatureVendorXCVbi), "'XCVbi' (CORE-V Immediate Branching)">; +// MIPS Extensions + +def FeatureVendorXMIPSCMove +: RISCVExten

[clang-tools-extra] [clang-tidy] Replace /* ... */ single-line comments with // ... comments (PR #124319)

2025-01-27 Thread via cfe-commits
@@ -0,0 +1,39 @@ +.. title:: clang-tidy - use-cpp-style-comments + +readability-use-cpp-style-comments +== + +Replace C-style comments with C++-style comments. +C-style comments (``/* ... */``) are inherited from C, while C++ introduces +``//`` as

[clang-tools-extra] [clang-tidy] Replace /* ... */ single-line comments with // ... comments (PR #124319)

2025-01-27 Thread via cfe-commits
@@ -173,13 +173,18 @@ New checks Replace comparisons between signed and unsigned integers with their safe C++20 ``std::cmp_*`` alternative, if available. - + EugeneZelenko wrote: Please remove spaces. https://github.com/llvm/llvm-project/pull/124319 __

[clang-tools-extra] [clang-tidy] Replace /* ... */ single-line comments with // ... comments (PR #124319)

2025-01-27 Thread via cfe-commits
https://github.com/4m4n-x-B4w4ne updated https://github.com/llvm/llvm-project/pull/124319 >From 581cc0eda9d42458ff71f2c913a2e03d2de0b5f2 Mon Sep 17 00:00:00 2001 From: NagaChaitanya Vellanki Date: Fri, 19 Jul 2024 14:26:23 -0700 Subject: [PATCH 01/12] This commit is to resolve the issue #24841

[clang] [Clang][counted_by] Refactor __builtin_dynamic_object_size on FAMs (PR #122198)

2025-01-27 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers approved this pull request. Thanks, I appreciate the comments about common usage patterns; they help make it easier to understand (subjectively) the 4 cases you handle in code. I still think we may need to triple check how this extension behaves with count fi

[clang] [clang] Add __nullptr as a keyword to C (PR #123119)

2025-01-27 Thread Aaron Ballman via cfe-commits
@@ -514,9 +514,7 @@ available in all language modes. __nullptr - -``__nullptr`` is an alternate spelling for ``nullptr``, but is also available in -C++ modes prior to C++11. Note that it's currently not availbale in C despite -C23 having support for ``nullptr``. +``__

[clang] [clang] Add __nullptr as a keyword to C (PR #123119)

2025-01-27 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/123119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [Clang] Make `-Wreturn-type` default to an error in all language modes (PR #123470)

2025-01-27 Thread Vitaly Buka via cfe-commits
@@ -1,4 +1,4 @@ -// RUN: %clang_hwasan %s -o %t && %env_hwasan_opts=random_tags=1 %run %t +// RUN: %clang_hwasan -Wno-error=return-type %s -o %t && %env_hwasan_opts=random_tags=1 %run %t vitalybuka wrote: It should be fine to change HWASAN tests, it does nothing

[clang] [Clang] Add -fwrapv-pointer flag (PR #122486)

2025-01-27 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/122486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][counted_by] Refactor __builtin_dynamic_object_size on FAMs (PR #122198)

2025-01-27 Thread Bill Wendling via cfe-commits
bwendling wrote: > I still think we may need to triple check how this extension behaves with > count fields that do not get extended AND are negative at runtime (if we > don't already have tests for that), but perhaps is orthogonal to this initial > refactoring. I'll look into test cases with

[clang] Warn when unique objects might be duplicated in shared libraries (PR #117622)

2025-01-27 Thread Reid Kleckner via cfe-commits
rnk wrote: +1 to separating implementation from enablement. Enabling the warning by default will predictably generate pushback and folks may ask to revert, and it's a good best practice to be able to easily do that while leaving the implementation in place. https://github.com/llvm/llvm-projec

[clang] WIP: [clang] MicrosoftCXXABI: Fix exception copy constructor LUT after loading AST (PR #114075)

2025-01-27 Thread Andrey Glebov via cfe-commits
https://github.com/glebov-andrey updated https://github.com/llvm/llvm-project/pull/114075 >From 7c4f07ddbc8cdb77e8526dccd6bd19fa5a64744a Mon Sep 17 00:00:00 2001 From: Andrey Glebov Date: Mon, 28 Oct 2024 00:02:51 +0300 Subject: [PATCH] [clang] MicrosoftCXXABI: restore the RecordToCopyCtor tabl

[clang] [clang] Add __nullptr as a keyword to C (PR #123119)

2025-01-27 Thread Aidan Goldfarb via cfe-commits
https://github.com/AidanGoldfarb updated https://github.com/llvm/llvm-project/pull/123119 >From bc5d1419d94ac492c0fcf62a74844eb43ce17f1a Mon Sep 17 00:00:00 2001 From: Aidan Date: Wed, 15 Jan 2025 15:24:12 -0500 Subject: [PATCH 01/13] __nullptr -> KEYALL, added relevant test --- clang/include

[clang] [clang-tools-extra] [lldb] [Clang] [NFC] Rename `isAnyPointerType()` and `getPointeeOrArrayElementType()`. (PR #122938)

2025-01-27 Thread via cfe-commits
Sirraide wrote: ping https://github.com/llvm/llvm-project/pull/122938 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [NFC] Introduce `ConstDynamicRecursiveASTVisitor` (PR #122991)

2025-01-27 Thread via cfe-commits
Sirraide wrote: ping https://github.com/llvm/llvm-project/pull/122991 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] add AllowedTypes option to misc-const-correctness (PR #122951)

2025-01-27 Thread via cfe-commits
@@ -196,3 +196,12 @@ Options // The following pointer may not become a 'int *const'. int *changing_pointee = &value; changing_pointee = &result; + +.. option:: AllowedTypes (default = '') EugeneZelenko wrote: Defaults usually stated in last sentenc

[clang] Add configuration option PenaltyBreakBeforeMemberAccess (PR #118409)

2025-01-27 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/118409 >From 86bc2d2fe03d84879870eec1a8c10912076686c2 Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Mon, 2 Dec 2024 15:16:39 -0700 Subject: [PATCH 1/4] [clang-format] Add PenaltyBreakBeforeMemberAccess Add a config

[libclc] [libclc] Optimize CLC vector any/all builtins (PR #124568)

2025-01-27 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck created https://github.com/llvm/llvm-project/pull/124568 By using the vector reduction buitins we can avoid scalarization. Targets that don't support vector reductions will scalarize later on anyway. The vector reduction builtins should be well-enough supported b

[clang-tools-extra] [clang-tidy] add AllowedTypes option to misc-const-correctness (PR #122951)

2025-01-27 Thread Baranov Victor via cfe-commits
@@ -196,3 +196,12 @@ Options // The following pointer may not become a 'int *const'. int *changing_pointee = &value; changing_pointee = &result; + +.. option:: AllowedTypes (default = '') vbvictor wrote: In this file all the options has default in

[clang] [clang][ASTImporter] Fix possible crash at import of function template (PR #124273)

2025-01-27 Thread Balázs Kéri via cfe-commits
balazske wrote: It seems that this test is not reducible any further (except very small changes) (to get the original crash). I could remove only few lines. https://github.com/llvm/llvm-project/pull/124273 ___ cfe-commits mailing list cfe-commits@list

[clang] [Clang] Skip past code generation for unevaluated lambdas (PR #124572)

2025-01-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) Changes This is taken from https://github.com/llvm/llvm-project/pull/122423#discussion_r1930102632 as suggested by Corentin. Fixes #82926 --- Full diff: https://github.com/llvm/llvm-project/pull/124572.diff 3 Fi

[clang-tools-extra] [clang-tidy] add AllowedTypes option to misc-const-correctness (PR #122951)

2025-01-27 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor updated https://github.com/llvm/llvm-project/pull/122951 >From 841cfec5a0ab4ce5ce64e71facfb7becaf4340e8 Mon Sep 17 00:00:00 2001 From: Victor Baranov Date: Tue, 14 Jan 2025 22:05:43 +0300 Subject: [PATCH 1/7] [clang-tidy] add AllowedTypes to misc-const-correctness -

[clang] [llvm] [mlir] [Offload] Rework offloading entry type to be more generic (PR #124018)

2025-01-27 Thread Joseph Huber via cfe-commits
@@ -24,11 +24,24 @@ namespace offloading { /// This is the record of an object that just be registered with the offloading /// runtime. struct EntryTy { + /// Reserved bytes used to detect an older version of the struct, always zero. + uint64_t Reserved = 0x0; --

[libclc] c3a0fcc - [libclc] Optimize CLC vector any/all builtins (#124568)

2025-01-27 Thread via cfe-commits
Author: Fraser Cormack Date: 2025-01-27T16:37:21Z New Revision: c3a0fcc982061f9a69cfc1199dc91bd1fc3158c0 URL: https://github.com/llvm/llvm-project/commit/c3a0fcc982061f9a69cfc1199dc91bd1fc3158c0 DIFF: https://github.com/llvm/llvm-project/commit/c3a0fcc982061f9a69cfc1199dc91bd1fc3158c0.diff LOG

[clang] [clang][Sema][FMV] Add a note to the 'cannot become multiversioned' diagnostic (PR #124364)

2025-01-27 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs closed https://github.com/llvm/llvm-project/pull/124364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 73db9ee - [clang][Sema][FMV] Add a note to the 'cannot become multiversioned' diagnostic (#124364)

2025-01-27 Thread via cfe-commits
Author: Jon Roelofs Date: 2025-01-27T08:49:32-08:00 New Revision: 73db9ee1e87b4cfccbc9d67d2b47d9476f92413f URL: https://github.com/llvm/llvm-project/commit/73db9ee1e87b4cfccbc9d67d2b47d9476f92413f DIFF: https://github.com/llvm/llvm-project/commit/73db9ee1e87b4cfccbc9d67d2b47d9476f92413f.diff L

[clang-tools-extra] [clang-tidy] Replace /* ... */ single-line comments with // ... comments (PR #124319)

2025-01-27 Thread via cfe-commits
@@ -0,0 +1,127 @@ +//===--- UseCppStyleCommentsCheck.cpp - clang-tidy-===// + +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang] [Driver][ASan] Refactor Clang-Driver "Sanitizer Bitcode" linking. (PR #123922)

2025-01-27 Thread Amit Kumar Pandey via cfe-commits
@@ -70,6 +70,10 @@ def err_drv_no_rocm_device_lib : Error< "cannot find ROCm device library%select{| for %1| for ABI version %1}0; provide its path via " "'--rocm-path' or '--rocm-device-lib-path', or pass '-nogpulib' to build " "without ROCm device library">; +def err_d

[clang] [Clang] Remove unnecessary Decl transform & profiles for SizeOfPackExpr (PR #124533)

2025-01-27 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: In my comment here, it really looks like a clang-17 regression: https://github.com/llvm/llvm-project/issues/124161#event-16079402729 >From what I can tell you also address the simplified version, so I believe a >release note is probably warrented. Are ther

[clang-tools-extra] [clang-tidy] Replace /* ... */ single-line comments with // ... comments (PR #124319)

2025-01-27 Thread via cfe-commits
@@ -0,0 +1,127 @@ +//===--- UseCppStyleCommentsCheck.cpp - clang-tidy-===// + +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang-tidy] Replace /* ... */ single-line comments with // ... comments (PR #124319)

2025-01-27 Thread via cfe-commits
@@ -0,0 +1,40 @@ +.. title:: clang-tidy - use-cpp-style-comments + +modernize-use-cpp-style-comments + + +Replace C-style comments with C++-style comments. 4m4n-x-B4w4ne wrote: Done Thanks. https://github.com/llvm/llvm-project/pul

[clang] [clang] Prevent duplicated instantiation of enumerators of unscoped member enumerations (PR #124407)

2025-01-27 Thread André Brand via cfe-commits
https://github.com/thebrandre edited https://github.com/llvm/llvm-project/pull/124407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Replace /* ... */ single-line comments with // ... comments (PR #124319)

2025-01-27 Thread via cfe-commits
@@ -0,0 +1,127 @@ +//===--- UseCppStyleCommentsCheck.cpp - clang-tidy-===// + +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang-tidy] Replace /* ... */ single-line comments with // ... comments (PR #124319)

2025-01-27 Thread via cfe-commits
@@ -0,0 +1,127 @@ +//===--- UseCppStyleCommentsCheck.cpp - clang-tidy-===// + +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier:

[clang-tools-extra] [clang-tidy] Replace /* ... */ single-line comments with // ... comments (PR #124319)

2025-01-27 Thread via cfe-commits
@@ -0,0 +1,40 @@ +.. title:: clang-tidy - use-cpp-style-comments + +modernize-use-cpp-style-comments + + +Replace C-style comments with C++-style comments. +C-style comments (``/* ... */``) are inherited from C, while C++ introduces +``//`` as a mo

[clang-tools-extra] [clang-tidy] Replace /* ... */ single-line comments with // ... comments (PR #124319)

2025-01-27 Thread via cfe-commits
@@ -0,0 +1,68 @@ +// RUN: %check_clang_tidy -std=c++11 %s modernize-use-cpp-style-comments %t -- -- + +// Single-line full C-style comment +static const int CONSTANT = 42; /* Important constant value */ +// CHECK-MESSAGES: :[[@LINE-1]]:33: warning: use C++ style comments '//' in

[clang-tools-extra] [clang-tidy] Replace /* ... */ single-line comments with // ... comments (PR #124319)

2025-01-27 Thread via cfe-commits
@@ -0,0 +1,40 @@ +//===--- UseCppStyleCommentsCheck.h - clang-tidy---===// 4m4n-x-B4w4ne wrote: Done Thanks. https://github.com/llvm/llvm-project/pull/124319 ___ cfe-commits mailing list cfe-co

[clang] [Clang] Fix immediate escalation of template function specializations. (PR #124404)

2025-01-27 Thread via cfe-commits
cor3ntin wrote: I'll push a fix for the build failure on arm shortly https://github.com/llvm/llvm-project/pull/124404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Replace /* ... */ single-line comments with // ... comments (PR #124319)

2025-01-27 Thread via cfe-commits
https://github.com/4m4n-x-B4w4ne deleted https://github.com/llvm/llvm-project/pull/124319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Replace /* ... */ single-line comments with // ... comments (PR #124319)

2025-01-27 Thread via cfe-commits
4m4n-x-B4w4ne wrote: Can anyone please help me? Why is Test Documentation build is failing? I am in no clue. https://github.com/llvm/llvm-project/pull/124319 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [clang][docs] Fix typos concerning wasm __funcref (PR #124365)

2025-01-27 Thread Timothy Herchen via cfe-commits
https://github.com/anematode updated https://github.com/llvm/llvm-project/pull/124365 >From 2508da6fd7f38101011573460724f13df1c1616d Mon Sep 17 00:00:00 2001 From: Timothy Herchen Date: Fri, 24 Jan 2025 15:13:30 -0800 Subject: [PATCH] [clang][docs] Fix typos concerning wasm __funcref --- clan

[clang-tools-extra] [clang-tidy] Replace /* ... */ single-line comments with // ... comments (PR #124319)

2025-01-27 Thread via cfe-commits
https://github.com/4m4n-x-B4w4ne updated https://github.com/llvm/llvm-project/pull/124319 >From 581cc0eda9d42458ff71f2c913a2e03d2de0b5f2 Mon Sep 17 00:00:00 2001 From: NagaChaitanya Vellanki Date: Fri, 19 Jul 2024 14:26:23 -0700 Subject: [PATCH 1/8] This commit is to resolve the issue #24841 -

[clang] [clang][SME] Emit error for OpemMP captured regions in streaming functions (PR #124590)

2025-01-27 Thread Benjamin Maxwell via cfe-commits
https://github.com/MacDue created https://github.com/llvm/llvm-project/pull/124590 Currently, these generate incorrect code, as streaming attributes are not propagated to the outlined function. As we've yet to work on mixing OpenMP and streaming functions (and determine how they should interac

[clang] [Clang] Remove unnecessary Decl transform & profiles for SizeOfPackExpr (PR #124533)

2025-01-27 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > In my comment here, it really looks like a clang-17 regression: [#124161 > (comment)](https://github.com/llvm/llvm-project/issues/124161#event-16079402729) > > From what I can tell you also address the simplified version, so I believe a > release note is probably warrente

[clang] [llvm] [clang][docs] Fix typos concerning wasm __funcref (PR #124365)

2025-01-27 Thread Timothy Herchen via cfe-commits
@@ -1211,6 +1211,15 @@ WebAssemblyTargetLowering::LowerCall(CallLoweringInfo &CLI, } } } + +// If outgoing arguments are passed via the stack, we cannot tail call +for (const ISD::OutputArg &Out : CLI.Outs) { anematode wrote: Whoops!

[clang] [clang][SME] Emit error for OpemMP captured regions in streaming functions (PR #124590)

2025-01-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Benjamin Maxwell (MacDue) Changes Currently, these generate incorrect code, as streaming attributes are not propagated to the outlined function. As we've yet to work on mixing OpenMP and streaming functions (and determine how they should

[clang] [clang][SME] Emit error for OpemMP captured regions in streaming functions (PR #124590)

2025-01-27 Thread Sander de Smalen via cfe-commits
@@ -4568,9 +4568,23 @@ buildCapturedStmtCaptureList(Sema &S, CapturedRegionScopeInfo *RSI, return false; } +static bool +isOpenMPCapturedRegionInArmStreamingFunction(Sema const &S, + CapturedRegionKind Kind) { + if (!S.getLangOpt

[clang] [clang] Add __nullptr as a keyword to C (PR #123119)

2025-01-27 Thread Aidan Goldfarb via cfe-commits
https://github.com/AidanGoldfarb updated https://github.com/llvm/llvm-project/pull/123119 >From bc5d1419d94ac492c0fcf62a74844eb43ce17f1a Mon Sep 17 00:00:00 2001 From: Aidan Date: Wed, 15 Jan 2025 15:24:12 -0500 Subject: [PATCH 1/9] __nullptr -> KEYALL, added relevant test --- clang/include/c

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-27 Thread Djordje Todorovic via cfe-commits
@@ -1228,6 +1228,21 @@ def HasVendorXCVbi : Predicate<"Subtarget->hasVendorXCVbi()">, AssemblerPredicate<(all_of FeatureVendorXCVbi), "'XCVbi' (CORE-V Immediate Branching)">; +// MIPS Extensions + +def FeatureVendorXMIPSCMove +: RISCVExten

[clang] [llvm] [RISCV] Add MIPS extensions (PR #121394)

2025-01-27 Thread Djordje Todorovic via cfe-commits
@@ -1228,6 +1228,21 @@ def HasVendorXCVbi : Predicate<"Subtarget->hasVendorXCVbi()">, AssemblerPredicate<(all_of FeatureVendorXCVbi), "'XCVbi' (CORE-V Immediate Branching)">; +// MIPS Extensions + +def FeatureVendorXMIPSCMove +: RISCVExten

[libclc] [libclc] Move copysign to CLC library; fix & optimize (PR #124598)

2025-01-27 Thread Fraser Cormack via cfe-commits
https://github.com/frasercrmck edited https://github.com/llvm/llvm-project/pull/124598 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add __nullptr as a keyword to C (PR #123119)

2025-01-27 Thread Aidan Goldfarb via cfe-commits
https://github.com/AidanGoldfarb updated https://github.com/llvm/llvm-project/pull/123119 >From bc5d1419d94ac492c0fcf62a74844eb43ce17f1a Mon Sep 17 00:00:00 2001 From: Aidan Date: Wed, 15 Jan 2025 15:24:12 -0500 Subject: [PATCH 01/10] __nullptr -> KEYALL, added relevant test --- clang/include

[clang] [llvm] [RISCV] Renaming muladdi to muliadd as per v0.5 spec. (PR #124237)

2025-01-27 Thread Sam Elliott via cfe-commits
https://github.com/lenary approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/124237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [lldb] Analyze enum promotion type during parsing (PR #115005)

2025-01-27 Thread Ilia Kuklin via cfe-commits
@@ -3903,6 +3903,7 @@ class EnumDecl : public TagDecl { void setInstantiationOfMemberEnum(ASTContext &C, EnumDecl *ED, TemplateSpecializationKind TSK); +public: kuilpd wrote: I left this in so that that I could simply do

[clang] [clang] improve print / dump of anonymous declarations (PR #124605)

2025-01-27 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/124605 >From cf6413e220574adac3c89b28cc5011050ce11144 Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Mon, 27 Jan 2025 15:08:01 -0300 Subject: [PATCH 1/2] NFC: convert clang/test/AST/HLSL/StructuredBuffers-AST.h

[clang] [Clang] [NFC] Introduce `ConstDynamicRecursiveASTVisitor` (PR #122991)

2025-01-27 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. Thank you for this cleanup -- LGTM! Thank you for investigating the compile time overhead impacts ahead of time, that's appreciated. :-) https://github.com/llvm/llvm-project/pull/122991 ___ c

[clang] [clang] Add __nullptr as a keyword to C (PR #123119)

2025-01-27 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM aside from a change to the documentation. Thank you! https://github.com/llvm/llvm-project/pull/123119 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[libclc] libclc: clspv: add missing clc_isnan.cl dependency (PR #124614)

2025-01-27 Thread Romaric Jodin via cfe-commits
rjodinchr wrote: @frasercrmck, could you review please? https://github.com/llvm/llvm-project/pull/124614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] improve print / dump of anonymous declarations (PR #124605)

2025-01-27 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/124605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add configuration option PenaltyBreakBeforeMemberAccess (PR #118409)

2025-01-27 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/118409 >From 86bc2d2fe03d84879870eec1a8c10912076686c2 Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Mon, 2 Dec 2024 15:16:39 -0700 Subject: [PATCH 1/7] [clang-format] Add PenaltyBreakBeforeMemberAccess Add a config

[clang] [StrTable] Mechanically convert NVPTX builtins to use TableGen (PR #122873)

2025-01-27 Thread Artem Belevich via cfe-commits
@@ -104,9 +104,39 @@ class PrototypeParser { void ParseType(StringRef T) { T = T.trim(); + +auto ConsumeAddrSpace = [&]() -> std::optional { + T = T.trim(); + if (!T.consume_back(">")) +return std::nullopt; + + auto Open = T.find_last_of('<');

[clang-tools-extra] [clang-tidy] Refactor: removed typos in 'AllowedTypes' option in various checks (PR #122957)

2025-01-27 Thread Nicolas van Kempen via cfe-commits
@@ -31,6 +31,6 @@ Options A semicolon-separated list of names of types allowed to be copied in each iteration. Regular expressions are accepted, e.g. `[Rr]ef(erence)?$` matches every type with suffix `Ref`, `ref`, `Reference` and `reference`. The default -

[clang] [Clang] raise extension warning for unknown namespaced attributes (PR #120925)

2025-01-27 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Ultimately we want > > 1. I know all of these attributes, don't tell me about them > > 2. I know all of these attribute namespaces, don't tell me about them - > which this patch is doing > > 3. Have a way to disable unknown attributes warnings for all unknown

[clang] [clang] improve print / dump of anonymous declarations (PR #124605)

2025-01-27 Thread Matheus Izvekov via cfe-commits
@@ -875,7 +875,41 @@ void TextNodeDumper::dumpBareDeclRef(const Decl *D) { if (const NamedDecl *ND = dyn_cast(D)) { ColorScope Color(OS, ShowColors, DeclNameColor); -OS << " '" << ND->getDeclName() << '\''; +if (DeclarationName Name = ND->getDeclName()) + OS

[clang] Add configuration option PenaltyBreakBeforeMemberAccess (PR #118409)

2025-01-27 Thread Gedare Bloom via cfe-commits
https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/118409 >From 86bc2d2fe03d84879870eec1a8c10912076686c2 Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Mon, 2 Dec 2024 15:16:39 -0700 Subject: [PATCH 1/6] [clang-format] Add PenaltyBreakBeforeMemberAccess Add a config

[libclc] libclc: clspv: add missing clc_isnan.cl dependency (PR #124614)

2025-01-27 Thread Romaric Jodin via cfe-commits
https://github.com/rjodinchr created https://github.com/llvm/llvm-project/pull/124614 clc_isnan.cl is needed since https://github.com/llvm/llvm-project/pull/124097 >From 1c11070d2f2997b76412e7be07fa05501147c5ff Mon Sep 17 00:00:00 2001 From: Romaric Jodin Date: Mon, 27 Jan 2025 20:21:31 +0100

[clang] [StrTable] Mechanically convert NVPTX builtins to use TableGen (PR #122873)

2025-01-27 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B approved this pull request. LGTM overall with a couple of nits. I like the direction of the change. Tablegen is probably a better way to handle NVPTX quirks, than a preprocessor. We may finally be able to replace the string-based constraints that are growing a bit to

[clang] [StrTable] Mechanically convert NVPTX builtins to use TableGen (PR #122873)

2025-01-27 Thread Artem Belevich via cfe-commits
@@ -0,0 +1,1078 @@ +//===--- BuiltinsNVPTX.td - NVPTX Builtin function defs -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: A

[clang] [StrTable] Mechanically convert NVPTX builtins to use TableGen (PR #122873)

2025-01-27 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B edited https://github.com/llvm/llvm-project/pull/122873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix immediate escalation of template function specializations. (PR #124404)

2025-01-27 Thread Nikita Popov via cfe-commits
nikic wrote: FYI this change has some measurable compile-time overhead (about 0.2% for debug builds): https://llvm-compile-time-tracker.com/compare.php?from=eaa5897534cbd263d0cdbf780f72133c2fe8d8d4&to=561132e71b29d9b747dfda1509f715847852f77b&stat=instructions:u Not sure whether that's expected

[clang] [llvm] [LLVM][AMDGPU] Add Intrinsic and Builtin for ds_bpermute_fi_b32 (PR #124616)

2025-01-27 Thread Acim Maravic via cfe-commits
https://github.com/Acim-Maravic created https://github.com/llvm/llvm-project/pull/124616 None >From dea0bd7a2cb5f67599257a7d6ae6d0bb0e8804ab Mon Sep 17 00:00:00 2001 From: Acim Maravic Date: Mon, 27 Jan 2025 19:26:03 +0100 Subject: [PATCH] [LLVM][AMDGPU] Add Intrinsic and Builtin for ds_bperm

[clang] [llvm] [LLVM][AMDGPU] Add Intrinsic and Builtin for ds_bpermute_fi_b32 (PR #124616)

2025-01-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-ir Author: Acim Maravic (Acim-Maravic) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/124616.diff 6 Files Affected: - (modified) clang/include/clang/Basic/BuiltinsAMDGPU.def (+2) - (modified) clang/test/CodeGenOpenCL/builtins

[clang] [llvm] [LLVM][AMDGPU] Add Intrinsic and Builtin for ds_bpermute_fi_b32 (PR #124616)

2025-01-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Acim Maravic (Acim-Maravic) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/124616.diff 6 Files Affected: - (modified) clang/include/clang/Basic/BuiltinsAMDGPU.def (+2) - (modified) clang/test/CodeGenOpenCL/builtins-a

[clang] [clang] disallow narrowing when matching template template parameters (PR #124313)

2025-01-27 Thread Matheus Izvekov via cfe-commits
@@ -11682,6 +11683,7 @@ class Sema final : public SemaBase { SmallVectorImpl &SugaredConverted, SmallVectorImpl &CanonicalConverted, CheckTemplateArgumentKind CTAK, bool PartialOrdering, +

[clang] [clang] disallow narrowing when matching template template parameters (PR #124313)

2025-01-27 Thread Erich Keane via cfe-commits
@@ -11682,6 +11683,7 @@ class Sema final : public SemaBase { SmallVectorImpl &SugaredConverted, SmallVectorImpl &CanonicalConverted, CheckTemplateArgumentKind CTAK, bool PartialOrdering, +

[clang-tools-extra] [clang-tidy] Replace /* ... */ single-line comments with // ... comments (PR #124319)

2025-01-27 Thread Baranov Victor via cfe-commits
vbvictor wrote: As @PiotrZSL mentioned in the issue, adding an option called `ExcludeDoxygenStyleComments` would be very helpful (or even necessary) before releasing this check. Otherwise, it could create a lot of trouble for projects that use doxygen for their documentation (including LLVM it

[clang-tools-extra] [clang-tidy] Refactor: removed typos in 'AllowedTypes' option in various checks (PR #122957)

2025-01-27 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/122957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Refactor: removed typos in 'AllowedTypes' option in various checks (PR #122957)

2025-01-27 Thread Baranov Victor via cfe-commits
@@ -31,6 +31,6 @@ Options A semicolon-separated list of names of types allowed to be copied in each iteration. Regular expressions are accepted, e.g. `[Rr]ef(erence)?$` matches every type with suffix `Ref`, `ref`, `Reference` and `reference`. The default -

[clang] [Clang] Skip past code generation for unevaluated lambdas (PR #124572)

2025-01-27 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: See also discussion on #117845. I think it makes some sense to add a way for CodeGen to query whether a given declaration is impossible to emit. I suggested in that discussion that it could be a kind of linkage. I'd prefer not to mess with the way DeferredDecls works for

[clang-tools-extra] [clang-tidy] Refactor: removed typos in 'AllowedTypes' option in various checks (PR #122957)

2025-01-27 Thread Baranov Victor via cfe-commits
https://github.com/vbvictor edited https://github.com/llvm/llvm-project/pull/122957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement -fstrict-bool (PR #116732)

2025-01-27 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: I second that we need to document how values outside of zero and one are handled. I would like also really want to see a test that demonstrates the behavior we are expecting to support with comments explaining the result and why we expect it. After seei

[clang] [clang] Implement -fstrict-bool (PR #116732)

2025-01-27 Thread via cfe-commits
apple-fcloutier wrote: I will get back to this later. https://github.com/llvm/llvm-project/pull/116732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   6   >