https://github.com/Artem-B approved this pull request.
LGTM overall with a couple of nits. I like the direction of the change. Tablegen is probably a better way to handle NVPTX quirks, than a preprocessor. We may finally be able to replace the string-based constraints that are growing a bit too long already with something more flexible (custom code blocks similar to LLVM's constraints + sensible error message generation to go along with them) https://github.com/llvm/llvm-project/pull/122873 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
