https://github.com/RIscRIpt approved this pull request.
LGTM, this fixes `clang/test/SemaCXX/msvc-pragma-function-no-builtin-attr.cpp`
on macOS.
https://github.com/llvm/llvm-project/pull/119873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/119842
>From efe9cd9e78988a531dfbb6387691819ec5c18ac3 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Thu, 12 Dec 2024 00:30:25 +0800
Subject: [PATCH 1/2] [clang-tidy][doc][NFC] extract common global options in
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Edd Dawson (playstation-edd)
Changes
Responsibility for setting up implicit library search paths was recently
transferred to the PS5 driver (llvm#109796). Prior to this, SIE private
patches in lld performed this function. During the trans
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Edd Dawson (playstation-edd)
Changes
Responsibility for setting up implicit library search paths was recently
transferred to the PS5 driver (llvm#109796). Prior to this, SIE private
patches in lld performed this function. During th
https://github.com/shiltian updated
https://github.com/llvm/llvm-project/pull/104661
>From 69d491983634adb2c059025ac848d1c53b0b282a Mon Sep 17 00:00:00 2001
From: Shilei Tian
Date: Fri, 13 Dec 2024 08:59:59 -0500
Subject: [PATCH] [Clang] Remove 3-element vector load and store special
handling
https://github.com/lenary approved this pull request.
LGTM, but please wait for Craig to approve as well.
https://github.com/llvm/llvm-project/pull/119823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/momchil-velikov closed
https://github.com/llvm/llvm-project/pull/118125
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Momchil Velikov
Date: 2024-12-13T14:06:54Z
New Revision: c2172431c72c9b249bf5bdfcc0c239fbfe64fa9b
URL:
https://github.com/llvm/llvm-project/commit/c2172431c72c9b249bf5bdfcc0c239fbfe64fa9b
DIFF:
https://github.com/llvm/llvm-project/commit/c2172431c72c9b249bf5bdfcc0c239fbfe64fa9b.diff
LO
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/119887
The missing part of #119580
>From f50c1e075e129dd7a78f539476a2183e730a4608 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Fri, 13 Dec 2024 22:37:28 +0800
Subject: [PATCH] [clang-tidy][NFC][doc] clean ou
https://github.com/RIscRIpt closed
https://github.com/llvm/llvm-project/pull/119873
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: VScigolevs
Date: 2024-12-13T15:12:09+02:00
New Revision: 12a42a60f9e63fab5699b210248b5b51bd21b6e3
URL:
https://github.com/llvm/llvm-project/commit/12a42a60f9e63fab5699b210248b5b51bd21b6e3
DIFF:
https://github.com/llvm/llvm-project/commit/12a42a60f9e63fab5699b210248b5b51bd21b6e3.diff
LO
Author: Kristóf Umann
Date: 2024-12-13T14:31:06+01:00
New Revision: ea8e328ae2bea9d9a7d556ef4d791fa116f7de18
URL:
https://github.com/llvm/llvm-project/commit/ea8e328ae2bea9d9a7d556ef4d791fa116f7de18
DIFF:
https://github.com/llvm/llvm-project/commit/ea8e328ae2bea9d9a7d556ef4d791fa116f7de18.diff
fsfod wrote:
Yes I could rename it and make it the set symbol visibility macros to export
instead.
https://github.com/llvm/llvm-project/pull/112304
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
llvmbot wrote:
@llvm/pr-subscribers-backend-risc-v
Author: Djordje Todorovic (djtodoro)
Changes
Depends on https://github.com/llvm/llvm-project/pull/119882.
---
Full diff: https://github.com/llvm/llvm-project/pull/119885.diff
7 Files Affected:
- (modified) clang/test/Driver/riscv-cpus.
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Djordje Todorovic (djtodoro)
Changes
Depends on https://github.com/llvm/llvm-project/pull/119882.
---
Full diff: https://github.com/llvm/llvm-project/pull/119885.diff
7 Files Affected:
- (modified) clang/test/Driver/riscv-cpus.c (+17)
@@ -0,0 +1,279 @@
+//===-- RISCVSchedMIPSP8700.td - MIPS RISC-V Processor -*- tablegen
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
Author: erichkeane
Date: 2024-12-13T06:33:04-08:00
New Revision: 55154d6896e31dd707ac90dd15ed09bec446b4cf
URL:
https://github.com/llvm/llvm-project/commit/55154d6896e31dd707ac90dd15ed09bec446b4cf
DIFF:
https://github.com/llvm/llvm-project/commit/55154d6896e31dd707ac90dd15ed09bec446b4cf.diff
LO
@@ -22,6 +22,7 @@ def WriteIMul32 : SchedWrite;// 32-bit multiply on
RV64I
def WriteJmp: SchedWrite;// Jump
def WriteJal: SchedWrite;// Jump and link
def WriteJalr : SchedWrite;// Jump and link register
+def WriteJmpReg : SchedWrit
@@ -26,7 +26,8 @@ Options
.. option:: IgnoreMacros
carlosgalvezp wrote:
Personally I don't see much benefit in this change, it makes the documentation
harder to read as one has to go back and forth. I don't see the trouble with
this duplication, since it's
EugeneZelenko wrote:
But #113577 is still open. Also local `IncludeStyle` should be just deprecated
after.
https://github.com/llvm/llvm-project/pull/119842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/NagyDonat updated
https://github.com/llvm/llvm-project/pull/119388
From cb9b5ef4d8b0ed8e67276947525d327c547424fc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Don=C3=A1t=20Nagy?=
Date: Thu, 28 Nov 2024 17:22:58 +0100
Subject: [PATCH 1/2] [analyzer] Don't assume third iteration in
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Vitaly Buka (vitalybuka)
Changes
This check is a part of UBSAN, but does not support
verbose output like other UBSAN checks.
This is a step to fix that.
---
Full diff: https://github.com/llvm/llvm-project/pull/119894.diff
6 Files Affec
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/119894
This check is a part of UBSAN, but does not support
verbose output like other UBSAN checks.
This is a step to fix that.
>From 6cd26753f380d9ee89d85139a5dc58bc0e4b0632 Mon Sep 17 00:00:00 2001
From: Vitaly B
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Vitaly Buka (vitalybuka)
Changes
This check is a part of UBSAN, but does not support
verbose output like other UBSAN checks.
This is a step to fix that.
---
Full diff: https://github.com/llvm/llvm-project/pull/119894.diff
6 Fil
https://github.com/tbaederr created
https://github.com/llvm/llvm-project/pull/119895
Around shifting negative values.
>From f72e8e1a6a63b4a6e0f4095f20f551703a037c77 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Timm=20B=C3=A4der?=
Date: Fri, 13 Dec 2024 17:02:22 +0100
Subject: [PATCH] [clang][bytec
@@ -20,9 +21,13 @@ elif clang_bolt_mode == "perf":
else:
assert 0, "Unsupported CLANG_BOLT_MODE variable"
-config.clang = perf_wrapper + os.path.realpath(
+clang_nowrapper = os.path.realpath(
lit.util.which(clang_binary, config.clang_tools_dir)
).replace("\\", "/")
+
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Timm Baeder (tbaederr)
Changes
Around shifting negative values.
---
Full diff: https://github.com/llvm/llvm-project/pull/119895.diff
3 Files Affected:
- (modified) clang/lib/AST/ByteCode/Integral.h (+5-2)
- (modified) clang/lib/AST/Byt
https://github.com/tstellar created
https://github.com/llvm/llvm-project/pull/119896
This change removes the need to call the clang-bolt target in order to apply
bolt optimizations to clang. Now running `ninja clang` will build a clang with
bolt optimizations, and `ninja check-clang` and `nin
https://github.com/michaelmaitland edited
https://github.com/llvm/llvm-project/pull/119885
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/michaelmaitland commented:
Please split the processor definition and scheduler model into their own
patches.
See:
https://github.com/llvm/llvm-project/commit/867ece181afe59aa020d365928169d2ebdc7d74a
https://github.com/llvm/llvm-project/commit/373d9d72145cd40c9dc00abefd1463276
https://github.com/spall edited https://github.com/llvm/llvm-project/pull/119820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jmorse wrote:
> Ah, fair enough, because the subprogram will contian a list of these local
> types, then the local type's scope will be a (potentially series of) lexical
> scope - so the lexical scopes are preserved?
That's certainly the outcome that the original patch series is aiming for --
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Tom Stellard (tstellar)
Changes
This change removes the need to call the clang-bolt target in order to apply
bolt optimizations to clang. Now running `ninja clang` will build a clang with
bolt optimizations, and `ninja check-clang` and `
@@ -1024,12 +1024,14 @@ void EmitAssemblyHelper::RunOptimizationPipeline(
FPM.addPass(BoundsCheckingPass());
});
-if (LangOpts.Sanitize.has(SanitizerKind::Realtime))
+if (LangOpts.Sanitize.has(SanitizerKind::Realtime)) {
vitalybuk
Author: erichkeane
Date: 2024-12-13T08:11:28-08:00
New Revision: 331f3cc94b3c66eebf5ec462a8f1ee0d7704dd26
URL:
https://github.com/llvm/llvm-project/commit/331f3cc94b3c66eebf5ec462a8f1ee0d7704dd26
DIFF:
https://github.com/llvm/llvm-project/commit/331f3cc94b3c66eebf5ec462a8f1ee0d7704dd26.diff
LO
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r
ea6e13586ce22291e9e7a4e382f6b2409b406da9...dd1f6807904691586c715d447fff54915a46c751
clang
Author: erichkeane
Date: 2024-12-13T06:23:05-08:00
New Revision: 7a3504a133437525f3e56f5811e313e4695f932f
URL:
https://github.com/llvm/llvm-project/commit/7a3504a133437525f3e56f5811e313e4695f932f
DIFF:
https://github.com/llvm/llvm-project/commit/7a3504a133437525f3e56f5811e313e4695f932f.diff
LO
https://github.com/jthackray edited
https://github.com/llvm/llvm-project/pull/119845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jthackray edited
https://github.com/llvm/llvm-project/pull/119845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-backend-risc-v
Author: Djordje Todorovic (djtodoro)
Changes
The P8700 is a high-performance processor from MIPS designed to meet the
demands of modern workloads, offering exceptional scalability and efficiency.
It builds on MIPS's established architect
https://github.com/djtodoro created
https://github.com/llvm/llvm-project/pull/119882
The P8700 is a high-performance processor from MIPS designed to meet the
demands of modern workloads, offering exceptional scalability and efficiency.
It builds on MIPS's established architectural strengths wh
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 473e2518e850598feae62916ebef4b4dbc88a0ee
a089ea0865504e39fd93320504c6572c04be2b19 --e
pawosm-arm wrote:
> This should fix https://lab.llvm.org/buildbot/#/builders/190/builds/11300
>
> I am compiling clang locally to verify that there would be no other problems
> with the test on macOS.
>
> > I suppose this is the reason check-clang fails today.
>
> Are there other test failure
dyung wrote:
I'm going to bring out Windows buildbot back online that was failing so that
when you do submit the revert, the bot should go back to green. I am looking
into this and will get back to you on the original bug when I find something.
https://github.com/llvm/llvm-project/pull/119638
NagyDonat wrote:
Thanks for the review, I'll fix the minor remarks soon.
> I wonder how you found out that loop widening may conflict with this
> heuristic, were any tests broken that raised your awareness?
Yes, some (IIRC three) testcases fail in `loop-widening.c`.
> I have one concern with
https://github.com/dyung approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/119638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: erichkeane
Date: 2024-12-13T07:31:18-08:00
New Revision: b2b1eec2b249698337d90a77c000340f0248c9cd
URL:
https://github.com/llvm/llvm-project/commit/b2b1eec2b249698337d90a77c000340f0248c9cd
DIFF:
https://github.com/llvm/llvm-project/commit/b2b1eec2b249698337d90a77c000340f0248c9cd.diff
LO
carlocab wrote:
> > I don't quite understand why the failing tests are caused to fail when
> > `CLANG_USE_XCSELECT` is enabled. I'll have to put more time into
> > investigating them -- I consider this another blocker for enabling this
> > feature more widely.
>
> I think the issue is that th
carlocab wrote:
> Maybe the fix is to always _ignore_ config files in clang-cl mode
I'd be fine with doing this too -- I just wasn't aware that clang-cl did not
support config files (since this fact doesn't seem to be documented anywhere,
unless I missed it).
https://github.com/llvm/llvm-proj
https://github.com/yuxuanchen1997 created
https://github.com/llvm/llvm-project/pull/119903
https://github.com/llvm/llvm-project/commit/30ad53b92cec0cff9679d559edcc5b933312ba0c
introduced a new test that includes from the system include path
without honoring environment variables that may prov
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Yuxuan Chen (yuxuanchen1997)
Changes
https://github.com/llvm/llvm-project/commit/30ad53b92cec0cff9679d559edcc5b933312ba0c
introduced a new test that includes from the system include
path without honoring environment variables tha
https://github.com/cachemeifyoucan edited
https://github.com/llvm/llvm-project/pull/119670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,290 @@
+//===-- RISCVSchedMIPSP8700.td - MIPS RISC-V Processor -*- tablegen
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/cachemeifyoucan commented:
Let's investigate to see all those test failed (many of them have versioned
deployment target).
Maybe it is because the `darwin` legacy OS in the triple? Maybe don't use
`xcselect` when it is darwin since the modern spelling should `macOS` family?
https://github.com/cjappl created
https://github.com/llvm/llvm-project/pull/119904
This seems to pass tests and behaves as expected.
As suggested by @vitalybuka on #118989
>From 8cfcf0461739e45716be1b3ed6700b5712b7801e Mon Sep 17 00:00:00 2001
From: Chris Apple
Date: Thu, 12 Dec 2024 10:37:1
@@ -1,3 +1,6 @@
+// XFAIL: xcselect
cachemeifyoucan wrote:
I don't feel XFAIL is correct to use here in general. It is possible to have a
different host SDK and the test will actually pass, right?
https://github.com/llvm/llvm-project/pull/119670
___
@@ -0,0 +1,290 @@
+//===-- RISCVSchedMIPSP8700.td - MIPS RISC-V Processor -*- tablegen
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,290 @@
+//===-- RISCVSchedMIPSP8700.td - MIPS RISC-V Processor -*- tablegen
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Chris Apple (cjappl)
Changes
This seems to pass tests and behaves as expected.
As suggested by @vitalybuka on #118989
---
Full diff: https://github.com/llvm/llvm-project/pull/119904.diff
1 Files Affected:
- (modified) clang/li
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Chris Apple (cjappl)
Changes
This seems to pass tests and behaves as expected.
As suggested by @vitalybuka on #118989
---
Full diff: https://github.com/llvm/llvm-project/pull/119904.diff
1 Files Affected:
- (modified) clang/lib/CodeGe
kpdev wrote:
Hm... No, it should work. @phuang May I kindly ask you to take a look at this
issue? http://45.33.8.238/linux/155432/step_6.txt
https://github.com/llvm/llvm-project/pull/118192
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
Author: erichkeane
Date: 2024-12-13T09:24:20-08:00
New Revision: 6d69d18437adc79ada8fbc852b3ffb4d797cebb4
URL:
https://github.com/llvm/llvm-project/commit/6d69d18437adc79ada8fbc852b3ffb4d797cebb4
DIFF:
https://github.com/llvm/llvm-project/commit/6d69d18437adc79ada8fbc852b3ffb4d797cebb4.diff
LO
https://github.com/fmayer approved this pull request.
https://github.com/llvm/llvm-project/pull/119904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/topperc approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/119823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shiltian edited
https://github.com/llvm/llvm-project/pull/119261
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1270,77 +1270,21 @@ exit:
; MODULE: attributes #[[ATTR1:[0-9]+]] = { convergent nocallback nounwind }
; MODULE: attributes #[[ATTR2:[0-9]+]] = { convergent nocallback nofree
nounwind willreturn }
; MODULE: attributes #[[ATTR3:[0-9]+]] = { nocallback nofree nosync nounwind
@@ -868,8 +868,54 @@ static Expr *constructTypedBufferConstraintExpr(Sema &S,
SourceLocation NameLoc,
return TypedResExpr;
}
-static ConceptDecl *constructTypedBufferConceptDecl(Sema &S,
-NamespaceDecl *NSD) {
+static Expr
@@ -0,0 +1,20 @@
+// REQUIRES: host-supports-jit, x86_64-linux
+
+// RUN: rm -rf %t
+// RUN: mkdir -p %t
+//
+// RUN: split-file %s %t
+//
+// RUN: %clang++ -std=c++20 -fPIC -c %t/vec.cpp -o %t/vec.o
+// RUN: %clang++ -shared %t/vec.o -o %t/vec.so
yuxuanchen1997 w
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/119643
>From cbcdcd37ec82e7bbb5fdd1cf83b093778d4fcf9f Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Wed, 11 Dec 2024 17:02:02 -0800
Subject: [PATCH 1/5] add concepts for raw buffers
---
clang/lib/Sema/HLSLExte
https://github.com/joaosaffran updated
https://github.com/llvm/llvm-project/pull/116331
>From ae719102cdafe101b3d718a144ed2f3488ecd44f Mon Sep 17 00:00:00 2001
From: Joao Saffran
Date: Fri, 25 Oct 2024 17:48:41 +
Subject: [PATCH 01/17] adding comments
---
clang/include/clang/Basic/Attr.td
@@ -20,4 +20,7 @@ void vla(int n, ...)
__builtin_va_list ap;
void *p;
p = __builtin_va_arg(ap, typeof (int (*)[++n])); // CHECK: add nsw i32
{{.*}}, 1
+ // Don't crash on some undefined behaviors.
+ p = __builtin_va_arg(ap, typeof (int [++n])); // expected-warning{{sec
@@ -6121,6 +6121,8 @@ RValue CodeGenFunction::EmitVAArg(VAArgExpr *VE, Address
&VAListAddr,
VAListAddr = VE->isMicrosoftABI() ? EmitMSVAListRef(VE->getSubExpr())
: EmitVAListRef(VE->getSubExpr());
QualType Ty = VE->getType();
+ if (Ty->
@@ -16538,6 +16538,13 @@ ExprResult Sema::BuildVAArgExpr(SourceLocation
BuiltinLoc,
<< TInfo->getTypeLoc().getSourceRange();
}
+if (TInfo->getType()->isVariableArrayType()) {
efriedma-quic wrote:
This should check for any array type; the issu
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Ryosuke Niwa (rniwa)
Changes
In WebKit, we often capture this as Ref or RefPtr in addition to this itself so
that the object lives as long as a capturing lambda stays alive.
Detect this pattern and treat it as safe. This PR also makes the
https://github.com/rniwa created
https://github.com/llvm/llvm-project/pull/119932
In WebKit, we often capture this as Ref or RefPtr in addition to this itself so
that the object lives as long as a capturing lambda stays alive.
Detect this pattern and treat it as safe. This PR also makes the ch
@@ -238,18 +239,13 @@ void Sema::inferLifetimeBoundAttribute(FunctionDecl *FD) {
default:
break;
}
-return;
higher-performance wrote:
Done.
https://github.com/llvm/llvm-project/pull/107627
___
cfe-
@@ -3250,26 +3285,17 @@ static void mergeParamDeclAttributes(ParmVarDecl
*newDecl,
diag::note_carries_dependency_missing_first_decl) << 1/*Param*/;
}
- if (!oldDecl->hasAttrs())
-return;
-
- bool foundAny = newDecl->hasAttrs();
-
- // Ensure that any movin
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/119842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -10,6 +10,7 @@ See also:
:maxdepth: 1
The list of clang-tidy checks
+ The list of clang-tidy global options
Clang-tidy IDE/Editor Integrations
Getting Involved
External Clang-Tidy Examples
HerrCai0907 wrote:
I think the root cause
HerrCai0907 wrote:
This PR is not in the correct way. see
https://discourse.llvm.org/t/rfc-global-option-rules-for-clang-tidy/83647
https://github.com/llvm/llvm-project/pull/119842
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Congcong Cai (HerrCai0907)
Changes
Uppercase each word in title and toctree
_Originally posted by @nicovank in
https://github.com/llvm/llvm-project/pull/119842#discussion_r1884559775_.
---
Full diff: https://github.com/llvm/
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/119938
Uppercase each word in title and toctree
_Originally posted by @nicovank in
https://github.com/llvm/llvm-project/pull/119842#discussion_r1884559775_.
>From 16ad345cbb84f4d58a0d2c64734d92de9e4efb56 Mon Sep
nico wrote:
If all other bots are happy, then I'm doing something wrong probably. If you
don't mind reverting, it'd be nice since then I can catch other, actual
problems, with the bot, but it's not a requirement.
https://github.com/llvm/llvm-project/pull/118192
@@ -3250,26 +3285,17 @@ static void mergeParamDeclAttributes(ParmVarDecl
*newDecl,
diag::note_carries_dependency_missing_first_decl) << 1/*Param*/;
}
- if (!oldDecl->hasAttrs())
-return;
-
- bool foundAny = newDecl->hasAttrs();
-
- // Ensure that any movin
https://github.com/HazardyKnusperkeks edited
https://github.com/llvm/llvm-project/pull/108332
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1169,6 +1181,18 @@ template <> struct MappingTraits {
IO.mapOptional("WhitespaceSensitiveMacros",
Style.WhitespaceSensitiveMacros);
+// If AlignAfterOpenBracket was specified but AlignAfterOpenBracketBreak
+// was not, initialize the latter f
@@ -1169,6 +1181,18 @@ template <> struct MappingTraits {
IO.mapOptional("WhitespaceSensitiveMacros",
Style.WhitespaceSensitiveMacros);
+// If AlignAfterOpenBracket was specified but AlignAfterOpenBracketBreak
+// was not, initialize the latter f
@@ -811,10 +816,11 @@ void
ContinuationIndenter::addTokenOnCurrentLine(LineState &State, bool DryRun,
if (!Tok.Previous)
return true;
if (Tok.Previous->isIf())
- return Style.AlignAfterOpenBracket == FormatStyle::BAS_AlwaysBreak;
-return !Tok.Previous->i
@@ -1452,6 +1476,7 @@ FormatStyle getLLVMStyle(FormatStyle::LanguageKind
Language) {
FormatStyle LLVMStyle;
LLVMStyle.AccessModifierOffset = -2;
LLVMStyle.AlignAfterOpenBracket = FormatStyle::BAS_Align;
+ LLVMStyle.AlignAfterOpenBracketBreak = {};
Hazar
https://github.com/HazardyKnusperkeks commented:
I don't think this is the way to go, or at least not with this name.
How about going the `Custom` way?
https://github.com/llvm/llvm-project/pull/108332
___
cfe-commits mailing list
cfe-commits@lists.llv
https://github.com/higher-performance updated
https://github.com/llvm/llvm-project/pull/107627
>From 3764d3e1062c6b748cea1faa9e4bd9628a1a5dea Mon Sep 17 00:00:00 2001
From: higher-performance
Date: Fri, 6 Sep 2024 14:16:15 -0400
Subject: [PATCH 1/3] Propagate lifetimebound from formal parameter
yushanwei wrote:
It's just a format conversion issue,not up to the level of backend.
https://github.com/llvm/llvm-project/pull/109320
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3227,6 +3227,41 @@ void Sema::mergeDeclAttributes(NamedDecl *New, Decl *Old,
if (!foundAny) New->dropAttrs();
}
+template
+static unsigned propagateAttribute(ParmVarDecl *toDecl,
higher-performance wrote:
Done.
https://github.com/llvm/llvm-project/pul
@@ -499,6 +499,7 @@ static bool isNormalAssignmentOperator(const FunctionDecl
*FD) {
}
bool implicitObjectParamIsLifetimeBound(const FunctionDecl *FD) {
+ FD = FD->getMostRecentDecl();
higher-performance wrote:
Done.
https://github.com/llvm/llvm-project/pu
@@ -1208,6 +1208,21 @@ struct FormatStyle {
/// \version 3.7
bool BinPackArguments;
+ /// If ``BinPackArguments`` is ``false`` this option can override it if
+ /// ``true`` when 20 or more items are in a braced initializer list.
HazardyKnusperkeks wrote:
https://github.com/HazardyKnusperkeks commented:
I think it should be merges with `BinPackArguments` to get an enum
* Never
* TwentyOrAbove (name is debatable)
* Always
* (Leave?)
https://github.com/llvm/llvm-project/pull/112482
___
cfe-commits mailing
https://github.com/HazardyKnusperkeks edited
https://github.com/llvm/llvm-project/pull/112482
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3227,6 +3227,41 @@ void Sema::mergeDeclAttributes(NamedDecl *New, Decl *Old,
if (!foundAny) New->dropAttrs();
}
+template
+static unsigned propagateAttribute(ParmVarDecl *toDecl,
higher-performance wrote:
Done.
https://github.com/llvm/llvm-project/pul
@@ -43,8 +43,8 @@
// RUN: %clang -target x86_64-apple-macos10.13 -mlinker-version=520 \
// RUN: -### %t.o 2>&1 \
-// RUN: | FileCheck --check-prefix=NOSDK %s
+// RUN: | FileCheck --check-prefix=INFERRED-SDK %s
carlocab wrote:
I think it does provide som
https://github.com/rniwa updated
https://github.com/llvm/llvm-project/pull/119932
>From 5c032267f263fb6b7f10d25745d14e63b2f7af59 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Fri, 13 Dec 2024 14:34:39 -0800
Subject: [PATCH 1/2] [webkit.UncountedLambdaCapturesChecker] Detect
protectedThis p
301 - 400 of 404 matches
Mail list logo