[clang] [HIP] Always add -fnative-half-arguments-and-returns cmdline option. (PR #113335)

2024-10-22 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu approved this pull request. https://github.com/llvm/llvm-project/pull/113335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8bbd079 - [clang] Allocate `Module` instances in `BumpPtrAllocator` (#112795)

2024-10-22 Thread via cfe-commits
Author: Jan Svoboda Date: 2024-10-22T08:57:33-07:00 New Revision: 8bbd0797d4b8aa1d993f587eb2dfd9a89df1f406 URL: https://github.com/llvm/llvm-project/commit/8bbd0797d4b8aa1d993f587eb2dfd9a89df1f406 DIFF: https://github.com/llvm/llvm-project/commit/8bbd0797d4b8aa1d993f587eb2dfd9a89df1f406.diff L

[clang] [llvm] [mlir] [OpenMP][OMPIRBuilder] Error propagation across callbacks (PR #112533)

2024-10-22 Thread Sergio Afonso via cfe-commits
@@ -2331,8 +2332,10 @@ void CGOpenMPRuntime::emitBarrierCall(CodeGenFunction &CGF, SourceLocation Loc, auto *OMPRegionInfo = dyn_cast_or_null(CGF.CapturedStmtInfo); if (CGF.CGM.getLangOpts().OpenMPIRBuilder) { -CGF.Builder.restoreIP(OMPBuilder.createBarrier( -

[clang] [clang] constexpr built-in fma function. (PR #113020)

2024-10-22 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/113020 >From 93c625ad60fc834e72df667addc6eec83247fc8c Mon Sep 17 00:00:00 2001 From: c8ef Date: Sat, 19 Oct 2024 03:45:17 + Subject: [PATCH 1/3] constexpr fma --- clang/docs/ReleaseNotes.rst | 1 +

[clang] [clang][modules] Timestamp PCM files when writing (PR #112452)

2024-10-22 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir approved this pull request. https://github.com/llvm/llvm-project/pull/112452 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Respect the [[clang::unsafe_buffer_usage]] attribute for field and constructor initializers (PR #91991)

2024-10-22 Thread Dana Jansens via cfe-commits
danakj wrote: Sorry I just haven't gotten back to making the fixes yet. If someone else wants to apply them and land it I won't be upset, otherwise I will get to this eventually.. https://github.com/llvm/llvm-project/pull/91991 ___ cfe-commits mailin

[clang] [llvm] [ARM] Save floating point registers and status registers with save_fp function attribute (PR #89654)

2024-10-22 Thread Benson Chu via cfe-commits
https://github.com/pestctrl updated https://github.com/llvm/llvm-project/pull/89654 >From c95cabceac9daa7fe927127ec57d9b31232941fe Mon Sep 17 00:00:00 2001 From: Jake Vossen Date: Wed, 30 Jun 2021 15:13:13 -0500 Subject: [PATCH 1/3] [ARM] Save floating point registers with save_fp function att

[clang] [llvm] Define CLANG_ABI and LLVM_ABI for z/OS (PR #113333)

2024-10-22 Thread via cfe-commits
https://github.com/muiez created https://github.com/llvm/llvm-project/pull/11 This patch fixes the build failure seen on z/OS: ``` llvm/clang/include/clang/ASTMatchers/ASTMatchers.h:7212:1: error: unknown type name 'CLANG_ABI' ``` >From dca5899894f81e70ba3a5c990936ac3316256fc9 Mon Sep 17

[clang] [HIP] Always add -fnative-half-arguments-and-returns cmdline option. (PR #113335)

2024-10-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Christudasan Devadasan (cdevadas) Changes This command-line option is now required while building the HIP applications (mainly for the host side) after we enabled __fp16 args and return values with patches D133885 & D145345. --- Full diff:

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-10-22 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: > The amount of churn is already pretty high -- please make sure the original > commit, fixes, and reverts get added to > https://github.com/llvm/llvm-project/blob/main/.git-blame-ignore-revs. At the > end of the day, we have a number of tests and files which are sensitive to

[clang] [PS5][Driver] Pass default -z options to PS5 linker (PR #113162)

2024-10-22 Thread Paul T Robinson via cfe-commits
@@ -240,11 +242,32 @@ void tools::PS5cpu::Linker::ConstructJob(Compilation &C, const JobAction &JA, CmdArgs.push_back( Args.MakeArgString("--sysroot=" + TC.getSDKLibraryRootDir())); - // Default to PIE for non-static executables. - const bool PIE = - !Args.hasA

[clang] [llvm] [SanitizerCoverage] Add gated tracing callbacks support to trace-cmp (PR #113227)

2024-10-22 Thread Vitaly Buka via cfe-commits
@@ -816,12 +821,30 @@ Value *ModuleSanitizerCoverage::CreateFunctionLocalGateCmp(IRBuilder<> &IRB) { return Cmp; } +Instruction *ModuleSanitizerCoverage::CreateGateBranch(Function &F, vitalybuka wrote: It would be nice to have a separate NFC patch for extr

[clang] [clang-format] Fix working -assume-filename with .clang-format-ignore (PR #113100)

2024-10-22 Thread via cfe-commits
kakkoko wrote: > I get what you are doing here, simply passing the input to the output even if > we've said ignore the file.. Its not that I don't think this is ok I'm just > wondering why the fix is here and not in the VS Code extension. Sorry. This was my mistake. I had misconfigured some se

[clang] [clang-format] Fix working -assume-filename with .clang-format-ignore (PR #113100)

2024-10-22 Thread via cfe-commits
https://github.com/kakkoko updated https://github.com/llvm/llvm-project/pull/113100 >From 07ac17e531315126c932b130963798a296736736 Mon Sep 17 00:00:00 2001 From: kakkoko Date: Mon, 21 Oct 2024 03:48:13 +0900 Subject: [PATCH] [clang-format] Fix working -assume-filename with .clang-format-ignore

[clang] [llvm] [HLSL] implement elementwise firstbithigh hlsl builtin (PR #111082)

2024-10-22 Thread Farzon Lotfi via cfe-commits
@@ -808,6 +835,20 @@ bool SPIRVInstructionSelector::selectExtInst(Register ResVReg, return false; } +bool SPIRVInstructionSelector::selectNAryOpWithSrcs(Register ResVReg, +const SPIRVType *ResType, +

[clang] [llvm] [llvm] Support llvm::Any across shared libraries on windows (PR #108051)

2024-10-22 Thread Thomas Fransham via cfe-commits
fsfod wrote: > > @ymand, is your concern resolved? > > Sorry, it isn't -- a) we still need comments with at least minimal > explanation and b) I'm not sure why the definition is now in > TypeErasedDataflowAnalysis.cpp -- is this because we lack NoopAnalysis.cpp? > If so, why is TypeErasedData

[clang] [llvm] [HLSL] implement elementwise firstbithigh hlsl builtin (PR #111082)

2024-10-22 Thread Farzon Lotfi via cfe-commits
@@ -2547,6 +2588,10 @@ bool SPIRVInstructionSelector::selectIntrinsic(Register ResVReg, return selectExtInst(ResVReg, ResType, I, CL::rsqrt, GL::InverseSqrt); case Intrinsic::spv_sign: return selectSign(ResVReg, ResType, I); + case Intrinsic::spv_firstbituhigh: // T

[clang] [llvm] [HLSL] implement elementwise firstbithigh hlsl builtin (PR #111082)

2024-10-22 Thread Farzon Lotfi via cfe-commits
@@ -2547,6 +2588,10 @@ bool SPIRVInstructionSelector::selectIntrinsic(Register ResVReg, return selectExtInst(ResVReg, ResType, I, CL::rsqrt, GL::InverseSqrt); case Intrinsic::spv_sign: return selectSign(ResVReg, ResType, I); + case Intrinsic::spv_firstbituhigh: // T

[clang] [llvm] [ci] Write test results to unique file names (PR #113160)

2024-10-22 Thread Vitaly Buka via cfe-commits
@@ -15,3 +15,5 @@ documentation setup. If you are writing a package for LLVM, see docs/Packaging.rst for our suggestions. + +Test line. vitalybuka wrote: Why thus change? https://github.com/llvm/llvm-project/pull/113160 __

[clang] [llvm] [ci] Write test results to unique file names (PR #113160)

2024-10-22 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/113160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [SYCL] The sycl_kernel_entry_point attribute. (PR #111389)

2024-10-22 Thread Tom Honermann via cfe-commits
@@ -14296,6 +14296,30 @@ void ASTContext::getFunctionFeatureMap(llvm::StringMap &FeatureMap, } } +static SYCLKernelInfo BuildSYCLKernelInfo(ASTContext &Context, tahonermann wrote: Oops, yes. It will be needed in future PRs, but should be added then. I'll

[clang] [llvm] [SanitizerCoverage] Add gated tracing callbacks support to trace-cmp (PR #113227)

2024-10-22 Thread via cfe-commits
https://github.com/thetruestblue updated https://github.com/llvm/llvm-project/pull/113227 >From 53b316d74683064f2db88ec401f6c3018ee6896a Mon Sep 17 00:00:00 2001 From: thetruestblue <92476612+thetruestb...@users.noreply.github.com> Date: Mon, 21 Oct 2024 11:06:02 -0700 Subject: [PATCH] [Sanitize

[clang] [llvm] [HLSL] Re-implement countbits with the correct return type (PR #113189)

2024-10-22 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/113189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Relax __builtin_amdgcn_update_dpp sema check (PR #113341)

2024-10-22 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec created https://github.com/llvm/llvm-project/pull/113341 Recent change applied too strict check for old and src operands match. These shall be compatible, but not necessarily exactly the same. >From 01e8c4224a1a0b8e1067c087f3a5e1283566f80a Mon Sep 17 00:00:00 2001 F

[clang] [AMDGPU] Relax __builtin_amdgcn_update_dpp sema check (PR #113341)

2024-10-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Stanislav Mekhanoshin (rampitec) Changes Recent change applied too strict check for old and src operands match. These shall be compatible, but not necessarily exactly the same. --- Full diff: https://github.com/llvm/llvm-project/pull/1133

[clang] [llvm] [HLSL] implement elementwise firstbithigh hlsl builtin (PR #111082)

2024-10-22 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,153 @@ +// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \ +// RUN: dxil-pc-shadermodel6.3-library %s -fnative-half-type \ +// RUN: -emit-llvm -disable-llvm-passes -o - | FileCheck %s -DTARGET=dx +// RUN: %clang_cc1 -finclude-default-header -x hlsl -tripl

[clang] [HLSL] get inout/out ABI for array parameters working (PR #111047)

2024-10-22 Thread Sarah Spall via cfe-commits
@@ -4690,8 +4690,9 @@ void CodeGenFunction::EmitCallArg(CallArgList &args, const Expr *E, return emitWritebackArg(*this, args, CRE); } - assert(type->isReferenceType() == E->isGLValue() && - "reference binding to unmaterialized r-value!"); + assert(type->isArr

[clang] [llvm] [HLSL] implement elementwise firstbithigh hlsl builtin (PR #111082)

2024-10-22 Thread Farzon Lotfi via cfe-commits
@@ -424,7 +424,7 @@ Register SPIRVGlobalRegistry::getOrCreateCompositeOrNull( LLT LLTy = LLT::scalar(64); Register SpvVecConst = CurMF->getRegInfo().createGenericVirtualRegister(LLTy); -CurMF->getRegInfo().setRegClass(SpvVecConst, &SPIRV::iIDRegClass); +

[clang] [clang-format] Fix working -assume-filename with .clang-format-ignore (PR #113100)

2024-10-22 Thread via cfe-commits
https://github.com/kakkoko updated https://github.com/llvm/llvm-project/pull/113100 >From 07ac17e531315126c932b130963798a296736736 Mon Sep 17 00:00:00 2001 From: kakkoko Date: Mon, 21 Oct 2024 03:48:13 +0900 Subject: [PATCH] [clang-format] Fix working -assume-filename with .clang-format-ignore

[clang] [clang] Improve diagnostic on [[nodiscard]] attribute (PR #112521)

2024-10-22 Thread Yihe Li via cfe-commits
@@ -416,6 +416,9 @@ Improvements to Clang's diagnostics name was a reserved name, which we improperly allowed to suppress the diagnostic. +- Clang now includes the return type of the function or constructor in the warning generated + when `[[nodiscard]]` is triggered by

[clang] clang-format: Add "AllowShortNamespacesOnASingleLine" option (PR #105597)

2024-10-22 Thread Galen Elias via cfe-commits
galenelias wrote: > I don't think we want to add any tests whose formats are questionable or > still under discussion. WDYT @mydeveloperday @HazardyKnusperkeks @rymiel ? Ok, that's fair. I have removed these tests. Thanks for the detailed response and context. https://github.com/llvm/llvm-p

[clang] [clang codegen] avoid to crash when emit init func for global variable with flexible array init (PR #113336)

2024-10-22 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/113336 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] prevent assertion failure in value-dependent initializer expressions (PR #112612)

2024-10-22 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @shafik could you take a look at the latest changes? thanks https://github.com/llvm/llvm-project/pull/112612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve diagnostic on [[nodiscard]] attribute (PR #112521)

2024-10-22 Thread Erich Keane via cfe-commits
erichkeane wrote: > I think this is fine the way it is, but I’ll leave it to @erichkeane to > approve this seeing as I proposed this approach here iirc. > > Side note: please try to avoid force-pushing in the future as that makes it > really annoying to try and figure out what has changed sinc

[clang] [Clang] prevent setting default lexical access specifier for missing primary declarations (PR #112424)

2024-10-22 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @shafik could you take a look at the latest changes? thanks https://github.com/llvm/llvm-project/pull/112424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] implement elementwise firstbithigh hlsl builtin (PR #111082)

2024-10-22 Thread Justin Bogner via cfe-commits
https://github.com/bogner edited https://github.com/llvm/llvm-project/pull/111082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] implement elementwise firstbithigh hlsl builtin (PR #111082)

2024-10-22 Thread Justin Bogner via cfe-commits
@@ -2626,6 +2671,148 @@ Register SPIRVInstructionSelector::buildPointerToResource( MIRBuilder); } +bool SPIRVInstructionSelector::selectFirstBitHigh16(Register ResVReg, +const

[clang] [llvm] [HLSL] implement elementwise firstbithigh hlsl builtin (PR #111082)

2024-10-22 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. Looks good to me once @farzonl's feedback is taken into account. https://github.com/llvm/llvm-project/pull/111082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] [llvm] [HLSL] implement elementwise firstbithigh hlsl builtin (PR #111082)

2024-10-22 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/111082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Support -mabi=vec-extabi and -mabi=vec-default on AIX (PR #113215)

2024-10-22 Thread Tom Eccles via cfe-commits
@@ -203,6 +203,30 @@ void Flang::AddAArch64TargetArgs(const ArgList &Args, } } +void Flang::AddPPCTargetArgs(const ArgList &Args, + ArgStringList &CmdArgs) const { + bool VecExtabi = false; + for (const Arg *A : Args.filtered(options::OPT_mabi_E

[clang] [clang codegen] avoid to crash when emit init func for global variable with flexible array init (PR #113336)

2024-10-22 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/113336 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] bd6c430 - [clang codegen] avoid to crash when emit init func for global variable with flexible array init (#113336)

2024-10-22 Thread via cfe-commits
Author: Congcong Cai Date: 2024-10-23T09:21:27+08:00 New Revision: bd6c430dcb52f3e4f86abc5f572126355fa39936 URL: https://github.com/llvm/llvm-project/commit/bd6c430dcb52f3e4f86abc5f572126355fa39936 DIFF: https://github.com/llvm/llvm-project/commit/bd6c430dcb52f3e4f86abc5f572126355fa39936.diff

[clang] [llvm] Define CLANG_ABI and LLVM_ABI for z/OS (PR #113333)

2024-10-22 Thread via cfe-commits
https://github.com/muiez updated https://github.com/llvm/llvm-project/pull/11 >From dca5899894f81e70ba3a5c990936ac3316256fc9 Mon Sep 17 00:00:00 2001 From: Muiez Date: Tue, 22 Oct 2024 11:23:55 -0400 Subject: [PATCH 1/2] [z/OS] Define CLANG_ABI --- clang/include/clang/Support/Compiler.h |

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-10-22 Thread via cfe-commits
ldrumm wrote: @AaronBallman you said this has happened before, but I don't see this in history. Can you link to the commit to which you're referring? I only see one other commit (9783f28cb) that touches the root `.gitattributes` https://github.com/llvm/llvm-project/pull/86318 _

[clang] [clang codegen] avoid to crash when emit init func for global variable with flexible array init (PR #113336)

2024-10-22 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/113336 Fixes: #113187 Avoid to create init function since clang does not support global variable with flexible array init. It will cause assertion failure later. >From ac8916ceba73bd223527fcb89c45ee4a8fdb9b5b Mon

[clang] [clang codegen] avoid to crash when emit init func for global variable with flexible array init (PR #113336)

2024-10-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-codegen Author: Congcong Cai (HerrCai0907) Changes Fixes: #113187 Avoid to create init function since clang does not support global variable with flexible array init. It will cause assertion failure later. --- Full dif

[clang] [clang-format] Fix working -assume-filename with .clang-format-ignore (PR #113100)

2024-10-22 Thread Owen Pan via cfe-commits
owenca wrote: Also, the main purpose of `-assume-filename` is to set the language for input from stdin, and IMO the pseudo filename should not be filtered out by any .clang-format-ignore file. https://github.com/llvm/llvm-project/pull/113100 ___ cfe-

[clang] [FlowSensitive] Allow to dump nested RecordStorageLocation (PR #112457)

2024-10-22 Thread Florian Mayer via cfe-commits
fmayer wrote: > I would suggest a brief comment explaining the choice not to filter. I'm not sure I understand. There wasn't a choice to filter before, there was just the (incorrect) assumption that we don't have nested `RecordStorageLocation`, leading to a crash. https://github.com/llvm/llvm

[clang] clang-format: Add "AllowShortNamespacesOnASingleLine" option (PR #105597)

2024-10-22 Thread Galen Elias via cfe-commits
https://github.com/galenelias updated https://github.com/llvm/llvm-project/pull/105597 >From 4118b7dde9adbee7b6aaf5d094d34cb6b64f6c77 Mon Sep 17 00:00:00 2001 From: Galen Elias Date: Wed, 21 Aug 2024 16:33:42 -0700 Subject: [PATCH 01/11] clang-format: Add "AllowShortNamespacesOnASingleLine" op

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

2024-10-22 Thread Justin Fargnoli via cfe-commits
justinfargnoli wrote: @vvereschaka, I agree. Note: The problem is that `IRNormalizer` produces a change that invalidates an analysis. It's not that IRNormalizer should declare that it's not preserving an analysis. I likely won't be able to fix this for a few days. @vvereschaka, should I re

[clang] [clang] Improve diagnostic on [[nodiscard]] attribute (PR #112521)

2024-10-22 Thread via cfe-commits
Sirraide wrote: > My opinion is that the function's attribute should take precedence since it > is "more specific". GCC/MSVC trunk agrees with me and prints Reason 2 in > warning, while Clang trunk prints Reason 1. ([Compiler > Explorer](https://godbolt.org/z/h3dYoe96c)). After this PR, Clang

[clang] Respect the [[clang::unsafe_buffer_usage]] attribute for field and constructor initializers (PR #91991)

2024-10-22 Thread Artem Dergachev via cfe-commits
haoNoQ wrote: No worries! I've just seen folks independently rediscover some of your work so I wanted them to see if they want to deduplicate the efforts. https://github.com/llvm/llvm-project/pull/91991 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] [llvm] [LLVM] Add IRNormalizer Pass (PR #68176)

2024-10-22 Thread Vladimir Vereschaka via cfe-commits
vvereschaka wrote: Reverting the changes is the optimal way in those cases. Yes, would you revert this PR. Thank you. https://github.com/llvm/llvm-project/pull/68176 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] [llvm] [LLVM][IR] Use splat syntax when printing Constant[Data]Vector. (PR #112548)

2024-10-22 Thread Paul Walker via cfe-commits
@@ -1687,6 +1692,46 @@ static void WriteConstantInternal(raw_ostream &Out, const Constant *CV, return; } + // When in the mode where Constant{Int,FP} do not support vector types the + // "splat(Ty val)" syntax is interpreted as a ConstantDataVector. Maintaining + //

[clang] [clang-format] Fix working -assume-filename with .clang-format-ignore (PR #113100)

2024-10-22 Thread via cfe-commits
kakkoko wrote: > Also, the main purpose of -assume-filename is to set the language for input > from stdin, and IMO the pseudo filename should not be filtered out by any > .clang-format-ignore file. It is also worth noting that if the `-style=file` option is specified, it will look for `.clang

[clang] [llvm] Define CLANG_ABI and LLVM_ABI for z/OS (PR #113333)

2024-10-22 Thread via cfe-commits
https://github.com/muiez closed https://github.com/llvm/llvm-project/pull/11 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9edb4f7 - Define CLANG_ABI and LLVM_ABI for z/OS (#113333)

2024-10-22 Thread via cfe-commits
Author: muiez Date: 2024-10-22T14:13:37-04:00 New Revision: 9edb4f74a606a7ba021accdb8896295bbaf18314 URL: https://github.com/llvm/llvm-project/commit/9edb4f74a606a7ba021accdb8896295bbaf18314 DIFF: https://github.com/llvm/llvm-project/commit/9edb4f74a606a7ba021accdb8896295bbaf18314.diff LOG: De

[clang] [Clang] fix range calculation for conditionals with throw expressions (PR #112081)

2024-10-22 Thread Oleksandr T. via cfe-commits
@@ -9827,6 +9827,9 @@ static IntRange GetExprRange(ASTContext &C, const Expr *E, unsigned MaxWidth, return IntRange(BitField->getBitWidthValue(C), BitField->getType()->isUnsignedIntegerOrEnumerationType()); + if (GetExprType(E)->isVoidType()) +ret

[clang] [Clang] fix range calculation for conditionals with throw expressions (PR #112081)

2024-10-22 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk deleted https://github.com/llvm/llvm-project/pull/112081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8536c2e - [clang][NFC] Move `concepts::createSubstDiagAt` from AST to Sema (#113294)

2024-10-22 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2024-10-22T22:18:25+04:00 New Revision: 8536c2e9a25681b6b0c740e708411f0ed3b12f11 URL: https://github.com/llvm/llvm-project/commit/8536c2e9a25681b6b0c740e708411f0ed3b12f11 DIFF: https://github.com/llvm/llvm-project/commit/8536c2e9a25681b6b0c740e708411f0ed3b12f11.

[clang] [clang][NFC] Move `concepts::createSubstDiagAt` from AST to Sema (PR #113294)

2024-10-22 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/113294 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] Replace usages of `DeclSpec::TQ` with `Qualifiers::TQ` (PR #113295)

2024-10-22 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/113295 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 1b0fcf1 - [clang-tidy][NFC] Replace usages of `DeclSpec::TQ` with `Qualifiers::TQ` (#113295)

2024-10-22 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2024-10-22T22:21:08+04:00 New Revision: 1b0fcf1e42e05611ec37aa7956988ae6317ad116 URL: https://github.com/llvm/llvm-project/commit/1b0fcf1e42e05611ec37aa7956988ae6317ad116 DIFF: https://github.com/llvm/llvm-project/commit/1b0fcf1e42e05611ec37aa7956988ae6317ad116.

[clang] [clang] Improve diagnostic on [[nodiscard]] attribute (PR #112521)

2024-10-22 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/112521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve diagnostic on [[nodiscard]] attribute (PR #112521)

2024-10-22 Thread via cfe-commits
https://github.com/Sirraide commented: I think this is fine the way it is, but I’ll leave it to @erichkeane to approve this seeing as I proposed this approach here iirc. Side note: please try to avoid force-pushing in the future as that makes it really annoying to try and figure out what has c

[clang] [clang] Improve diagnostic on [[nodiscard]] attribute (PR #112521)

2024-10-22 Thread via cfe-commits
@@ -416,6 +416,9 @@ Improvements to Clang's diagnostics name was a reserved name, which we improperly allowed to suppress the diagnostic. +- Clang now includes the return type of the function or constructor in the warning generated + when `[[nodiscard]]` is triggered by

[clang] [clang] Improve diagnostic on [[nodiscard]] attribute (PR #112521)

2024-10-22 Thread via cfe-commits
Sirraide wrote: > and figure out what has changed since the last review. Especially if the last review was a week ago ;Þ https://github.com/llvm/llvm-project/pull/112521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [llvm] [HLSL] Re-implement countbits with the correct return type (PR #113189)

2024-10-22 Thread Justin Bogner via cfe-commits
@@ -461,6 +461,67 @@ class OpLowerer { }); } + [[nodiscard]] bool lowerCtpopToCBits(Function &F) { +IRBuilder<> &IRB = OpBuilder.getIRB(); +Type *Int32Ty = IRB.getInt32Ty(); + +return replaceFunction(F, [&](CallInst *CI) -> Error { + IRB.SetInsertPoint(

[clang] [llvm] [HLSL] Re-implement countbits with the correct return type (PR #113189)

2024-10-22 Thread Justin Bogner via cfe-commits
@@ -553,11 +553,10 @@ def Rbits : DXILOp<30, unary> { let attributes = [Attributes]; } -def CBits : DXILOp<31, unary> { +def CBits : DXILOp<31, unaryBits> { bogner wrote: Can we rename this to CountBits while we're at it? It's best if the OpCode names h

[clang] [llvm] [HLSL] Re-implement countbits with the correct return type (PR #113189)

2024-10-22 Thread Justin Bogner via cfe-commits
@@ -461,6 +461,67 @@ class OpLowerer { }); } + [[nodiscard]] bool lowerCtpopToCBits(Function &F) { +IRBuilder<> &IRB = OpBuilder.getIRB(); +Type *Int32Ty = IRB.getInt32Ty(); + +return replaceFunction(F, [&](CallInst *CI) -> Error { + IRB.SetInsertPoint(

[clang] [llvm] [HLSL] Re-implement countbits with the correct return type (PR #113189)

2024-10-22 Thread Justin Bogner via cfe-commits
@@ -461,6 +461,67 @@ class OpLowerer { }); } + [[nodiscard]] bool lowerCtpopToCBits(Function &F) { +IRBuilder<> &IRB = OpBuilder.getIRB(); +Type *Int32Ty = IRB.getInt32Ty(); + +return replaceFunction(F, [&](CallInst *CI) -> Error { + IRB.SetInsertPoint(

[clang] [AMDGPU] Relax __builtin_amdgcn_update_dpp sema check (PR #113341)

2024-10-22 Thread via cfe-commits
https://github.com/ronlieb approved this pull request. https://github.com/llvm/llvm-project/pull/113341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve diagnostic on [[nodiscard]] attribute (PR #112521)

2024-10-22 Thread Yihe Li via cfe-commits
Mick235711 wrote: > Side note: please try to avoid force-pushing in the future as that makes it > really annoying to try and figure out what has changed since the last review. > We always squash on merge anyway, so a clean commit history on a pr is > irrelevant. Oh, sorry about that, I don't u

[clang] [clang] Improve diagnostic on [[nodiscard]] attribute (PR #112521)

2024-10-22 Thread Yihe Li via cfe-commits
https://github.com/Mick235711 updated https://github.com/llvm/llvm-project/pull/112521 >From 59f7dbdd8eed456b76e93f6260bf0e361242e9fd Mon Sep 17 00:00:00 2001 From: Yihe Li Date: Wed, 16 Oct 2024 18:53:04 +0800 Subject: [PATCH 1/2] [clang] Improve diagnostic on [[nodiscard]] attribute --- cla

[clang] [HIP] Always add -fnative-half-arguments-and-returns cmdline option. (PR #113335)

2024-10-22 Thread Christudasan Devadasan via cfe-commits
https://github.com/cdevadas created https://github.com/llvm/llvm-project/pull/113335 This command-line option is now required while building the HIP applications (mainly for the host side) after we enabled __fp16 args and return values with patches D133885 & D145345. >From e843f0f792b83aa7b545e

[clang] [HIP] Always add -fnative-half-arguments-and-returns cmdline option. (PR #113335)

2024-10-22 Thread Christudasan Devadasan via cfe-commits
cdevadas wrote: * **#113335** https://app.graphite.dev/github/pr/llvm/llvm-project/113335?utm_source=stack-comment-icon"; target="_blank">https://static.graphite.dev/graphite-32x32-black.png"; alt="Graphite" width="10px" height="10px"/> 👈 * `main` This stack of pull requests is managed by Grap

[clang] [HIP] Always add -fnative-half-arguments-and-returns cmdline option. (PR #113335)

2024-10-22 Thread Christudasan Devadasan via cfe-commits
cdevadas wrote: ### Merge activity * **Oct 22, 12:36 PM EDT**: A user started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/113335). https://github.com/llvm/llvm-project/pull/113335 __

[clang] 91fd1b4 - [HIP] Always add -fnative-half-arguments-and-returns cmdline option. (#113335)

2024-10-22 Thread via cfe-commits
Author: Christudasan Devadasan Date: 2024-10-22T22:07:35+05:30 New Revision: 91fd1b4f32206267f6b9ce0dc4977d62ef227151 URL: https://github.com/llvm/llvm-project/commit/91fd1b4f32206267f6b9ce0dc4977d62ef227151 DIFF: https://github.com/llvm/llvm-project/commit/91fd1b4f32206267f6b9ce0dc4977d62ef227

[clang] [HIP] Always add -fnative-half-arguments-and-returns cmdline option. (PR #113335)

2024-10-22 Thread Christudasan Devadasan via cfe-commits
https://github.com/cdevadas closed https://github.com/llvm/llvm-project/pull/113335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PS5][Driver] Pass default -z options to PS5 linker (PR #113162)

2024-10-22 Thread Paul T Robinson via cfe-commits
@@ -240,11 +242,32 @@ void tools::PS5cpu::Linker::ConstructJob(Compilation &C, const JobAction &JA, CmdArgs.push_back( Args.MakeArgString("--sysroot=" + TC.getSDKLibraryRootDir())); - // Default to PIE for non-static executables. - const bool PIE = - !Args.hasA

[clang] [llvm] [LLVM][IR] Use splat syntax when printing Constant[Data]Vector. (PR #112548)

2024-10-22 Thread Paul Walker via cfe-commits
paulwalker-arm wrote: FYI: I've separated the code changes into a separate (first) commit to aid review. https://github.com/llvm/llvm-project/pull/112548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [llvm] [LLVM][IR] Use splat syntax when printing Constant[Data]Vector. (PR #112548)

2024-10-22 Thread Paul Walker via cfe-commits
https://github.com/paulwalker-arm edited https://github.com/llvm/llvm-project/pull/112548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HIP] Don't use the OpenCLKernel CC when targeting AMDGCNSPIRV (PR #110447)

2024-10-22 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx closed https://github.com/llvm/llvm-project/pull/110447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2074de2 - [clang][HIP] Don't use the OpenCLKernel CC when targeting AMDGCNSPIRV (#110447)

2024-10-22 Thread via cfe-commits
Author: Alex Voicu Date: 2024-10-22T17:16:46+01:00 New Revision: 2074de252b59a82279c275a1c8e7a4be6e1101d8 URL: https://github.com/llvm/llvm-project/commit/2074de252b59a82279c275a1c8e7a4be6e1101d8 DIFF: https://github.com/llvm/llvm-project/commit/2074de252b59a82279c275a1c8e7a4be6e1101d8.diff LO

[clang] [Clang][Sema] Fix exception specification comparison for functions with different template depths (PR #111561)

2024-10-22 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/111561 >From d41114109ebfb98570152fe8fdc2854863f23397 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Tue, 8 Oct 2024 12:54:26 -0400 Subject: [PATCH 1/4] [Clang][Sema] Fix exception specification comparison

[clang] [compiler-rt] [libcxx] [llvm] [clang] Warn about memset/memcpy to NonTriviallyCopyable types (PR #111434)

2024-10-22 Thread Carlos Galvez via cfe-commits
@@ -102,7 +102,7 @@ struct __aliasing_iterator_wrapper { _LIBCPP_HIDE_FROM_ABI _Alias operator*() const _NOEXCEPT { _Alias __val; - __builtin_memcpy(&__val, std::__to_address(__base_), sizeof(value_type)); + __builtin_memcpy(&__val, static_cast(std::__to_ad

[clang] [TBAA] Extend pointer TBAA to pointers of non-builtin types. (PR #110569)

2024-10-22 Thread John McCall via cfe-commits
https://github.com/rjmccall approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/110569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] modified AST for SEI redemption project (PR #111705)

2024-10-22 Thread Nicholas Reimer via cfe-commits
@@ -11,6 +11,22 @@ // similar to RecursiveASTVisitor. // //===--===// +// +// Modifications to this file by SEI staff are copyright Carnegie Mellon +// University and contributed under the Apache License v2.0

[clang] [llvm] [LLVM][IR] Use splat syntax when printing Constant[Data]Vector. (PR #112548)

2024-10-22 Thread Paul Walker via cfe-commits
https://github.com/paulwalker-arm edited https://github.com/llvm/llvm-project/pull/112548 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Define CLANG_ABI and LLVM_ABI for z/OS (PR #113333)

2024-10-22 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6e535a9ac70fc0e69778f0d6c4568cb64a0e25db dca5899894f81e70ba3a5c990936ac3316256fc9 --e

[clang] [HIP] Always add -fnative-half-arguments-and-returns cmdline option. (PR #113335)

2024-10-22 Thread Christudasan Devadasan via cfe-commits
https://github.com/cdevadas ready_for_review https://github.com/llvm/llvm-project/pull/113335 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Allocate `Module` instances in `BumpPtrAllocator` (PR #112795)

2024-10-22 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 closed https://github.com/llvm/llvm-project/pull/112795 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Timestamp PCM files when writing (PR #112452)

2024-10-22 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 updated https://github.com/llvm/llvm-project/pull/112452 >From 6550eecf945d5a8537242646ef17b49b49eff859 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Tue, 15 Oct 2024 16:29:37 -0700 Subject: [PATCH 1/2] [clang][modules] Timestamp PCM files when writing Clang

[clang] [clang] Allocate `Module` instances in `BumpPtrAllocator` (PR #112795)

2024-10-22 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-m68k-linux-cross` running on `suse-gary-m68k-cross` while building `clang` at step 4 "build stage 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/27/builds/881 Here is the relevant piece of

[clang] [NFC] Move RegisterBuiltinMacro function into the Preprocessor class (PR #100142)

2024-10-22 Thread via cfe-commits
muiez wrote: Can I get a round of reviews please? https://github.com/llvm/llvm-project/pull/100142 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] implement elementwise firstbithigh hlsl builtin (PR #111082)

2024-10-22 Thread Farzon Lotfi via cfe-commits
@@ -2626,6 +2671,148 @@ Register SPIRVInstructionSelector::buildPointerToResource( MIRBuilder); } +bool SPIRVInstructionSelector::selectFirstBitHigh16(Register ResVReg, +const

[clang] [llvm] [SanitizerCoverage] Add gated tracing callbacks support to trace-cmp (PR #113227)

2024-10-22 Thread Vitaly Buka via cfe-commits
@@ -1013,19 +1051,10 @@ void ModuleSanitizerCoverage::InjectCoverageAtBlock(Function &F, BasicBlock &BB, ConstantInt::get(IntptrTy, Idx * 4)), PtrTy); if (Options.GatedCallbacks) { - if (!FunctionGateCmp) { -// Create this in the

[clang] [llvm] [HLSL] implement elementwise firstbithigh hlsl builtin (PR #111082)

2024-10-22 Thread Farzon Lotfi via cfe-commits
@@ -2626,6 +2671,148 @@ Register SPIRVInstructionSelector::buildPointerToResource( MIRBuilder); } +bool SPIRVInstructionSelector::selectFirstBitHigh16(Register ResVReg, +const

[clang] [llvm] [HLSL] implement elementwise firstbithigh hlsl builtin (PR #111082)

2024-10-22 Thread Farzon Lotfi via cfe-commits
@@ -28,6 +28,8 @@ bool DirectXTTIImpl::isTargetIntrinsicTriviallyScalarizable( switch (ID) { case Intrinsic::dx_frac: case Intrinsic::dx_rsqrt: + case Intrinsic::dx_firstbituhigh: + case Intrinsic::dx_firstbitshigh: farzonl wrote: you will want to reba

[clang] [llvm] [HLSL] implement elementwise firstbithigh hlsl builtin (PR #111082)

2024-10-22 Thread Farzon Lotfi via cfe-commits
farzonl wrote: This looks really good. I hade a few minor things and questions about either pulling things out of this pr and putting them into their own changes or future clean up to consolidate things. One more iteration and I'll be happy to approve. https://github.com/llvm/llvm-project/pull

<    1   2   3   4   5   >