https://github.com/Sirraide commented:
I think this is fine the way it is, but I’ll leave it to @erichkeane to approve this seeing as I proposed this approach here iirc. Side note: please try to avoid force-pushing in the future as that makes it really annoying to try and figure out what has changed since the last review. We always squash on merge anyway, so a clean commit history on a pr is irrelevant. https://github.com/llvm/llvm-project/pull/112521 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
