[clang] modified AST for SEI redemption project (PR #111705)

2024-10-17 Thread Aaron Ballman via cfe-commits
@@ -184,6 +206,18 @@ class JSONNodeDumper StringRef getCommentCommandName(unsigned CommandID) const; + /// SEI: simple cacher for addresses of nodes to reduce AaronBallman wrote: This comment should be rewritten and the function renamed. `cacheAddress()`

[clang] modified AST for SEI redemption project (PR #111705)

2024-10-17 Thread Aaron Ballman via cfe-commits
@@ -177,14 +193,34 @@ class ASTNodeTraverser if (!SQT.Quals.hasQualifiers()) return Visit(SQT.Ty); -getNodeDelegate().AddChild([=] { +// SEI: changed from default label to "qualTypeDetail" +getNodeDelegate().AddChild("qualTypeDetail", [this, T] { g

[clang] modified AST for SEI redemption project (PR #111705)

2024-10-17 Thread Aaron Ballman via cfe-commits
@@ -410,8 +447,17 @@ class ASTNodeTraverser Visit(T->getSizeExpr()); } void VisitVectorType(const VectorType *T) { Visit(T->getElementType()); } - void VisitFunctionType(const FunctionType *T) { Visit(T->getReturnType()); } + void VisitFunctionType(const FunctionType

[clang] modified AST for SEI redemption project (PR #111705)

2024-10-17 Thread Aaron Ballman via cfe-commits
@@ -132,6 +151,9 @@ class JSONNodeDumper StringRef LastLocFilename, LastLocPresumedFilename; unsigned LastLocLine, LastLocPresumedLine; + // SEI: caches addresses for QualType nodes that are duplicates + std::unordered_set AddressCache; AaronBallman wrot

[clang] modified AST for SEI redemption project (PR #111705)

2024-10-17 Thread Aaron Ballman via cfe-commits
@@ -410,8 +447,17 @@ class ASTNodeTraverser Visit(T->getSizeExpr()); } void VisitVectorType(const VectorType *T) { Visit(T->getElementType()); } - void VisitFunctionType(const FunctionType *T) { Visit(T->getReturnType()); } + void VisitFunctionType(const FunctionType

[clang] modified AST for SEI redemption project (PR #111705)

2024-10-17 Thread Aaron Ballman via cfe-commits
@@ -209,7 +245,8 @@ class ASTNodeTraverser } void Visit(const Attr *A) { -getNodeDelegate().AddChild([=] { +// SEI: renamed from default label AaronBallman wrote: ```suggestion ``` https://github.com/llvm/llvm-project/pull/111705

[clang] modified AST for SEI redemption project (PR #111705)

2024-10-17 Thread Aaron Ballman via cfe-commits
@@ -87,13 +100,44 @@ void JSONNodeDumper::Visit(const Type *T) { T->containsUnexpandedParameterPack()); attributeOnlyIfTrue("isImported", T->isFromAST()); InnerTypeVisitor::Visit(T); + // SEI AaronBallman wrote: ```suggestion ``` ht

[libcxx] [libcxxabi] [libunwind] [CMake] Handle multiple flags in ADDITIONAL_COMPILE_FLAGS properly (PR #112703)

2024-10-17 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[libcxx] [libcxxabi] [libunwind] [CMake] Handle multiple flags in ADDITIONAL_COMPILE_FLAGS properly (PR #112703)

2024-10-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libunwind Author: Stephanos Ioannidis (stephanosio) Changes When multiple space-separated compile flags are specified in an `ADDITIONAL_COMPILE_FLAGS` cache string, the resulting flags are enclosed by double quotes because `ADDITIONAL_COMPILE_FLAGS` is

[libcxx] [libcxxabi] [libunwind] [CMake] Handle multiple flags in ADDITIONAL_COMPILE_FLAGS properly (PR #112703)

2024-10-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-libcxx @llvm/pr-subscribers-libcxxabi Author: Stephanos Ioannidis (stephanosio) Changes When multiple space-separated compile flags are specified in an `ADDITIONAL_COMPILE_FLAGS` cache string, the resulting flags are enclosed by double quotes because `

[clang] 388d7f1 - Different info in docs in AST methods (#112190)

2024-10-17 Thread via cfe-commits
Author: Mikhnenko Sasha Date: 2024-10-17T08:44:45-04:00 New Revision: 388d7f144880dcd85ff31f06793304405a9f44b6 URL: https://github.com/llvm/llvm-project/commit/388d7f144880dcd85ff31f06793304405a9f44b6 DIFF: https://github.com/llvm/llvm-project/commit/388d7f144880dcd85ff31f06793304405a9f44b6.dif

[clang] Different info in docs in AST methods (PR #112190)

2024-10-17 Thread via cfe-commits
github-actions[bot] wrote: @4JustMe4 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build

[clang] Different info in docs in AST methods (PR #112190)

2024-10-17 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/112190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Different info in docs in AST methods (PR #112190)

2024-10-17 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/112190 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Improve solver (PR #112583)

2024-10-17 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/112583 >From 4bf74c7f9caf89b67e6001b601f70741c1a672cc Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Wed, 16 Oct 2024 15:52:31 +0200 Subject: [PATCH 1/7] [analyzer][Solver] Improve getSymVal and friends Instead o

[clang] [clang-format] Add RemoveEmptyLinesInUnwrappedLines option (PR #112325)

2024-10-17 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. nice! https://github.com/llvm/llvm-project/pull/112325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-include-cleaner] Fix -Wpessimizing-move warning introduced in 4cda28c1ada702a08f6960eb4c93919187c1d4d1 (PR #112684)

2024-10-17 Thread Byoungchan Lee via cfe-commits
https://github.com/bc-lee closed https://github.com/llvm/llvm-project/pull/112684 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Reject if constexpr in C (PR #112685)

2024-10-17 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/112685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Reject if constexpr in C (PR #112685)

2024-10-17 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > LGTM - I think we should backport that to 19 (so we don't need a changelog) Agreed https://github.com/llvm/llvm-project/pull/112685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [compiler-rt] [llvm] [FMV][AArch64] Unify features memtag and memtag2. (PR #112511)

2024-10-17 Thread via cfe-commits
Wilco1 wrote: There also isn't any demand to make it work in EL1 - almost all software runs in user space and kernels typically already have their own mechanisms to support different ISA variants. So I wouldn't call it a limitation - it's a high-level feature for average users by design, not k

[clang] [clang-format] Add basic support for C++/CLI (#27126) (PR #112689)

2024-10-17 Thread via cfe-commits
https://github.com/mydeveloperday commented: How would a user specify to use CLI? https://github.com/llvm/llvm-project/pull/112689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Reject if constexpr in C (PR #112685)

2024-10-17 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: *sobs while doing manual cherry-pick* https://github.com/llvm/llvm-project/pull/112685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] [docs] Replace _not_ in reserved-identifier.rst with *not* (PR #112162)

2024-10-17 Thread Nick Riasanovsky via cfe-commits
https://github.com/njriasan updated https://github.com/llvm/llvm-project/pull/112162 >From e5a70cb2f9d744716e376ec0939645a7b0365ead Mon Sep 17 00:00:00 2001 From: Nicholas Riasanovsky Date: Mon, 14 Oct 2024 01:42:39 -0400 Subject: [PATCH] Replace _not_ in reserved-identifier.rst from the clang-

[clang] [HLSL] Simplify debug check in ResourceBindings::addDeclBindingInfo (PR #112661)

2024-10-17 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp approved this pull request. https://github.com/llvm/llvm-project/pull/112661 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 51b4ada - clang/AMDGPU: Set noalias.addrspace metadata on atomicrmw (#102462)

2024-10-17 Thread via cfe-commits
Author: Matt Arsenault Date: 2024-10-17T17:10:45+04:00 New Revision: 51b4ada4588ecb3044b57c325a59aedcc19d7084 URL: https://github.com/llvm/llvm-project/commit/51b4ada4588ecb3044b57c325a59aedcc19d7084 DIFF: https://github.com/llvm/llvm-project/commit/51b4ada4588ecb3044b57c325a59aedcc19d7084.diff

[clang] clang/AMDGPU: Set noalias.addrspace metadata on atomicrmw (PR #102462)

2024-10-17 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm closed https://github.com/llvm/llvm-project/pull/102462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add basic support for C++/CLI (#27126) (PR #112689)

2024-10-17 Thread via cfe-commits
mydeveloperday wrote: My point was that mostly this change is about changing the call isPointerOrReference call, its an invasive change for little extra. Can you give me an example of what it was doing wrong (hence the github issue), My code base contains both c++,c# and (some) managed c++ an

[clang] [CLANG][AArch64]Add SVE tuple types for mfloat8_t (PR #112687)

2024-10-17 Thread via cfe-commits
https://github.com/CarolineConcatto updated https://github.com/llvm/llvm-project/pull/112687 >From 310e16c83e60ff64dadc27528da9b4e266d7db2e Mon Sep 17 00:00:00 2001 From: Caroline Concatto Date: Thu, 17 Oct 2024 10:01:17 + Subject: [PATCH 1/2] [CLANG][AArch64]Add SVE tuple types for mfloat8

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] Probe for -nostdlib++ and -nostdinc++ with the C compiler (PR #108357)

2024-10-17 Thread Martin Storsjö via cfe-commits
@@ -38,9 +38,13 @@ check_cxx_compiler_flag(-nolibc CXX_SUPPORTS_NOLIBC_FLAG) # required during compilation (which has the -nostdlib++ or -nodefaultlibs). libc is # required for the link to go through. We remove sanitizers from the # configuration checks to avoid spurious link

[clang] [llvm] [ARM] Fix -mno-omit-leaf-frame-pointer flag doesn't works on 32-bit ARM (PR #109628)

2024-10-17 Thread via cfe-commits
hstk30-hw wrote: LGTM, thx. https://github.com/llvm/llvm-project/pull/109628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 4a2bd78 - [ARM] Fix -mno-omit-leaf-frame-pointer flag doesn't works on 32-bit ARM (#109628)

2024-10-17 Thread via cfe-commits
Author: gxlayer Date: 2024-10-17T20:25:06+08:00 New Revision: 4a2bd78f5b0d0661c23dff9c4b93a393a49dbf9a URL: https://github.com/llvm/llvm-project/commit/4a2bd78f5b0d0661c23dff9c4b93a393a49dbf9a DIFF: https://github.com/llvm/llvm-project/commit/4a2bd78f5b0d0661c23dff9c4b93a393a49dbf9a.diff LOG:

[clang] [llvm] [ARM] Fix -mno-omit-leaf-frame-pointer flag doesn't works on 32-bit ARM (PR #109628)

2024-10-17 Thread via cfe-commits
https://github.com/hstk30-hw closed https://github.com/llvm/llvm-project/pull/109628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ARM] Fix -mno-omit-leaf-frame-pointer flag doesn't works on 32-bit ARM (PR #109628)

2024-10-17 Thread via cfe-commits
github-actions[bot] wrote: @guoxin049 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a buil

[clang] [llvm] [Coverage] Introduce "partial fold" on BranchRegion (PR #112694)

2024-10-17 Thread NAKAMURA Takumi via cfe-commits
https://github.com/chapuni created https://github.com/llvm/llvm-project/pull/112694 Currently both True/False counts were folded. It lost the information, "It is True or False before folding." It prevented recalling branch counts in merging template instantiations. In `llvm-cov`, a folded bra

[clang] [llvm] [Coverage] Introduce "partial fold" on BranchRegion (PR #112694)

2024-10-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-pgo Author: NAKAMURA Takumi (chapuni) Changes Currently both True/False counts were folded. It lost the information, "It is True or False before folding." It prevented recalling branch counts in merging template instantiations. In `llvm-cov`, a folded

[clang] [llvm] [Coverage] Introduce "partial fold" on BranchRegion (PR #112694)

2024-10-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: NAKAMURA Takumi (chapuni) Changes Currently both True/False counts were folded. It lost the information, "It is True or False before folding." It prevented recalling branch counts in merging template instantiations. In `llvm-cov`

[clang] [llvm] [LoongArch] [CodeGen] Add options for Clang to generate LoongArch-specific frecipe & frsqrte instructions (PR #109917)

2024-10-17 Thread Lu Weining via cfe-commits
https://github.com/SixWeining approved this pull request. https://github.com/llvm/llvm-project/pull/109917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Reject if constexpr in C (PR #112685)

2024-10-17 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon milestoned https://github.com/llvm/llvm-project/pull/112685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Reject if constexpr in C (PR #112685)

2024-10-17 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: /cherry-pick e21c80ac73a9da5c86c20dbce37c9227a17ab06a https://github.com/llvm/llvm-project/pull/112685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-10-17 Thread Yi Kong via cfe-commits
kongy wrote: Thanks for the clarification! https://github.com/llvm/llvm-project/pull/100692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Improve solver (PR #112583)

2024-10-17 Thread Donát Nagy via cfe-commits
@@ -2883,22 +2883,16 @@ const llvm::APSInt *RangeConstraintManager::getSymVal(ProgramStateRef St, const llvm::APSInt *RangeConstraintManager::getSymMinVal(ProgramStateRef St, SymbolRef Sym) const { - // TODO: Use `getR

[clang] [clang-format] Add basic support for C++/CLI (#27126) (PR #112689)

2024-10-17 Thread via cfe-commits
https://github.com/mydeveloperday requested changes to this pull request. This change needs tests, documentation changes and a git hub issue https://github.com/llvm/llvm-project/pull/112689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] f9d0789 - [PGO] Initialize GCOV Writeout and Reset Functions in the Runtime on AIX (#108570)

2024-10-17 Thread via cfe-commits
Author: Qiongsi Wu Date: 2024-10-17T09:32:10-04:00 New Revision: f9d07890640434a4be0e7f651dd295478598b36d URL: https://github.com/llvm/llvm-project/commit/f9d07890640434a4be0e7f651dd295478598b36d DIFF: https://github.com/llvm/llvm-project/commit/f9d07890640434a4be0e7f651dd295478598b36d.diff LO

[clang] [compiler-rt] [llvm] [PGO] Initialize GCOV Writeout and Reset Functions in the Runtime on AIX (PR #108570)

2024-10-17 Thread Qiongsi Wu via cfe-commits
https://github.com/qiongsiwu closed https://github.com/llvm/llvm-project/pull/108570 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [llvm] [PGO] Initialize GCOV Writeout and Reset Functions in the Runtime on AIX (PR #108570)

2024-10-17 Thread Qiongsi Wu via cfe-commits
qiongsiwu wrote: We prefer to keep the formatting in this particular file. I am merging this PR. https://github.com/llvm/llvm-project/pull/108570 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [Clang][ASTMatchers] Add visibility macros to variables declared by macros (PR #110206)

2024-10-17 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/110206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Inline Assembly: RVC constraint and N modifier (PR #112561)

2024-10-17 Thread Sam Elliott via cfe-commits
lenary wrote: It would be great to get more comments than just Craig, so I can be sure that there's wider consensus that adding this is good. https://github.com/llvm/llvm-project/pull/112561 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[clang] [clang] Fix C23 constexpr crashes (PR #112708)

2024-10-17 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon created https://github.com/llvm/llvm-project/pull/112708 Before using a constexpr variable that is not properly initialized check that it is valid. Fixes https://github.com/llvm/llvm-project/issues/109095 Fixes https://github.com/llvm/llvm-project/issues/112516 >

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-10-17 Thread via cfe-commits
ldrumm wrote: I've let this patch stew for long enough, and I think it's now time. The spurious test failures in files unchanged by this patch have gone away. After re-reading the discussion above I'm ready to merge these changes. There's been a good discussion, which helped me polish this a f

[clang] [clang] Fix C23 constexpr crashes (PR #112708)

2024-10-17 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon edited https://github.com/llvm/llvm-project/pull/112708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix C23 constexpr crashes (PR #112708)

2024-10-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mariya Podchishchaeva (Fznamznon) Changes Before using a constexpr variable that is not properly initialized check that it is valid. Fixes https://github.com/llvm/llvm-project/issues/109095 Fixes https://github.com/llvm/llvm-project/issu

[clang] [Clang][Sema] Fix exception specification comparison for functions with different template depths (PR #111561)

2024-10-17 Thread Krystian Stasiowski via cfe-commits
@@ -501,6 +519,89 @@ bool Sema::CheckEquivalentExceptionSpec( return Result; } +static const Expr *SubstituteExceptionSpecWithoutEvaluation( +Sema &S, const Sema::TemplateCompareNewDeclInfo &DeclInfo, +const Expr *ExceptionSpec) { + MultiLevelTemplateArgumentList ML

[clang] [llvm] [LLVM][MC][AArch64] Assembler support for Armv9.6-A memory systems extensions (PR #112341)

2024-10-17 Thread Nashe Mncube via cfe-commits
@@ -4660,6 +4746,21 @@ let Predicates = [HasLOR] in { def STLLRH0 : InstAlias<"stllrh\t$Rt, [$Rn, #0]", (STLLRH GPR32: $Rt, GPR64sp:$Rn)>; } +// v9.6-a Unprivileged load store operations +let Predicates = [HasLSUI] in { +defm LDTXRW : LoadUnprivilegedLSUI<0b10, GPR32, "l

[clang] [llvm] [LLVM][MC][AArch64] Assembler support for Armv9.6-A memory systems extensions (PR #112341)

2024-10-17 Thread Nashe Mncube via cfe-commits
@@ -4660,6 +4746,21 @@ let Predicates = [HasLOR] in { def STLLRH0 : InstAlias<"stllrh\t$Rt, [$Rn, #0]", (STLLRH GPR32: $Rt, GPR64sp:$Rn)>; } +// v9.6-a Unprivileged load store operations +let Predicates = [HasLSUI] in { +defm LDTXRW : LoadUnprivilegedLSUI<0b10, GPR32, "l

[clang] [clang-format] Add basic support for C++/CLI (#27126) (PR #112689)

2024-10-17 Thread Calum Robinson via cfe-commits
https://github.com/calumr created https://github.com/llvm/llvm-project/pull/112689 * This only looks for ^ as a pointer/reference token, which is the main issue when trying to format C++/CLI. Obviously there's more to C++/CLI than this minor change, but it's extremely useful to be able to cla

[clang] [llvm] [LLVM][MC][AArch64] Assembler support for Armv9.6-A memory systems extensions (PR #112341)

2024-10-17 Thread Nashe Mncube via cfe-commits
@@ -4660,6 +4746,21 @@ let Predicates = [HasLOR] in { def STLLRH0 : InstAlias<"stllrh\t$Rt, [$Rn, #0]", (STLLRH GPR32: $Rt, GPR64sp:$Rn)>; } +// v9.6-a Unprivileged load store operations +let Predicates = [HasLSUI] in { +defm LDTXRW : LoadUnprivilegedLSUI<0b10, GPR32, "l

[clang-tools-extra] 2954d1f - [include-cleaner] Fix -Wpessimizing-move in IncludeCleaner.cpp (NFC)

2024-10-17 Thread Jie Fu via cfe-commits
Author: Jie Fu Date: 2024-10-17T18:51:40+08:00 New Revision: 2954d1f7bc8fa77c51768855d9df98f5559a5c5e URL: https://github.com/llvm/llvm-project/commit/2954d1f7bc8fa77c51768855d9df98f5559a5c5e DIFF: https://github.com/llvm/llvm-project/commit/2954d1f7bc8fa77c51768855d9df98f5559a5c5e.diff LOG: [

[clang] [llvm] [LLVM][MC][AArch64] Assembler support for Armv9.6-A memory systems extensions (PR #112341)

2024-10-17 Thread Nashe Mncube via cfe-commits
@@ -2568,12 +2580,59 @@ defm CASPA : CompareAndSwapPair<1, 0, "a">; defm CASPL : CompareAndSwapPair<0, 1, "l">; defm CASPAL : CompareAndSwapPair<1, 1, "al">; +// v9.6-a atomic CAST nasherm wrote: Done https://github.com/llvm/llvm-project/pull/112341 __

[clang] [clang-format] Add basic support for C++/CLI (#27126) (PR #112689)

2024-10-17 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang][ASTImporter] Fix of unchecked Error object (NFC) (PR #112688)

2024-10-17 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat approved this pull request. The change itself LGTM, but I'm a bit confused by the commit message. Do I understand it correctly that the import was crashing (more precisely running into an assertion failure) on some input? If yes, then this is not an NFC change (but

[clang] [clang][ASTImporter] Fix of unchecked Error object (NFC) (PR #112688)

2024-10-17 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/112688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e21c80a - [clang] Reject if constexpr in C (#112685)

2024-10-17 Thread via cfe-commits
Author: Mariya Podchishchaeva Date: 2024-10-17T13:42:35+02:00 New Revision: e21c80ac73a9da5c86c20dbce37c9227a17ab06a URL: https://github.com/llvm/llvm-project/commit/e21c80ac73a9da5c86c20dbce37c9227a17ab06a DIFF: https://github.com/llvm/llvm-project/commit/e21c80ac73a9da5c86c20dbce37c9227a17ab0

[clang] [clang] Reject if constexpr in C (PR #112685)

2024-10-17 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon closed https://github.com/llvm/llvm-project/pull/112685 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [LLVM][MC][AArch64] Assembler support for Armv9.6-A memory systems extensions (PR #112341)

2024-10-17 Thread Nashe Mncube via cfe-commits
@@ -4660,6 +4746,21 @@ let Predicates = [HasLOR] in { def STLLRH0 : InstAlias<"stllrh\t$Rt, [$Rn, #0]", (STLLRH GPR32: $Rt, GPR64sp:$Rn)>; } +// v9.6-a Unprivileged load store operations +let Predicates = [HasLSUI] in { +defm LDTXRW : LoadUnprivilegedLSUI<0b10, GPR32, "l

[clang] [analyzer] Improve solver (PR #112583)

2024-10-17 Thread Balazs Benics via cfe-commits
@@ -1485,6 +1487,18 @@ class SymbolicRangeInferrer Sym->getType()); } + std::optional getRangeCommutativeSymSym(const SymSymExpr *SSE) { +bool IsCommutative = llvm::is_contained({BO_Add, BO_Mul}, SSE->getOpcode()); +if (!IsCommutative) + return std::nu

[clang] 5bcc66d - VisitIfStmt: Prune a redundant condition.

2024-10-17 Thread NAKAMURA Takumi via cfe-commits
Author: NAKAMURA Takumi Date: 2024-10-17T20:04:00+09:00 New Revision: 5bcc66dc009893c55aefdcd16a0ca2dad315481b URL: https://github.com/llvm/llvm-project/commit/5bcc66dc009893c55aefdcd16a0ca2dad315481b DIFF: https://github.com/llvm/llvm-project/commit/5bcc66dc009893c55aefdcd16a0ca2dad315481b.dif

[clang] [analyzer] Improve solver (PR #112583)

2024-10-17 Thread Donát Nagy via cfe-commits
@@ -1485,6 +1487,18 @@ class SymbolicRangeInferrer Sym->getType()); } + std::optional getRangeCommutativeSymSym(const SymSymExpr *SSE) { +bool IsCommutative = llvm::is_contained({BO_Add, BO_Mul}, SSE->getOpcode()); +if (!IsCommutative) + return std::nu

[clang] [analyzer] Improve solver (PR #112583)

2024-10-17 Thread Balazs Benics via cfe-commits
@@ -2866,12 +2877,14 @@ ConditionTruthVal RangeConstraintManager::checkNull(ProgramStateRef State, const llvm::APSInt *RangeConstraintManager::getSymVal(ProgramStateRef St, SymbolRef Sym) const { - const RangeSet *T = get

[clang] [analyzer] Improve solver (PR #112583)

2024-10-17 Thread Donát Nagy via cfe-commits
@@ -2866,12 +2877,14 @@ ConditionTruthVal RangeConstraintManager::checkNull(ProgramStateRef State, const llvm::APSInt *RangeConstraintManager::getSymVal(ProgramStateRef St, SymbolRef Sym) const { - const RangeSet *T = get

[clang] [analyzer] Improve solver (PR #112583)

2024-10-17 Thread Balazs Benics via cfe-commits
@@ -2883,22 +2883,16 @@ const llvm::APSInt *RangeConstraintManager::getSymVal(ProgramStateRef St, const llvm::APSInt *RangeConstraintManager::getSymMinVal(ProgramStateRef St, SymbolRef Sym) const { - // TODO: Use `getR

[clang] [clang] constexpr built-in abs function. (PR #112539)

2024-10-17 Thread via cfe-commits
@@ -563,6 +563,19 @@ static bool interp__builtin_fabs(InterpState &S, CodePtr OpPC, return true; } +static bool interp__builtin_abs(InterpState &S, CodePtr OpPC, +const InterpFrame *Frame, const Function *Func, +

[clang] [clang] constexpr built-in abs function. (PR #112539)

2024-10-17 Thread via cfe-commits
@@ -265,6 +265,15 @@ namespace fpclassify { char classify_subnorm [__builtin_fpclassify(-1, -1, -1, +1, -1, 1.0e-38f)]; } +namespace abs { +static_assert(__builtin_abs(14) == 14, ""); +static_assert(__builtin_labs(14L) == 14L, ""); +static_assert(__builtin_llabs(14LL) == 14L

[clang] [clang] constexpr built-in abs function. (PR #112539)

2024-10-17 Thread via cfe-commits
c8ef wrote: > Please add an entry to `clang/docs/ReleaseNotes.rst`, thanks! Done. https://github.com/llvm/llvm-project/pull/112539 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add basic support for C++/CLI (#27126) (PR #112689)

2024-10-17 Thread Calum Robinson via cfe-commits
calumr wrote: #27126 was the issue. I've added a comment there with a clearer example of what clang-format is currently doing to C++/CLI code. I appreciate this PR is not complete & I need to add tests. https://github.com/llvm/llvm-project/pull/112689

[clang] clang/AMDGPU: Set noalias.addrspace metadata on atomicrmw (PR #102462)

2024-10-17 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-aarch64-linux-fuzzer` running on `sanitizer-buildbot12` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/159/builds/8365 Here is the relevant pie

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-10-17 Thread via cfe-commits
https://github.com/ldrumm closed https://github.com/llvm/llvm-project/pull/86318 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2024-10-17 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin updated https://github.com/llvm/llvm-project/pull/111992 >From f7740527720756a469f7f3e7a17a354097438abf Mon Sep 17 00:00:00 2001 From: Dmitry Polukhin Date: Fri, 11 Oct 2024 05:35:18 -0700 Subject: [PATCH 1/3] [C++20][Modules] Load function body from the module tha

[clang-tools-extra] dccebdd - Finally formalise our defacto line-ending policy

2024-10-17 Thread Luke Drummond via cfe-commits
Author: Luke Drummond Date: 2024-10-17T14:47:54+01:00 New Revision: dccebddb3b802c4c1fe287222e454b63f850f012 URL: https://github.com/llvm/llvm-project/commit/dccebddb3b802c4c1fe287222e454b63f850f012 DIFF: https://github.com/llvm/llvm-project/commit/dccebddb3b802c4c1fe287222e454b63f850f012.diff

[clang] [clang] Fix C23 constexpr crashes (PR #112708)

2024-10-17 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. These changes seem reasonable to me, and likely worth backporting (CC @tbaederr for a second set of eyes just to be sure) https://github.com/llvm/llvm-project/pull/112708 ___ cfe-commits mail

[clang] [C++20][Modules] Load function body from the module that gives canonical decl (PR #111992)

2024-10-17 Thread Dmitry Polukhin via cfe-commits
dmpolukhin wrote: > Thanks for the analysis. I feel (2) is easier to me IIUC. I feel it is a > natural extension of your previous work. WDYT? I implemented this approach and it works. I tried to limit eager deserialization to the minimal set of functions (at the moment it is friend inline fri

[clang] [clang] Fix covariant cv-qualification check to require the override function return type to have the same or less cv-qualification (PR #112713)

2024-10-17 Thread Boaz Brickner via cfe-commits
https://github.com/bricknerb created https://github.com/llvm/llvm-project/pull/112713 This prevents changing cv-qualification from const to volatile or vice versa, for example. https://eel.is/c++draft/class.virtual#8.3 Previously, we checked that the new type is the same or more qualified to

[clang] [clang] Fix covariant cv-qualification check to require the override function return type to have the same or less cv-qualification (PR #112713)

2024-10-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Boaz Brickner (bricknerb) Changes This prevents changing cv-qualification from const to volatile or vice versa, for example. https://eel.is/c++draft/class.virtual#8.3 Previously, we checked that the new type is the same or more qualified

[clang] [llvm] [PATCH] [COFF] Implement pragma clang section on COFF targets (PR #112714)

2024-10-17 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [llvm] [PATCH] [COFF] Implement pragma clang section on COFF targets (PR #112714)

2024-10-17 Thread Vinicius Tadeu Zein via cfe-commits
https://github.com/vtz created https://github.com/llvm/llvm-project/pull/112714 This patch implements the directive pragma clang section on COFF targets with the exact same features available on ELF and Mach-O. >From 02223262c678f02b024b3ce83bb89f08d94815bf Mon Sep 17 00:00:00 2001 From: Vinici

[clang] [clang] Make -fveclib={ArmPL, SLEEF} imply -fno-math-errno (PR #112580)

2024-10-17 Thread Benjamin Maxwell via cfe-commits
https://github.com/MacDue updated https://github.com/llvm/llvm-project/pull/112580 >From d8ac47d27ad860a8b11424621ab88cd9267cf866 Mon Sep 17 00:00:00 2001 From: Benjamin Maxwell Date: Wed, 2 Oct 2024 10:28:29 + Subject: [PATCH 1/4] [clang] Make -fveclib={ArmPL,SLEEF} imply -fno-math-errno

[clang] Fix build break in SemaHLSL.cpp on MSVC 2022: warning C4715: 'getResourceClass': not all control paths return a value (PR #112767)

2024-10-17 Thread Daniel Paoliello via cfe-commits
https://github.com/dpaoliello created https://github.com/llvm/llvm-project/pull/112767 Adds a default case to the switch to the existing `llvm_unreachable` statement. Build break was introduced by #111203 It was not caught by the builders as they use Visual Studio 2019, whereas this warning o

[clang] Fix build break in SemaHLSL.cpp on MSVC 2022: warning C4715: 'getResourceClass': not all control paths return a value (PR #112767)

2024-10-17 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Daniel Paoliello (dpaoliello) Changes Adds a default case to the switch to the existing `llvm_unreachable` statement. Build break was introduced by #111203 It was not caught by the builders as they use Visual Studio 2019, whereas this wa

[clang] [Clang][AArch64] Fix Pure Scalables Types argument passing and return (PR #112747)

2024-10-17 Thread Jonathan Thackray via cfe-commits
@@ -533,11 +638,158 @@ bool AArch64ABIInfo::isZeroLengthBitfieldPermittedInHomogeneousAggregate() return true; } +// Check if a type is a Pure Scalable Type as defined by AAPCS64. Return the +// number of data vectors and the number of predicate vectors in the types, into

[clang] [Clang] fix range calculation for conditionals with throw expressions (PR #112081)

2024-10-17 Thread Shafik Yaghmour via cfe-commits
@@ -9827,6 +9827,9 @@ static IntRange GetExprRange(ASTContext &C, const Expr *E, unsigned MaxWidth, return IntRange(BitField->getBitWidthValue(C), BitField->getType()->isUnsignedIntegerOrEnumerationType()); shafik wrote: So why doesn'

[clang] [Clang][AArch64] Fix Pure Scalables Types argument passing and return (PR #112747)

2024-10-17 Thread Jonathan Thackray via cfe-commits
@@ -423,6 +510,19 @@ ABIArgInfo AArch64ABIInfo::classifyReturnType(QualType RetTy, // Homogeneous Floating-point Aggregates (HFAs) are returned directly. return ABIArgInfo::getDirect(); + // In AAPCS return values of a Pure Scalable type are treated is a first named

[clang] [Clang][AArch64] Fix Pure Scalables Types argument passing and return (PR #112747)

2024-10-17 Thread Jonathan Thackray via cfe-commits
@@ -533,11 +638,158 @@ bool AArch64ABIInfo::isZeroLengthBitfieldPermittedInHomogeneousAggregate() return true; } +// Check if a type is a Pure Scalable Type as defined by AAPCS64. Return the +// number of data vectors and the number of predicate vectors in the types, into

[clang] [Clang][AArch64] Fix Pure Scalables Types argument passing and return (PR #112747)

2024-10-17 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray edited https://github.com/llvm/llvm-project/pull/112747 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-17 Thread Damyan Pepper via cfe-commits
@@ -1,64 +1,64 @@ -// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-library -x hlsl -ast-dump -DEMPTY %s | FileCheck -check-prefix=EMPTY %s damyanp wrote: hmmmaybe a line endings change issue on this file? I'm wondering if some config in the root of this

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-17 Thread Damyan Pepper via cfe-commits
@@ -323,30 +324,99 @@ struct TemplateParameterListBuilder { S.Context, Builder.Record->getDeclContext(), SourceLocation(), SourceLocation(), /* TemplateDepth */ 0, Position, &S.Context.Idents.get(Name, tok::TokenKind::identifier), -/* Typename */

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-17 Thread Damyan Pepper via cfe-commits
@@ -323,30 +324,99 @@ struct TemplateParameterListBuilder { S.Context, Builder.Record->getDeclContext(), SourceLocation(), SourceLocation(), /* TemplateDepth */ 0, Position, &S.Context.Idents.get(Name, tok::TokenKind::identifier), -/* Typename */

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-17 Thread Damyan Pepper via cfe-commits
@@ -323,30 +324,99 @@ struct TemplateParameterListBuilder { S.Context, Builder.Record->getDeclContext(), SourceLocation(), SourceLocation(), /* TemplateDepth */ 0, Position, &S.Context.Idents.get(Name, tok::TokenKind::identifier), -/* Typename */

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-17 Thread Damyan Pepper via cfe-commits
@@ -1078,10 +1078,10 @@ ConceptDecl *ConceptDecl::Create(ASTContext &C, DeclContext *DC, TemplateParameterList *Params, Expr *ConstraintExpr) { bool Invalid = AdoptTemplateParameterList(Params, DC); - auto *T

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-17 Thread Damyan Pepper via cfe-commits
@@ -323,30 +324,99 @@ struct TemplateParameterListBuilder { S.Context, Builder.Record->getDeclContext(), SourceLocation(), SourceLocation(), /* TemplateDepth */ 0, Position, &S.Context.Idents.get(Name, tok::TokenKind::identifier), -/* Typename */

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-17 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp edited https://github.com/llvm/llvm-project/pull/112600 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add implicit resource element type concepts to AST (PR #112600)

2024-10-17 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp commented: Some comments based on a quick read through: https://github.com/llvm/llvm-project/pull/112600 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   6   >