mydeveloperday wrote:

My point was that mostly this change is about changing the call 
isPointerOrReference call, its an invasive change for little extra. 

Can you give me an example of what it was doing wrong (hence the github issue), 
My code base contains both c++,c# and (some) managed c++ and its all 
clang-formatted already. So I'm trying to understand why we need the change. 
(i.e. where is it broken)

as you set CPlusPlusCLI to 1 then I don't see how anyone can ever turn it off.  
How does this impact the ObjC tests, (did you run the unit tests)

Whilst we welcome changes, we need unit tests to ensure we don't break anything 
but also someone doesn't break you later.




https://github.com/llvm/llvm-project/pull/112689
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to