https://github.com/NagyDonat approved this pull request.
The change itself LGTM, but I'm a bit confused by the commit message. Do I understand it correctly that the import was crashing (more precisely running into an assertion failure) on some input? If yes, then this is not an NFC change (but a valuable bugfix :slightly_smiling_face: ), so you should not mark it as NFC. Also, did the [apparently NFC removal of `std::move`](https://github.com/llvm/llvm-project/commit/30a9cace807d4b5c98f2d0e2bd5bdea49061c8b8) influence anything in the behavior of this code? Do you only mention it because it's a recent modification of this code, or did the crash appear when it was merged? https://github.com/llvm/llvm-project/pull/112688 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
