[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)

2024-10-02 Thread Dmitry Sidorov via cfe-commits
MrSidims wrote: > There's nothing new to do here. This has always existed @arsenm here is a small experiment, I've compiled the following OpenCL code: ``` struct S { char i8_3[3]; }; kernel void test(global struct S *p, float3 v) { int3 tmp; frexp(v, &tmp); tmp += 1; p->i8_3[0]

[clang] [Clang] Emit a diagnostic note at the class declaration when the method definition does not match any declaration. (PR #110638)

2024-10-02 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/110638 >From 38430b6cdfc524972fbdabca6a037174eaf1549f Mon Sep 17 00:00:00 2001 From: c8ef Date: Tue, 1 Oct 2024 09:08:14 + Subject: [PATCH 1/8] 110558 --- clang/lib/Sema/SemaDecl.cpp | 5 + 1 file changed, 5 inse

[clang] [Clang] Emit a diagnostic note at the class declaration when the method definition does not match any declaration. (PR #110638)

2024-10-02 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/110638 >From 38430b6cdfc524972fbdabca6a037174eaf1549f Mon Sep 17 00:00:00 2001 From: c8ef Date: Tue, 1 Oct 2024 09:08:14 + Subject: [PATCH 1/8] 110558 --- clang/lib/Sema/SemaDecl.cpp | 5 + 1 file changed, 5 inse

[clang] [llvm] [AArch64] Split FeatureAES to FEAT_AES and FEAT_PMULL. (PR #110816)

2024-10-02 Thread Alexandros Lamprineas via cfe-commits
@@ -1117,39 +1117,41 @@ int caller(void) { return used_def_without_default_decl() + used_decl_without_de // CHECK: attributes #[[ATTR2]] = { noinline nounwind optnone "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-features"="+fp-armv8,+lse,+neon,+sha2" }

[clang] [llvm] [AArch64] Split FeatureAES to FEAT_AES and FEAT_PMULL. (PR #110816)

2024-10-02 Thread Alexandros Lamprineas via cfe-commits
labrinea wrote: Adding the GCC folks @andrewcarlotti and @Wilco1 for visibility. https://github.com/llvm/llvm-project/pull/110816 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Split FeatureAES to FEAT_AES and FEAT_PMULL. (PR #110816)

2024-10-02 Thread Alexandros Lamprineas via cfe-commits
@@ -88,9 +88,9 @@ def : FMVExtension<"sve-bf16", "FEAT_SVE_BF16", "+sve,+bf16,+fullfp16,+fp-armv8, def : FMVExtension<"sve-ebf16", "FEAT_SVE_EBF16", "+sve,+bf16,+fullfp16,+fp-armv8,+neon", 330>; def : FMVExtension<"sve-i8mm", "FEAT_SVE_I8MM", "+sve,+i8mm,+fullfp16,+fp-armv8,+

[clang] [clang][RISC-V] fixed fp calling convention for fpcc eligible structs for risc-v (PR #110690)

2024-10-02 Thread Kamran Yousafzai via cfe-commits
@@ -251,6 +253,15 @@ bool RISCVABIInfo::detectFPCCEligibleStructHelper(QualType Ty, CharUnits CurOff, // bitwidth is XLen or less. if (getContext().getTypeSize(QTy) > XLen && BitWidth <= XLen) QTy = getContext().getIntTypeForBitwidth(XLen, false); +

[clang] [clang][RISC-V] fixed fp calling convention for fpcc eligible structs for risc-v (PR #110690)

2024-10-02 Thread Kamran Yousafzai via cfe-commits
@@ -251,6 +253,15 @@ bool RISCVABIInfo::detectFPCCEligibleStructHelper(QualType Ty, CharUnits CurOff, // bitwidth is XLen or less. if (getContext().getTypeSize(QTy) > XLen && BitWidth <= XLen) QTy = getContext().getIntTypeForBitwidth(XLen, false); +

[clang] [llvm] Introduce the Armv9.6-A architecture version (PR #110825)

2024-10-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-arm Author: Jonathan Thackray (jthackray) Changes This introduces the Armv9.6-A architecture version, including the relevant command-line option for -march. More details about the Armv9.6-A architecture version can be found at: * https://com

[clang] [llvm] Introduce the Armv9.6-A architecture version (PR #110825)

2024-10-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Author: Jonathan Thackray (jthackray) Changes This introduces the Armv9.6-A architecture version, including the relevant command-line option for -march. More details about the Armv9.6-A architecture version can be found at: * https:/

[clang] [llvm] Introduce the Armv9.6-A architecture version (PR #110825)

2024-10-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Jonathan Thackray (jthackray) Changes This introduces the Armv9.6-A architecture version, including the relevant command-line option for -march. More details about the Armv9.6-A architecture version can be found at: * https://co

[clang] [llvm] [AArch64][SVE] Fix definition of bfloat fcvt intrinsics. (PR #110281)

2024-10-02 Thread Paul Walker via cfe-commits
@@ -4072,6 +4078,30 @@ static Value *upgradeX86IntrinsicCall(StringRef Name, CallBase *CI, Function *F, return Rep; } +static Value *upgradeAArch64IntrinsicCall(StringRef Name, CallBase *CI, + Function *F, IRBuilder<> &Builder) { +

[clang] [llvm] [AArch64][SVE] Fix definition of bfloat fcvt intrinsics. (PR #110281)

2024-10-02 Thread Paul Walker via cfe-commits
@@ -5553,6 +5553,14 @@ static SDValue getSVEPredicateBitCast(EVT VT, SDValue Op, SelectionDAG &DAG) { if (InVT == VT) return Op; + // Look through casts to when their input has more lanes than paulwalker-arm wrote: Done, plus removed another redundan

[clang] [llvm] [AArch64][SVE] Fix definition of bfloat fcvt intrinsics. (PR #110281)

2024-10-02 Thread Paul Walker via cfe-commits
@@ -1003,6 +998,13 @@ defm SVFCVT_F32_F64 : SInstCvtMXZ<"svcvt_f32[_f64]", "MMPd", "MPd", "d", "aarc defm SVFCVT_F64_F16 : SInstCvtMXZ<"svcvt_f64[_f16]", "ddPO", "dPO", "d", "aarch64_sve_fcvt_f64f16">; defm SVFCVT_F64_F32 : SInstCvtMXZ<"svcvt_f64[_f32]", "ddPM", "dPM", "

[clang] [clang][RISC-V] fixed fp calling convention for fpcc eligible structs for risc-v (PR #110690)

2024-10-02 Thread Kamran Yousafzai via cfe-commits
@@ -251,6 +253,15 @@ bool RISCVABIInfo::detectFPCCEligibleStructHelper(QualType Ty, CharUnits CurOff, // bitwidth is XLen or less. if (getContext().getTypeSize(QTy) > XLen && BitWidth <= XLen) QTy = getContext().getIntTypeForBitwidth(XLen, false); +

[clang] [clang][RISC-V] fixed fp calling convention for fpcc eligible structs for risc-v (PR #110690)

2024-10-02 Thread Kamran Yousafzai via cfe-commits
https://github.com/KamranYousafzai edited https://github.com/llvm/llvm-project/pull/110690 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Introduce the Armv9.6-A architecture version (PR #110825)

2024-10-02 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray created https://github.com/llvm/llvm-project/pull/110825 This introduces the Armv9.6-A architecture version, including the relevant command-line option for -march. More details about the Armv9.6-A architecture version can be found at: * https://community.arm.com

[clang] [llvm] [CloneFunction][DebugInfo] Avoid cloning DILocalVariables of inlined functions (PR #75385)

2024-10-02 Thread Jeremy Morse via cfe-commits
jmorse wrote: Hadn't realised lambda types will pop up everywhere, the cost might be too high. I'll test with building clang and our internal codebases to see if the fix works and what the cost is. > Surely if we can compute a unique mangled name for this local class, we > should use it as th

[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)

2024-10-02 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/110695 >From 758fb6e28844d89031b5497d651cb2a9b71b6a0e Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Tue, 1 Oct 2024 17:10:50 +0100 Subject: [PATCH 1/2] Explicitly encode native integer widths for SPIR-V. --- clang/

[clang] [clang][RISC-V] fixed fp calling convention for fpcc eligible structs for risc-v (PR #110690)

2024-10-02 Thread Kamran Yousafzai via cfe-commits
https://github.com/KamranYousafzai updated https://github.com/llvm/llvm-project/pull/110690 >From f1da56e337a4a2f0414fd600897addb0fa61b843 Mon Sep 17 00:00:00 2001 From: "muhammad.kamran4" Date: Tue, 1 Oct 2024 17:21:21 +0200 Subject: [PATCH] fixed fp calling convention for fpcc eligible struct

[clang] [lldb] [clang][RecordLayoutBuilder] Be stricter about inferring packed-ness in ExternalLayouts (PR #97443)

2024-10-02 Thread Michael Buch via cfe-commits
Michael137 wrote: > > Skipping empty fields does seem like a better heuristic here > > FWIW, I (independently) came to the same conclusion when investigating the > fallout of #76756, though it's not fully clear to me whether the PR has been > updated to do that. Not yet, but will have a look

[clang] [clang][Itanium Mangle] Enable mangling of enclosing class for member… (PR #110503)

2024-10-02 Thread Viktoriia Bakalova via cfe-commits
https://github.com/VitaNuo updated https://github.com/llvm/llvm-project/pull/110503 >From 27c2b3d4d2d9b54ed635a6b00dbb545241b498e8 Mon Sep 17 00:00:00 2001 From: Viktoriia Bakalova Date: Mon, 30 Sep 2024 12:50:09 + Subject: [PATCH] [clang][Itanium Mangle] Enable mangling of enclosing class

[clang] [clang][Itanium Mangle] Enable mangling of enclosing class for member… (PR #110503)

2024-10-02 Thread via cfe-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 735a5f67e351fc072a9f7c18b030036681f7935a...fb2d704c3dfe8d30c72eba4e848d0404d7349ec9 clang

[clang] [Clang] Emit a diagnostic note at the class declaration when the method definition does not match any declaration. (PR #110638)

2024-10-02 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/110638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Emit a diagnostic note at the class declaration when the method definition does not match any declaration. (PR #110638)

2024-10-02 Thread Vlad Serebrennikov via cfe-commits
@@ -1009,18 +1012,20 @@ namespace cwg355 { struct ::cwg355_S s; } // cwg356: na namespace cwg357 { // cwg357: yes - template struct A { + template struct A { // #cwg357-A void f() const; // #cwg357-f }; template void A::f() {} // expected-error@-1 {{out-of-line

[clang] [Clang] Emit a diagnostic note at the class declaration when the method definition does not match any declaration. (PR #110638)

2024-10-02 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll commented: LGTM otherwise https://github.com/llvm/llvm-project/pull/110638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Emit a diagnostic note at the class declaration when the method definition does not match any declaration. (PR #110638)

2024-10-02 Thread via cfe-commits
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/110638 >From 38430b6cdfc524972fbdabca6a037174eaf1549f Mon Sep 17 00:00:00 2001 From: c8ef Date: Tue, 1 Oct 2024 09:08:14 + Subject: [PATCH 1/9] 110558 --- clang/lib/Sema/SemaDecl.cpp | 5 + 1 file changed, 5 inse

[clang] [llvm] [X86] Don't request 0x90 nop filling in p2align directives (PR #110134)

2024-10-02 Thread Jeremy Morse via cfe-commits
https://github.com/jmorse closed https://github.com/llvm/llvm-project/pull/110134 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Split FeatureAES to FEAT_AES and FEAT_PMULL. (PR #110816)

2024-10-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Author: Alexandros Lamprineas (labrinea) Changes Currently in LLVM FeatureAES models both FEAT_AES and FEAT_PMULL lumped together. Similarly FeatureSVE2AES means FEAT_SVE_AES plus FEAT_SVE_PMULL128. However the architecture does not man

[clang] [clang][Itanium Mangle] Enable mangling of enclosing class for member… (PR #110503)

2024-10-02 Thread Haojian Wu via cfe-commits
@@ -693,14 +693,13 @@ ItaniumMangleContextImpl::getEffectiveDeclContext(const Decl *D) { if (VD->isExternC()) return getASTContext().getTranslationUnitDecl(); - if (const auto *FD = D->getAsFunction()) { -if (FD->isExternC()) hokein wrote: why

[clang] [clang][Itanium Mangle] Enable mangling of enclosing class for member… (PR #110503)

2024-10-02 Thread Haojian Wu via cfe-commits
@@ -693,14 +693,13 @@ ItaniumMangleContextImpl::getEffectiveDeclContext(const Decl *D) { if (VD->isExternC()) return getASTContext().getTranslationUnitDecl(); - if (const auto *FD = D->getAsFunction()) { -if (FD->isExternC()) - return getASTContext().getTr

[clang] 33fa40c - [clang][ExtractAPI] Generate subheading for typedef'd anonymous types (#110689)

2024-10-02 Thread via cfe-commits
Author: Daniel Grumberg Date: 2024-10-02T11:14:27+01:00 New Revision: 33fa40cc9659b7b56a9b440edc0587ff58793cac URL: https://github.com/llvm/llvm-project/commit/33fa40cc9659b7b56a9b440edc0587ff58793cac DIFF: https://github.com/llvm/llvm-project/commit/33fa40cc9659b7b56a9b440edc0587ff58793cac.dif

[clang] [clang][ExtractAPI] Generate subheading for typedef'd anonymous types (PR #110689)

2024-10-02 Thread Daniel Grumberg via cfe-commits
https://github.com/daniel-grumberg closed https://github.com/llvm/llvm-project/pull/110689 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)

2024-10-02 Thread Matt Arsenault via cfe-commits
arsenm wrote: > with the PR pulled in (on top of LLVM's HEAD > [aadfba9](https://github.com/llvm/llvm-project/commit/aadfba9b2aa107f9cada2fd9bcbe612cbf560650)), > the compilation command is: `clang++ -cl-std=CL2.0 -emit-llvm -c -x cl -g0 > --target=spir -Xclang -finclude-default-header -O2 tes

[clang] [compiler-rt] [llvm] [FMV][AArch64] Unify features ssbs and ssbs2. (PR #110297)

2024-10-02 Thread Alexandros Lamprineas via cfe-commits
@@ -1125,31 +1125,32 @@ int caller(void) { return used_def_without_default_decl() + used_decl_without_de // CHECK: attributes #[[ATTR10]] = { noinline nounwind optnone "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-features"="+fp-armv8,+ls64,+neon" } // C

[clang] [analyzer][NFC] Remove dangling method declaration from ErrnoChecker (PR #110820)

2024-10-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Donát Nagy (NagyDonat) Changes Remove the declaration of `ErrnoChecker::checkBranchCondition()` because this method is not defined or used anywhere. (It's probably a leftover from some old refactoring.) --- Full diff: https://github.com/

[clang] [analyzer][NFC] Remove dangling method declaration from ErrnoChecker (PR #110820)

2024-10-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Donát Nagy (NagyDonat) Changes Remove the declaration of `ErrnoChecker::checkBranchCondition()` because this method is not defined or used anywhere. (It's probably a leftover from some old refactoring.) --- Full diff: h

[clang] [analyzer][NFC] Remove dangling method declaration from ErrnoChecker (PR #110820)

2024-10-02 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat created https://github.com/llvm/llvm-project/pull/110820 Remove the declaration of `ErrnoChecker::checkBranchCondition()` because this method is not defined or used anywhere. (It's probably a leftover from some old refactoring.) From 72bc17b87a7955a58210dfe42d7d73

[clang] Multilib error fixes (PR #110804)

2024-10-02 Thread Peter Smith via cfe-commits
https://github.com/smithp35 edited https://github.com/llvm/llvm-project/pull/110804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Multilib error fixes (PR #110804)

2024-10-02 Thread Peter Smith via cfe-commits
https://github.com/smithp35 commented: Change looks good to me. A few small comment nits. https://github.com/llvm/llvm-project/pull/110804 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] Multilib error fixes (PR #110804)

2024-10-02 Thread Peter Smith via cfe-commits
@@ -124,12 +124,11 @@ bool MultilibSet::select(const Driver &D, const Multilib::flags_list &Flags, } // If this multilib is actually a placeholder containing a fatal -// error message written by the multilib.yaml author, display that -// error message, and ret

[clang] [clang][RISC-V] fixed fp calling convention for fpcc eligible structs for risc-v (PR #110690)

2024-10-02 Thread Kamran Yousafzai via cfe-commits
https://github.com/KamranYousafzai updated https://github.com/llvm/llvm-project/pull/110690 >From 8ca2d40d834c500fd463c6fa0d475cd9f91407c2 Mon Sep 17 00:00:00 2001 From: "muhammad.kamran4" Date: Tue, 1 Oct 2024 17:21:21 +0200 Subject: [PATCH] fixed fp calling convention for fpcc eligible struct

[clang] [llvm] [AArch64][SVE] Fix definition of bfloat fcvt intrinsics. (PR #110281)

2024-10-02 Thread Paul Walker via cfe-commits
https://github.com/paulwalker-arm updated https://github.com/llvm/llvm-project/pull/110281 >From 7fd66c7630ec03db05203c7ffdf8e36e23e30d93 Mon Sep 17 00:00:00 2001 From: Paul Walker Date: Thu, 26 Sep 2024 18:07:52 +0100 Subject: [PATCH 1/2] [AArch64][SVE] Fix definition of bfloat fcvt intrinsics

[clang] [Clang] omit parentheses in fold expressions with a single expansion (PR #110761)

2024-10-02 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/110761 >From 9c69d6584d6b71554aec55f0de52abb4baa9435f Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Wed, 2 Oct 2024 02:13:51 +0300 Subject: [PATCH] [Clang] omit parentheses in fold expressions with a single expa

[clang] [llvm] [clang][llvm][SPIR-V] Explicitly encode native integer widths for SPIR-V (PR #110695)

2024-10-02 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/110695 >From 758fb6e28844d89031b5497d651cb2a9b71b6a0e Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Tue, 1 Oct 2024 17:10:50 +0100 Subject: [PATCH] Explicitly encode native integer widths for SPIR-V. --- clang/lib/

[clang] [llvm] [AArch64] Split FeatureAES to FEAT_AES and FEAT_PMULL. (PR #110816)

2024-10-02 Thread Andrew Carlotti via cfe-commits
andrewcarlotti wrote: > However the architecture does not mandate that both need to be implemented at > the same time. This premise is incorrect. For FEAT_SVE_AES and FEAT_SVE_PMULL128, the latest version of the Arm ARM (DDI 0487K.a) includes the following in the definition of `ID_AA64ZFR0_E

[clang] [analyzer][NFC] Remove dangling method declaration from ErrnoChecker (PR #110820)

2024-10-02 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. https://github.com/llvm/llvm-project/pull/110820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] a10d3d2 - [analyzer][NFC] Remove dangling method declaration from ErrnoChecker (#110820)

2024-10-02 Thread via cfe-commits
Author: Donát Nagy Date: 2024-10-02T13:32:45+02:00 New Revision: a10d3d2a3a82a577625ee8877853b4c4c9e2bbdc URL: https://github.com/llvm/llvm-project/commit/a10d3d2a3a82a577625ee8877853b4c4c9e2bbdc DIFF: https://github.com/llvm/llvm-project/commit/a10d3d2a3a82a577625ee8877853b4c4c9e2bbdc.diff LO

[clang] [analyzer][NFC] Remove dangling method declaration from ErrnoChecker (PR #110820)

2024-10-02 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat closed https://github.com/llvm/llvm-project/pull/110820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][HIP] Warn when __AMDGCN_WAVEFRONT_SIZE is used in host code without relying on target-dependent overload resolution (PR #109663)

2024-10-02 Thread Fabian Ritter via cfe-commits
ritter-x2a wrote: @Artem-B thank you for the suggestion! Do I understand correctly that it boils down to the following? - If a (new) clang CLI option is set: enable PR #91478 - which, among other things, warns during host compilation whenever `__AMDGCN_WAVEFRONT_SIZE__` is used in template d

[clang] [clang] WIP: Warn on mismatched RequiresCapability attributes (PR #67520)

2024-10-02 Thread Kevin Wolf via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: kevmw wrote: > This example from the failing test should warn I think > [...] > Since the definition of foo2 specifies attributes that aren't pres

[clang] [clang][analyzer] Less redundant warnings from FixedAddressChecker (PR #110458)

2024-10-02 Thread Balázs Kéri via cfe-commits
https://github.com/balazske updated https://github.com/llvm/llvm-project/pull/110458 From eb03076eca550ea53143bc753639f22bbb7caa35 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Mon, 30 Sep 2024 09:19:52 +0200 Subject: [PATCH 1/2] [clang][analyzer] Less redundant warni

[clang] [clang][HLSL] Add radians intrinsic (PR #110802)

2024-10-02 Thread Adam Yang via cfe-commits
https://github.com/adam-yang created https://github.com/llvm/llvm-project/pull/110802 partially fixes #99151 ### Changes * Implemented `radians` clang builtin * Linked `radians` clang builtin with `hlsl_intrinsics.h` * Added sema checks for `radians` to `CheckHLSLBuiltinFunctionCall` in `SemaC

[clang] [clang][HLSL] Add radians intrinsic (PR #110802)

2024-10-02 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang][ExtractAPI] Generate subheading for typedef'd anonymous types (PR #110689)

2024-10-02 Thread Daniel Grumberg via cfe-commits
@@ -1621,6 +1621,9 @@ DeclarationFragmentsBuilder::getSubHeading(const NamedDecl *Decl) { cast(Decl)->isOverloadedOperator()) { Fragments.append(Decl->getNameAsString(), DeclarationFragments::FragmentKind::Identifier); + } else if (dyn_ca

[clang] [clang][ExtractAPI] Generate subheading for typedef'd anonymous types (PR #110689)

2024-10-02 Thread Daniel Grumberg via cfe-commits
https://github.com/daniel-grumberg updated https://github.com/llvm/llvm-project/pull/110689 >From 30e06bed5b8ba378b2b43f0706617f6978f4be6c Mon Sep 17 00:00:00 2001 From: Daniel Grumberg Date: Tue, 1 Oct 2024 16:29:30 +0100 Subject: [PATCH] [clang][ExtractAPI] Generate subheading for typedef'd

[clang-tools-extra] aadfba9 - [clang-tidy] Fix check alphabetical ordering in release notes (#110428)

2024-10-02 Thread via cfe-commits
Author: Mike Crowe Date: 2024-10-02T09:10:45+02:00 New Revision: aadfba9b2aa107f9cada2fd9bcbe612cbf560650 URL: https://github.com/llvm/llvm-project/commit/aadfba9b2aa107f9cada2fd9bcbe612cbf560650 DIFF: https://github.com/llvm/llvm-project/commit/aadfba9b2aa107f9cada2fd9bcbe612cbf560650.diff LO

[clang-tools-extra] [clang-tidy] Fix check alphabetical ordering in release notes (PR #110428)

2024-10-02 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/110428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix check alphabetical ordering in release notes (PR #110428)

2024-10-02 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/110428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Update Interpreter tests to use clang_target_link_libraries (PR #110154)

2024-10-02 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev closed https://github.com/llvm/llvm-project/pull/110154 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f0858bf - [Clang] Update Interpreter tests to use clang_target_link_libraries (#110154)

2024-10-02 Thread via cfe-commits
Author: Thomas Fransham Date: 2024-10-02T10:12:17+03:00 New Revision: f0858bfb62468e5887e7b7d158bd07543ed82467 URL: https://github.com/llvm/llvm-project/commit/f0858bfb62468e5887e7b7d158bd07543ed82467 DIFF: https://github.com/llvm/llvm-project/commit/f0858bfb62468e5887e7b7d158bd07543ed82467.dif

[clang] [clang] Catch missing format attributes (PR #105479)

2024-10-02 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovichtec updated https://github.com/llvm/llvm-project/pull/105479 From 7dafc4011b5597dd7eaf931dab33980b0f51643b Mon Sep 17 00:00:00 2001 From: budimirarandjelovicsyrmia Date: Fri, 5 Apr 2024 15:20:37 +0200 Subject: [PATCH] [clang] Catch missing format attribute

[clang] [Clang] Add __builtin_(elementwise|reduce)_(max|min)imum (PR #110198)

2024-10-02 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `premerge-monolithic-linux` running on `premerge-linux-1` while building `clang` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/153/builds/10649 Here is

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-10-02 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev approved this pull request. Looks good to me, too. We can wait a couple of more days for @AaronBallman to have the final say. https://github.com/llvm/llvm-project/pull/108276 ___ cfe-commits mailing list cfe-commits@lists

[clang] [llvm] [Inliner] Propagate more attributes to params when inlining (PR #91101)

2024-10-02 Thread Nikita Popov via cfe-commits
nikic wrote: Based on llvm-opt-benchmark results, it looks like there are some significant compile-time regressions, could you please take a look? I also see: ``` early-cse.NumCSECall 18050 -> 17883 -0.93% simplifycfg.NumInvokesMerged 121710 -> 120984 -0.60% ``` EarlyCSE uses isIdenticalTo and

[clang] [llvm] [Inliner] Propagate more attributes to params when inlining (PR #91101)

2024-10-02 Thread Nikita Popov via cfe-commits
nikic wrote: It may be a good idea to skip the inference for constant arguments. I see a decent amount of things like `range(i64 -2147483576, 34359738361) 272` in the diffs. Though I still don't think that we should be inferring range at all. https://github.com/llvm/llvm-project/pull/91101 __

[clang] [Clang] Add explicit visibility symbol macros (PR #108276)

2024-10-02 Thread Vassil Vassilev via cfe-commits
https://github.com/vgvassilev updated https://github.com/llvm/llvm-project/pull/108276 >From 3c19f9edb391988c180b6a2dd35198b7b95e2144 Mon Sep 17 00:00:00 2001 From: Thomas Fransham Date: Tue, 10 Sep 2024 02:22:18 +0100 Subject: [PATCH 1/6] [Clang] Add explicit visibility symbol macros and updat

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] Probe for -nostdlib++ and -nostdinc++ with the C compiler (PR #108357)

2024-10-02 Thread Martin Storsjö via cfe-commits
@@ -38,9 +38,13 @@ check_cxx_compiler_flag(-nolibc CXX_SUPPORTS_NOLIBC_FLAG) # required during compilation (which has the -nostdlib++ or -nodefaultlibs). libc is # required for the link to go through. We remove sanitizers from the # configuration checks to avoid spurious link

[clang] [llvm] [InstrPGO] Instrument sampling profile based cold function (PR #109837)

2024-10-02 Thread Lei Wang via cfe-commits
@@ -1784,6 +1784,12 @@ defm debug_info_for_profiling : BoolFOption<"debug-info-for-profiling", PosFlag, NegFlag>; +def fprofile_generate_cold_function_coverage : Flag<["-"], "fprofile-generate-cold-function-coverage">, wlei-llvm wrote: > I meant, why not

[clang-tools-extra] [llvm] [clangd] Add CodeAction to swap operands to binary operators (PR #78999)

2024-10-02 Thread Julian Schmidt via cfe-commits
5chmidti wrote: > @5chmidti this should be ready for merge Yep. Though, please check out: https://discourse.llvm.org/t/hidden-emails-on-github-should-we-do-something-about-it/74223 TLDR: LLVM wants commit emails that can be reached out to. I have created a new email address for this to separa

[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)

2024-10-02 Thread Leandro Lupori via cfe-commits
@@ -339,11 +335,11 @@ just added using your new frontend option. ## CMake Support As of [#7246](https://gitlab.kitware.com/cmake/cmake/-/merge_requests/7246) -(and soon to be released CMake 3.24.0), `cmake` can detect `flang-new` as a +(and soon to be released CMake 3.24.0), `

[clang] [llvm] [mlir] [NFC][TableGen] Change `Record::getSuperClasses` to use const Record* (PR #110845)

2024-10-02 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm approved this pull request. https://github.com/llvm/llvm-project/pull/110845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [mlir] [NFC][TableGen] Change `Record::getSuperClasses` to use const Record* (PR #110845)

2024-10-02 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/110845 >From 71482b22871022ad783386680362f9e2430d9a38 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Wed, 2 Oct 2024 07:01:40 -0700 Subject: [PATCH] [NFC][TableGen] Change `Record::getSuperClasses` to use const Reco

[clang] [llvm] [llvm][opt][Transforms][SPIR-V] Enable `InferAddressSpaces` for SPIR-V (PR #110897)

2024-10-02 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 09ba83be0ac178851e3c9c9c8fefddbdd4d8353f fcab1ddf1e7f53276c071b479f1b5b7749d33ba5 --e

[clang] [llvm] [llvm][opt][Transforms][SPIR-V] Enable `InferAddressSpaces` for SPIR-V (PR #110897)

2024-10-02 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx created https://github.com/llvm/llvm-project/pull/110897 Albeit not currently enabled, the InferAddressSpaces pass is desirable / profitable for SPIR-V, as it can leverage info that might subsequently be lost as transforms are applied to the IR/resulting SPIR-V. This

[clang] [llvm] [llvm][opt][Transforms][SPIR-V] Enable `InferAddressSpaces` for SPIR-V (PR #110897)

2024-10-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alex Voicu (AlexVlx) Changes Albeit not currently enabled, the InferAddressSpaces pass is desirable / profitable for SPIR-V, as it can leverage info that might subsequently be lost as transforms are applied to the IR/resulting SPIR-V. Thi

[clang] [clang][DebugInfo] Revert to printing canonical typenames for template aliases (PR #110767)

2024-10-02 Thread via cfe-commits
jimingham wrote: > On Oct 2, 2024, at 9:22 AM, David Blaikie ***@***.***> wrote: > > > Not quite sure how we get to caching and template specializations and pretty > printers. > > If we're still producing the typedef-style DWARF for these alias template > specializations - perhaps lldb cou

[clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

2024-10-02 Thread Sean Perry via cfe-commits
perry-ca wrote: > > sorry this is same as #107906 (with a bigger impact radius, as you're also > > changing getBufferForFile) and doesn't address any of the issues mention > > about explaining the semantics of `IsText` or justification for changing > > the core VFS interfaces, for an operation

[clang-tools-extra] [clang-tidy] Create bugprone-bit-cast-pointers check (PR #108083)

2024-10-02 Thread Julian Schmidt via cfe-commits
5chmidti wrote: > What about `bugprone-bitwise-pointer-copy` @5chmidti ? > `bugprone-bitwise-pointer-cast` could work as well Both sound good to me. https://github.com/llvm/llvm-project/pull/108083 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] 694fd1f - Allow tag-based API notes on anonymous tag decls with typedef names

2024-10-02 Thread via cfe-commits
Author: Doug Gregor Date: 2024-10-02T18:21:23+01:00 New Revision: 694fd1f297feaf59cd29a3d17e63ee2f6514dd16 URL: https://github.com/llvm/llvm-project/commit/694fd1f297feaf59cd29a3d17e63ee2f6514dd16 DIFF: https://github.com/llvm/llvm-project/commit/694fd1f297feaf59cd29a3d17e63ee2f6514dd16.diff L

[clang-tools-extra] [clang-tidy][readability-container-contains] Fix matching of non-binaryOperator cases (PR #110386)

2024-10-02 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/110386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Allow tag-based API notes on anonymous tag decls with typedef names (PR #110768)

2024-10-02 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan closed https://github.com/llvm/llvm-project/pull/110768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][opt][Transforms][SPIR-V] Enable `InferAddressSpaces` for SPIR-V (PR #110897)

2024-10-02 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/110897 >From 9f3cac44dde7d0adcf6cd090c0b91f57cb1c4dca Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Wed, 2 Oct 2024 11:18:36 +0100 Subject: [PATCH 1/2] Enable `InferAddressSpaces` for SPIR-V. --- .../amdgpu-kernel-

[clang] [clang-tools-extra] [RecursiveASTVisitor] Skip implicit instantiations. (PR #110899)

2024-10-02 Thread Harald van Dijk via cfe-commits
https://github.com/hvdijk created https://github.com/llvm/llvm-project/pull/110899 In DEF_TRAVERSE_TMPL_SPEC_DECL, we attempted to skip implicit instantiations by detecting that D->getTemplateArgsAsWritten() returns nullptr, but as this test shows, it is possible for that to return a non-null

[clang] [clang-tools-extra] [RecursiveASTVisitor] Skip implicit instantiations. (PR #110899)

2024-10-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-tools-extra Author: Harald van Dijk (hvdijk) Changes In DEF_TRAVERSE_TMPL_SPEC_DECL, we attempted to skip implicit instantiations by detecting that D->getTemplateArgsAsWritten() returns nullptr, but as this test shows,

[clang] [clang-tools-extra] [RecursiveASTVisitor] Skip implicit instantiations. (PR #110899)

2024-10-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Harald van Dijk (hvdijk) Changes In DEF_TRAVERSE_TMPL_SPEC_DECL, we attempted to skip implicit instantiations by detecting that D->getTemplateArgsAsWritten() returns nullptr, but as this test shows, it is possible for that to return

[clang] [clang-tools-extra] [lldb] [llvm] Propagate IsText parameter to openFileForRead function (PR #110661)

2024-10-02 Thread Abhina Sree via cfe-commits
abhina-sree wrote: > > sorry this is same as #107906 (with a bigger impact radius, as you're also > > changing getBufferForFile) and doesn't address any of the issues mention > > about explaining the semantics of `IsText` or justification for changing > > the core VFS interfaces, for an operat

[clang-tools-extra] [llvm] [clangd] Add CodeAction to swap operands to binary operators (PR #78999)

2024-10-02 Thread Tor Shepherd via cfe-commits
torshepherd wrote: I'll try to rectify this; for now you can add tor [dot] aksel [dot] shepherd [at] gmail [dot] com https://github.com/llvm/llvm-project/pull/78999 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang-tools-extra] [clang-tidy] exclude CXXParenListInitExpr from RedundantCastingCheck (PR #109741)

2024-10-02 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti approved this pull request. https://github.com/llvm/llvm-project/pull/109741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5e92bfe - [OpenACC] Check Loop counts for 'collapse' clause. (#110851)

2024-10-02 Thread via cfe-commits
Author: Erich Keane Date: 2024-10-02T10:33:49-07:00 New Revision: 5e92bfe97fe0f72f3052df53f813d8dcbb7038d3 URL: https://github.com/llvm/llvm-project/commit/5e92bfe97fe0f72f3052df53f813d8dcbb7038d3 DIFF: https://github.com/llvm/llvm-project/commit/5e92bfe97fe0f72f3052df53f813d8dcbb7038d3.diff L

[clang] [llvm] [llvm][opt][Transforms][SPIR-V] Enable `InferAddressSpaces` for SPIR-V (PR #110897)

2024-10-02 Thread Matt Arsenault via cfe-commits
@@ -91,6 +97,88 @@ SPIRVTargetMachine::SPIRVTargetMachine(const Target &T, const Triple &TT, setRequiresStructuredCFG(false); } +enum AddressSpace { + Function = storageClassToAddressSpace(SPIRV::StorageClass::Function), + CrossWorkgroup = + storageClassToAddressSpac

[clang] [llvm] [llvm][opt][Transforms][SPIR-V] Enable `InferAddressSpaces` for SPIR-V (PR #110897)

2024-10-02 Thread Matt Arsenault via cfe-commits
@@ -178,6 +266,9 @@ void SPIRVPassConfig::addIRPasses() { addPass(createSPIRVStructurizerPass()); } + if (TM.getOptLevel() > CodeGenOptLevel::None) +addPass(createInferAddressSpacesPass(AddressSpace::Generic)); arsenm wrote: Not sure why this is a

[clang] [llvm] [llvm][opt][Transforms][SPIR-V] Enable `InferAddressSpaces` for SPIR-V (PR #110897)

2024-10-02 Thread Matt Arsenault via cfe-commits
@@ -91,6 +97,88 @@ SPIRVTargetMachine::SPIRVTargetMachine(const Target &T, const Triple &TT, setRequiresStructuredCFG(false); } +enum AddressSpace { + Function = storageClassToAddressSpace(SPIRV::StorageClass::Function), + CrossWorkgroup = + storageClassToAddressSpac

[clang] [llvm] [llvm][opt][Transforms][SPIR-V] Enable `InferAddressSpaces` for SPIR-V (PR #110897)

2024-10-02 Thread Matt Arsenault via cfe-commits
@@ -91,6 +97,88 @@ SPIRVTargetMachine::SPIRVTargetMachine(const Target &T, const Triple &TT, setRequiresStructuredCFG(false); } +enum AddressSpace { + Function = storageClassToAddressSpace(SPIRV::StorageClass::Function), + CrossWorkgroup = + storageClassToAddressSpac

[clang] [llvm] [llvm][opt][Transforms][SPIR-V] Enable `InferAddressSpaces` for SPIR-V (PR #110897)

2024-10-02 Thread Matt Arsenault via cfe-commits
@@ -91,6 +97,88 @@ SPIRVTargetMachine::SPIRVTargetMachine(const Target &T, const Triple &TT, setRequiresStructuredCFG(false); } +enum AddressSpace { + Function = storageClassToAddressSpace(SPIRV::StorageClass::Function), + CrossWorkgroup = + storageClassToAddressSpac

[clang] [clang][dataflow] Add a test demonstrating an issue in unchecked-optional-access-check (PR #110870)

2024-10-02 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. https://github.com/llvm/llvm-project/pull/110870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][opt][Transforms][SPIR-V] Enable `InferAddressSpaces` for SPIR-V (PR #110897)

2024-10-02 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,29 @@ +; NOTE: Assertions have been autogenerated by utils/update_test_checks.py arsenm wrote: You don't need to duplicate all of these tests. You just need some basic samples that the target is implemented, the full set is testing pass mechanics whi

[clang] [llvm] [InstrPGO] Instrument sampling profile based cold function (PR #109837)

2024-10-02 Thread Snehasish Kumar via cfe-commits
@@ -1784,6 +1784,12 @@ defm debug_info_for_profiling : BoolFOption<"debug-info-for-profiling", PosFlag, NegFlag>; +def fprofile_generate_cold_function_coverage : Flag<["-"], "fprofile-generate-cold-function-coverage">, snehasish wrote: > also to central

[clang-tools-extra] [clang-tidy] Create bugprone-bitwise-pointer-cast check (PR #108083)

2024-10-02 Thread Carlos Galvez via cfe-commits
https://github.com/carlosgalvezp updated https://github.com/llvm/llvm-project/pull/108083 >From 1b1d54e0ce0d0bc4250ff045840b0a0a7bac59a1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Carlos=20G=C3=A1lvez?= Date: Tue, 10 Sep 2024 13:46:51 + Subject: [PATCH] [clang-tidy] Create bugprone-bitwise-po

[clang] [flang] [llvm] [openmp] [flang][driver] rename flang-new to flang (PR #110023)

2024-10-02 Thread Håkon Strandenes via cfe-commits
@@ -339,11 +335,11 @@ just added using your new frontend option. ## CMake Support As of [#7246](https://gitlab.kitware.com/cmake/cmake/-/merge_requests/7246) -(and soon to be released CMake 3.24.0), `cmake` can detect `flang-new` as a +(and soon to be released CMake 3.24.0), `

  1   2   3   4   5   >