[clang] [llvm] [DirectX] Start documenting DXIL Resource handling (PR #90553)

2024-07-16 Thread Chris B via cfe-commits
@@ -0,0 +1,425 @@ +== +DXIL Resource Handling +== + +.. contents:: + :local: + +.. toctree:: + :hidden: + +Introduction + + +Resources in DXIL are represented via ``TargetExtType`` in LLVM IR and +eventually lowered by the Di

[clang] [llvm] [AArch64] Implement intrinsics for SME2 FAMIN/FAMAX (PR #99063)

2024-07-16 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov created https://github.com/llvm/llvm-project/pull/99063 This patch implements these intrinsics: ``` c // Variants are also available for: // [_f32_x2], [_f64_x2], // [_f16_x4], [_f32_x4], [_f64_x4] svfloat16x2_t svamax[_f16_x2](svfloat16x2 zd, svfloa

[clang] [llvm] [AArch64] Implement intrinsics for SME2 FAMIN/FAMAX (PR #99063)

2024-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Momchil Velikov (momchil-velikov) Changes This patch implements these intrinsics: ``` c // Variants are also available for: // [_f32_x2], [_f64_x2], // [_f16_x4], [_f32_x4], [_f64_x4] svfloat16x2_t svamax[_f16_x2](svfloat16x2 zd,

[clang] [llvm] [AArch64] Implement intrinsics for SME2 FAMIN/FAMAX (PR #99063)

2024-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Author: Momchil Velikov (momchil-velikov) Changes This patch implements these intrinsics: ``` c // Variants are also available for: // [_f32_x2], [_f64_x2], // [_f16_x4], [_f32_x4], [_f64_x4] svfloat16x2_t svamax[_f16_x2](svflo

[clang-tools-extra] [clang-doc] add ftime profiling (PR #97644)

2024-07-16 Thread Paul Kirth via cfe-commits
@@ -670,6 +671,7 @@ llvm::Error ClangDocBitcodeReader::readRecord(unsigned ID, T I) { template <> llvm::Error ClangDocBitcodeReader::readRecord(unsigned ID, Reference *I) { + llvm::TimeTraceScope("Reducing infos", "readRecord"); ilovepi wrote: I know this i

[clang-tools-extra] [clang-doc] add ftime profiling (PR #97644)

2024-07-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi edited https://github.com/llvm/llvm-project/pull/97644 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] add ftime profiling (PR #97644)

2024-07-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. LGTM modulo a small nit in the naming, we can always add more instrumentation if we need it, but this is a good start. https://github.com/llvm/llvm-project/pull/97644 ___ cfe-commits mailing list

[clang-tools-extra] [clang-doc] Improve performance by adding a short circuit (PR #96809)

2024-07-16 Thread Paul Kirth via cfe-commits
ilovepi wrote: > When sorted by USR, there are no differences between the index between this > patch and what's on main, I'm not sure I completely follow. are you saying that when you sort the contents of all the files you no longer have any differences? So you're sure the only differences i

[clang] [clang] Limit alignment for emitted vectors (PR #98629)

2024-07-16 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic commented: What's the relationship between the max vector alignment, and choosing whether to return a vector directly? As long as clang isn't emitting the byval attribute, I don't think it's the frontend's problem. https://github.com/llvm/llvm-project/pull/986

[clang] [llvm] [RISCV][FMV] Support target_version (PR #99040)

2024-07-16 Thread Craig Topper via cfe-commits
@@ -0,0 +1,8 @@ +// RUN: not %clang_cc1 -triple riscv64 -target-feature +i -emit-llvm -o - %s 2>&1 | FileCheck %s --check-prefix=CHECK-UNSUPPORT-OS topperc wrote: "invalid" in test name is misspelled https://github.com/llvm/llvm-project/pull/99040 _

[clang] [llvm] [PAC][Driver] Support `pauthtest` ABI for AArch64 Linux triples (PR #97237)

2024-07-16 Thread Anton Korobeynikov via cfe-commits
@@ -324,6 +324,9 @@ ARMTargetInfo::ARMTargetInfo(const llvm::Triple &Triple, case llvm::Triple::GNU: setABI("apcs-gnu"); break; +case llvm::Triple::PAuthTest: asl wrote: Do we really need to touch 32-bit ARM? https://github.com/llvm/llvm-p

[clang] [Clang] Protect ObjCMethodList assignment operator against self-assignment (PR #97933)

2024-07-16 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann commented: As far as I can tell, `ObjCMethodList` is already self-assignment safe so long as `PointerIntPair` is. It looks like the latter might not be though since its copy assignment operator (as implemented via `PunnedPointer`) uses `memcpy` and it does not gu

[clang] [clang] Prevent dangling StringRefs (PR #98699)

2024-07-16 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: This LGTM but when someone blocks you should wait for approval before landing the change. https://github.com/llvm/llvm-project/pull/98699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [clang] Prevent dangling StringRefs (PR #98699)

2024-07-16 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/98699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-16 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space approved this pull request. https://github.com/llvm/llvm-project/pull/99058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Prevent null pointer dereference in TransformUnaryTransformType() (PR #97912)

2024-07-16 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann approved this pull request. Looks good! Thanks @smanna12! https://github.com/llvm/llvm-project/pull/97912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Prevent null pointer dereference in TransformUnaryTransformType() (PR #97912)

2024-07-16 Thread via cfe-commits
smanna12 wrote: Thank you @tahonermann for reviews! https://github.com/llvm/llvm-project/pull/97912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ca61bdd - [Clang] Prevent null pointer dereference in TransformUnaryTransformType() (#97912)

2024-07-16 Thread via cfe-commits
Author: smanna12 Date: 2024-07-16T12:24:57-05:00 New Revision: ca61bdde476aae4d179f16561ce4d245df9f0fdf URL: https://github.com/llvm/llvm-project/commit/ca61bdde476aae4d179f16561ce4d245df9f0fdf DIFF: https://github.com/llvm/llvm-project/commit/ca61bdde476aae4d179f16561ce4d245df9f0fdf.diff LOG:

[clang] [Clang] Prevent null pointer dereference in TransformUnaryTransformType() (PR #97912)

2024-07-16 Thread via cfe-commits
https://github.com/smanna12 closed https://github.com/llvm/llvm-project/pull/97912 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [test] Precommit tests for PR96025, NFC (PR #98704)

2024-07-16 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM Please don't use `[test]` as a prefix in commit messages; just use the same prefix you'd use for the code change, e.g. `[clang codegen]` https://github.com/llvm/llvm-project/pull/98704 ___

[clang] [clang][NFC] Move more functions from `Sema` to `SemaObjC` (PR #97172)

2024-07-16 Thread John McCall via cfe-commits
rjmccall wrote: I agree that blocks don't belong in the ObjC segment. https://github.com/llvm/llvm-project/pull/97172 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove unnecessary copy (PR #97902)

2024-07-16 Thread via cfe-commits
https://github.com/smanna12 updated https://github.com/llvm/llvm-project/pull/97902 >From 1f80c0a172b58ad15d6b1dce02b63ac682bc7dc0 Mon Sep 17 00:00:00 2001 From: "Manna, Soumi" Date: Sat, 6 Jul 2024 09:03:15 -0700 Subject: [PATCH 1/5] [Clang] Remove unnecessary copy Reported by Static Analyzer

[clang] [Clang] Remove unnecessary copy (PR #97902)

2024-07-16 Thread via cfe-commits
@@ -1551,7 +1551,7 @@ ASTNodeImporter::VisitCountAttributedType(const CountAttributedType *T) { Expr *CountExpr = importChecked(Err, T->getCountExpr()); SmallVector CoupledDecls; - for (auto TI : T->dependent_decls()) { + for (const TypeCoupledDeclRefInfo &TI : T->depen

[clang] [Clang] Remove unnecessary copy (PR #97902)

2024-07-16 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/97902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] C++20 Coroutines: Introduce Frontend Attribute [[clang::coro_inplace_task]] (PR #98971)

2024-07-16 Thread Yuxuan Chen via cfe-commits
yuxuanchen1997 wrote: @ChuanqiXu9 > I feel the name `[[coro_inplace_task]]` is not so good. Since it doesn't > happen unconditionally. It happens conditionally. I still want to try to make > it clear in the name. I still like names like `[[coro_elide_after_await]]`, > which I feel is more cl

[clang] [Clang] Protect ObjCMethodList assignment operator against self-assignment (PR #97933)

2024-07-16 Thread via cfe-commits
smanna12 wrote: > As far as I can tell, `ObjCMethodList` is already self-assignment safe so > long as `PointerIntPair` is. It looks like the latter might not be though > since its copy assignment operator (as implemented via `PunnedPointer`) uses > `memcpy` and it does not guard against self-a

[clang] [Parser][ObjC] Add -Wobjc-prefix-length warning option. (PR #97597)

2024-07-16 Thread Alastair Houghton via cfe-commits
https://github.com/al45tair updated https://github.com/llvm/llvm-project/pull/97597 >From c11624370bf5615c7902993052435b92ae50b41b Mon Sep 17 00:00:00 2001 From: Alastair Houghton Date: Wed, 3 Jul 2024 17:00:51 +0100 Subject: [PATCH 1/7] [Parser][ObjC] Add -Wobjc-prefix-length warning option.

[clang] [Clang] Fix null pointer dereference in enum debug info generation (PR #97105)

2024-07-16 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann approved this pull request. Thanks @smanna12. I think this looks ok; returning null here does appear to be consistent with other overloads of `CreateTypeDefinition` for `RecordType` and `ObjCInterfaceType`. I agree with @Michael137 that it would be nice to have an

[clang] [clang] Add deprecation warning for `-Ofast` driver option (PR #98736)

2024-07-16 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Could you add a flang driver test as well? The RFC was specifically about `-Ofast` in Clang and not behavior in Flang, so what test behavior would you like to see? This patch currently deprecates for both Clang and Flang, is that acceptable? https://github.com/llvm/llvm-

[clang-tools-extra] Add support for std::rotate(_copy) and inplace_merge to modernize-use-ranges (PR #99057)

2024-07-16 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. LGTM, some tests for rotate_copy and implace_merge would be welcome but it isn't must as it work similar to rotate. https://github.com/llvm/llvm-project/pull/99057 ___ cfe-commits mailing list cf

[clang] [Clang] C++20 Coroutines: Introduce Frontend Attribute [[clang::coro_inplace_task]] (PR #98971)

2024-07-16 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 updated https://github.com/llvm/llvm-project/pull/98971 >From 628f30e84d8b5a708f3a88576d18f290429e4c88 Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Tue, 4 Jun 2024 23:22:00 -0700 Subject: [PATCH] [Clang] Introduce [[clang::coro_inplace_task]] Implement noa

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-16 Thread David Truby via cfe-commits
DavidTruby wrote: I don't know why the pre-commit build failed on Windows. The build itself looks fine but seems to be complaining about slow tests? https://github.com/llvm/llvm-project/pull/99058 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [llvm] [RISCV] Add capital letters to T-Head extension names in descriptions. (PR #99070)

2024-07-16 Thread Craig Topper via cfe-commits
https://github.com/topperc created https://github.com/llvm/llvm-project/pull/99070 This matches their documentation and the capitalization we use for the RISCVSubtarget methods. >From 40ee0ece0118bd074919b88fc404446e6db4df46 Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Tue, 16 Jul 2024 1

[clang] [llvm] [RISCV] Add capital letters to T-Head extension names in descriptions. (PR #99070)

2024-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v @llvm/pr-subscribers-clang Author: Craig Topper (topperc) Changes This matches their documentation and the capitalization we use for the RISCVSubtarget methods. --- Full diff: https://github.com/llvm/llvm-project/pull/99070.diff 3 File

[clang] [Clang] Fix potential null pointer dereferences in Sema::AddInitializerToDecl (PR #94368)

2024-07-16 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann edited https://github.com/llvm/llvm-project/pull/94368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix potential null pointer dereferences in Sema::AddInitializerToDecl (PR #94368)

2024-07-16 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann commented: Thanks @smanna12. I'm uncertain about this change; see my additional comment. https://github.com/llvm/llvm-project/pull/94368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] [Clang] Fix potential null pointer dereferences in Sema::AddInitializerToDecl (PR #94368)

2024-07-16 Thread Tom Honermann via cfe-commits
@@ -13681,12 +13681,13 @@ void Sema::AddInitializerToDecl(Decl *RealDecl, Expr *Init, bool DirectInit) { } Init = Result.getAs(); +assert(Init && "Init must not be null"); + IsParenListInit = !InitSeq.steps().empty() && InitSeq.step_beg

[clang] [llvm] [DirectX] Start documenting DXIL Resource handling (PR #90553)

2024-07-16 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/90553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Finish deleting the le32/le64 targets (PR #98497)

2024-07-16 Thread Steven Johnson via cfe-commits
steven-johnson wrote: After some initial experiments, it looks unlikely that a quick fix is possible on our side. May I suggest a revert with a (say) 30-day expiration date? That should give us enough time to come up with a fix on our side (which will actually be a drop-other-work-and-fix-it a

[clang] [llvm] [msan] Precommit MSan Arm NEON vst tests (PR #98247)

2024-07-16 Thread Thurston Dang via cfe-commits
thurstond wrote: Updated to IR tests https://github.com/llvm/llvm-project/pull/98247 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-16 Thread Carlos Seo via cfe-commits
ceseo wrote: > I don't know why the pre-commit build failed on Windows. The build itself > looks fine but seems to be complaining about slow tests? Actually, the error is here: ``` FAIL: Flang :: Driver/linker-flags.f90 (218 of 2807) TEST 'Flang :: Driver/linker-flags.f90'

[clang] The pragma STDC CX_LIMITED_RANGE ON should have precedence. (PR #98520)

2024-07-16 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/98520 >From da863999000a6b12f2930247de9df3daf0e5a608 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 11 Jul 2024 11:54:13 -0700 Subject: [PATCH 1/7] The pragma STDC CX_LIMITED_RANGE ON should have prece

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-16 Thread Carlos Seo via cfe-commits
https://github.com/ceseo commented: linker-flags test seems to be failing on Windows. https://github.com/llvm/llvm-project/pull/99058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add capital letters to T-Head extension names in descriptions. (PR #99070)

2024-07-16 Thread Philip Reames via cfe-commits
https://github.com/preames approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/99070 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Prevent null pointer dereference in designated initializer check (PR #97220)

2024-07-16 Thread via cfe-commits
https://github.com/smanna12 updated https://github.com/llvm/llvm-project/pull/97220 >From 63f45c952ff8ab7df261a150355a34267e4a645c Mon Sep 17 00:00:00 2001 From: "Manna, Soumi" Date: Sun, 30 Jun 2024 08:40:27 -0700 Subject: [PATCH 1/4] [Clang] Prevent null pointer dereference in designated ini

[clang] [clang] replaced the usage of `asctime` with `strftime` (PR #99075)

2024-07-16 Thread Yi-Chi Lee via cfe-commits
https://github.com/yichi170 created https://github.com/llvm/llvm-project/pull/99075 In `clang/lib/Lex/PPMacroExpansion.cpp`, replaced the usage of the obsolete `asctime` function with `strftime` for generating timestamp strings. This is my first time contributing to an open-source project. If

[clang] [clang] replaced the usage of `asctime` with `strftime` (PR #99075)

2024-07-16 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang] replaced the usage of `asctime` with `strftime` (PR #99075)

2024-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yi-Chi Lee (yichi170) Changes In `clang/lib/Lex/PPMacroExpansion.cpp`, replaced the usage of the obsolete `asctime` function with `strftime` for generating timestamp strings. This is my first time contributing to an open-source project. I

[clang] [Clang] Prevent null pointer dereference in designated initializer check (PR #97220)

2024-07-16 Thread via cfe-commits
@@ -3206,9 +3206,11 @@ ExprResult SemaObjC::BuildInstanceMessage( } if (!isDesignatedInitChain) { const ObjCMethodDecl *InitMethod = nullptr; + auto *CurMD = SemaRef.getCurMethodDecl(); + if (!CurMD) +return ExprResult((Expr *)nullptr); -

[clang] [clang] Diagnose use of deprecated template alias (PR #97619)

2024-07-16 Thread via cfe-commits
https://github.com/premanandrao updated https://github.com/llvm/llvm-project/pull/97619 >From e1076942f07b1d2de857688c88de6ff966861650 Mon Sep 17 00:00:00 2001 From: Premanand M Rao Date: Wed, 3 Jul 2024 11:20:42 -0700 Subject: [PATCH 1/2] [clang] Diagnose use of deprecated template alias Issu

[clang] The pragma STDC CX_LIMITED_RANGE ON should have precedence. (PR #98520)

2024-07-16 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/98520 >From da863999000a6b12f2930247de9df3daf0e5a608 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 11 Jul 2024 11:54:13 -0700 Subject: [PATCH 1/8] The pragma STDC CX_LIMITED_RANGE ON should have prece

[clang] [clang] Diagnose use of deprecated template alias (PR #97619)

2024-07-16 Thread via cfe-commits
@@ -0,0 +1,58 @@ +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s +// +// This test checks that a deprecated attribute on an alias +// template triggers a warning diagnostic when it is used. + +template +struct NoAttr { + void foo() {} +}; + +// expected-note@+2 5{{'Using

[clang] [Clang] Prevent null pointer dereference in designated initializer check (PR #97220)

2024-07-16 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/97220 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix smart pointers handling in bugprone-use-after-move (PR #94869)

2024-07-16 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL updated https://github.com/llvm/llvm-project/pull/94869 >From ceeb4006d54b40a226a7a1f4f78f7f5f9d9dd7a1 Mon Sep 17 00:00:00 2001 From: Piotr Zegar Date: Tue, 16 Jul 2024 18:34:25 + Subject: [PATCH] [clang-tidy] Fix smart pointers handling in bugprone-use-after-mo

[clang-tools-extra] [clang-tidy] Fix smart pointers handling in bugprone-use-after-move (PR #94869)

2024-07-16 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/94869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add deprecation warning for `-Ofast` driver option (PR #98736)

2024-07-16 Thread Kiran Chandramohan via cfe-commits
kiranchandramohan wrote: > > Could you add a flang driver test as well? > > The RFC was specifically about `-Ofast` in Clang and not behavior in Flang, > so what test behavior would you like to see? This patch currently deprecates > for both Clang and Flang, is that acceptable? I was asking f

[clang] [clang] Add deprecation warning for `-Ofast` driver option (PR #98736)

2024-07-16 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > > Could you add a flang driver test as well? > > > > > > The RFC was specifically about `-Ofast` in Clang and not behavior in Flang, > > so what test behavior would you like to see? This patch currently > > deprecates for both Clang and Flang, is that acceptable? > >

[clang] [llvm] Finish deleting the le32/le64 targets (PR #98497)

2024-07-16 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > After some initial experiments, it looks unlikely that a quick fix is > possible on our side. May I suggest a revert with a (say) 30-day expiration > date? That should give us enough time to come up with a fix on our side > (which will actually be a drop-other-work-and-fi

[clang] d3f8105 - Revert "Finish deleting the le32/le64 targets" (#99079)

2024-07-16 Thread via cfe-commits
Author: Aaron Ballman Date: 2024-07-16T14:47:09-04:00 New Revision: d3f8105c65046173e20c4c59394b4a7f1bbe7627 URL: https://github.com/llvm/llvm-project/commit/d3f8105c65046173e20c4c59394b4a7f1bbe7627 DIFF: https://github.com/llvm/llvm-project/commit/d3f8105c65046173e20c4c59394b4a7f1bbe7627.diff

[clang] [llvm] Revert "Finish deleting the le32/le64 targets" (PR #99079)

2024-07-16 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/99079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Revert "Finish deleting the le32/le64 targets" (PR #99079)

2024-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes Reverts llvm/llvm-project#98497 We're reverting this for approx 30 days so that the Halide project has time to transition off the target. --- Full diff: https://gith

[clang] [llvm] Finish deleting the le32/le64 targets (PR #98497)

2024-07-16 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: d3f8105c65046173e20c4c59394b4a7f1bbe7627 restores the targets, thank you all for the discussion! https://github.com/llvm/llvm-project/pull/98497 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [llvm] Finish deleting the le32/le64 targets (PR #98497)

2024-07-16 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: > I was under the impression those bits were still needed for Chromium. CC > @dschuff Oh, clang/lib/CodeGen/Targets/PNaCl.cpp is still live for mipsel-nacl target triple. Which we also have zero tests for, but I guess that's a separate issue. https://github.com/llvm/llvm

[clang] [llvm] [Inliner] Propagate more attributes to params when inlining (PR #91101)

2024-07-16 Thread Yingwei Zheng via cfe-commits
dtcxzyw wrote: I don't see any performance benefits based on IR diff or instruction count. Changes on code size are mainly affected by JumpThreading/Inlining. But I don't object to propagating more attributes if the compile-time impact is negligible :) https://github.com/llvm/llvm-project/p

[clang-tools-extra] Add support for std::rotate(_copy) and inplace_merge to modernize-use-ranges (PR #99057)

2024-07-16 Thread Nathan James via cfe-commits
njames93 wrote: > LGTM, some tests for rotate_copy and implace_merge would be welcome but it > isn't must as it work similar to rotate. Yeah, like with the other supported algorithms, I didn't see the need to add a test for every single function, as long as there's a test for each kind of fun

[clang] Fix assertion failure during conversion function overload resolution. (PR #98671)

2024-07-16 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov approved this pull request. LGTM as well https://github.com/llvm/llvm-project/pull/98671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Refactor uses of `Cand->Function` in SemaOverload.cpp (PR #98965)

2024-07-16 Thread via cfe-commits
vortex73 wrote: @haberman Please review. https://github.com/llvm/llvm-project/pull/98965 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add BinPackBinaryOperations configuration (PR #95013)

2024-07-16 Thread Björn Schäpers via cfe-commits
HazardyKnusperkeks wrote: > It seems that this patch implements the new option without regard to the > relative precedence of the binary operators: > > ``` > $ cat bar.cc > f1 = f2 * f3 + > f4 / f5 - f6; >

[clang] [clang][driver] Support `--precompile` and `-fmodule-*` options in Clang-CL (PR #98761)

2024-07-16 Thread Sharadh Rajaraman via cfe-commits
https://github.com/sharadhr updated https://github.com/llvm/llvm-project/pull/98761 >From 1fed92a00f0d732a2575861c2bf6a6d053407255 Mon Sep 17 00:00:00 2001 From: Sharadh Rajaraman Date: Sat, 13 Jul 2024 19:25:47 +0100 Subject: [PATCH 1/4] Allow `--precompile` and `-fprebuilt-module-path` to be

[clang-tools-extra] Ensure functions are anchored in the global namespace (PR #99084)

2024-07-16 Thread via cfe-commits
https://github.com/matthew-f created https://github.com/llvm/llvm-project/pull/99084 The regular expressions match functions that aren't anchored in the global namespace. For example `::connect` matches `QObject::connect` This change is to remove these false positives >From d5aa95877b2c33189b

[clang-tools-extra] Ensure functions are anchored in the global namespace (PR #99084)

2024-07-16 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang-tools-extra] Ensure functions are anchored in the global namespace (PR #99084)

2024-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: None (matthew-f) Changes The regular expressions match functions that aren't anchored in the global namespace. For example `::connect` matches `QObject::connect` This change is to remove these false positives --- Full diff: h

[clang] [clang] Ensure pointers passed to runtime support functions are correctly signed (PR #98276)

2024-07-16 Thread Anton Korobeynikov via cfe-commits
@@ -333,7 +338,8 @@ void CodeGenFunction::registerGlobalDtorWithLLVM(const VarDecl &VD, llvm::FunctionCallee Dtor, llvm::Constant *Addr) { // Create a function which calls the d

[clang] [clang] Ensure pointers passed to runtime support functions are correctly signed (PR #98276)

2024-07-16 Thread Anton Korobeynikov via cfe-commits
https://github.com/asl approved this pull request. https://github.com/llvm/llvm-project/pull/98276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PAC][Driver] Support `pauthtest` ABI for AArch64 Linux triples (PR #97237)

2024-07-16 Thread Daniil Kovalev via cfe-commits
https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/97237 >From 3b4b1b1739b810d758e68f30c48b648963cff740 Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Mon, 1 Jul 2024 00:50:21 +0300 Subject: [PATCH 1/7] [PAC][Driver] Implement `-mbranch-protection=pauthabi` opti

[clang] [llvm] [PAC][Driver] Support `pauthtest` ABI for AArch64 Linux triples (PR #97237)

2024-07-16 Thread Daniil Kovalev via cfe-commits
@@ -324,6 +324,9 @@ ARMTargetInfo::ARMTargetInfo(const llvm::Triple &Triple, case llvm::Triple::GNU: setABI("apcs-gnu"); break; +case llvm::Triple::PAuthTest: kovdan01 wrote: No, we do not need that, thanks for bringing attention to this.

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-16 Thread Kelvin Li via cfe-commits
kkwli wrote: The linker-flags test fails on AIX too. https://github.com/llvm/llvm-project/pull/99058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix a regression with alignas on structure members in C (PR #98642)

2024-07-16 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > The part I'm confused about is that this commit doesn't appear to simply be > adding "or `alignas`" to some code that said "if `_Alignas`". Yes, the newly > added `isAlignas()` checks do cover both attributes, but `_Alignas` was still > working even after > [b9cf7f1](htt

[clang] [llvm] Support for assume directive : Parse & AST modules (PR #97535)

2024-07-16 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: > In clang/lib/Sema/SemaOpenMP.cpp I have retained the marking of the inner > regions of the associated statements with AssumeAttr. This will make the work > in Codegen easier. How it will make the codegen easier? It is better to try to avoid post-building attribute assig

[clang] [clang] Add deprecation warning for `-Ofast` driver option (PR #98736)

2024-07-16 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/98736 >From 44b4a682f2b3d7e140f7b1bd124e7aabdbf439ad Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Sat, 13 Jul 2024 13:10:25 +0300 Subject: [PATCH 1/5] [clang] Add deprecation warning for `-Ofast` driver opt

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-16 Thread David Truby via cfe-commits
https://github.com/DavidTruby updated https://github.com/llvm/llvm-project/pull/99058 >From 66e13f92a0680742b552fabde25df7752f8510c9 Mon Sep 17 00:00:00 2001 From: David Truby Date: Tue, 16 Jul 2024 15:39:28 + Subject: [PATCH 1/2] [flang] Add -rtlib flag This patch allows the -rtlib flag w

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-16 Thread David Truby via cfe-commits
DavidTruby wrote: It looks like clang_rt.crtbegin and clang_rt.crtend aren't always used on every platform so I've just removed the check for those. The check for `libclang_rt.builtins` and NOT `libgcc` and `libgcc_s` should be enough to check we are linking the right thing. https://github.co

[clang] [clang][dataflow] Only propagate past CXXDefaultInitExpr if init is (PR #99236)

2024-07-16 Thread Samira Bazuzi via cfe-commits
https://github.com/bazuzi created https://github.com/llvm/llvm-project/pull/99236 rewritten. >From 7c75181c590f30cc439af6fa523f3ca78f8a933d Mon Sep 17 00:00:00 2001 From: Samira Bazuzi Date: Tue, 16 Jul 2024 16:25:32 -0400 Subject: [PATCH] [clang][dataflow] Only propagate past CXXDefaultInitEx

[clang] [clang][dataflow] Only propagate past CXXDefaultInitExpr if init is (PR #99236)

2024-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Samira Bazuzi (bazuzi) Changes rewritten. --- Full diff: https://github.com/llvm/llvm-project/pull/99236.diff 2 Files Affected: - (modified) clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp (+6-1) - (modified) clang/unittests/A

[clang] 9be5f4f - [DirectX] Start documenting DXIL Resource handling (#90553)

2024-07-16 Thread via cfe-commits
Author: Justin Bogner Date: 2024-07-16T13:42:55-07:00 New Revision: 9be5f4f5d5617d11e96fe53e8c3f463252486641 URL: https://github.com/llvm/llvm-project/commit/9be5f4f5d5617d11e96fe53e8c3f463252486641 DIFF: https://github.com/llvm/llvm-project/commit/9be5f4f5d5617d11e96fe53e8c3f463252486641.diff

[clang] [llvm] [DirectX] Start documenting DXIL Resource handling (PR #90553)

2024-07-16 Thread Justin Bogner via cfe-commits
https://github.com/bogner closed https://github.com/llvm/llvm-project/pull/90553 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Implement dynamic memory allocation handling (PR #70306)

2024-07-16 Thread Leandro Lupori via cfe-commits
luporl wrote: In my debug build, clang is receiving a SIGSEGV in frame 7 below (that is actually frame 0, as the frames below it are from a gdb call that received a signal). In it, `this` holds an invalid address. In frame 8, `NE` is 0x3fff, which probably caused the invalid access. In fram

[clang] [Clang SA]: add support for mismatched ownership_returns+ownership_takes calls for custom allocation classes (PR #98941)

2024-07-16 Thread Pavel Skripkin via cfe-commits
pskrgag wrote: Hello @steakhal, could you, please, take a look? I just found linked issue quite interesting and decided to give it a try. I am new to llvm world, so I would really appreciate your review https://github.com/llvm/llvm-project/pull/98941 _

[clang] [clang] Ensure pointers passed to runtime support functions are correctly signed (PR #98276)

2024-07-16 Thread Oliver Hunt via cfe-commits
ojhunt wrote: I notice the r+, but I haven't fully addressed this feedback - are you suggesting corrections in a follow up patch, or just conceptually approving with this PR? :D https://github.com/llvm/llvm-project/pull/98276 ___ cfe-commits mailing

[clang] [clang][dataflow] Only propagate past CXXDefaultInitExpr if init is (PR #99236)

2024-07-16 Thread Eli Friedman via cfe-commits
@@ -465,7 +465,12 @@ class ResultObjectVisitor : public AnalysisASTVisitor { } if (auto *DIE = dyn_cast(E)) { - PropagateResultObject(DIE->getExpr(), Loc); + // If it has a rewritten init, we should propagate to that. If it doesn't, + // then the CXXDe

[clang] [llvm] [Clang] C++20 Coroutines: Introduce Frontend Attribute [[clang::coro_inplace_task]] (PR #98971)

2024-07-16 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 updated https://github.com/llvm/llvm-project/pull/98971 >From d38f0608753417c6b79e0684cb9dc23933dc957b Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Tue, 4 Jun 2024 23:22:00 -0700 Subject: [PATCH] [Clang] Introduce [[clang::coro_inplace_task]] Implement noa

[clang] [NFCI][clang][analyzer] Make ProgramStatePartialTrait a template definition (PR #98150)

2024-07-16 Thread Endre Fülöp via cfe-commits
gamesh411 wrote: The warning just ''Type ProgramStatePartialTrait is incomplete", and to reproduce it here is minimal exmaple: `` https://github.com/llvm/llvm-project/pull/98150 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-16 Thread Carlos Seo via cfe-commits
https://github.com/ceseo approved this pull request. Yes, this should be enough. https://github.com/llvm/llvm-project/pull/99058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Ensure pointers passed to runtime support functions are correctly signed (PR #98276)

2024-07-16 Thread Anton Korobeynikov via cfe-commits
asl wrote: > I notice the r+, but I haven't fully addressed this feedback - are you > suggesting corrections in a follow up patch, or just conceptually approving > with this PR? :D I think this patch is fine to go as-is. We can re-consider that `MaybeSigned` abstraction further on if it could

[clang] [CMake][Fuchsia] Use escaped double quote (PR #99246)

2024-07-16 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek created https://github.com/llvm/llvm-project/pull/99246 Using single quotes made the build to break on Windows. >From 526401e3da96c366f04ba98cfb453a72fd67cc76 Mon Sep 17 00:00:00 2001 From: Petr Hosek Date: Tue, 16 Jul 2024 14:47:58 -0700 Subject: [PATCH] [CMake][F

[clang] [CMake][Fuchsia] Use escaped double quote (PR #99246)

2024-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Petr Hosek (petrhosek) Changes Using single quotes made the build to break on Windows. --- Full diff: https://github.com/llvm/llvm-project/pull/99246.diff 1 Files Affected: - (modified) clang/cmake/caches/Fuchsia-stage2.cmake (+2-2)

[clang] Implement resource binding type prefix mismatch diagnostic infrastructure (PR #97103)

2024-07-16 Thread Xiang Li via cfe-commits
@@ -459,7 +467,475 @@ void SemaHLSL::handleResourceClassAttr(Decl *D, const ParsedAttr &AL) { D->addAttr(HLSLResourceClassAttr::Create(getASTContext(), RC, ArgLoc)); } -void SemaHLSL::handleResourceBindingAttr(Decl *D, const ParsedAttr &AL) { +struct RegisterBindingFlags {

[clang] [CMake][Fuchsia] Use escaped double quote (PR #99246)

2024-07-16 Thread via cfe-commits
https://github.com/zeroomega approved this pull request. https://github.com/llvm/llvm-project/pull/99246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f761e50 - [CMake][Fuchsia] Use escaped double quote (#99246)

2024-07-16 Thread via cfe-commits
Author: Petr Hosek Date: 2024-07-16T14:58:33-07:00 New Revision: f761e50a98f4123f6a57d8e9c3be64e5e39a16fe URL: https://github.com/llvm/llvm-project/commit/f761e50a98f4123f6a57d8e9c3be64e5e39a16fe DIFF: https://github.com/llvm/llvm-project/commit/f761e50a98f4123f6a57d8e9c3be64e5e39a16fe.diff LO

[clang] [CMake][Fuchsia] Use escaped double quote (PR #99246)

2024-07-16 Thread via cfe-commits
https://github.com/zeroomega closed https://github.com/llvm/llvm-project/pull/99246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >