https://github.com/tahonermann approved this pull request.
Thanks @smanna12. I think this looks ok; returning null here does appear to be consistent with other overloads of `CreateTypeDefinition` for `RecordType` and `ObjCInterfaceType`. I agree with @Michael137 that it would be nice to have an example that fails the added condition. The code already checks for an incomplete type so is presumably intended to handle such types. Perhaps we are missing a test though? Presumably one that uses a forward declareable enum type? https://github.com/llvm/llvm-project/pull/97105 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
