njames93 wrote:

> LGTM, some tests for rotate_copy and implace_merge would be welcome but it 
> isn't must as it work similar to rotate.

Yeah, like with the other supported algorithms, I didn't see the need to add a 
test for every single function, as long as there's a test for each kind of 
function it should be ok 

https://github.com/llvm/llvm-project/pull/99057
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to