[clang] ef2b170 - [Sema][HLSL] Consolidate handling of HLSL attributes

Author: Justin Bogner Date: 2023-08-29T08:55:38-07:00 New Revision: ef2b1700f4648816e6a6ce27cfee1c501421ee50 URL: https://github.com/llvm/llvm-project/commit/ef2b1700f4648816e6a6ce27cfee1c501421ee50 DIFF: https://github.com/llvm/llvm-project/commit/ef2b1700f4648816e6a6ce27cfee1c501421ee50.diff

[PATCH] D158803: [Sema][HLSL] Consolidate handling of HLSL attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rGef2b1700f464: [Sema][HLSL] Consolidate handling of HLSL attributes (authored by bogner). Changed prior to commit: https://reviews.llvm.org/D158803?vs=554044&id=554379#toc Repository: rG LLVM Github M

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

v.g.vassilev updated this revision to Diff 554378. v.g.vassilev added a comment. Address review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159115/new/ https://reviews.llvm.org/D159115 Files: clang/lib/Interpreter/IncrementalExecutor.cpp clang/unittests/Interpreter/Inter

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

sammccall added a comment. In D158872#4624821 , @aaron.ballman wrote: > In D158872#4623193 , @danix800 > wrote: > >> In D158872#4622124 , >> @aaron.ballman wrote: >> >>

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

danix800 added inline comments. Comment at: clang/lib/StaticAnalyzer/Core/DynamicExtent.cpp:34 +if (auto SSize = +SVB.convertToArrayIndex(*Size).getAs()) + return *SSize; donat.nagy wrote: > I think it's a good convention if `getDynamicExtent

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

v.g.vassilev updated this revision to Diff 554385. v.g.vassilev marked an inline comment as done. v.g.vassilev added a comment. Address style comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159115/new/ https://reviews.llvm.org/D159115 Files: clang/lib/Interpreter/IncrementalEx

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

nickdesaulniers added a comment. I assume you plan to add some clang CodeGen tests at some point? Comment at: clang/lib/CodeGen/CGBuiltin.cpp:875-876 +if (auto *RD = DRE->getType()->getPointeeType()->getAsRecordDecl()) + for (FieldDecl *Field : RD->fields()) +

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

danix800 updated this revision to Diff 554383. danix800 added a comment. 1. Cleanup unnecessary undef/zero checking; 2. Use better defensive API for getting `ConstantArrayType`; 3. Comment on bool argument for readability; 4. Add more test for extent with offset cases. Repository: rG LLVM Gith

[PATCH] D158707: [analyzer] Fix a few size-type signedness inconsistency related to DynamicExtent

danix800 added a comment. In D158707#4621377 , @steakhal wrote: > In D158707#4621270 , @donat.nagy > wrote: > >> In D158707#4621135 , @steakhal >> wrote: >> >>> Oh, so w

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

xgupta added a comment. In D158540#4620286 , @NoumanAmir657 wrote: > @xgupta It passed the test cases now Thanks, I think we also want a note similar to MSVC diagnostic: (6): note: see reference to function 'Derived::Derived(void)' CHANGES SINCE LAS

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

aaron.ballman added a comment. In D158872#4625425 , @sammccall wrote: > In D158872#4624821 , @aaron.ballman > wrote: > >> In D158872#4623193 , @danix800 >> wrote: >> >>>

[PATCH] D137556: [POC] Clang implementation for AArch64 SME and SME2 builtins

sdesmalen updated this revision to Diff 554399. sdesmalen added a comment. Herald added a subscriber: qcolombet. The latest patch contains a number of fixes and has been rebased to a more recent commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D159118: [libc] Implement the 'clock()' function on the GPU

jhuber6 created this revision. jhuber6 added reviewers: arsenm, tra, JonChesterfield, jdoerfert, sivachandra, lntue, michaelrj. Herald added subscribers: libc-commits, tpr. Herald added projects: libc-project, All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, w

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl updated this revision to Diff 554401. AntonRydahl added a comment. After landing this patch, two of the unit tests broke aarch64 and Windows build bots. To avoid that, `// REQUIRES:` was added to the unit tests to ensure that they only run when the target triple is supported. Repos

[PATCH] D159118: [libc] Implement the 'clock()' function on the GPU

jdoerfert added inline comments. Comment at: libc/src/time/gpu/clock.cpp:61-62 +return clock_t(ticks / (GPU_CLOCKS_PER_SEC / CLOCKS_PER_SEC)); + else +return clock_t(ticks * (CLOCKS_PER_SEC / GPU_CLOCKS_PER_SEC)); +} Repository: rG LLVM Github Monor

[PATCH] D159118: [libc] Implement the 'clock()' function on the GPU

JonChesterfield added a comment. I think something needs to notice when clock_t is a different thing on the host and on the GPU for the offloading languages and complain, probably fatally. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159118/new/

[PATCH] D156565: Diagnose use of VLAs in C++ by default

aaron.ballman added a comment. I put up an RFC at https://discourse.llvm.org/t/rfc-diagnosing-use-of-vlas-in-c/73109 to reach a slightly wider audience for awareness. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156565/new/ https://reviews.llvm.org/D156565 __

[PATCH] D158869: [clang] Fix timing of propagation of MSInheritanceAttr for template instantiation declarations.

tahonermann updated this revision to Diff 554413. tahonermann marked an inline comment as done. tahonermann edited the summary of this revision. tahonermann added a comment. Address prior review feedback. This update also modifies the propagation of the `MSInheritanceAttr` attribute for explicit

[PATCH] D158808: [Clang] Modify Parser::ParseLambdaExpressionAfterIntroducer to check whether the lambda-declarator is valid

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158808/new/ https://reviews.llvm.org/D158808 ___ cfe-commits mailing list cfe-co

[PATCH] D158863: Implement the monolithic CI pipeline in the monorepo

ldionne updated this revision to Diff 554420. ldionne marked an inline comment as done. ldionne added a comment. Address review comments. I did some testing using GH PRs and this should work, but some tweaks might be necessary. After discussing with Mikhail, I'll merge this now and we can make t

[PATCH] D159103: [Driver][HLSL] Improve diagnostics for invalid shader model and stage

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:710-716 + "Shader model is required in target '%0' for DXIL generation">; +def err_drv_dxil_unsupported_shader_model : Error< + "Shader model '%0' in target '%1' is invalid for D

[PATCH] D158863: Implement the monolithic CI pipeline in the monorepo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf1a3d93581f: Implement the monolithic CI pipeline in the monorepo (authored by ldionne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D158472: [clang][Diagnostics] Emit fix-it hint separately on overload resolution failure

hazohelet added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158472/new/ https://reviews.llvm.org/D158472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

ellis added a comment. Thanks for working on this! I've added a few other reviewers that might be interested. In particular it might conflict with the stack D138846 IIRC It seems that the `__llvm_prf_names` is retained in this mode. What is the overhead of thi

[PATCH] D156616: [clang-tidy] Fix c_str() removal and cast addition when re-ordering arguments

mikecrowe added a comment. Thanks for the review and landing this. Mike. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156616/new/ https://reviews.llvm.org/D156616 ___ cfe-commits mailing list cfe-commi

[PATCH] D158688: [Driver,ARM,AArch64] Ignore -mbranch-protection= diagnostics for assembler input

MaskRay added a comment. In D158688#4624267 , @simon_tatham wrote: > The change LGTM, and "agree with gcc" seems like a reasonable justification > in this case. Thank you both! > But I'm curious more generally about what options should / shouldn't be

[PATCH] D159118: [libc] Implement the 'clock()' function on the GPU

jhuber6 updated this revision to Diff 554434. jhuber6 added a comment. Address nits and add static check for size of `clock_t` type. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159118/new/ https://reviews.llvm.org/D159118 Files: clang/lib/Head

[PATCH] D158778: [CUDA] Propagate __float128 support from the host.

tra added a subscriber: jhuber6. tra added a comment. In D158778#4624408 , @ABataev wrote: > Just checks removal should be fine Looks like OpenMP handles long double and __float128 differently -- it always insists on using the host's FP format for both.

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin created this revision. Herald added subscribers: ChuanqiXu, Anastasia. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Like concepts checking, a trailing return type of a lambda in a dependent

[PATCH] D159018: [clang][modules] Add a c23 module feature

This revision was automatically updated to reflect the committed changes. Closed by commit rGadb68c979d84: [clang][modules] Add a c23 module feature (authored by iana). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159018/new/ https://reviews.llvm.o

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin added a subscriber: beanz. cor3ntin added a comment. @beanz The changes to TreeTransform.h cause a lot of HLSL test failures similar to this one: clang: /home/cor3ntin/dev/compilers/LLVM/llvm-project/clang/lib/AST/ExprClassification.cpp:57: Cl clang::Expr::ClassifyImpl(clang::ASTCon

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

aaron.ballman added a subscriber: bogner. aaron.ballman added a comment. In D159126#4625911 , @cor3ntin wrote: > @beanz The changes to TreeTransform.h cause a lot of HLSL test failures > similar to this one: > > clang: > /home/cor3ntin/dev/compilers/L

[PATCH] D154287: [clang-tidy] Add modernize-use-std-format check

mikecrowe updated this revision to Diff 55. mikecrowe added a comment. Rebase and fix minor doc conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154287/new/ https://reviews.llvm.org/D154287 Files: clang-tools-extra/clang-tidy/moderni

[clang] adb68c9 - [clang][modules] Add a c23 module feature

Author: Ian Anderson Date: 2023-08-29T11:11:14-07:00 New Revision: adb68c979d846a55bef2ea8208a69565e8c1a833 URL: https://github.com/llvm/llvm-project/commit/adb68c979d846a55bef2ea8208a69565e8c1a833 DIFF: https://github.com/llvm/llvm-project/commit/adb68c979d846a55bef2ea8208a69565e8c1a833.diff

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

sammccall added a comment. Thanks for the history, I wasn't aware this was such a big deal for such a long time! In D158872#462 , @aaron.ballman wrote: >> A few ideas: >> >> - could we move these (and possibly other rarely-used matchers) to >> Obs

[PATCH] D158808: [Clang] Modify Parser::ParseLambdaExpressionAfterIntroducer to check whether the lambda-declarator is valid

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f30ef360127: [Clang] Modify Parser::ParseLambdaExpressionAfterIntroducer to check whether… (authored by shafik). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D157913: [Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu added a comment. > It seems that the `__llvm_prf_names` is retained in this mode. What is the > overhead of this section generally? Can we instead use debug info to lookup > function names? With debug info correlation enabled, `__llvm_prf_names` section will only contain functions nam

[PATCH] D154287: [clang-tidy] Add modernize-use-std-format check

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:168 +- New :doc:`modernize-use-std-format + ` check. Please keep alphabetical order (by check name) in this section. Repository: rG LLVM Github Monorepo CHANGES SINC

[clang] 6f30ef3 - [Clang] Modify Parser::ParseLambdaExpressionAfterIntroducer to check whether the lambda-declarator is valid

Author: Shafik Yaghmour Date: 2023-08-29T11:28:57-07:00 New Revision: 6f30ef360127ffb3346fd3d3e60a229ed44dc667 URL: https://github.com/llvm/llvm-project/commit/6f30ef360127ffb3346fd3d3e60a229ed44dc667 DIFF: https://github.com/llvm/llvm-project/commit/6f30ef360127ffb3346fd3d3e60a229ed44dc667.dif

[PATCH] D159051: [clang-format][NFC] Change EXPECT_EQ to verifyFormat or verifyNoChang

owenpan added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:23933 verifyNoChange("FOO(String-ized&Messy+But(: :Still)=Intentional);", Style); - EXPECT_EQ( - "FOO(String-ized&Messy+But\\(: :Still)=Intentional);", - format("FOO(String-ized&Messy+B

[PATCH] D157331: [clang] Implement C23

aaron.ballman added a comment. I have some suggested changes for the way we're checking and diagnosing unsuitable types; I've not tried my suggestions out though, so if you run into problems, please let me know. Comment at: clang/include/clang/AST/Type.h:2159 bool isEnumer

[PATCH] D158641: [AArch64][Android][DRAFT] Fix FMV ifunc resolver usage on old Android APIs.

enh added inline comments. Comment at: compiler-rt/lib/builtins/cpu_model.c:1382 +return; +#if defined(__ANDROID__) + // ifunc resolvers don't have hwcaps in arguments on Android API lower rprichard wrote: > enh wrote: > > srhines wrote: > > > MaskRay wrote:

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

sammccall added a comment. I did some testing on my machine (host compiler clang-14), and I'm not sure the specifics justify the level of caution here: ASTMatchers.h parses in 6.5s (with `clang-check`) If I comment out the code + internal ASTMatcher includes, then just the deps (mostly AST head

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

aaron.ballman added subscribers: carlosgalvezp, LegalizeAdulthood. aaron.ballman added a comment. In D158872#4626065 , @sammccall wrote: > I did some testing on my machine (host compiler clang-14), and I'm not sure > the specifics justify the level of ca

[PATCH] D159133: [Sema] Make C++ functional-style cast warn about dropped qualifiers (-Wcast-qual)

krisb created this revision. krisb added reviewers: lebedev.ri, rnk, alexfh. Herald added a subscriber: StephenFan. Herald added a project: All. krisb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Functional-style cast (i.e. a simple-type

[PATCH] D155997: [Phase Ordering] Don't speculate in SimplifyCFG before PGO annotation

tejohnson added a comment. In D155997#4570562 , @aeubanks wrote: > can we try not gating this on PGO as suggested? minimizing differences > between pipelines is nice, and as mentioned it'll help with other cases Sorry for the delay, was OOO for a bit an

[PATCH] D159115: [clang-repl] Adapt to the recent dylib-related changes in ORC.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG196d8569d46d: [clang-repl] Adapt to the recent dylib-related changes in ORC. (authored by v.g.vassilev). Herald added a project: clang. Repository:

[clang] 196d856 - [clang-repl] Adapt to the recent dylib-related changes in ORC.

Author: Vassil Vassilev Date: 2023-08-29T19:17:18Z New Revision: 196d8569d46dc5200c44e70cdf839b042148b988 URL: https://github.com/llvm/llvm-project/commit/196d8569d46dc5200c44e70cdf839b042148b988 DIFF: https://github.com/llvm/llvm-project/commit/196d8569d46dc5200c44e70cdf839b042148b988.diff LO

[clang] 39191c4 - [NFC][Clang] Fix static analyzer concerns

Author: Elizabeth Andrews Date: 2023-08-29T12:23:26-07:00 New Revision: 39191c45771564b8a0930d71b4c229147cf839db URL: https://github.com/llvm/llvm-project/commit/39191c45771564b8a0930d71b4c229147cf839db DIFF: https://github.com/llvm/llvm-project/commit/39191c45771564b8a0930d71b4c229147cf839db.d

[PATCH] D157118: [NFC][Clang] Fix static analyzer concerns

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG39191c457715: [NFC][Clang] Fix static analyzer concerns (authored by eandrews). Herald added a project: clang. Repository: rG LLVM Github Monorepo

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

rsmith added a comment. In D158967#4621361 , @zyounan wrote: >> Currently the code in CompilerInstance::ExecuteAction seems to acknowledge >> that there should be a fallback. I'm suggesting to move this fallback down >> to a function that actually runs

[clang] e6cd950 - Revert "[clang-repl] Adapt to the recent dylib-related changes in ORC."

Author: Vassil Vassilev Date: 2023-08-29T19:34:20Z New Revision: e6cd950d1b4a07f8c339b6f55374e4aa229e42f7 URL: https://github.com/llvm/llvm-project/commit/e6cd950d1b4a07f8c339b6f55374e4aa229e42f7 DIFF: https://github.com/llvm/llvm-project/commit/e6cd950d1b4a07f8c339b6f55374e4aa229e42f7.diff LO

[PATCH] D153907: [AIX] [TOC] Add -mtocdata/-mno-tocdata options on AIX

syzaara updated this revision to Diff 554461. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153907/new/ https://reviews.llvm.org/D153907 Files: clang/docs/UsersManual.rst clang/include/clang/Basic/CodeGenOptions.h clang/include/clang/Basic/DiagnosticDriverKinds.td clang/include/c

[PATCH] D158778: [CUDA] Propagate __float128 support from the host.

jhuber6 added a comment. In D158778#4625892 , @tra wrote: > In D158778#4624408 , @ABataev wrote: > >> Just checks removal should be fine > > Looks like OpenMP handles long double and __float128 differently -- it a

[PATCH] D155858: Add a concept AST node.

sammccall added a comment. OK, so I learned a bit about initializeLocal/trivial TypeSourceInfo. Mostly things I didn't want to know :-) TL;DR I think the current version of the patch is right. The crash is caused by: 1. `CheckTemplateArgument` calls `SubstType` without passing a `TypeLoc`, whic

[PATCH] D158869: [clang] Fix timing of propagation of MSInheritanceAttr for template instantiation declarations.

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm Comment at: clang/test/CodeGenCXX/microsoft-abi-member-pointers.cpp:958 +extern template class a; +template class a; +} tahonermann wrote: > rnk wrote: > > My

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

beanz added a comment. I'll apply this patch and debug the issue today. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159126/new/ https://reviews.llvm.org/D159126 ___ cfe-commits mailing list cfe-commits

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

serge-sans-paille added a comment. Jumping a bit late in the thread, apologize in advance if I missed something. The GCC version of the attributes seems to be `element_count` (as found in the link https://gcc.gnu.org/bugzilla/show_bug.cgi?id=108896 mentionned by @kees) I guess we could align (I

[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

rnk added a subscriber: mstorsjo. rnk added a comment. I need to get to it, my recollection is that @mstorsjo ran into the same issue here for mingw and made some changes, I wanted to go dig those up as a starting point. I may have completely forgotten things though. Repository: rG LLVM Gith

[clang] ca0aa53 - [clang-format] Handle Template Arguments with AlignConsecutiveXX

Author: Björn Schäpers Date: 2023-08-29T21:59:44+02:00 New Revision: ca0aa533656ceb806d2744c38766f70c317f1053 URL: https://github.com/llvm/llvm-project/commit/ca0aa533656ceb806d2744c38766f70c317f1053 DIFF: https://github.com/llvm/llvm-project/commit/ca0aa533656ceb806d2744c38766f70c317f1053.diff

[PATCH] D158967: [clang][clangd] Ensure the stack bottom before building AST

sammccall added a comment. In D158967#4626156 , @rsmith wrote: > Adding another fallback in `ASTFrontendAction::ExecuteAction` seems OK to me > if that's an entry point that's commonly used by tools. (Where is that being > called from in clangd's case?

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

This revision was automatically updated to reflect the committed changes. Closed by commit rG086305120887: Reland "[clang-format] Annotate constructor/destructor names" (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157963/new/

[PATCH] D61670: [clang] [MinGW] Add the option -fno-autoimport

mstorsjo added a comment. In D61670#4621724 , @aeubanks wrote: > I don't have all the context here, but seems fine once the commit description > is updated with the new spelling Thanks. Yeah I've updated the commit message locally (I wonder if the `arc`

[PATCH] D158872: [clang][ASTMatchers] Add a few type-related Matchers

sammccall added a comment. In D158872#4626095 , @aaron.ballman wrote: > Out of curiosity, are you testing on Windows with MSVC? My understanding on > build time performance impacts was that it's debug builds with MSVC that get > hit especially hard. (I

[PATCH] D158778: [CUDA] Propagate __float128 support from the host.

tra added a comment. In D158778#4626181 , @jhuber6 wrote: > Just doing a simple example here https://godbolt.org/z/Y3E58PKMz shows that > for NVPTX we error out (as I would expect) but for AMDGPU we emit an x86 > 80-bit double. With this patch NVPTX wi

[clang] 452cb7f - Reland "[clang-repl] Adapt to the recent dylib-related changes in ORC."

Author: Vassil Vassilev Date: 2023-08-29T19:42:58Z New Revision: 452cb7f20bc7b976eb6fec4ac9f2d902f4175c08 URL: https://github.com/llvm/llvm-project/commit/452cb7f20bc7b976eb6fec4ac9f2d902f4175c08 DIFF: https://github.com/llvm/llvm-project/commit/452cb7f20bc7b976eb6fec4ac9f2d902f4175c08.diff LO

[PATCH] D158614: [UBSan] Disable the function sanitizer on an execute-only target.

MaggieYi updated this revision to Diff 554474. MaggieYi marked 7 inline comments as done. MaggieYi added a comment. Thanks @MaskRay, I have updated the patch following your suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158614/new/ https://reviews.llvm.org/D158614 Files:

[PATCH] D158614: [UBSan] Disable the function sanitizer on an execute-only target.

MaggieYi added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:326 def err_unsupported_abi_for_opt : Error<"'%0' can only be used with the '%1' ABI">; +def err_unsupported_opt_for_execute_only_target +: Error<"unsupported option '%0' for the

[clang] 0863051 - Reland "[clang-format] Annotate constructor/destructor names"

Author: Owen Pan Date: 2023-08-29T13:14:52-07:00 New Revision: 0863051208870b284a1ee899defc0ba2b6e53fc4 URL: https://github.com/llvm/llvm-project/commit/0863051208870b284a1ee899defc0ba2b6e53fc4 DIFF: https://github.com/llvm/llvm-project/commit/0863051208870b284a1ee899defc0ba2b6e53fc4.diff LOG:

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

qiongsiwu1 created this revision. qiongsiwu1 added reviewers: w2yehia, MaskRay. qiongsiwu1 added a project: clang. Herald added a project: All. qiongsiwu1 requested review of this revision. Herald added a subscriber: cfe-commits. https://reviews.llvm.org/D157280 enabled `-fprofile-update` for `-f

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

NoumanAmir657 updated this revision to Diff 554485. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158540/new/ https://reviews.llvm.org/D158540 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaDeclCXX.cpp clang/test/CXX/dcl.dcl/dcl.spec/dcl.constexpr/p3.cpp

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

qiongsiwu1 added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:440 + StringRef Val = A->getValue(); + if (Val == "atomic" || Val == "prefer-atomic") +CmdArgs.push_back("-latomic"); This check here is copied from https://githu

[PATCH] D154287: [clang-tidy] Add modernize-use-std-format check

mikecrowe updated this revision to Diff 554486. mikecrowe edited the summary of this revision. mikecrowe added a comment. Fix ReleaseNotes order and remove unnecessary .html from list.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154287/new/ ht

[PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

NoumanAmir657 updated this revision to Diff 554489. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158540/new/ https://reviews.llvm.org/D158540 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaDeclCXX.cpp clang/test/CXX/dcl.dcl/dcl.spec/dcl.constexpr/p3.cpp

[PATCH] D159138: [clang][Sema] Fix format size estimator's handling of %o, %x, %X with alternative form

hazohelet created this revision. hazohelet added reviewers: aaron.ballman, nickdesaulniers, serge-sans-paille. Herald added a project: All. hazohelet requested review of this revision. Herald added a project: clang. The wrong handling of %x specifier with alternative form causes a false positive

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

beanz added a comment. @cor3ntin, I know what the problem is and I think I can put up a review for a fix tonight or (more likely) tomorrow. Is that okay? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159126/new/ https://reviews.llvm.org/D159126 _

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

cor3ntin added a comment. @beanz Oh wow, excellent, i did not expect a solution so fast! I'm glad to know there may indeed be an issue with HLSL rather than this patch because I'm not sure I could have come up with a different fix! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D159126: [Clang] Add captures to the instantiation scope of lambda call operators

beanz added a comment. Yea, the gist of it is that in HLSL `this` is a reference not a pointer, which means the `CXXThisExpr` is always an LValue. I think the right fix for this is to cleanup the `CXXThisExpr` creation code and create a `CXXThisExpr::Create` method like the other AST nodes. The

[PATCH] D152752: [MS] Fix passing aligned records by value in some cases

rnk added a comment. I put together a fix here: https://github.com/llvm/llvm-project/compare/main...rnk:llvm-project:fix-vararg-align I don't have arcanist set up like I used to, and I don't write as much code as I used to, so I kind of want to submit this as a pull request as soon as they are

[PATCH] D159133: [Sema] Make C++ functional-style cast warn about dropped qualifiers (-Wcast-qual)

shafik added reviewers: aaron.ballman, clang-language-wg. shafik added a comment. Add more reviewers for visibility. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159133/new/ https://reviews.llvm.org/D159133 ___

[PATCH] D159024: [Parser] Parse string literal arguments of 'availability', 'external_source_symbol' and 'uuid' attributes as unevaluated

barannikov88 updated this revision to Diff 554497. barannikov88 added a comment. Update the failing test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159024/new/ https://reviews.llvm.org/D159024 Files: clang/lib/Parse/ParseDecl.cpp clang/lib/

[PATCH] D159133: [Sema] Make C++ functional-style cast warn about dropped qualifiers (-Wcast-qual)

shafik added a comment. I think this makes sense especially if it matches up w/ gcc but would like to see more feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159133/new/ https://reviews.llvm.org/D159133 __

[clang] 4c62e94 - [OpenMP] Allow exceptions in target regions when offloading to GPUs

Author: Anton Rydahl Date: 2023-08-29T15:05:59-07:00 New Revision: 4c62e943b7178127861ca39163a0ed4caeb14943 URL: https://github.com/llvm/llvm-project/commit/4c62e943b7178127861ca39163a0ed4caeb14943 DIFF: https://github.com/llvm/llvm-project/commit/4c62e943b7178127861ca39163a0ed4caeb14943.diff

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4c62e943b717: [OpenMP] Allow exceptions in target regions when offloading to GPUs (authored by AntonRydahl). Repository: rG LLVM Github Monorepo

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

MaskRay added inline comments. Comment at: clang/include/clang/Basic/SizedDeallocation.h:23 +namespace clang { +inline llvm::VersionTuple sizedDeallocMinVersion(llvm::Triple::OSType OS) { + switch (OS) { wangpc wrote: > MaskRay wrote: > > Does this need to be in

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:440 + StringRef Val = A->getValue(); + if (Val == "atomic" || Val == "prefer-atomic") +CmdArgs.push_back("-latomic"); qiongsiwu1 wrote: > This check here is copied fr

[PATCH] D159145: [RISCV] Don't add -unaligned-scalar-mem to target features by default.

craig.topper created this revision. craig.topper added reviewers: wangpc, kito-cheng, asb, reames, jrtc27. Herald added subscribers: jobnoorman, luke, sunshaoce, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, Mar

Re: [PATCH] D158540: Improve error message for constexpr constructors of virtual base classes

On Tue, 22 Aug 2023 at 12:43, Nouman Amir via Phabricator via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Index: clang/include/clang/Basic/DiagnosticSemaKinds.td > === > --- clang/include/clang/Basic/DiagnosticSemaKinds.td > ++

[clang] 7af0eff - Revert "[OpenMP] Allow exceptions in target regions when offloading to GPUs"

Author: antonrydahl Date: 2023-08-29T15:59:47-07:00 New Revision: 7af0eff5405bb88dc96c0b19892da0fbb44db433 URL: https://github.com/llvm/llvm-project/commit/7af0eff5405bb88dc96c0b19892da0fbb44db433 DIFF: https://github.com/llvm/llvm-project/commit/7af0eff5405bb88dc96c0b19892da0fbb44db433.diff L

[PATCH] D117929: [XRay] Add support for RISCV

ashwin98 updated this revision to Diff 554513. ashwin98 added a comment. Sorry - I missed adding updates with the last diff - I think I've addressed most of the comments. Just realized that the diff didn't include context, updated that as well. CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D158475: [driver] Refactor getRuntimePaths. NFC

smeenai added a comment. In D158475#4623852 , @glandium wrote: > In D158475#4623842 , @smeenai wrote: > >> In D158475#4623471 , @glandium >> wrote: >> >>> This conflicts

[PATCH] D159103: [Driver][HLSL] Improve diagnostics for invalid shader model and stage

bogner added inline comments. Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:710-716 + "Shader model is required in target '%0' for DXIL generation">; +def err_drv_dxil_unsupported_shader_model : Error< + "Shader model '%0' in target '%1' is invalid for DXIL gen

[PATCH] D159133: [Sema] Make C++ functional-style cast warn about dropped qualifiers (-Wcast-qual)

rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. This seems like it will generate warning cleanup work for vendors, so I'll mention #clang-vendors , but I think the code looks good. I don't think it ma

[PATCH] D153924: [OpenMP] Allow exceptions in target regions when offloading to GPUs

AntonRydahl updated this revision to Diff 554520. AntonRydahl added a comment. Updating the line numbers in the unit tests to match the addition of `// REQUIRES: ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153924/new/ https://reviews.llvm.org/

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

qiongsiwu1 updated this revision to Diff 554523. qiongsiwu1 added a comment. Address code review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159137/new/ https://reviews.llvm.org/D159137 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/test/Driver/fprofile-update.c Ind

[PATCH] D159137: [AIX] Fix Link Issue when `-fprofile-update=[atomic|prefer-atomic]` is in Effect

qiongsiwu1 marked 2 inline comments as done. qiongsiwu1 added inline comments. Comment at: clang/test/Driver/fprofile-update.c:17 +// AIX specific tests +// RUN: %if system-aix %{ %clang -### %s -fprofile-generate -fprofile-update=atomic 2>&1 | FileCheck %s --check-prefix=AIX %}

[PATCH] D148381: [WIP][Clang] Add counted_by attribute

void added a comment. In D148381#4626229 , @serge-sans-paille wrote: > Jumping a bit late in the thread, apologize in advance if I missed something. > > The GCC version of the attributes seems to be `element_count` (as found in > the link https://gcc.gn

[clang] 8f48392 - clang: Update tests after is.fpclass combine change

Author: Matt Arsenault Date: 2023-08-29T19:46:24-04:00 New Revision: 8f48392bc05a130218a15c65302f684988921307 URL: https://github.com/llvm/llvm-project/commit/8f48392bc05a130218a15c65302f684988921307 DIFF: https://github.com/llvm/llvm-project/commit/8f48392bc05a130218a15c65302f684988921307.diff

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

kaz7 updated this revision to Diff 554528. kaz7 added a comment. Change to not control backend default bahavior but support VPU flag in the backend for VE. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157813/new/ https://reviews.llvm.org/D157813

[PATCH] D157813: [VE][Clang] Change to enable VPU flag by default

kaz7 marked an inline comment as done. kaz7 added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/VE.cpp:22 + std::vector &Features) { + // Defaults. + bool EnableVPU = true; MaskRay wrote: > Delete the comment. The cod

<    1   2   3   >