qiongsiwu1 marked 2 inline comments as done.
qiongsiwu1 added inline comments.
================
Comment at: clang/test/Driver/fprofile-update.c:17
+// AIX specific tests
+// RUN: %if system-aix %{ %clang -### %s -fprofile-generate
-fprofile-update=atomic 2>&1 | FileCheck %s --check-prefix=AIX %}
+// RUN: %if system-aix %{ %clang -### %s -fprofile-generate
-fprofile-update=prefer-atomic 2>&1 | FileCheck %s --check-prefix=AIX %}
----------------
MaskRay wrote:
> The idiom is to use `--target=...`. This driver decision is not dependent on
> what OS the host runs, so `%if system-aix` should be avoided.
Ah yes thanks for the feedback. Fixed!
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D159137/new/
https://reviews.llvm.org/D159137
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
