rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

This seems like it will generate warning cleanup work for vendors, so I'll 
mention #clang-vendors <https://reviews.llvm.org/tag/clang-vendors/> , but I 
think the code looks good. I don't think it makes sense to add a fine-grained 
diagnostic category to allow people to clean up incrementally in this case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D159133/new/

https://reviews.llvm.org/D159133

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to