[clang] 3758aed - [flang][driver] Mark -Wl as visible in Flang

Author: Andrzej Warzynski Date: 2023-08-21T07:06:11Z New Revision: 3758aed31a512d9219bd31174a300c34d1af9fda URL: https://github.com/llvm/llvm-project/commit/3758aed31a512d9219bd31174a300c34d1af9fda DIFF: https://github.com/llvm/llvm-project/commit/3758aed31a512d9219bd31174a300c34d1af9fda.diff

[PATCH] D158309: [flang][driver] Mark -Wl as visible in Flang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3758aed31a51: [flang][driver] Mark -Wl as visible in Flang (authored by awarzynski). Changed prior to commit: https://reviews.llvm.org/D158309?vs=

[PATCH] D158307: [flang][driver] Disable Clang options in Flang

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. For reasons I won't get into, buildbots don't show what llvm-test-suite revision they are using but we can be sure by now that the other change has gone through. Fingers crossed

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

FreddyYe added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13319 +Value *Features = Builder.CreateAlignedLoad( +Int32Ty, Builder.CreateGEP(ATy, CpuFeatures2, Idxs), +CharUnits::fromQuantity(4)); Will function multi version als

[PATCH] D158372: [Clang] Treat invalid UDL as two tokens

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:9322 def warn_user_literal_reserved : Warning< - "user-defined literal suffixes %select{|not starting with '_'|containing '__'}0 are reserved" - "%select{; no literal will invoke this

[PATCH] D158329: [X86] Support arch=x86-64{,-v2,-v3,-v4} for target_clones attribute

FreddyYe added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:13317 + continue; +Value *Idxs[] = {Builder.getInt32(0), Builder.getInt32(i - 1)}; +Value *Features = Builder.CreateAlignedLoad( Don't quite understand why we need to change

[PATCH] D157953: [CGCall][RISCV] Handle function calls with parameter of RVV tuple type

eopXD updated this revision to Diff 551919. eopXD marked 2 inline comments as done. eopXD added a comment. Address comments from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157953/new/ https://reviews.llvm.org/D157953 Files: clang/lib/C

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

wangpc added a comment. @ldionne Sorry for bothering, what do you think about landing this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112921/new/ https://reviews.llvm.org/D112921 ___ cfe-commit

[PATCH] D157879: [clang] Report missing designated initializers in C++

Fznamznon updated this revision to Diff 551924. Fznamznon added a comment. Rebase to maybe pass precommit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157879/new/ https://reviews.llvm.org/D157879 Files: clang/docs/ReleaseNotes.rst clang/lib/S

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

cor3ntin added a comment. I'm really not qualified to give you meaningful feedback on design here, but I spotted a few minor things that can be improved, I hope it helps! Comment at: clang/include/clang/Sema/Sema.h:1357 +/// Whether rewrite the default argument. +bool

[PATCH] D155647: [RISCV] Add C intrinsics for scalar bitmanip and crypto

wangpc accepted this revision. wangpc added a comment. This revision is now accepted and ready to land. Herald added a subscriber: sunshaoce. LGTM if the proposal is merged. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155647/new/ https://reviews.

[PATCH] D157879: [clang] Report missing designated initializers in C++

Fznamznon added a comment. The failure is unrelated, since the patch doesn't touch modules and I've seen the test failing for other patches as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157879/new/ https://reviews.llvm.org/D157879 __

[clang] 9108897 - [clang] Report missing designated initializers in C++

Author: Podchishchaeva, Mariya Date: 2023-08-21T02:05:34-07:00 New Revision: 91088978d712cd7b33610c59f69d87d5a39e3113 URL: https://github.com/llvm/llvm-project/commit/91088978d712cd7b33610c59f69d87d5a39e3113 DIFF: https://github.com/llvm/llvm-project/commit/91088978d712cd7b33610c59f69d87d5a39e3

[PATCH] D157879: [clang] Report missing designated initializers in C++

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG91088978d712: [clang] Report missing designated initializers in C++ (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D157104: [analyzer] Improve underflow handling in ArrayBoundV2

donat.nagy added a comment. A (somewhat delayed) ping to @steakhal because you asked me to tell you when I have the results. (If you've already seen the table that I uploaded on Friday, then you've nothing to do.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D157838: [clang-repl] Disambiguate declarations with private typedefs

Hahnfeld added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:94 + // involve namespaces and friend declarations. + if (NextToken().is(tok::identifier)) +return true; v.g.vassilev wrote: > I am wondering what is the

[clang] b16a758 - [flang][driver] Disable Clang options in Flang

Author: Andrzej Warzynski Date: 2023-08-21T09:27:07Z New Revision: b16a7581ff8bcb2d24aace1239af4440f47ccb5f URL: https://github.com/llvm/llvm-project/commit/b16a7581ff8bcb2d24aace1239af4440f47ccb5f DIFF: https://github.com/llvm/llvm-project/commit/b16a7581ff8bcb2d24aace1239af4440f47ccb5f.diff

[PATCH] D158307: [flang][driver] Disable Clang options in Flang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb16a7581ff8b: [flang][driver] Disable Clang options in Flang (authored by awarzynski). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D152914: [Draft] Make __builtin_cpu builtins target-independent

ilinpv added a comment. Friendly ping, are there any questions remained to proceed with target-independent __builtin_cpu_supports ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152914/new/ https://reviews.llvm.org/D152914 ___

[PATCH] D158156: [analyzer] Add C++ array delete checker

donat.nagy added a comment. By the way, what would you think about putting the implementation of the two checkers (DeleteWithNonVirtualDtor, ArrayDelete) into two separate checker classes and placing the shared code into a common base class of these classes? I think this could be a significant

[clang] fa1b6e6 - [X86] Fix i128 argument passing under SysV ABI

Author: Nikita Popov Date: 2023-08-21T11:44:35+02:00 New Revision: fa1b6e6b34eb6382c451f3a06a7c52d7ac6ada1d URL: https://github.com/llvm/llvm-project/commit/fa1b6e6b34eb6382c451f3a06a7c52d7ac6ada1d DIFF: https://github.com/llvm/llvm-project/commit/fa1b6e6b34eb6382c451f3a06a7c52d7ac6ada1d.diff

[PATCH] D158169: [X86] Fix i128 argument passing under SysV ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rGfa1b6e6b34eb: [X86] Fix i128 argument passing under SysV ABI (authored by nikic). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D156910: [clang] Add pragma force_vectorize

kitaisreal added a comment. Herald added a subscriber: sunshaoce. Hello @aaron.ballman, @erichkeane could you please review this revision ? I wondering if this feature would be useful. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156910/new/ http

[PATCH] D158156: [analyzer] Add C++ array delete checker

Discookie planned changes to this revision. Discookie added a comment. Indeed it would make more sense to separate checkers into their own classes, but using a shared base. This checker doesn't have quite as advanced logic as MallocChecker, so there's not that much of a need for a single class m

[PATCH] D157838: [clang-repl] Disambiguate declarations with private typedefs

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. This change looks reasonable to me. Comment at: clang/test/Interpreter/disambiguate-decl-stmt.cpp:74 +// expected-error@-1 2 {{'Inner' is a private member of 'PR1

[PATCH] D156799: Update generic scheduling to use A510 scheduling model

harviniriawan updated this revision to Diff 551951. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156799/new/ https://reviews.llvm.org/D156799 Files: clang/test/CodeGen/aarch64-ABI-align-packed-assembly.c llvm/lib/Target/AArch64/AArch64.td llv

[PATCH] D142144: [RISCV][Driver] Add -mrvv-vector-bits= option similar to -msve-vector-bits=

wangpc added inline comments. Herald added subscribers: jobnoorman, sunshaoce. Comment at: clang/test/Driver/riscv-rvv-vector-bits.c:43 +// RUN: %clang -c %s -### --target=riscv64-linux-gnu -march=rv64gcv \ +// RUN: -mrvv-vector-bits=64 2>&1 | FileCheck --check-prefix=CHECK-BAD

[PATCH] D157104: [analyzer] Improve underflow handling in ArrayBoundV2

steakhal accepted this revision. steakhal added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157104/new/ https://reviews.llvm.org/D157104 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D156799: Update generic scheduling to use A510 scheduling model

harviniriawan updated this revision to Diff 551953. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156799/new/ https://reviews.llvm.org/D156799 Files: clang/test/CodeGen/aarch64-ABI-align-packed-assembly.c llvm/lib/Target/AArch64/AArch64.td llv

[PATCH] D157104: [analyzer] Improve underflow handling in ArrayBoundV2

steakhal added a comment. Hold on, make sure this is clang-format compliant before committing. (Check buildkite) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157104/new/ https://reviews.llvm.org/D157104 ___

[PATCH] D61670: [RFC] [MinGW] Allow opting out from .refptr stubs

mstorsjo updated this revision to Diff 551957. mstorsjo added a comment. Herald added a subscriber: MaskRay. Updated as discussed, adding a new option `-fno-autoimport` (and the corresponding positive one, `-fautoimport`, which is the implicit default), which affects code generation and linking.

[PATCH] D61670: [clang] [MinGW] Add the option -fno-autoimport

mstorsjo added inline comments. Comment at: clang/include/clang/Driver/Options.td:1477 + "automatic dllimport, and enable support for it in the linker. " + "Enabled by default.">>; +} // let Flags = [TargetSpecific] I see that most similar `Bool

[PATCH] D157810: [clang][ExtractAPI] Create extractapi::RecordLocation

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:182-189 DocComment Comment; if (auto *RawComment = - getDerivedExtractAPIVisitor().fetchRawCommentForDecl(Decl)) -Comment = RawComment->getFormattedLines(Context.getSourc

[clang] 1851858 - [clang][Interp][NFC] Fix a doc comment.

Author: Timm Bäder Date: 2023-08-21T12:48:57+02:00 New Revision: 18518582550485ce3d153bb918bf73c257ce259e URL: https://github.com/llvm/llvm-project/commit/18518582550485ce3d153bb918bf73c257ce259e DIFF: https://github.com/llvm/llvm-project/commit/18518582550485ce3d153bb918bf73c257ce259e.diff LO

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem updated this revision to Diff 551966. artem marked an inline comment as done. artem added a comment. Rebased and fixed legacy FileCheck syntax. Gentle reminder that I do not have commit rights. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https://reviews.llvm.org/D15

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:1787 +if (!VCI->isMinSignedValue()) { + return EmitAbs(CGF, ArgValue, true); +} MaskRay wrote: > MaskRay wrote: > > nit: we delete braces in this cascading case > > > > https:/

[PATCH] D147219: [OpenMP][Flang][MLIR] Lowering of requires directive from MLIR to LLVM IR

skatrak updated this revision to Diff 551968. skatrak added a comment. Update patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147219/new/ https://reviews.llvm.org/D147219 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp llvm/include/llvm/Fron

[PATCH] D158407: #llvm #flow-analysis Simplify formula at CNF construction time, and short-cut solving of known contradictory formulas.

burakemir created this revision. Herald added a reviewer: NoQ. Herald added a project: All. burakemir requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In dataflow analysis, SAT solver: simplify formula during CNF construction and short-cut

[PATCH] D156799: Update generic scheduling to use A510 scheduling model

harviniriawan updated this revision to Diff 551978. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156799/new/ https://reviews.llvm.org/D156799 Files: clang/test/CodeGen/aarch64-ABI-align-packed-assembly.c llvm/lib/Target/AArch64/AArch64.td llv

[PATCH] D158409: [WebAssembly] Add multiple memories feature

ashleynh created this revision. ashleynh added reviewers: aheejin, dschuff, tlively. Herald added subscribers: pmatos, asb, sunfish, hiraditya, jgravelle-google. Herald added a project: All. ashleynh requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: ll

[PATCH] D158411: [clang] [MinGW] Pass LTO options to the linker

mstorsjo created this revision. mstorsjo added a reviewer: MaskRay. Herald added subscribers: ormris, steven_wu, hiraditya, inglorion. Herald added a project: All. mstorsjo requested review of this revision. Herald added a project: clang. This matches what is done on other platforms too. This fix

[PATCH] D158413: [Lex] Introduce Preprocessor::LexAll()

Hahnfeld created this revision. Hahnfeld added reviewers: hokein, aaron.ballman. Herald added subscribers: kbarton, nemanjai. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This new method repeatedly c

[PATCH] D158414: [LexerTest] Use LexAll() in StringifyArgs

Hahnfeld created this revision. Hahnfeld added a reviewer: erichkeane. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rely on `Preprocessor::LexAll()` and just replace `tok::comma` by `tok::eof` and p

[PATCH] D158415: [Lex] Handle repl_input_end in Preprocessor::LexAll()

Hahnfeld created this revision. Hahnfeld added reviewers: aaron.ballman, v.g.vassilev. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes many unit tests when trying to enable `IncrementalExtens

[PATCH] D158029: [clang][ExtractAPI] Add support for C++ member templates

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158029/new/ https://reviews.llvm.org/D158029 ___ cf

[PATCH] D158301: Add back overriding-t-options for -m-version-min diagnostic

hans added inline comments. Comment at: clang/test/Driver/darwin-version.c:217 // RUN: FileCheck --check-prefix=CHECK-VERSION-TNO-OSV1 %s -// CHECK-VERSION-TNO-OSV1: overriding '-mmacos-version-min=10.6' option with '-target x86_64-apple-macos10.11.2' +// CHECK-VERSION-TNO-OS

[PATCH] D158031: [clang][ExtractAPI] Refactor C++ method and field visitation

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. Did this change not affect ordering of the symbols in the generated JSON? Looks pretty good to me otherwise! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D158361: [clang][Sema] Fix a copy/paste bug in ~Sema()

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! I have absolutely no idea how you would test the Sema destructor, so I think it's fine that this comes with no test coverage. Good catch! Repository: rG LLVM Github Mono

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

abhina.sreeskantharajan added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158254/new/ https://reviews.llvm.org/D158254 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D158239: [clang][ExtractAPI] Add support for namespaces

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:38 +namespace { +inline SmallString<128> DetermineParentDecl(const DeclContext *Context) { + SmallString<128> ParentUSR; I think this should compute both the parent decl a

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

abhina.sreeskantharajan added a comment. It seems like clang-format might be failing with this patch which should be fixed first. And I think I cannot actually accept this patch because I see the following `hchilama created this object with edit policy "Administrators".` Repository: rG LLVM

[PATCH] D158372: [Clang] Treat invalid UDL as two tokens

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:283-284 +def ext_ms_reserved_user_defined_literal : ExtWarn< + "invalid suffix on literal; C++11 requires a space between literal and " + "a macro">, InGroup; def err_unsupported_s

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin marked 4 inline comments as done. yronglin added a comment. @cor3ntin Thanks for your review! Comment at: clang/include/clang/Sema/Sema.h:1357 +/// Whether rewrite the default argument. +bool IsRewriteDefaultArgument = false; + cor3ntin wrote:

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

DiggerLin added a comment. @MaskRay, would you have any additional comments to share? If not, would it be appropriate for me to proceed with committing the patch? Your input would be greatly appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D158285: [NFC][CLANG] Fix wrong orders of function arguments positions

aaron.ballman added a comment. > I've seen a few similar patches from you @Manna and probably some related > folks. > Could you please clarify the motivation and the expectations? Or feel free to > point me to the Discuss post around the subject if I happened to miss it. Intel has been addressi

[PATCH] D158285: [NFC][CLANG] Fix wrong orders of function arguments positions

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:18098-18101 case OMPC_allocate: Res = ActOnOpenMPAllocateClause(Data.DepModOrTailExpr, VarList, StartLoc, -LParenLoc, ColonLoc, EndLoc); +

[PATCH] D158285: [NFC][CLANG] Fix wrong orders of function arguments positions

steakhal added a comment. In D158285#4603477 , @aaron.ballman wrote: >> I've seen a few similar patches from you @Manna and probably some related >> folks. >> Could you please clarify the motivation and the expectations? Or feel free >> to point me to

[PATCH] D153701: [Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin updated this revision to Diff 552009. yronglin marked 7 inline comments as done. yronglin added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153701/new/ https://reviews.llvm.org/D153701 Files: clang/include/

[PATCH] D158367: [AMDGPU] Add target feature gds/gws to clang

yaxunl added inline comments. Comment at: llvm/lib/TargetParser/TargetParser.cpp:289 Features["image-insts"] = true; + Features["gds"] = true; + Features["gws"] = true; arsenm wrote: > Gds feature is unused I am thinking to keep it in case we ne

[PATCH] D156693: [clang][ASTImporter]Skip check depth of friend template parameter

balazske accepted this revision. balazske added a comment. This revision is now accepted and ready to land. My concern was related to nested namespaces or nested classes with friend declarations that are equivalent and differ only in the nesting level. It may be possible to construct code where

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

DmitryPolukhin added a comment. @ldionne, @arphaman and @jroelofs, friendly ping, could you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157283/new/ https://reviews.llvm.org/D157283

[PATCH] D158156: [analyzer] Add C++ array delete checker

balazske added a comment. I found that this concept of "fake" checkers (that change only options of a common checker instance) has more problems (checker dependencies, callback order, separation of "modeling" and bug report generation independently), it is better to avoid this. It is really the

[PATCH] D153114: [clangd] [C++20] [Modules] Support C++20 modules for clangd

sammccall added a comment. In D153114#4602414 , @ChuanqiXu wrote: >> Don't attempt any cross-file or cross-version coordination: i.e. don't try >> to reuse BMIs between different files, don't try to reuse BMIs between >> (preamble) reparses of the same

[PATCH] D158318: [Sema] tolerate more promotion matches in format string checking

aaron.ballman added a comment. Thank you for this! The changes should come with a release note (in `clang/docs/ReleaseNotes.rst`). Also, you should upload the patch with `-U999` amount of context so that reviewers can see the bigger picture a bit more easily. Comment at: cla

[PATCH] D158152: [clang-tidy]mark record initList as non-const param

PiotrZSL accepted this revision. PiotrZSL added a comment. This revision is now accepted and ready to land. LGTM, but note that type aliases may not work properly, but that more a legacy issue that got source in line 104, simply because we should use canonical type there. Com

[PATCH] D158285: [NFC][CLANG] Fix wrong orders of function arguments positions

tahonermann added a comment. > To me, an important metric of a quality patch is if the title and the summary > describe why we have this patch, and what we do about it. @steakhal, I'll work with the people submitting these patches to add more context to the title, summary, and commit comments.

[PATCH] D158285: [NFC][CLANG] Fix wrong orders of function arguments positions

aaron.ballman added a comment. In D158285#4603521 , @steakhal wrote: > In D158285#4603477 , @aaron.ballman > wrote: > >>> I've seen a few similar patches from you @Manna and probably some related >>> folks. >>>

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder updated this revision to Diff 552018. tbaeder marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157385/new/ https://reviews.llvm.org/D157385 Files: clang/include/clang/Analysis/CFG.h clang/lib/Analysis/CFG.cpp clang/lib/Analysis/ThreadSafety.cp

[PATCH] D157385: [clang][CFG] Cleanup functions

tbaeder added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:2429-2438 + +case CFGElement::CleanupFunction: { + const CFGCleanupFunction &CF = BI.castAs(); + + LocksetBuilder.handleCall(nullptr, CF.getFunctionDecl(), +

[PATCH] D158426: [clangd] Bump timeouts for LSPServerTests

kadircet created this revision. kadircet added reviewers: sammccall, nridge. Herald added a subscriber: arphaman. Herald added a project: All. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. We se

[PATCH] D158367: [AMDGPU] Add target feature gds/gws to clang

arsenm added inline comments. Comment at: llvm/lib/TargetParser/TargetParser.cpp:289 Features["image-insts"] = true; + Features["gds"] = true; + Features["gws"] = true; yaxunl wrote: > arsenm wrote: > > Gds feature is unused > I am thinking to k

[PATCH] D157708: [Sema] Suppress lookup diagnostics when checking reversed operators

ilya-biryukov added a reviewer: clang-language-wg. ilya-biryukov added a comment. @shafik, @rsmith friendly ping for a review. Also adding clang-language-wg for a wider set of potential reviewers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15770

[PATCH] D157104: [analyzer] Improve underflow handling in ArrayBoundV2

donat.nagy added a comment. Yup, there was a superfluous line break that was corrected by git clang-format; thanks for bringing it to my attention. As this is a very trivial change, I'll merge the fixed commit directly, without uploading it into Phabricator. Comment at: clang

[clang] 3e01403 - [analyzer] Improve underflow handling in ArrayBoundV2

Author: Donát Nagy Date: 2023-08-21T17:17:02+02:00 New Revision: 3e014038b373e5a4a96d89d46cea17e4d2456a04 URL: https://github.com/llvm/llvm-project/commit/3e014038b373e5a4a96d89d46cea17e4d2456a04 DIFF: https://github.com/llvm/llvm-project/commit/3e014038b373e5a4a96d89d46cea17e4d2456a04.diff LO

[PATCH] D157104: [analyzer] Improve underflow handling in ArrayBoundV2

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e014038b373: [analyzer] Improve underflow handling in ArrayBoundV2 (authored by donat.nagy). Changed prior to commit: https://reviews.llvm.org/D1

[PATCH] D78441: Delete NaCl support

dschuff added a comment. In D78441#4602312 , @brad wrote: > In D78441#4593287 , @dschuff wrote: > >> Deprecation is progressing >> (https://groups.google.com/a/chromium.org/g/chromium-extensions/c/v8H1UHnPotY/m/Nmz

[PATCH] D158254: Fixing the memory leak using split() instead of strtok

hchilama added a comment. Hi @abhina.sreeskantharajan I have verified the fix aganist the clang-format, seems fine. (FYI: I saw clean build on Friday) I have modified this object with the edit policy "All Users" Please let me know if I need to do anything else here? Repository: rG LLVM Gith

[PATCH] D158430: [flang][driver] Mark -fuse-ld as visible in Flang

erjin created this revision. Herald added a reviewer: sscalpone. Herald added a reviewer: awarzynski. Herald added projects: Flang, All. erjin requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. Herald added a project: clang. Repository: rG LLVM Github Monorepo

[clang-tools-extra] 845d3b5 - [clang-tidy][NFC] Fix release notes

Author: Piotr Zegar Date: 2023-08-21T15:45:17Z New Revision: 845d3b5489fc1ae7205968acb74486a93c5ca902 URL: https://github.com/llvm/llvm-project/commit/845d3b5489fc1ae7205968acb74486a93c5ca902 DIFF: https://github.com/llvm/llvm-project/commit/845d3b5489fc1ae7205968acb74486a93c5ca902.diff LOG: [

[PATCH] D158409: [WebAssembly] Add multiple memories feature

tlively added a comment. The other file to update here is clang/test/Driver/wasm-features.c. It looks like we haven't been as consistent about updating that one. Comment at: clang/include/clang/Driver/Options.td:4583-4584 def mno_extended_const : Flag<["-"], "mno-extended-con

[PATCH] D156799: Update generic scheduling to use A510 scheduling model

aeubanks added inline comments. Comment at: llvm/test/CodeGen/AArch64/stack-guard-sysreg.ll:1 -; RUN: split-file %s %t ; RUN: cat %t/main.ll %t/a.ll > %t/a2.ll ; RUN: cat %t/main.ll %t/b.ll > %t/b2.ll this test is broken, without the `split-file` the other file

[PATCH] D158409: [WebAssembly] Add multiple memories feature

sbc100 added inline comments. Comment at: clang/include/clang/Driver/Options.td:4583 def mno_extended_const : Flag<["-"], "mno-extended-const">, Group; +def mmulti_memories : Flag<["-"], "mmulti-memories">, Group; +def mno_multi_memories : Flag<["-"], "mno-multi-memories">, G

[PATCH] D158409: [WebAssembly] Add multiple memories feature

sbc100 added a comment. In D158409#4603829 , @tlively wrote: > The other file to update here is clang/test/Driver/wasm-features.c. It looks > like we haven't been as consistent about updating that one. Darn it, you beat be by 2 minutes. Repository:

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

aaron.ballman accepted this revision. aaron.ballman added a comment. In D149867#4544489 , @myhsu wrote: > Sorry I was busy on my phd defense (which I passed!) in the past month. I'll > get back to this next week. Congratulations!! 🎉 LGTM! ==

[PATCH] D142144: [RISCV][Driver] Add -mrvv-vector-bits= option similar to -msve-vector-bits=

craig.topper added inline comments. Comment at: clang/test/Driver/riscv-rvv-vector-bits.c:43 +// RUN: %clang -c %s -### --target=riscv64-linux-gnu -march=rv64gcv \ +// RUN: -mrvv-vector-bits=64 2>&1 | FileCheck --check-prefix=CHECK-BAD-VALUE-ERROR %s + wangpc w

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

aaron.ballman added inline comments. Comment at: clang/lib/Headers/stddef.h:118-122 +#ifdef __cplusplus +namespace std { +typedef decltype(nullptr) nullptr_t; +} +using ::std::nullptr_t; iana wrote: > ldionne wrote: > > iana wrote: > > > aaron.ballman wrote: > >

[clang] d8e9c5d - [clang][ExtractAPI] Visit method templates with better scheme

Author: Erick Velez Date: 2023-08-21T09:05:57-07:00 New Revision: d8e9c5d9cab51f0ec21d4953014f41fe4dc603d9 URL: https://github.com/llvm/llvm-project/commit/d8e9c5d9cab51f0ec21d4953014f41fe4dc603d9 DIFF: https://github.com/llvm/llvm-project/commit/d8e9c5d9cab51f0ec21d4953014f41fe4dc603d9.diff L

[PATCH] D158027: [clang][ExtractAPI] Visit method templates with better scheme

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd8e9c5d9cab5: [clang][ExtractAPI] Visit method templates with better scheme (authored by evelez7). Changed prior to commit: https://reviews.llvm.o

[PATCH] D149867: [Clang][M68k] Add Clang support for the new M68k_RTD CC

jrtc27 added inline comments. Comment at: clang/test/CodeGen/mrtd.c:2 +// RUN: %clang_cc1 -mrtd -triple i386-unknown-unknown -std=c89 -emit-llvm -o - %s 2>&1 | FileCheck --check-prefixes=CHECK,X86 %s +// RUN: %clang_cc1 -mrtd -triple m68k-unknown-unknown -std=c89 -emit-llvm -o -

[clang] f0bbda0 - [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

Author: Artem Labazov Date: 2023-08-21T09:13:25-07:00 New Revision: f0bbda00bd060919a548b97d564c5208312993a3 URL: https://github.com/llvm/llvm-project/commit/f0bbda00bd060919a548b97d564c5208312993a3 DIFF: https://github.com/llvm/llvm-project/commit/f0bbda00bd060919a548b97d564c5208312993a3.diff

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf0bbda00bd06: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin (authored by artem, committed by MaskRay). Changed prior to commit:

[PATCH] D158433: [Clang] Do not change the type of captured vars when checking lambda constraints

cor3ntin created this revision. Herald added a subscriber: ChuanqiXu. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When checking the constraint of a lambda, we need to respect the constness of the ca

[PATCH] D158430: [flang][driver] Mark -fuse-ld as visible in Flang

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158430/new/ https://reviews.llvm.org/D158430 __

[PATCH] D154784: [clang] Fix crash caused by PseudoObjectExprBitfields::NumSubExprs overflow

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/Stmt.h:596-597 -// These don't need to be particularly wide, because they're -// strictly limited by the forms of expressions we permit. -unsigned NumSubExprs : 8; -unsigned ResultIndex : 3

[PATCH] D158433: [Clang] Do not change the type of captured vars when checking lambda constraints

aaron.ballman added reviewers: erichkeane, hubert.reinterpretcast, clang-language-wg. aaron.ballman added a comment. Adding a few more reviewers for extra sets of eyes given that we'd like this to land in 17.x. The changes look correct to me, but a confirmation would be appreciated. Repositor

[PATCH] D117929: [XRay] Add support for RISCV

ashwin98 updated this revision to Diff 552054. ashwin98 added a reviewer: MaskRay. ashwin98 added a comment. Herald added a subscriber: sunshaoce. Ok, I've tried to make the changes you've suggested @MaskRay , let me know if I've missed something. On another note, I lost my previous qemu VM and

[PATCH] D158372: [Clang] Treat invalid UDL as two tokens

rZhBoYao updated this revision to Diff 552060. rZhBoYao marked 5 inline comments as done. rZhBoYao edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158372/new/ https://reviews.llvm.org/D158372 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Ba

[PATCH] D158372: [Clang] Treat invalid UDL as two tokens

rZhBoYao added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:1994-2009 if (!isAsciiIdentifierStart(C)) { if (C == '\\' && tryConsumeIdentifierUCN(CurPtr, Size, Result)) Consumed = true; else if (!isASCII(C) && tryConsumeIdentifierUTF8Char(CurPtr))

[PATCH] D141177: [Clang] Don't tell people to place _Alignas on a struct in diagnostics

theo-lw updated this revision to Diff 552061. theo-lw added a comment. Herald added a subscriber: jdoerfert. Rebased on the main branch & addressed comments. Added additional test case for C++ alignas. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141177/new/ https://reviews.llvm.org/D

[PATCH] D157879: [clang] Report missing designated initializers in C++

aeubanks added a comment. is there any way to suppress this for a specific field? (I believe) I'm seeing user code where a field is intentionally not being initialized Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157879/new/ https://reviews.llvm.

  1   2   3   >