donat.nagy added a comment.

By the way, what would you think about putting the implementation of the two 
checkers (DeleteWithNonVirtualDtor, ArrayDelete) into two separate checker 
classes and placing the shared code into a common base class of these classes? 
I think this could be a significant simplification: we could avoid the manual 
management of the two checker names and bug types and register two regular 
checker objects instead of the one dummy prerequisite checker + two "fake" 
checker registrations that just toggle boolean flags.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158156/new/

https://reviews.llvm.org/D158156

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to