[PATCH] D158046: [X86] Support -march=gracemont

RKSimon added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:551 case CK_Lunarlake: + case CK_Gracemont: case CK_Sierraforest: FreddyYe wrote: > RKSimon wrote: > > Why not handle this above (below tremont) as the next in the *mont series? > G

[PATCH] D147219: [OpenMP][Flang][MLIR] Lowering of requires directive from MLIR to LLVM IR

skatrak updated this revision to Diff 551147. skatrak added a comment. Herald added subscribers: gysit, Dinistro. Update patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147219/new/ https://reviews.llvm.org/D147219 Files: clang/lib/CodeGen/C

[PATCH] D147217: [OpenMP][OMPIRBuilder] OpenMPIRBuilder support for requires directive

skatrak updated this revision to Diff 551150. skatrak added a comment. Fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147217/new/ https://reviews.llvm.org/D147217 Files: clang/lib/CodeGen/CGOpenMPRuntime.cpp clang/lib/CodeGen/CG

[PATCH] D158137: Change -ffp-model= related warn_drv_overriding_flag_option to warn_drv_overriding_option

MaskRay added a comment. In D158137#4595234 , @hans wrote: >> Thanks! I agree. d9ad0681fad9a98f43d9baddb95d505b37153c48 (2013) renamed >> `warn_drv_overriding_t_option` to `warn_drv_overriding_flag_option`. >> Perhaps the original name `warn_drv_overridi

[clang-tools-extra] 12babb0 - [clang-tidy] Disable implicit search for a compilation db in some tests

Author: Justin Bogner Date: 2023-08-17T08:29:52-07:00 New Revision: 12babb08189cc1ca84d7fbb33d3c9726583b2e5a URL: https://github.com/llvm/llvm-project/commit/12babb08189cc1ca84d7fbb33d3c9726583b2e5a DIFF: https://github.com/llvm/llvm-project/commit/12babb08189cc1ca84d7fbb33d3c9726583b2e5a.diff

[PATCH] D158157: [clang-tidy] Disable implicit search for a compilation db in some tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG12babb08189c: [clang-tidy] Disable implicit search for a compilation db in some tests (authored by bogner). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158

[PATCH] D158137: Rename warn_drv_overriding_flag_option (-Woverriding-t-option) to warn_drv_overriding_flag_option (-Woverriding-option)

MaskRay updated this revision to Diff 551156. MaskRay retitled this revision from "Change -ffp-model= related warn_drv_overriding_flag_option to warn_drv_overriding_option" to "Rename warn_drv_overriding_flag_option (-Woverriding-t-option) to warn_drv_overriding_flag_option (-Woverriding-option)

[clang] f806be5 - APINotes: add initial stub of APINotesWriter

Author: Saleem Abdulrasool Date: 2023-08-17T08:49:35-07:00 New Revision: f806be5eaae156eedeebd3cae2d0894ab0fa65dd URL: https://github.com/llvm/llvm-project/commit/f806be5eaae156eedeebd3cae2d0894ab0fa65dd DIFF: https://github.com/llvm/llvm-project/commit/f806be5eaae156eedeebd3cae2d0894ab0fa65dd.

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf806be5eaae1: APINotes: add initial stub of APINotesWriter (authored by Saleem Abdulrasool , committed by compnerd). Changed p

[PATCH] D147219: [OpenMP][Flang][MLIR] Lowering of requires directive from MLIR to LLVM IR

skatrak requested review of this revision. skatrak marked 11 inline comments as done. skatrak added a comment. I think the change of approach to initialize the `OpenMPIRBuilderConfig` through the `amendOperation()` flow (rather than directly inside of `ModuleTranslation::getOpenMPBuilder()`) aft

[PATCH] D154581: [clang][Interp] Track existing InitMaps in InterpState

tbaeder updated this revision to Diff 551162. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154581/new/ https://reviews.llvm.org/D154581 Files: clang/lib/AST/Interp/Descriptor.cpp clang/lib/AST/Interp/Descriptor.h clang/lib/AST/Interp/EvalEmitter.cpp clang/lib/AST/Interp/EvalEmit

[PATCH] D158136: [clang][modules] Avoid storing command-line macro definitions into implicitly built PCM files

benlangmuir accepted this revision. benlangmuir added inline comments. This revision is now accepted and ready to land. Comment at: clang/test/Modules/module_file_info.m:44 // CHECK: Uses compiler/target-specific predefines [-undef]: Yes // CHECK: Uses detailed preprocessin

[PATCH] D147219: [OpenMP][Flang][MLIR] Lowering of requires directive from MLIR to LLVM IR

kiranchandramohan added inline comments. Comment at: mlir/lib/Target/LLVMIR/ModuleTranslation.cpp:1388-1393 + // Convert module itself before any functions and operations inside, so that + // the OpenMPIRBuilder is configured with the OpenMP dialect attributes + // attached to

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

Mordante added a comment. In D112921#4594092 , @wangpc wrote: > - Rebase. > - Update tests, remove clang-17. The removal of the markers in the libc++ tests breaks these test. FYI the tests are using a Clang build of apt.llvm.org and are not using this p

[PATCH] D158137: Rename warn_drv_overriding_flag_option (-Woverriding-t-option) to warn_drv_overriding_flag_option (-Woverriding-option)

dexonsmith added a comment. This seems to drop `-Woverriding-t-option` entirely. Could that break builds if someone has (e.g.) `-Werror -Wno-overriding-t-option` in their build settings? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158137/new/ ht

[PATCH] D157905: [include-cleaner] Filter references to identity macros

sammccall accepted this revision. sammccall added inline comments. Comment at: clang-tools-extra/include-cleaner/lib/Analysis.cpp:44 + // not the macro definition. So ignore such macros. + return MI && MI->getNumTokens() == 1 && MI->isObjectLike() && + MI->getReplacemen

[clang] 6cdaf7e - APINotes: remove accidentally committed downstream changes

Author: Saleem Abdulrasool Date: 2023-08-17T10:05:10-07:00 New Revision: 6cdaf7e6ad53f882d1b3a36f05c0e145db1d7051 URL: https://github.com/llvm/llvm-project/commit/6cdaf7e6ad53f882d1b3a36f05c0e145db1d7051 DIFF: https://github.com/llvm/llvm-project/commit/6cdaf7e6ad53f882d1b3a36f05c0e145db1d7051.

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

tmgross added a comment. @nikic posted a patch that fixes the register passing at https://reviews.llvm.org/D158169. I think that patch plus this one should resolve all the problems we have Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86310/new/

[PATCH] D112921: [clang] Enable sized deallocation by default in C++14 onwards

wangpc added a comment. In D112921#4595918 , @Mordante wrote: > In D112921#4594092 , @wangpc wrote: > >> - Rebase. >> - Update tests, remove clang-17. > > The removal of the markers in the libc++ tests breaks thes

[PATCH] D140828: [C++] Implement "Deducing this" (P0847R7)

aaron.ballman added inline comments. Comment at: clang/include/clang/Sema/Sema.h:3775 bool UseMemberUsingDeclRules, bool ConsiderCudaAttrs = true, - bool ConsiderRequiresClauses = true); + bool UseOverrideRules = false);

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

tra added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions-with-cuda-nvptx.c:16 +// causes a warning. +// RUN: %clang --target=x86_64-unknown-linux-gnu -nogpulib -nogpuinc \ +// RUN: --cuda-gpu-arch=sm_70 -x cuda -fsplit-machine-functions -S %s 2>&1

[PATCH] D158135: [Clang] Add __builtin_bcopy

cseo updated this revision to Diff 551187. cseo added a comment. Herald added subscribers: kbarton, nemanjai. Fix ppc bcopy test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158135/new/ https://reviews.llvm.org/D158135 Files: clang/include/clan

[PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

mgorny added a comment. This is the final version that was pushed, correct? (the commits don't link the revision) I've raised some concerns about the resulting API in https://reviews.llvm.org/D156270#4557902. I'd appreciate if you could take a look. Repository: rG LLVM Github Monorepo CHA

[PATCH] D158137: Rename warn_drv_overriding_flag_option (-Woverriding-t-option) to warn_drv_overriding_flag_option (-Woverriding-option)

MaskRay added a comment. In D158137#4595927 , @dexonsmith wrote: > This seems to drop `-Woverriding-t-option` entirely. Could that break builds > if someone has (e.g.) `-Werror -Wno-overriding-t-option` in their build > settings? Yes. We could also ad

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

overmighty updated this revision to Diff 551193. overmighty added a comment. Add tests for A[0]*B+C patterns. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158008/new/ https://reviews.llvm.org/D158008 Files: clang/test/CodeGen/aarch64-neon-scalar-x-indexed-elem-constrained.c llvm/l

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

overmighty added a comment. If this still looks good to you, please commit it as "OverMighty ". Thank you. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158008/new/ https://reviews.llvm.org/D158008 ___ cfe-commits mailing list cfe-commits@li

[clang] 6a11557 - [clang][modules] Avoid storing command-line macro definitions into implicitly built PCM files

Author: Jan Svoboda Date: 2023-08-17T11:11:29-07:00 New Revision: 6a115578324f273ae2b8caef0f034f4bc05ad0b4 URL: https://github.com/llvm/llvm-project/commit/6a115578324f273ae2b8caef0f034f4bc05ad0b4 DIFF: https://github.com/llvm/llvm-project/commit/6a115578324f273ae2b8caef0f034f4bc05ad0b4.diff L

[PATCH] D158136: [clang][modules] Avoid storing command-line macro definitions into implicitly built PCM files

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a115578324f: [clang][modules] Avoid storing command-line macro definitions into implicitly… (authored by jansvoboda11). Changed prior to commit: https://reviews.llvm.org/D158136?vs=550964&id=551197#toc

[PATCH] D158188: [clang][AST] TextNodeDumper learned to output friend information for functions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158188/new/ https://reviews.llvm.org/D158188

[PATCH] D158055: [clang][AST] Added some missing setter methods

aaron.ballman added a comment. In D158055#4594863 , @strimo378 wrote: > Yes, I have a need for these setters :) but I cannot decide if the LLVM > project in general or other people could profit from it. > > I am working on a C++-to-C transpiler based on

[clang] 30c4b97 - [test] Fix unit test case errors.

Author: Han Shen Date: 2023-08-17T11:32:06-07:00 New Revision: 30c4b97aec60895a6905816670f493cdd1d7c546 URL: https://github.com/llvm/llvm-project/commit/30c4b97aec60895a6905816670f493cdd1d7c546 DIFF: https://github.com/llvm/llvm-project/commit/30c4b97aec60895a6905816670f493cdd1d7c546.diff LOG:

[clang] 21e7f73 - Revert "[DebugInfo] Alternate (more efficient) MD5 fix"

Author: Paul Robinson Date: 2023-08-17T11:34:26-07:00 New Revision: 21e7f73494663814e0296066895dfacdebfac6d4 URL: https://github.com/llvm/llvm-project/commit/21e7f73494663814e0296066895dfacdebfac6d4 DIFF: https://github.com/llvm/llvm-project/commit/21e7f73494663814e0296066895dfacdebfac6d4.diff

[clang] 1783185 - Respect integer overflow handling in abs builtin

Author: Artem Labazov Date: 2023-08-17T14:36:00-04:00 New Revision: 1783185790de29b24d3850d33d9a9d586e6bbd39 URL: https://github.com/llvm/llvm-project/commit/1783185790de29b24d3850d33d9a9d586e6bbd39 DIFF: https://github.com/llvm/llvm-project/commit/1783185790de29b24d3850d33d9a9d586e6bbd39.diff

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rG1783185790de: Respect integer overflow handling in abs builtin (authored by artem, committed by aaron.ballman). Changed prior to commit: https://reviews.llvm.org/D156821?vs=550013&id=551210#toc Reposit

[PATCH] D158031: [clang][ExtractAPI] Refactor C++ method and field visitation

evelez7 updated this revision to Diff 551212. evelez7 added a comment. Fix passing Decl's template, introduced from parent updates Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158031/new/ https://reviews.llvm.org/D158031 Files: clang/include/cl

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

ronlieb added a comment. hi, this seems to be breaking out amdgpu opemp and hip buildbots https://lab.llvm.org/staging/#/builders/247/builds/4967 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92797/new/ https://reviews.llvm.org/D92797

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

dyung added a comment. In D92797#4596289 , @ronlieb wrote: > hi, this seems to be breaking out amdgpu opemp and hip buildbots > https://lab.llvm.org/staging/#/builders/247/builds/4967 And also some GCC based bots: https://lab.llvm.org/buildbot/#/builders/

[PATCH] D158071: [clang] Remove rdar links; NFC

aaron.ballman added a comment. In D158071#4593060 , @NoQ wrote: > Uh-oh looks like I missed 3 links that were spelled as `radar://`. I confirm > that they can be safely removed as I looked into those internal bug reports > and found no useful informatio

[PATCH] D155627: [clang][Interp] Handle SourceLocExprs

aaron.ballman added a comment. In D155627#4595089 , @tbaeder wrote: > Having https://reviews.llvm.org/D144457 and https://reviews.llvm.org/D144457 > approved would make rebasing easier :) I can look into https://reviews.llvm.org/D144457, but then having

[PATCH] D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set

rnk added a comment. I don't think this is the right thing to do, I think I recall saying as much on some other review. The MSVC docs say that `/Za`/`/Ze` control `_MSC_EXTENSION`, and as I understand it, `/Za`

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf updated this revision to Diff 551218. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 Files: clang/include/clang/Frontend/ASTUnit.h clang/include/clang/Interpreter/CodeCompletion.h clang/incl

[PATCH] D144457: [clang][Interp] Handle global composite temporaries

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:852 + return false; +return this->emitInitGlobalTempComp(TempDecl, E); } Should this still happen even if `TempDecl` is null? It looks like `getLifetimeExtended

[clang] 4edde41 - [clang][APINotes] Fix build error due to `-fpermissive` on GCC. NFC

Author: Michael Liao Date: 2023-08-17T15:00:39-04:00 New Revision: 4edde41daed5e5e0b9aab2322215ddc2535f4cfd URL: https://github.com/llvm/llvm-project/commit/4edde41daed5e5e0b9aab2322215ddc2535f4cfd DIFF: https://github.com/llvm/llvm-project/commit/4edde41daed5e5e0b9aab2322215ddc2535f4cfd.diff

[PATCH] D156571: [DebugInfo] Alternate MD5 fix, NFC

probinson added a comment. This patch is possibly a suspect in at least some bot failures although I'm at a loss to understand why. Perhaps I can't just blithely call getChecksum() and copy what it sends back? The ways of metadata remai

[PATCH] D154382: [ClangRepl] support code completion at a REPL

v.g.vassilev added a comment. @sammccall could you take another look? It seems quite ready to me to land. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154382/new/ https://reviews.llvm.org/D154382 ___ cf

[PATCH] D157596: [clang][Interp] Handle mixed floating/integral compound assign operators

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:2654 +/// Emit casts from a PrimType to another PrimType +template Comment at: clang/lib/AST/Interp/ByteCodeExprGen.cpp:2659-2664 + if (FromT == PT_F

[PATCH] D157913: [WIP][Coverage] Allow Clang coverage to be used with debug info correlation.

zequanwu updated this revision to Diff 551219. zequanwu added a comment. Update. Binary may still contains __llvm_prf_names sections for functions that are not emitted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157913/new/ https://reviews.llvm

[clang] 83a0699 - [flang][driver] Update the visibility of Clang options in Flang

Author: Andrzej Warzynski Date: 2023-08-17T19:12:12Z New Revision: 83a06997c69a17def2f58fd556c094b8f1060b89 URL: https://github.com/llvm/llvm-project/commit/83a06997c69a17def2f58fd556c094b8f1060b89 DIFF: https://github.com/llvm/llvm-project/commit/83a06997c69a17def2f58fd556c094b8f1060b89.diff

[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG83a06997c69a: [flang][driver] Update the visibility of Clang options in Flang (authored by awarzynski). Changed prior to commit: https://reviews.l

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

hvdijk added a comment. In D86310#4595996 , @tmgross wrote: > @nikic posted a patch that fixes the register passing at > https://reviews.llvm.org/D158169. I think that patch plus this one should > resolve all the problems we have Thanks for the link, th

[PATCH] D157762: [WIP] Implement [[msvc::no_unique_address]]

aaron.ballman added a subscriber: erichkeane. aaron.ballman added a comment. Thank you for working on this! I had some comments, but I ran out of time before I could complete my review. Comment at: clang/include/clang/Basic/Attr.td:1797 +def NoUniqueAddressMSVC : Inheritable

[PATCH] D158137: Rename warn_drv_overriding_flag_option (-Woverriding-t-option) to warn_drv_overriding_flag_option (-Woverriding-option)

MaskRay added a comment. In D158137#4596111 , @MaskRay wrote: > In D158137#4595927 , @dexonsmith > wrote: > >> This seems to drop `-Woverriding-t-option` entirely. Could that break builds >> if someone has (e.g.

[PATCH] D158206: [Driver] Add PIE support on Solaris

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: pengfei, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. `clang` currently lacks PIE support on Solaris. This patch fixes this. Tested on `amd6

[PATCH] D158207: [Driver] Link with crtbeginS.o/crtendS.o on Solaris

ro created this revision. ro added a reviewer: MaskRay. ro added a project: clang. Herald added subscribers: pengfei, jrtc27, fedor.sergeev, jyknight. Herald added a project: All. ro requested review of this revision. `clang` doesn't currently use `crtbeginS.o` and `crtendS.o` on Solaris with `-p

[PATCH] D158206: [Driver] Add PIE support on Solaris

MaskRay added inline comments. Comment at: clang/lib/Driver/ToolChains/Solaris.cpp:55 const char *LinkingOutput) const { + const bool IsPIE = + !Args.hasArg(options::OPT_shared) && On Linux, `clang -r` `-static` also disa

[PATCH] D158206: [Driver] Add PIE support on Solaris

MaskRay added a comment. > I'll submit a follow-up patch to make use of crtbeginS.o and crtendS.o > shortly. I think this patch should make this change, so that the change is correct on itself. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158206

[PATCH] D155568: [clang][Interp] Make sure we push integers of the correct size

vitalybuka added a comment. Breaks the bot https://lab.llvm.org/buildbot/#/builders/74/builds/21336/steps/13/logs/stdio Please take a look or revert? Note: msan_track_origins step may have useful details. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D157750: Properly handle -fsplit-machine-functions for fatbinary compilation

MaskRay added inline comments. Comment at: clang/test/Driver/fsplit-machine-functions-with-cuda-nvptx.c:16 +// causes a warning. +// RUN: %clang --target=x86_64-unknown-linux-gnu -nogpulib -nogpuinc \ +// RUN: --cuda-gpu-arch=sm_70 -x cuda -fsplit-machine-functions -S %s 2>

[PATCH] D157762: [WIP] Implement [[msvc::no_unique_address]]

akhuang added inline comments. Comment at: clang/lib/AST/Decl.cpp:4523-4524 bool FieldDecl::isPotentiallyOverlapping() const { - return hasAttr() && getType()->getAsCXXRecordDecl(); + return (hasAttr() || + hasAttr()) && + getType()->getAsCXXRecordDecl();

[PATCH] D157762: [WIP] Implement [[msvc::no_unique_address]]

akhuang updated this revision to Diff 551242. akhuang marked an inline comment as done. akhuang added a comment. Herald added a reviewer: shafik. Add function to check for no_unique_address attributes Some changes to layout code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D146054: [RISCV] Add --print-supported-extensions support

MaskRay added a comment. Herald added a subscriber: sunshaoce. In D146054#4587210 , @4vtomat wrote: > In D146054#4586067 , @MaskRay wrote: > >> I think the best place to test `RISCVISAInfo.cpp` is >> `llvm/unitte

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

SlaterLatiao updated this revision to Diff 551249. SlaterLatiao added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158006/new/ https://reviews.llvm.org/D158006 Files: clang/include/clang/AST/ExprCXX.h clang

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

SlaterLatiao marked 6 inline comments as done. SlaterLatiao added inline comments. Comment at: clang/lib/Sema/SemaExprMember.cpp:523-524 + auto *TD = TST->getTemplateName().getAsTemplateDecl(); + assert(isa(TD) && + "template decl in member access is not Cla

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

SlaterLatiao updated this revision to Diff 551253. SlaterLatiao marked 2 inline comments as done. SlaterLatiao added a comment. Remove changes in D156546 which doesn't belong to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D157762: [WIP] Implement [[msvc::no_unique_address]]

erichkeane added a comment. still on vaca, but doing a drive-by. Comment at: clang/include/clang/Basic/Attr.td:1798 +def NoUniqueAddressMSVC : InheritableAttr, TargetSpecificAttr { + let Spellings = [CXX11<"msvc", "no_unique_address", 201803>]; + let Subjects = SubjectList<[

[PATCH] D158008: [AArch64] Add patterns for FMADD, FMSUB

overmighty added a comment. The crashes in complex-deinterleaving-f16-mul.ll and fp16_intrinsic_lane.ll seem to be caused by D156831 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158008/new/ https://reviews.llvm.org/D158008 _

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

tmgross added a comment. Is clang still doing something wrong? From my testing, it seems like clang and GCC now agree with each other, I am not sure what would still be incorrect Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86310/new/ https://rev

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam updated this revision to Diff 551266. saiislam marked 6 inline comments as done. saiislam added a comment. Updated the patch as per reviewers comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139730/new/ https://reviews.llvm.org/D139

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

saiislam added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:17143-17145 + llvm::LoadInst *LD; + Constant *Offset, *Offset1; + Value *DP, *DP1; arsenm wrote: > Move down to define and initialize There are multiple uses of the same identifier. De

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

hvdijk added a comment. In D86310#4596712 , @tmgross wrote: > Is clang still doing something wrong? From my testing, it seems like clang > and GCC now agree with each other, I am not sure what would still be incorrect My understanding is that the code cl

[PATCH] D158218: [CMake] Deprecate DEFAULT_SYSROOT and GCC_INSTALL_PREFIX

MaskRay created this revision. MaskRay added reviewers: DavidSpickett, phosek, smeenai, tra, tstellar. Herald added subscribers: ekilmer, s.egerton, abidh, PkmX, atanasyan, simoncook, fedor.sergeev, kristof.beyls, krytarowski, arichardson, sdardis, emaste. Herald added a project: All. MaskRay req

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

tmgross added a comment. In D86310#4596730 , @hvdijk wrote: > My understanding is that the code clang generates for `__int128` will still > allow it to be passed half-in-register, half-in-memory, exactly what D158169 >

[PATCH] D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set

aidengrossman added a comment. In D157334#4596328 , @rnk wrote: > I don't think this is the right thing to do, I think I recall saying as much > on some other review. The MSVC docs >

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks created this revision. Herald added a reviewer: aaron.ballman. Herald added a project: All. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This simply marks the global with the `unnamed_addr` IR attribute so it be merged

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks added a comment. unsure if this should have an RFC or not will add release notes if this is ok to go ahead with Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158223/new/ https://reviews.llvm.org/D158223 __

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks added a comment. and naming can be bikeshed. `no_addrsig` follows https://llvm.org/docs/Extensions.html#sht-llvm-addrsig-section-address-significance-table, `unnamed_addr` follows the IR attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D158055: [clang][AST] Added some missing setter methods

strimo378 abandoned this revision. strimo378 added a comment. Alright, thank you for the review... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158055/new/ https://reviews.llvm.org/D158055 ___ cfe-commi

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

rnk added a comment. So, I'm strongly in favor of the feature, but I want to get feedback on the name. The major pro is that it maps directly to LLVM IR: the attribute does exactly what it says. The major con is that the name isn't really related to what the user wants to do, which is to merge

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86 datalayouts

tmgross added a comment. Was your failure in https://bugs.llvm.org/show_bug.cgi?id=50198 fixed with these patches? I cannot reproduce that failure for some reason, but it would likely make a good run-pass test. These two patches do not seem to fix varargs segfaulting, as documented in https://

[PATCH] D158137: Rename warn_drv_overriding_flag_option (-Woverriding-t-option) to warn_drv_overriding_flag_option (-Woverriding-option)

dexonsmith added a comment. Can you explain the downside of leaving behind an alias? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158137/new/ https://reviews.llvm.org/D158137 ___ cfe-commits mailing lis

[PATCH] D158223: [clang] Add clang::unnamed_addr attribute that marks globals' address as not significant

aeubanks added a comment. merging doesn't have to be done at link time, the optimizer can also do it. so I'd rule out any names with `icf` since that's specifically the name of a linker feature `no_unique_address` popped into my mind but that's already taken :). that's exactly what this is tho

[clang] 41279e8 - [-Wunsafe-buffer-usage] Refactor and improve for parameter fix-its

Author: Ziqing Luo Date: 2023-08-17T15:27:38-07:00 New Revision: 41279e870fa577f8a7f7030b8e45da250d0def9e URL: https://github.com/llvm/llvm-project/commit/41279e870fa577f8a7f7030b8e45da250d0def9e DIFF: https://github.com/llvm/llvm-project/commit/41279e870fa577f8a7f7030b8e45da250d0def9e.diff LO

[PATCH] D156188: [-Wunsafe-buffer-usage] Refactor and improve for parameter fix-its

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ziqingluo-90 marked 2 inline comments as done. Closed by commit rG41279e870fa5: [-Wunsafe-buffer-usage] Refactor and improve for parameter fix-its (authored by ziqinglu

[PATCH] D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set

rnk added a comment. > Also assuming that /Ze is similar to our -fms-extensions which I believe is > the case, but not completely sure I believe that /Ze has more in common with `-fms-compatibility` than `-fms-extensions`, but I could be wrong. Also, they may just be completely different thing

[PATCH] D158137: Rename warn_drv_overriding_flag_option (-Woverriding-t-option) to warn_drv_overriding_flag_option (-Woverriding-option)

MaskRay added a comment. In D158137#4596948 , @dexonsmith wrote: > Can you explain the downside of leaving behind an alias? Two minor ones. (a) Existing `-Wno-overriding-t-option` will not notice that they need to migrate and (b) Clang has accrued tiny

[PATCH] D158226: [CUDA/NVPTX] Improve handling of memcpy for -Os compilations.

tra created this revision. Herald added subscribers: mattd, gchakrabarti, asavonic, bixia, hiraditya, yaxunl. Herald added a project: All. tra published this revision for review. tra added a reviewer: alexfh. Herald added subscribers: llvm-commits, cfe-commits, wangpc, jholewinski. Herald added pr

[PATCH] D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set

aidengrossman added a comment. > I believe that /Ze has more in common with `-fms-compatibility` than > `-fms-extensions`, but I could be wrong. Also, they may just be completely > different things at this point. `/permissive` is closer in spirit to > `-fms-compatibility`. Better documentation

[clang] 110d141 - [clang][AST] TextNodeDumper learned to output friend information for functions

Author: Timo Stripf Date: 2023-08-17T22:41:41Z New Revision: 110d141f12b71c54005ad0919e18926b8895fd05 URL: https://github.com/llvm/llvm-project/commit/110d141f12b71c54005ad0919e18926b8895fd05 DIFF: https://github.com/llvm/llvm-project/commit/110d141f12b71c54005ad0919e18926b8895fd05.diff LOG: [

[PATCH] D158188: [clang][AST] TextNodeDumper learned to output friend information for functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG110d141f12b7: [clang][AST] TextNodeDumper learned to output friend information for functions (authored by strimo378). Repository: rG LLVM Github M

[PATCH] D158227: [clang] EditedSource::applyRewrites - useless call

Manna created this revision. Manna added reviewers: RKSimon, aaron.ballman, tahonermann. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Fixes https://github.com/llvm/llvm-project/issues/53426 Repository: rG LLVM Github Monorepo https://rev

[PATCH] D157441: [-Wunsafe-buffer-usage] Use `Strategy` to determine whether to fix a parameter

t-rasmud added inline comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:2719 + Strategy NaiveStrategy = getNaiveStrategy( + llvm::make_range(VisitedVars.begin(), VisitedVars.end())); VariableGroupsManagerImpl VarGrpMgr(Groups, VarGrpMap, GrpsUnionForParms);

[PATCH] D76283: [IRBuilder] Use preferred target type for len argument of memory intrinsic functions

arsenm requested changes to this revision. arsenm added a comment. This revision now requires changes to proceed. Herald added a project: All. I think any size type should be valid for the intrinsic. Legalization should have to cast the type to the target libcall if that's how it chooses to impl

[PATCH] D76283: [IRBuilder] Use preferred target type for len argument of memory intrinsic functions

arsenm added inline comments. Comment at: llvm/include/llvm/IR/IRBuilder.h:438-446 + ConstantInt *getIntPtrSize(Value *Ptr, uint64_t Size) { +assert(BB && "Must have a basic block to retrieve the module!"); + +Module *M = BB->getParent()->getParent(); +auto *PtrType

[PATCH] D157547: Arm64EC entry/exit thunks, consolidated.

dpaoliello added inline comments. Comment at: llvm/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:2726-2729 +// FIXME: For non-dllimport functions, MSVC emits the same entry +// twice, for reasons I don't understand. I have to assume the linker +// ignores the red

[PATCH] D158218: [CMake] Deprecate DEFAULT_SYSROOT and GCC_INSTALL_PREFIX

smeenai added a comment. Conceptually this seems like a great direction to go in. We should just leave it up for a while so that anyone using these can comment on any potential issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158218/new/ htt

[clang] e3a7950 - [clang-format] Exclude kw_decltype in RemoveParentheses

Author: Owen Pan Date: 2023-08-17T16:04:44-07:00 New Revision: e3a79503a30f8c9d8fba79f3e5427bb895f320cf URL: https://github.com/llvm/llvm-project/commit/e3a79503a30f8c9d8fba79f3e5427bb895f320cf DIFF: https://github.com/llvm/llvm-project/commit/e3a79503a30f8c9d8fba79f3e5427bb895f320cf.diff LOG:

[PATCH] D158155: [clang-format] Exclude kw_decltype in RemoveParentheses

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe3a79503a30f: [clang-format] Exclude kw_decltype in RemoveParentheses (authored by owenpan). Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D156189: [-Wunsafe-buffer-usage] Refactor to let local variable fix-its and parameter fix-its share common code

NoQ accepted this revision. NoQ added a comment. LGTM! I have minor suggestions for comments. Comment at: clang/lib/Analysis/UnsafeBufferUsage.cpp:1791-1794 // For a `VarDecl` of the form `T * var (= Init)?`, this -// function generates a fix-it for the declaration, which re-

[clang] 2afcda6 - [-Wunsafe-buffer-usage] Fix assertion failure in case of BindingDecl

Author: Rashmi Mudduluru Date: 2023-08-17T16:18:38-07:00 New Revision: 2afcda693acba8d63887a6bb0605038b1563c64c URL: https://github.com/llvm/llvm-project/commit/2afcda693acba8d63887a6bb0605038b1563c64c DIFF: https://github.com/llvm/llvm-project/commit/2afcda693acba8d63887a6bb0605038b1563c64c.di

[PATCH] D158112: [-Wunsafe-buffer-usage] Fix assertion failure in case of BindingDecl

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2afcda693acb: [-Wunsafe-buffer-usage] Fix assertion failure in case of BindingDecl (authored by t-rasmud). Herald added a project: clang. Herald adde

<    1   2   3   >