MaskRay added a comment.

In D158137#4595927 <https://reviews.llvm.org/D158137#4595927>, @dexonsmith 
wrote:

> This seems to drop `-Woverriding-t-option` entirely. Could that break builds 
> if someone has (e.g.) `-Werror -Wno-overriding-t-option` in their build 
> settings?

Yes. We could also add an ignored `-Wno-overriding-t-option` to `Options.td`. 
Users who want to ignore the existing diagnostics need to add 
`-Wno-overriding-option` now.
At some point we can add `clang_ignored_legacy_options_Group` to 
`-Wno-overriding-option` so that there will be a warning (error if `-Werror`)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D158137/new/

https://reviews.llvm.org/D158137

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to