[PATCH] D156693: [clang][ASTImporter]Skip check depth of friend template parameter

balazske added inline comments. Comment at: clang/unittests/AST/StructuralEquivalenceTest.cpp:1697 +TEST_F(StructuralEquivalenceTemplateTest, + ClassTemplateEquivalentFriendClassTemplate) { + auto t = makeDecls( IgnoreTemplateParmDepth) {

[PATCH] D156821: [CodeGen] [ubsan] Respect integer overflow handling in abs builtin

artem added a comment. Thanks for the review. I do not have commit rights, could you please push it? Artem Labazov <123321art...@gmail.com> CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156821/new/ https://reviews.llvm.org/D156821 ___ cfe-c

[PATCH] D155290: [PGO] Use Unique Profile Files when New Processes are Forked

phosek added a comment. Can we avoid the use of `pthread_atfork` and the dependency on pthreads? Using pthreads inside the profile runtime implementation is problematic in the case where you want to instrument the libc itself which is used on some platforms and it's one of the reasons why we wo

[PATCH] D157953: [CGCall][RISCV] Handle function calls with parameters of RVV tuple type

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, rogfer01, wangpc. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jon

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

jhenderson accepted this revision. jhenderson added a comment. I'm going to accept this change, although I still have significant concerns about how the whole parsing logic seems more complicated than it needs to be. Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:74 + << "

[PATCH] D156344: Disable call to fma for soft-float

shchenz added a comment. In D156344#4583767 , @long5hot wrote: > In D156344#4583559 , @shchenz wrote: > >> compiler-rt builtins library should not just undefining fma for PPC, right >> (see >> https://gcc.gnu.or

[PATCH] D156693: [clang][ASTImporter]Skip check depth of friend template parameter

jcsxky updated this revision to Diff 550208. jcsxky added a comment. Add more simple testcase to StructuralEquivalenceTest.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156693/new/ https://reviews.llvm.org/D156693 Files: clang/include/clang

[PATCH] D157691: [ASTImporter] Remove extranous FunctionTemplateDecl introduced by templated friend

balazske added a comment. When committing this patch, the commit message should not contain the whole AST and crash dump (phabricator takes the "summary" text), this looks too much in a commit message. One AST dump from the wrong To AST is enough. Comment at: clang/test/Impor

[clang] d60c3d0 - [clang] Skip stores in init for fields that are empty structs

Author: Martin Storsjö Date: 2023-08-15T10:59:23+03:00 New Revision: d60c3d08e78dfbb4b180776b83e910d810e1f36a URL: https://github.com/llvm/llvm-project/commit/d60c3d08e78dfbb4b180776b83e910d810e1f36a DIFF: https://github.com/llvm/llvm-project/commit/d60c3d08e78dfbb4b180776b83e910d810e1f36a.diff

[PATCH] D157332: [clang] Make init for empty no_unique_address fields a no-op write

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd60c3d08e78d: [clang] Skip stores in init for fields that are empty structs (authored by mstorsjo). Changed prior to commit: https://reviews.llvm.

[PATCH] D157691: [ASTImporter] Remove extranous FunctionTemplateDecl introduced by templated friend

danix800 added a comment. In D157691#4587490 , @balazske wrote: > When committing this patch, the commit message should not contain the whole > AST and crash dump (phabricator takes the "summary" text), this looks too > much in a commit message. One AST

[PATCH] D157691: [ASTImporter] Remove extranous FunctionTemplateDecl introduced by templated friend

danix800 updated this revision to Diff 550210. danix800 added a comment. 1. Remove unnecessary testcase. 2. Format unittest code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157691/new/ https://reviews.llvm.org/D157691 Files: clang/lib/AST/AST

[PATCH] D156693: [clang][ASTImporter]Skip check depth of friend template parameter

balazske added inline comments. Comment at: clang/unittests/AST/StructuralEquivalenceTest.cpp:1709 + classTemplateDecl(hasName("A"))); + EXPECT_TRUE(testStructuralMatch(t)); + EXPECT_TRUE(testStructuralMatch(t, true)); The intent was to have `EXPECT_FALSE`

[PATCH] D157952: [clang] Support function pointer types with attributes when extracting parameter names for signature help

sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Sema/SemaCodeComplete.cpp:6073 + if (auto A = Target.getAs()) { +Target = A.getModifiedLoc(); By unwrapping these in a

[clang] 8e329ca - Reland "[Clang][SemaCXX] Add unused warning for variables declared in condition expressions"

Author: Takuya Shimizu Date: 2023-08-15T17:24:13+09:00 New Revision: 8e329caa944c377c51ef567d5aa67cfac9ffd0fa URL: https://github.com/llvm/llvm-project/commit/8e329caa944c377c51ef567d5aa67cfac9ffd0fa DIFF: https://github.com/llvm/llvm-project/commit/8e329caa944c377c51ef567d5aa67cfac9ffd0fa.diff

[PATCH] D157691: [ASTImporter] Remove extranous FunctionTemplateDecl introduced by templated friend

balazske accepted this revision. balazske added a comment. This revision is now accepted and ready to land. Additionally, use the "[clang][ASTImporter]" tags at commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157691/new/ https://revie

[PATCH] D157151: [Driver] Refactor to use llvm Option's new Visibility flags

awarzynski accepted this revision. awarzynski added a comment. This revision is now accepted and ready to land. While quite extensive, I find the overall logic in this patch very well structured and executed in a very clean manner. It removes a lot of ambiguity, makes the overall design much eas

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. The test coverage is also impressive. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156312/new/ https://reviews.llvm.org/D156312 __

[PATCH] D156693: [clang][ASTImporter]Skip check depth of friend template parameter

jcsxky added inline comments. Comment at: clang/unittests/AST/StructuralEquivalenceTest.cpp:1709 + classTemplateDecl(hasName("A"))); + EXPECT_TRUE(testStructuralMatch(t)); + EXPECT_TRUE(testStructuralMatch(t, true)); balazske wrote: > The intent was to hav

[PATCH] D156693: [clang][ASTImporter]Skip check depth of friend template parameter

jcsxky updated this revision to Diff 550214. jcsxky added a comment. Add testcase to illustrate the difference between `TemplateTypeParm` and `NonTypeTemplateParm` in detecting by structural equivalence. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D157855: [clang][ExprConstant] Improve error message of compound assignment against uninitialized object

hazohelet updated this revision to Diff 550216. hazohelet marked an inline comment as done. hazohelet added a comment. Address comments from Timm - Moved test to C++14,20,23 test file from C++20-only one - NFC stylistic changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157855/new/

[PATCH] D157956: [clangd] don't add inlay hint for dependent type in structured binding

v1nh1shungry created this revision. v1nh1shungry added a reviewer: nridge. Herald added subscribers: kadircet, arphaman. Herald added a project: All. v1nh1shungry requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-ex

[PATCH] D157837: [flang][driver] Update the visibility of Clang options in Flang

tblah accepted this revision. tblah added a comment. Looks good to me, thanks for this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157837/new/ https://reviews.llvm.org/D157837 ___ cfe-commits mailing

[PATCH] D157151: [Driver] Refactor to use llvm Option's new Visibility flags

bogner added a comment. In D157151#4587522 , @awarzynski wrote: > This might cause some disruption to downstream consumers of this API and > Options.td. Hopefully, "update_options_td_flags.py" that you've included > should minimise that. I suggest "adv

[PATCH] D157150: [Driver] Update BoolOption to handle Visibility. NFC

bogner updated this revision to Diff 550224. bogner added a comment. Rebase on top of "Visibility" naming. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157150/new/ https://reviews.llvm.org/D157150 Files: clang/include/clang/Driver/Options.h c

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

awarzynski added a comment. Some high level comments: - The logic in `parseCodeGenArgs` in CompilerInvocation.cpp is a bit complex and quite specialized - could you move it to a dedicated method? - In a fair few places this patch make references to "diagnostic flags" or "diagnostic options". Th

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

ro marked an inline comment as done. ro added a comment. In D157275#4585184 , @MaskRay wrote: > Thanks for the update. Regarding testing, it seems that unittests will be > more convenience than creating so many placeholder files in `Inputs/`. > `clang/u

[PATCH] D157275: [Driver] Select newest GCC installation on Solaris

ro updated this revision to Diff 550226. ro marked an inline comment as done. ro added a comment. Herald added a subscriber: ormris. - Simplify `SolarisPrefixes` sorting. - Switch to unitest`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157275/new

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 550232. victorkingi marked 5 inline comments as done. victorkingi added a comment. code refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: flang

[PATCH] D151730: [RISCV] Support target attribute for function

BeMg updated this revision to Diff 550237. BeMg added a comment. rebase and update testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 Files: clang/lib/Basic/Targets/RISCV.cpp clang/lib/Basic/Tar

[PATCH] D152423: [RISCV] Add function that check extension name with version

BeMg updated this revision to Diff 550238. BeMg added a comment. revert last patch because it's wrong one Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152423/new/ https://reviews.llvm.org/D152423 Files: llvm/include/llvm/Support/RISCVISAInfo.h

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

chapuni added a comment. Would this cause many warnings in Clang/LLVM tree? https://lab.llvm.org/buildbot/#/builders/36/builds/36560 I hope you to fix possible warnings at first. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152495/new/ https://re

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

hazohelet added a comment. In D152495#4587804 , @chapuni wrote: > Would this cause many warnings in Clang/LLVM tree? > https://lab.llvm.org/buildbot/#/builders/36/builds/36560 > > I hope you to fix possible warnings at first. Thanks. I'll revert this cha

[PATCH] D157379: [CodeGen] Restrict addEmittedDeferredDecl to incremental extensions

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. @Hahnfeld, let's move forward and rely on a post-commit review here if necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1573

[clang] 5aded52 - Revert "Reland "[Clang][SemaCXX] Add unused warning for variables declared in condition expressions""

Author: Takuya Shimizu Date: 2023-08-15T19:54:51+09:00 New Revision: 5aded521ea94810b81369eaa951dcf59ad5ab82d URL: https://github.com/llvm/llvm-project/commit/5aded521ea94810b81369eaa951dcf59ad5ab82d DIFF: https://github.com/llvm/llvm-project/commit/5aded521ea94810b81369eaa951dcf59ad5ab82d.diff

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

v.g.vassilev accepted this revision. v.g.vassilev added a comment. This revision is now accepted and ready to land. @Hahnfeld, let's move forward and rely on a post-commit review here if necessary. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1565

[PATCH] D157962: [GNU ObjC] Unconditionally emit section markers.

theraven created this revision. Herald added a project: All. theraven requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In the GNUstep v2 ABI (on ELF), we rely on the linker-inserted section start and stop markers. These only exist when bina

[PATCH] D156537: [CodeGen] Keep track of eagerly emitted globals

aaron.ballman added a comment. In D156537#4587832 , @v.g.vassilev wrote: > @Hahnfeld, let's move forward and rely on a post-commit review here if > necessary. Because one of the codegen code owners has been active on the thread with concerns, I think

[PATCH] D157963: [clang-format] Annotate constructor/destructor names

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Annotate constructor/destructor names as `FunctionDeclarationName`.

[PATCH] D155081: Specify the developer policy around links to external resources

This revision was automatically updated to reflect the committed changes. Closed by commit rG677326999f27: Specify the developer policy around links to external resources (authored by aaron.ballman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1550

[PATCH] D144006: [DebugMetadata][DwarfDebug] Support function-local types in lexical block scopes (4/7)

dzhidzhoev updated this revision to Diff 550270. dzhidzhoev added a comment. Rebased (on top of https://reviews.llvm.org/D155818). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144006/new/ https://reviews.llvm.org/D144006 Files: clang/test/CodeG

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

dang added inline comments. Comment at: clang/test/ExtractAPI/objc_various_categories.m:8 +// RUN: %t/myclass_1.h \ +// RUN: %t/input.h -o %t/output.json | FileCheck -allow-empty %s + I don't think you need to have MyClass2 and the associated myclass2.h. It's fi

[PATCH] D157777: [ASTMatcher] Add matcher for 'MacroQualifiedType'

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:7261 +/// Matches macro qualified types. +/// danix800 wrote: > aaron.ballman

[clang] 98322d3 - Complete the implementation of P2361 Unevaluated string literals

Author: Corentin Jabot Date: 2023-08-15T14:13:13+02:00 New Revision: 98322d3eb43168a6a64c1a15a1e754e15c04aa2f URL: https://github.com/llvm/llvm-project/commit/98322d3eb43168a6a64c1a15a1e754e15c04aa2f DIFF: https://github.com/llvm/llvm-project/commit/98322d3eb43168a6a64c1a15a1e754e15c04aa2f.diff

[PATCH] D156237: Complete the implementation of P2361 Unevaluated string literals

This revision was automatically updated to reflect the committed changes. Closed by commit rG98322d3eb431: Complete the implementation of P2361 Unevaluated string literals (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156237/n

[PATCH] D157757: [Headers] Replace __need_STDDEF_H_misc with specific __need_ macros

aaron.ballman accepted this revision. aaron.ballman added a reviewer: libc++. aaron.ballman added a comment. This revision now requires review to proceed. LGTM but I'm adding libc++ as a blocking reviewer because there are questions about how well this interacts with their `stddef.h` (especially

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 550280. victorkingi marked 4 inline comments as done. victorkingi added a comment. code refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: flang

[PATCH] D157681: [clang][AST] TextNodeDumper learned to dump qualifiers (NestedNameSpecifier)

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a small nit (feel free to fix when landing). Comment at: clang/include/clang/AST/TextNodeDumper.h:205 void dumpCleanupObject(const ExprWithCl

[PATCH] D157705: [clang][AST] TextNodeDumper learned to output template specialization kind

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM with a small nit (feel free to fix when landing). Comment at: clang/lib/AST/TextNodeDumper.cpp:2053 VisitRecordDecl(D); + if (auto *CTSD = dyn_cast(D))

[PATCH] D157687: [clang][AST] TextNodeDumper learned to dump NRVO candidates of return stmts

aaron.ballman added a comment. Can you add test coverage for the changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157687/new/ https://reviews.llvm.org/D157687 ___ cfe-commits mailing list cfe-commi

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 550288. victorkingi added a comment. code refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: flang/include/flang/Frontend/CodeGenOptions.h fla

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi added inline comments. Comment at: flang/lib/Frontend/FrontendActions.cpp:976-1011 + void + optimizationRemarkHandler(const llvm::DiagnosticInfoOptimizationBase &d) { +if (d.isPassed()) { + // Optimization remarks are active only if the -Rpass flag has a re

[PATCH] D156032: Implement CWG2137 (list-initialization from objects of the same type)

aaron.ballman added a subscriber: Endill. aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaInit.cpp:4263-4264 + // CWG2311: T{ prvalue_of_type_T } is not eligible for copy elision + // Make this an elision if this won't call an initializer-list const

[PATCH] D157793: [Headers] Add missing __need_ macros to stdarg.h

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Comment at: clang/test/Headers/stdarg.c:34 +__va_copy(g, v); +va_copy(g, v); // c89-error{{implicit}} c89-note{{va_copy}} c99-no-diagnostics +} -

[PATCH] D156032: Implement CWG2137 (list-initialization from objects of the same type)

cor3ntin added inline comments. Comment at: clang/test/CXX/drs/dr23xx.cpp:50 +namespace dr2311 { +#if __cplusplus >= 201707L aaron.ballman wrote: > MitalAshok wrote: > > cor3ntin wrote: > > > the dr status html page is generated automatically by leaving a magic

[PATCH] D126864: [clang] Introduce -fstrict-flex-arrays= for stricter handling of flexible arrays

aaron.ballman added a comment. In D126864#4586307 , @efriedma wrote: > RecordDecl::hasFlexibleArrayMember() is supposed to reflect the standard's > definition of a flexible array member, which only includes incomplete arrays. > The places that care abo

[PATCH] D157962: [GNU ObjC] Unconditionally emit section markers.

theraven updated this revision to Diff 550295. theraven added a comment. Update test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157962/new/ https://reviews.llvm.org/D157962 Files: clang/lib/CodeGen/CGObjCGNU.cpp clang/test/CodeGenObjC/gnu-

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

vhscampos updated this revision to Diff 550298. vhscampos added a comment. - Redone test to cover only what's needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157479/new/ https://reviews.llvm.org/D157479 Files: clang/lib/CodeGen/CGDebugInfo

[PATCH] D157479: [Clang][DebugInfo] Emit narrower base types for structured binding declarations that bind to struct bitfields

vhscampos marked an inline comment as done. vhscampos added a comment. @aprantl We have discussed internally a few options to implement correct debug information in this case. But this will be future work. For the time being, we believe it is better to have no debug information rather than wron

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

Ruturaj4 updated this revision to Diff 550303. Ruturaj4 marked an inline comment as done. Ruturaj4 added a comment. - [clang][ExtractAPI] Add support for Objective-C categories 1. Updating D152770 : [clang][ExtractAPI] Add support for Objective-C categories # 2.

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

dang accepted this revision. dang added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152770/new/ https://reviews.llvm.org/D152770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D157383: [clang][Diagnostics] Provide source range to integer-overflow warnings

hazohelet added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157383/new/ https://reviews.llvm.org/D157383 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

MrTrillian added inline comments. Comment at: clang/test/Lexer/case-insensitive-include-win.c:5-9 +// Note: We must use the real path here, because the logic to detect case +// mismatch relies on resolving the real path and checking that casing differs. +// If we use %t and we ar

[PATCH] D153156: [Clang] CWG1473: do not err on the lack of space after operator""

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from some minor concerns. In D153156#4507440 , @rZhBoYao wrote: > There seems to be no clear objection to this and > https:/

[PATCH] D157452: [RFC][Clang][Codegen] `std::type_info` needs special care with explicit address spaces

AlexVlx updated this revision to Diff 550311. AlexVlx added a comment. Rework the patch as the proposed approach was unsound; keep `typeid` generic. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157452/new/ https://reviews.llvm.org/D157452 Files: clang/lib/CodeGen/CGExprCXX.cpp cla

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

thakis added a comment. In D157808#4587014 , @thakis wrote: > Hello, one of the many dump commits broke tests on macOS: > http://45.33.8.238/macm1/67030/step_7.txt > > Please take a look and revert for now if it takes a while to fix. > > Also, consider s

[PATCH] D157452: [RFC][Clang][Codegen] `std::type_info` needs special care with explicit address spaces

AlexVlx added a comment. In D157452#4586554 , @rjmccall wrote: > The path of least resistance here is that IRGen should just insert > conversions from the global AS to the default AS as part of evaluating > `typeid`. I haven't looked at it closely, but

[PATCH] D157687: [clang][AST] TextNodeDumper learned to dump NRVO candidates of return stmts

strimo378 updated this revision to Diff 550319. strimo378 added a comment. Added test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157687/new/ https://reviews.llvm.org/D157687 Files: clang/include/clang/AST/TextNodeDumper.h clang/lib/AST

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 550320. victorkingi added a comment. rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: flang/include/flang/Frontend/CodeGenOptions.h flang/lib/F

[PATCH] D157687: [clang][AST] TextNodeDumper learned to dump NRVO candidates of return stmts

strimo378 added a comment. @aaron.ballman Alright ... I managed to extend an existing test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157687/new/ https://reviews.llvm.org/D157687 ___ cfe-commits

[PATCH] D157452: [RFC][Clang][Codegen] `std::type_info` needs special care with explicit address spaces

AlexVlx added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:5237-5238 + + if (VTy->isPointerTy() && + VTy->getPointerAddressSpace() != IRTy->getPointerAddressSpace()) { +// In the case of targets that use a non-default address space

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

donat.nagy updated this revision to Diff 550318. donat.nagy edited the summary of this revision. donat.nagy added a comment. I verified that the checker handles the examples in the documentation correctly (and added them to the test suite). However, as I was tweaking the examples in the document

[PATCH] D157334: [clang] Define _MSC_EXTENSIONS on -gnu if -fms-extensions is set

aaron.ballman added a comment. I'm comfortable with the changes but we should add a release note so users know about the change in behavior. I also wonder if we should take this opportunity to add some user-facing documentation around how the target triple, `-fms-compatibility`, and `-fms-exten

[PATCH] D156312: [analyzer] Upstream BitwiseShiftChecker

donat.nagy added a comment. (The release notes entry is still missing, I'll try to add it tomorrow.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156312/new/ https://reviews.llvm.org/D156312 ___ cfe-com

[clang] 611ce24 - [PGO] Enable `-fprofile-update` for `-fprofile-generate`

Author: Qiongsi Wu Date: 2023-08-15T10:10:03-04:00 New Revision: 611ce24114aac1befac6e65d85b0daa721cf71fd URL: https://github.com/llvm/llvm-project/commit/611ce24114aac1befac6e65d85b0daa721cf71fd DIFF: https://github.com/llvm/llvm-project/commit/611ce24114aac1befac6e65d85b0daa721cf71fd.diff LO

[PATCH] D157280: [PGO] Enable `-fprofile-update` for `-fprofile-generate`

This revision was automatically updated to reflect the committed changes. Closed by commit rG611ce24114aa: [PGO] Enable `-fprofile-update` for `-fprofile-generate` (authored by qiongsiwu1). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157280/new/ h

[PATCH] D74094: Reapply: [IRGen] Emit lifetime intrinsics around temporary aggregate argument allocas

lei added a comment. Sorry I missed this. Will kick off now and let you know the results soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74094/new/ https://reviews.llvm.org/D74094 ___ cfe-commits ma

[PATCH] D157879: [clang] Report missing designated initializers in C++

aaron.ballman added a comment. Thank you for working on this! The changes should come with a release note. I think the diagnostic is triggered a bit to aggressively in the case where there is an invalid initializer for a field -- we'll claim there is no initializer in that case, but that effect

[PATCH] D155081: Specify the developer policy around links to external resources

reames added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:349 -* If the patch has been reviewed, add a link to its review page, as shown - `here `_. Removing this item seems very off

[PATCH] D157989: [NFC] Initialize pointer field

Manna created this revision. Manna added reviewers: aaron.ballman, tahonermann. Herald added a subscriber: hiraditya. Herald added a project: All. Manna requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rG LLVM Github Monorepo

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:349 -* If the patch has been reviewed, add a link to its review page, as shown - `here `_. reames wrote: > Removing t

[clang] 7a1735c - Add a triple to clang/test/AST/ast-dump-attr-json.cpp

Author: Hans Wennborg Date: 2023-08-15T17:05:31+02:00 New Revision: 7a1735cd05c2bc0c336f122f01fb35de66e85e16 URL: https://github.com/llvm/llvm-project/commit/7a1735cd05c2bc0c336f122f01fb35de66e85e16 DIFF: https://github.com/llvm/llvm-project/commit/7a1735cd05c2bc0c336f122f01fb35de66e85e16.diff

[PATCH] D157808: [clang] Add missing field to VisibilityAttr json AST dump

hans added a comment. Since reverting seems non-trivial, I added a triple in https://github.com/llvm/llvm-project/commit/7a1735cd05c2bc0c336f122f01fb35de66e85e16 which I believe should fix the test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman marked an inline comment as done. aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:349 -* If the patch has been reviewed, add a link to its review page, as shown - `here

[PATCH] D157917: clang/HIP: Use abs builtins instead of implementing them

AlexVlx accepted this revision. AlexVlx added a comment. This revision is now accepted and ready to land. LGTM, thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157917/new/ https://reviews.llvm.org/D157917 ___ cfe-commits mailing list cf

[PATCH] D156693: [clang][ASTImporter]Skip check depth of friend template parameter

balazske added inline comments. Comment at: clang/unittests/AST/StructuralEquivalenceTest.cpp:1716 + IgnoreTemplateParmDepthAtNonTypeTemplateParmDecl) { + auto t = makeDecls( + R"( The convention is to start variable names with uppercase, for example

[PATCH] D157989: [NFC] Initialize pointer field

tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land. Looks good to me. I see that `OpenMPIRBuilder::emitTargetKernel()` can return without having assigned the `Return` parameter. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D157687: [clang][AST] TextNodeDumper learned to dump NRVO candidates of return stmts

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157687/new/ https://reviews.llvm.org/D157687

[PATCH] D156320: [Flang][Driver] Add support for Rpass and related options

victorkingi updated this revision to Diff 550345. victorkingi added a comment. rebasing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156320/new/ https://reviews.llvm.org/D156320 Files: flang/include/flang/Frontend/CodeGenOptions.h flang/lib/F

[PATCH] D155081: Specify the developer policy around links to external resources

reames added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:349 -* If the patch has been reviewed, add a link to its review page, as shown - `here `_. aaron.ballman wrote: > aaron.ball

[clang] 1849318 - [clang][ExtractAPI] Add support for Objective-C categories

Author: ruturaj4 Date: 2023-08-15T10:34:21-05:00 New Revision: 184931853924b53f5f07602229b9d129540ab02a URL: https://github.com/llvm/llvm-project/commit/184931853924b53f5f07602229b9d129540ab02a DIFF: https://github.com/llvm/llvm-project/commit/184931853924b53f5f07602229b9d129540ab02a.diff LOG:

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

This revision was automatically updated to reflect the committed changes. Closed by commit rG184931853924: [clang][ExtractAPI] Add support for Objective-C categories (authored by Ruturaj4). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152770/new/ h

[PATCH] D157989: [NFC] Initialize pointer field

Manna added a comment. Thank you @tahonermann for reviews and feedbacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157989/new/ https://reviews.llvm.org/D157989 ___ cfe-commits mailing list cfe-commit

[PATCH] D157990: [clangd] Add --query-driver flag to clangd-indexer

tetsuo-cpp created this revision. tetsuo-cpp added reviewers: sammccall, nridge. tetsuo-cpp added projects: clang-tools-extra, All. Herald added subscribers: kadircet, arphaman. tetsuo-cpp requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. When using `clangd` for

[PATCH] D156693: [clang][ASTImporter]Skip check depth of friend template parameter

jcsxky updated this revision to Diff 550352. jcsxky added a comment. Fix variable names according to the convention. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156693/new/ https://reviews.llvm.org/D156693 Files: clang/include/clang/AST/ASTStr

[clang] 3bfafc4 - [clang][AST] TextNodeDumper learned to output template specialization kind

Author: Timo Stripf Date: 2023-08-15T15:46:31Z New Revision: 3bfafc4f22870d00631fe1466676007d73bf6794 URL: https://github.com/llvm/llvm-project/commit/3bfafc4f22870d00631fe1466676007d73bf6794 DIFF: https://github.com/llvm/llvm-project/commit/3bfafc4f22870d00631fe1466676007d73bf6794.diff LOG: [

[PATCH] D157705: [clang][AST] TextNodeDumper learned to output template specialization kind

This revision was automatically updated to reflect the committed changes. Closed by commit rG3bfafc4f2287: [clang][AST] TextNodeDumper learned to output template specialization kind (authored by strimo378). Changed prior to commit: https://reviews.llvm.org/D157705?vs=549346&id=550354#toc Repos

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:349 -* If the patch has been reviewed, add a link to its review page, as shown - `here `_. reames wrote: > aaron.ball

[PATCH] D155081: Specify the developer policy around links to external resources

reames added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:349 -* If the patch has been reviewed, add a link to its review page, as shown - `here `_. aaron.ballman wrote: > reames wro

[PATCH] D155081: Specify the developer policy around links to external resources

aaron.ballman marked 2 inline comments as done. aaron.ballman added inline comments. Comment at: llvm/docs/DeveloperPolicy.rst:349 -* If the patch has been reviewed, add a link to its review page, as shown - `here

  1   2   3   >