jhenderson accepted this revision.
jhenderson added a comment.
I'm going to accept this change, although I still have significant concerns
about how the whole parsing logic seems more complicated than it needs to be.
================
Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:74
+ << " -X{32|64|32_64|any} - Specify which archive symbol tables "
+ "should be generated if they do not already exist (AIX OS only)\n";
}
----------------
DiggerLin wrote:
> jhenderson wrote:
> > Strictly speaking, this should be "Big Archive formats only" not "AIX OS
> > only" since theoretically you could have Big Archive archives on other
> > platforms. However, I'm not bothered if you don't want to change this. The
> > same probably goes for other tools for that matter, but don't change them
> > now.
> Strictly speaking, this should be "Big Archive format on AIX OS only" ,
> in AIX OS , you can still input the -X option , but the X option not work for
> gnu archive format.
Ah, sorry, I misremembered the code, you are right.
It does raise a question whether the -X option at least should be available on
non-AIX platforms, because otherwise there's no way of controlling the symbol
table behaviour like there is on AIX. However, that's probably a different
patch (series) and not necessarily one we need to worry about unless somebody
has an actual use-case.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D142660/new/
https://reviews.llvm.org/D142660
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
