[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

cwalther added a comment. That summary wasn’t intended to be a commit message at all, but a description of the problem and start of the discussion. My commit message was part of the uploaded patch (since I generated it using `git show`) and said > [Driver] Recognize powerpc-*-unknown-eabi as a

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

cor3ntin added a comment. @aaron.ballman @shafik Thanks! I'll address the small nitpicks one we all agree on a direction on whether to have a warning/error/nothing on `static_assert(true, non_constant_expression)` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG76482078cdd2: [RISCV][POC] Model frm control for vfadd (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D154628: [1/8][RISCV] Add rounding mode control variant for vfsub, vfrsub

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG474e37c113ac: [1/8][RISCV] Add rounding mode control variant for vfsub, vfrsub (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

v.g.vassilev added a comment. In D41416#4492367 , @v.g.vassilev wrote: > Address most of the comments. I will need some help with the > `Modules/pr60085.cppm` failure. I suspect we pass to CodeGen some > instantiation by iterator index and that does not

[clang] 6272226 - [dataflow] Remove deprecated BoolValue flow condition accessors

Author: Sam McCall Date: 2023-07-13T09:39:23+02:00 New Revision: 6272226b9f94ba252eabfa7d32e44408b8a12883 URL: https://github.com/llvm/llvm-project/commit/6272226b9f94ba252eabfa7d32e44408b8a12883 DIFF: https://github.com/llvm/llvm-project/commit/6272226b9f94ba252eabfa7d32e44408b8a12883.diff LO

[PATCH] D155152: [dataflow] Remove deprecated BoolValue flow condition accessors

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6272226b9f94: [dataflow] Remove deprecated BoolValue flow condition accessors (authored by sammccall). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D154629: [2/8][RISCV] Add rounding mode control variant for vfwadd, vfwsub

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG00093667b1bd: [2/8][RISCV] Add rounding mode control variant for vfwadd, vfwsub (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D154631: [3/8][RISCV] Add rounding mode control variant for vfmul, vfdiv, vfrdiv, vfwmul

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1a905e823892: [3/8][RISCV] Add rounding mode control variant for vfmul, vfdiv, vfrdiv, vfwmul (authored by eopXD). Repository: rG LLVM Github Mono

[PATCH] D154632: [4/8][RISCV] Add rounding mode control variant for vfmacc, vfnmacc, vfmsac, vfnmsac, vfmadd, vfnmadd, vfmsub, vfnmsub

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1f224a647e6: [4/8][RISCV] Add rounding mode control variant for vfmacc, vfnmacc, vfmsac… (authored by eopXD). Repository: rG LLVM Github Monorepo

[PATCH] D154633: [5/8][RISCV] Add rounding mode control variant for vfwmacc, vfwnmacc, vfwmsac, vfwnmsac

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4085b23609e9: [5/8][RISCV] Add rounding mode control variant for vfwmacc, vfwnmacc, vfwmsac… (authored by eopXD). Repository: rG LLVM Github Monor

[PATCH] D154634: [6/8][RISCV] Add rounding mode control variant for vfsqrt, vfrec7

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG51b9e336619b: [6/8][RISCV] Add rounding mode control variant for vfsqrt, vfrec7 (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D155160: Allow immediate integer for a "p" inline asm constraint

pengfei created this revision. Herald added a project: All. pengfei requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D155160 Files: clang/lib/Basic/Targets/X86.cpp Index: c

[PATCH] D154635: [7/8][RISCV] Add rounding mode control variant for conversion intrinsics between floating-point and integer

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d18d43f26ad: [7/8][RISCV] Add rounding mode control variant for conversion intrinsics… (authored by eopXD). Repository: rG LLVM Github Monorepo

[PATCH] D154636: [8/8][RISCV] Add rounding mode control variant for vfredosum, vfredusum, vfwredosum, vfwredusum

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2c38d6332345: [8/8][RISCV] Add rounding mode control variant for vfredosum, vfredusum… (authored by eopXD). Repository: rG LLVM Github Monorepo C

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

tbaeder added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16999-17000 + + if (CheckOnly) +return true; + aaron.ballman wrote: > E, this seems like a pretty big surprise because evaluating that char > range can fail. This means: > ``` > c

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

ChuanqiXu added a comment. In D41416#4496293 , @v.g.vassilev wrote: > In D41416#4492367 , @v.g.vassilev > wrote: > >> Address most of the comments. I will need some help with the >> `Modules/pr60085.cppm` failure

[clang] 405889e - [RISCV] Remove unused private field 'HasFRMRoundModeOp' in RVVIntrinsic (NFC)

Author: Jie Fu Date: 2023-07-13T16:17:03+08:00 New Revision: 405889ebad95956b4b6db92c92cd15607840f94b URL: https://github.com/llvm/llvm-project/commit/405889ebad95956b4b6db92c92cd15607840f94b DIFF: https://github.com/llvm/llvm-project/commit/405889ebad95956b4b6db92c92cd15607840f94b.diff LOG: [

[clang] d172b65 - [analyzer] Fix crash in MoveChecker when it tries to report duplicate issue

Author: Arseniy Zaostrovnykh Date: 2023-07-13T10:19:40+02:00 New Revision: d172b65ef0013e674a95090940af41885a7ccd36 URL: https://github.com/llvm/llvm-project/commit/d172b65ef0013e674a95090940af41885a7ccd36 DIFF: https://github.com/llvm/llvm-project/commit/d172b65ef0013e674a95090940af41885a7ccd3

[PATCH] D155084: [analyzer] Fix crash in MoveChecker when it tries to report duplicate issue

This revision was automatically updated to reflect the committed changes. Closed by commit rGd172b65ef001: [analyzer] Fix crash in MoveChecker when it tries to report duplicate issue (authored by arseniy-sonar, committed by tomasz-kaminski-sonarsource). Repository: rG LLVM Github Monorepo CHA

[PATCH] D155102: [Clang][RISCV] Align RVV intrinsic builtin names with the C intrinsics

eopXD updated this revision to Diff 539892. eopXD added a comment. Rebase to latest main Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155102/new/ https://reviews.llvm.org/D155102 Files: clang/lib/Sema/SemaChecking.cpp clang/lib/Support/RISCVV

[PATCH] D153612: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

donat.nagy added a comment. (Just added some side remarks about string handling annoyances.) @balazske Please (1) handle the `dyn_cast` request of @steakhal and also (2) do something with this "how to convert `StringRef` to `char *`" question that we're bikeshedding. I hope that after those we

[PATCH] D41416: [modules] [pch] Do not deserialize all lazy template specializations when looking for one.

v.g.vassilev added a comment. In D41416#4496389 , @ChuanqiXu wrote: > In D41416#4496293 , @v.g.vassilev > wrote: > >> In D41416#4492367 , @v.g.vassilev >> wrote: >> >>> Add

[clang] 85c6d57 - [Format][Tooling] Fix HeaderIncludes::insert not respect the main-file header.

Author: Haojian Wu Date: 2023-07-13T10:41:46+02:00 New Revision: 85c6d57eb304482264964778d89fd0554df07592 URL: https://github.com/llvm/llvm-project/commit/85c6d57eb304482264964778d89fd0554df07592 DIFF: https://github.com/llvm/llvm-project/commit/85c6d57eb304482264964778d89fd0554df07592.diff LO

[PATCH] D154963: [Format][Tooling] Fix HeaderIncludes::insert not respect the main-file header.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. hokein marked an inline comment as done. Closed by commit rG85c6d57eb304: [Format][Tooling] Fix HeaderIncludes::insert not respect the main-file header. (authored by ho

[PATCH] D145227: [LLVM][OHOS] Clang toolchain and targets

kpdev42 marked an inline comment as done. kpdev42 added inline comments. Comment at: clang/lib/Driver/ToolChains/OHOS.h:38 + bool isPICDefaultForced() const override { return false; } + bool useRelaxRelocations() const override { return false; } + UnwindLibType GetUnwindLibTyp

[PATCH] D151730: [RISCV] Support target attribute for function

BeMg updated this revision to Diff 539901. BeMg added a comment. Update testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 Files: clang/lib/Basic/Targets/RISCV.cpp clang/lib/Basic/Targets/RISCV.

[PATCH] D155164: [clangd][NFC] Remove dead code

Fznamznon created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. Fznamznon requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. refactor/tweaks/ExtractVariable.cpp: Co

[PATCH] D151730: [RISCV] Support target attribute for function

BeMg updated this revision to Diff 539907. BeMg added a comment. Move riscv-func-attr-target.ll into D155155 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 Files: cla

[PATCH] D155165: [clang][Interp] Fully serialize Floatings to bytes

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, shafik, cor3ntin. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This commit is a bit ugly at the moment since I'm gath

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo marked 19 inline comments as done. VitaNuo added a comment. Thank you! Comment at: clang-tools-extra/clangd/index/SymbolCollector.cpp:839 + if (!Headers.empty()) +SymbolProviders.insert({S.ID, Headers[0]}); } kadircet wrote: > once we have the opt

[PATCH] D152900: [clangd] Update symbol collector to use include-cleaner.

VitaNuo updated this revision to Diff 539908. VitaNuo marked 3 inline comments as done. VitaNuo added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152900/new/ https://reviews.llvm.org/D152900 Files: clang-too

[PATCH] D86310: [X86] Align i128 to 16 bytes in x86-64 datalayout

nikic added a comment. In D86310#4495825 , @hvdijk wrote: > A thought occurs: in older versions of LLVM, the data layout mechanism worked > differently and permitted targets to declare that they supported multiple > different data layout strings, by over

[clang] dd158c1 - [Clang][RISCV] Align RVV intrinsic builtin names with the C intrinsics

Author: eopXD Date: 2023-07-13T02:47:47-07:00 New Revision: dd158c1b4f80d44be4bf92ac4f48d4d3a83c916e URL: https://github.com/llvm/llvm-project/commit/dd158c1b4f80d44be4bf92ac4f48d4d3a83c916e DIFF: https://github.com/llvm/llvm-project/commit/dd158c1b4f80d44be4bf92ac4f48d4d3a83c916e.diff LOG: [C

[PATCH] D155102: [Clang][RISCV] Align RVV intrinsic builtin names with the C intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdd158c1b4f80: [Clang][RISCV] Align RVV intrinsic builtin names with the C intrinsics (authored by eopXD). Repository: rG LLVM Github Monorepo CHA

[PATCH] D155164: [clangd][NFC] Remove dead code

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155164/new/ https://reviews.llvm.org/D155164 __

[PATCH] D155163: [Triple] Add llvm::Triple::isLoongArch{32,64}

SixWeining updated this revision to Diff 539915. SixWeining added a comment. Herald added subscribers: cfe-commits, Enna1, hiraditya. Herald added a project: clang. Use the new added `isLoongArch64()` in some places. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D154701: [ASTImporter] Fix 'isVirtual()' assert failure while importing overridden methods

danix800 updated this revision to Diff 539910. danix800 retitled this revision from "[clang] Overridden CXXMethodDecl::isVirtual() assertion failed before fully imported." to "[ASTImporter] Fix 'isVirtual()' assert failure while importing overridden methods". danix800 edited the summary of this

[PATCH] D155173: [clangd] Refine the workflow for diagnostic Fixits.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a subscriber: arphaman. Herald added a project: All. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. - Remove the diagnostic fixits m

[clang-tools-extra] 8b4a27f - [clangd][NFC] Remove dead code

Author: Mariya Podchishchaeva Date: 2023-07-13T06:47:49-04:00 New Revision: 8b4a27f410ba42b2e19651ddafc60cd878d0963c URL: https://github.com/llvm/llvm-project/commit/8b4a27f410ba42b2e19651ddafc60cd878d0963c DIFF: https://github.com/llvm/llvm-project/commit/8b4a27f410ba42b2e19651ddafc60cd878d096

[PATCH] D155164: [clangd][NFC] Remove dead code

This revision was automatically updated to reflect the committed changes. Closed by commit rG8b4a27f410ba: [clangd][NFC] Remove dead code (authored by Fznamznon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155164/new/ https://reviews.llvm.org/D15

[PATCH] D155175: [Clang] Fix consteval propagation for aggregates and defaulted constructors

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. This patch does a few things: - Fix aggregate initialization. When an aggregate has an initializer that is immedi

[clang] 245d10b - [clang][Interp][NFC] Trim Source.h includes

Author: Timm Bäder Date: 2023-07-13T13:26:03+02:00 New Revision: 245d10b7a2c12ec25e7b5860a38c61991543a739 URL: https://github.com/llvm/llvm-project/commit/245d10b7a2c12ec25e7b5860a38c61991543a739 DIFF: https://github.com/llvm/llvm-project/commit/245d10b7a2c12ec25e7b5860a38c61991543a739.diff LO

[PATCH] D151834: Include math-errno with fast-math

zahiraam updated this revision to Diff 539961. zahiraam marked 6 inline comments as done and an inline comment as not done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151834/new/ https://reviews.llvm.org/D151834 Files: clang/include/clang/Basic/FPOptions.def clang/include/clang/Ba

[PATCH] D153881: Create diagnostic group for definition deprecation warning

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! Do you need me to land this on your behalf? If so, what name and email address would you like me to use for patch attribution? (If I'm landing it, I can fix up the release

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:16999-17000 + + if (CheckOnly) +return true; + tbaeder wrote: > aaron.ballman wrote: > > E, this seems like a pretty big surprise because evaluating that char > > range can

[PATCH] D141414: [clang] add warning on shifting boolean type

aaron.ballman added a comment. In D141414#4494064 , @arsenm wrote: > ping? Thank you for pinging this! I took a quick pass over the changes and they're moving in the right direction, but there are some new test failures that need addressing and some un

[clang] e35719d - [clang][Interp][NFC] Use std::byte for byte code.

Author: Timm Bäder Date: 2023-07-13T13:45:48+02:00 New Revision: e35719da5eaf256ecedfba55b50d7c07bfe596c2 URL: https://github.com/llvm/llvm-project/commit/e35719da5eaf256ecedfba55b50d7c07bfe596c2 DIFF: https://github.com/llvm/llvm-project/commit/e35719da5eaf256ecedfba55b50d7c07bfe596c2.diff LO

[clang] ddbd8ff - [clang][Interp][NFC] Move a declaration into an if statement

Author: Timm Bäder Date: 2023-07-13T13:45:48+02:00 New Revision: ddbd8ffe314bf121c7e488de1b510dea5ecc8b42 URL: https://github.com/llvm/llvm-project/commit/ddbd8ffe314bf121c7e488de1b510dea5ecc8b42 DIFF: https://github.com/llvm/llvm-project/commit/ddbd8ffe314bf121c7e488de1b510dea5ecc8b42.diff LO

[clang] e98cbb9 - [CodeGenCXX] Add test for forward declare as array elem (NFC)

Author: Nikita Popov Date: 2023-07-13T14:26:25+02:00 New Revision: e98cbb95b8b96d3908a808bbcd639680a5197428 URL: https://github.com/llvm/llvm-project/commit/e98cbb95b8b96d3908a808bbcd639680a5197428 DIFF: https://github.com/llvm/llvm-project/commit/e98cbb95b8b96d3908a808bbcd639680a5197428.diff

[PATCH] D153969: [clang][ExprConstant] Fix crash on uninitialized base class subobject

aaron.ballman added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:2422 + << BS.getType(); + Info.Note(BS.getBeginLoc(), diag::note_constexpr_base_inherited_here); + return false; hazohelet wrote: > aaron.ballman wrote

[PATCH] D155145: Add AVX-VNNI-INT16 instructions.

pengfei added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:1059 .Case("avx512vp2intersect", HasAVX512VP2INTERSECT) + .Case("avxvnniint16", HasAVXVNNIINT16) .Case("avxifma", HasAVXIFMA) alphabetical order. Comm

[PATCH] D155146: Add SHA512 instructions.

pengfei added inline comments. Comment at: clang/lib/Headers/CMakeLists.txt:207 shaintrin.h + sha512intrin.h smmintrin.h alphabetical order Comment at: llvm/include/llvm/IR/IntrinsicsX86.td:5112 +def int_x86_vsha512msg1 : ClangBuiltin<"_

[PATCH] D153701: [WIP][Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8901-8914 + // [P2718R0] Lifetime extension in range-based for loops. + // + // 6.7.7 [class.temporary] p5: + // There are four contexts in which temporaries are destroyed at a different + // point th

[PATCH] D154290: [Clang] Implement P2741R3 - user-generated static_assert messages

tbaeder added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:17059 +// the message is grammatically valid without evaluating it. +if (!Failed && AssertMessage && !!Cond) { + std::string Str; Should work, shouldn't it? Repository: rG

[PATCH] D154475: [clang][Interp] Fix ignoring MaterializeTemporaryExprs

tbaeder added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154475/new/ https://reviews.llvm.org/D154475 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D155191: clang/HIP: Directly use f32 exp and log builtins

arsenm created this revision. arsenm added reviewers: AMDGPU, yaxunl, jhuber6, JonChesterfield. Herald added a project: All. arsenm requested review of this revision. Herald added a subscriber: wdng. These are now lowered correctly by the backend, and you get proper fast math flags when directly h

[PATCH] D155147: Add SM3 instructions.

pengfei added inline comments. Comment at: llvm/test/MC/Disassembler/X86/sm3-32.txt:1 + +# RUN: llvm-mc --disassemble %s -triple=i386-unknown-unknown | FileCheck %s --check-prefixes=ATT Remove blank line Comment at: llvm/test/MC/Disassembler/X

[PATCH] D152632: [Clang] Add warnings for CWG2521

aaron.ballman added a comment. Mostly just minor nits from me, otherwise this is looking close to good! If you're able to handle the libc++ failures as part of this patch as well, that'd be great (but isn't required for landing the changes). Comment at: clang/docs/ReleaseNote

[PATCH] D155148: Add SM4 instructions.

pengfei added inline comments. Comment at: llvm/test/MC/Disassembler/X86/sm4-64.txt:3-4 + +# RUN: llvm-mc --disassemble %s -triple=x86_64 | FileCheck %s --check-prefixes=ATT +# RUN: llvm-mc --disassemble %s -triple=x86_64 -x86-asm-syntax=intel --output-asm-variant=1 | FileCheck

[PATCH] D155192: [clang] scan-view: Remove unused python import

tuliom created this revision. tuliom added a reviewer: clang. tuliom added a project: clang. Herald added a project: All. tuliom requested review of this revision. Herald added a subscriber: cfe-commits. [clang] scan-view: Remove unused python import Python's module imp is not being used and is n

[PATCH] D155148: Add SM4 instructions.

pengfei added inline comments. Comment at: llvm/test/CodeGen/X86/sm4-intrinsics.ll:2 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; RUN: llc < %s -O0 -verify-machineinstrs -mtriple=x86_64-unknown-unknown --show-mc-encoding -mattr=+sm4 | FileChe

[PATCH] D155195: [include-cleaner] Avoid a caching issue when running --edit mode on multiple files.

hokein created this revision. hokein added a reviewer: kadircet. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang-tools-extra. Snapshot all analysing files before running the tool, this makes sure that we analyse all files statelessly and avoid t

[PATCH] D155191: clang/HIP: Directly use f32 exp and log builtins

JonChesterfield accepted this revision. JonChesterfield added a comment. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155191/new/ https://reviews.llvm.org/D155191 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:4016-4019 + // Ensure that `-Wunused-variable` will be emitted for condition variables + // that are not referenced later. e.g.: if (int var = init()); + if (!T->isAggregateType()) +ConditionVa

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:4016-4019 + // Ensure that `-Wunused-variable` will be emitted for condition variables + // that are not referenced later. e.g.: if (int var = init()); + if (!T->isAggregateType()) +ConditionVar->se

[clang] 509d051 - [Driver] Warn about -mios-version-min instead of erroring out when

Author: Akira Hatanaka Date: 2023-07-13T06:44:54-07:00 New Revision: 509d051606e837d1b8291743cd1683cf8c582afc URL: https://github.com/llvm/llvm-project/commit/509d051606e837d1b8291743cd1683cf8c582afc DIFF: https://github.com/llvm/llvm-project/commit/509d051606e837d1b8291743cd1683cf8c582afc.diff

[PATCH] D155148: Add SM4 instructions.

skan added inline comments. Comment at: llvm/lib/Target/X86/X86InstrSSE.td:8308 +RC:$src2))]>, + Sched<[WriteVecIMul]>; +def rm : I<0xda, MRMSrcMem, (outs RC:$dst), From the description, it seems that `WriteVecIMul` is not the rig

[PATCH] D155123: [Driver] Warn about -mios-version-min instead of erroring out when targeting MachO embedded architectures

ahatanak closed this revision. ahatanak marked 2 inline comments as done. ahatanak added a comment. Thank you for the review. 509d051606e837d1b8291743cd1683cf8c582afc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D155147: Add SM3 instructions.

skan added inline comments. Comment at: llvm/lib/Target/X86/X86InstrSSE.td:8331 +VR128:$src2, (loadv4i32 addr:$src3), timm:$src4))]>, + Sched<[WriteVecIMul]>; + } Is the schedule appropriate? Comment at: llvm/test/

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

hazohelet marked an inline comment as done. hazohelet added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:4016-4019 + // Ensure that `-Wunused-variable` will be emitted for condition variables + // that are not referenced later. e.g.: if (int var = init()); + if

[PATCH] D152914: [Draft] Make __builtin_cpu builtins target-independent

nemanjai added a comment. In D152914#4428692 , @ilinpv wrote: > Thank you for the patch, it comes in the right time - we are also working on > AArch64 __builtin_cpu_supports, and I was thinking how to make it more > general. > I uploaded our RFC version

[PATCH] D153612: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

balazske updated this revision to Diff 540015. balazske marked 6 inline comments as done. balazske added a comment. Changed format string back to `str().c_str()`, changed `dyn_cast_or_null`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153612/new/

[PATCH] D152914: [Draft] Make __builtin_cpu builtins target-independent

nemanjai added a comment. @arsenm Has my description adequately addressed your question? Do you think we should move forward with [some version of] this patch or do you have any fundamental objections? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D154688: [clang] Show verify prefix in error messages

aaron.ballman added a comment. I'm not opposed but I am wondering what the need is for this? (It'd be good to capture that information in the patch summary as well.) Some examples showing where this helps to correct the issue would be useful. CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D152914: [Draft] Make __builtin_cpu builtins target-independent

arsenm added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:903-907 +// Load of a value provided by the system library at a fixed address. Used for +// accessing things like HWCAP word provided by GLIBC. +def int_fixed_addr_ld +: DefaultAttrsIntrinsic<[llvm_i

[PATCH] D152495: [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:4016-4019 + // Ensure that `-Wunused-variable` will be emitted for condition variables + // that are not referenced later. e.g.: if (int var = init()); + if (!T->isAggregateType()) +ConditionVar->se

[PATCH] D155075: [clang][dataflow] Add `DataflowEnvironment::createObject()`.

mboehme updated this revision to Diff 540022. mboehme added a comment. Rebased to head Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155075/new/ https://reviews.llvm.org/D155075 Files: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironme

[PATCH] D155202: [clang][dataflow] Simplify implementation of `transferStdForwardCall()` in optional check.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The argument and return value of `std::forward`

[PATCH] D155204: [clang][dataflow] Add `refreshStructValue()`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added subscribers: cfe-commits, wangpc. Herald added a project: clang. Besides being a useful abstraction, this

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

pscoro updated this revision to Diff 540026. pscoro added a comment. Fix driver usage of flang-rt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154869/new/ https://reviews.llvm.org/D154869 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp flan

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

aaron.ballman added reviewers: cor3ntin, tahonermann. aaron.ballman added a comment. Adding some other reviewers for more opinions while I ponder the changes. Sema seems like the wrong place to perform such concatenations, but given that adjacent string literals are concatenated during phase 6,

[PATCH] D155202: [clang][dataflow] Simplify implementation of `transferStdForwardCall()` in optional check.

gribozavr2 accepted this revision. gribozavr2 added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:683 - StorageLocation *LocRet = State.Env.getStorageLocation(*E, SkipPast

[PATCH] D86993: Document Clang's expectations of the C standard library.

aaron.ballman added a comment. In D86993#4477744 , @RalfJung wrote: > It would probably be worth including all string functions that take a length > in such a DR. In Rust we are currently puzzling over whether calling 0-length > `memcmp` on something lik

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf added inline comments. Comment at: clang/lib/Interpreter/Interpreter.cpp:304 +llvm::Expected> +Interpreter::createForCodeCompletion( +IncrementalCompilerBuilder &CB, const CompilerInstance *ParentCI, v.g.vassilev wrote: > I still do not entirely unde

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

hazohelet updated this revision to Diff 540029. hazohelet edited the summary of this revision. hazohelet added a comment. Address comments from Corentin, Mark and Nikolas - Removed `InConstantEvaluated` - Removed `RuntimeEvaluated` expression evaluation context kind and instead added a boolean `

[PATCH] D154382: [ClangRepl] support code completion at a REPL

capfredf added inline comments. Comment at: clang/lib/Interpreter/CodeCompletion.cpp:102 + std::vector Results; + auto *CConsumer = new ReplCompletionConsumer(Results); + auto Interp = Interpreter::createForCodeCompletion( v.g.vassilev wrote: > Let's move this

[PATCH] D152914: [Draft] Make __builtin_cpu builtins target-independent

nemanjai added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:903-907 +// Load of a value provided by the system library at a fixed address. Used for +// accessing things like HWCAP word provided by GLIBC. +def int_fixed_addr_ld +: DefaultAttrsIntrinsic<[llvm

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

cor3ntin added inline comments. Comment at: clang/include/clang/Parse/Parser.h:578-582 + bool isTokenConcatenable() const { +return isTokenStringLiteral() || + getLangOpts().MicrosoftExt && + tok::isMSPredefinedMacro(Tok.getKind()); + } -

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

hazohelet marked 9 inline comments as done. hazohelet added a comment. Thank you for the review! Comment at: clang/include/clang/Sema/Sema.h:1277 +/// as PotentiallyEvaluated. +RuntimeEvaluated }; cor3ntin wrote: > I think I'd prefer a boolean for th

[PATCH] D86993: Document Clang's expectations of the C standard library.

xbolva00 added a comment. In D86993#4497744 , @aaron.ballman wrote: > In D86993#4477744 , @RalfJung wrote: > >> It would probably be worth including all string functions that take a length >> in such a DR. In Rust

[PATCH] D86993: Document Clang's expectations of the C standard library.

aaron.ballman added a comment. In D86993#4497851 , @xbolva00 wrote: > In D86993#4497744 , @aaron.ballman > wrote: > >> In D86993#4477744 , @RalfJung wrote: >> >>> It would p

[PATCH] D153701: [WIP][Clang] Implement P2718R0 "Lifetime extension in range-based for loops"

hubert.reinterpretcast added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:8901-8914 + // [P2718R0] Lifetime extension in range-based for loops. + // + // 6.7.7 [class.temporary] p5: + // There are four contexts in which temporaries are destroyed at a different

[PATCH] D153914: [clang-cl] Enable concatenation of predefined identifiers

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1300 case tok::kw___PRETTY_FUNCTION__: // primary-expression: __P..Y_F..N__ [GNU] -Res = Actions.ActOnPredefinedExpr(Tok.getLocation(), SavedKind); -ConsumeToken(); +Res = ParsePredefinedExp

[PATCH] D152914: [Draft] Make __builtin_cpu builtins target-independent

arsenm added inline comments. Comment at: llvm/include/llvm/IR/Intrinsics.td:903-907 +// Load of a value provided by the system library at a fixed address. Used for +// accessing things like HWCAP word provided by GLIBC. +def int_fixed_addr_ld +: DefaultAttrsIntrinsic<[llvm_i

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

AlexVlx added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153092/new/ https://reviews.llvm.org/D153092 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D133289: [C2X] N3007 Type inference for object definitions

aaron.ballman added a comment. In D133289#4489883 , @aaron.ballman wrote: > - `_Atomic auto x = 12;` is now something we should be accepting and deduce > as an `_Atomic int` The committee is discussing this again on the reflectors. Thus far, almost ev

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

cwalther added a comment. I have gone ahead and removed the last paragraph of the summary, assuming that was what was requested. Happy to make other edits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154357/new/ https://reviews.llvm.org/D154357 __

[PATCH] D154357: [Driver] Recognize powerpc-unknown-eabi as a bare-metal toolchain

MaskRay added a comment. In D154357#4496247 , @cwalther wrote: > That summary wasn’t intended to be a commit message at all, but a description > of the problem and start of the discussion. My commit message was part of the > uploaded patch (since I gene

[PATCH] D154688: [clang] Show verify prefix in error messages

tbaeder added a comment. When passing a different prefix via `-verify=foo`, the error messages now say "error: 'foo-error' diagnostics seen but not expected", etc. I'm often working in test files where two different prefixes are used and I'm always confused about which one of the two the error

  1   2   >