pengfei added inline comments.
================ Comment at: clang/lib/Headers/CMakeLists.txt:207 shaintrin.h + sha512intrin.h smmintrin.h ---------------- alphabetical order ================ Comment at: llvm/include/llvm/IR/IntrinsicsX86.td:5112 +def int_x86_vsha512msg1 : ClangBuiltin<"__builtin_ia32_vsha512msg1">, + Intrinsic<[llvm_v4i64_ty], [llvm_v4i64_ty, llvm_v2i64_ty], [IntrNoMem]>; +def int_x86_vsha512msg2 : ClangBuiltin<"__builtin_ia32_vsha512msg2">, ---------------- DefaultAttrsIntrinsic ================ Comment at: llvm/include/llvm/IR/IntrinsicsX86.td:5114 +def int_x86_vsha512msg2 : ClangBuiltin<"__builtin_ia32_vsha512msg2">, + Intrinsic<[llvm_v4i64_ty], [llvm_v4i64_ty, llvm_v4i64_ty], [IntrNoMem]>; +def int_x86_vsha512rnds2 : ClangBuiltin<"__builtin_ia32_vsha512rnds2">, ---------------- ditto. ================ Comment at: llvm/include/llvm/IR/IntrinsicsX86.td:5116 +def int_x86_vsha512rnds2 : ClangBuiltin<"__builtin_ia32_vsha512rnds2">, + Intrinsic<[llvm_v4i64_ty], [llvm_v4i64_ty, llvm_v4i64_ty, llvm_v2i64_ty], + [IntrNoMem]>; ---------------- ditto. ================ Comment at: llvm/test/CodeGen/X86/sha512-intrinsics.ll:2 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; ; RUN: llc < %s -O0 -verify-machineinstrs -mtriple=x86_64-unknown-unknown --show-mc-encoding -mattr=+sha512 | FileCheck %s --check-prefixes=X64 +; RUN: llc < %s -O0 -verify-machineinstrs -mtriple=i686-unknown-unknown --show-mc-encoding -mattr=+sha512 | FileCheck %s --check-prefixes=X86 ---------------- `X64,CHECK` ================ Comment at: llvm/test/CodeGen/X86/sha512-intrinsics.ll:2 +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; ; RUN: llc < %s -O0 -verify-machineinstrs -mtriple=x86_64-unknown-unknown --show-mc-encoding -mattr=+sha512 | FileCheck %s --check-prefixes=X64 +; RUN: llc < %s -O0 -verify-machineinstrs -mtriple=i686-unknown-unknown --show-mc-encoding -mattr=+sha512 | FileCheck %s --check-prefixes=X86 ---------------- pengfei wrote: > `X64,CHECK` No need O0 ================ Comment at: llvm/test/CodeGen/X86/sha512-intrinsics.ll:3 +; ; RUN: llc < %s -O0 -verify-machineinstrs -mtriple=x86_64-unknown-unknown --show-mc-encoding -mattr=+sha512 | FileCheck %s --check-prefixes=X64 +; RUN: llc < %s -O0 -verify-machineinstrs -mtriple=i686-unknown-unknown --show-mc-encoding -mattr=+sha512 | FileCheck %s --check-prefixes=X86 + ---------------- `X86,CHECK` ================ Comment at: llvm/test/CodeGen/X86/sha512-intrinsics.ll:3 +; ; RUN: llc < %s -O0 -verify-machineinstrs -mtriple=x86_64-unknown-unknown --show-mc-encoding -mattr=+sha512 | FileCheck %s --check-prefixes=X64 +; RUN: llc < %s -O0 -verify-machineinstrs -mtriple=i686-unknown-unknown --show-mc-encoding -mattr=+sha512 | FileCheck %s --check-prefixes=X86 + ---------------- pengfei wrote: > `X86,CHECK` ditto. ================ Comment at: llvm/test/MC/Disassembler/X86/sha512-64.txt:1-2 +# RUN: llvm-mc --disassemble %s -triple=x86_64 | FileCheck %s --check-prefixes=ATT +# RUN: llvm-mc --disassemble %s -triple=x86_64 -x86-asm-syntax=intel --output-asm-variant=1 | FileCheck %s --check-prefixes=INTEL + ---------------- This can be merged with `sha512-32.txt` ================ Comment at: llvm/test/MC/X86/sha512-att-64.s:1 +// RUN: llvm-mc -triple x86_64 --show-encoding %s | FileCheck %s + ---------------- ditto. ================ Comment at: llvm/test/MC/X86/sha512-intel-64.s:1 +// RUN: llvm-mc -triple x86_64 -x86-asm-syntax=intel -output-asm-variant=1 --show-encoding %s | FileCheck %s + ---------------- ditto. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews.llvm.org/D155146 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
