[PATCH] D153652: [llvm][Support] Don'tt set "all_exe" mode by default for file written by llvm::writeToOutput.

hokein updated this revision to Diff 534438. hokein added a comment. Herald added subscribers: MaskRay, emaste. Herald added a reviewer: alexander-shaposhnikov. add lit tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153652/new/ https://review

[PATCH] D153652: [llvm][Support] Don'tt set "all_exe" mode by default for file written by llvm::writeToOutput.

hokein added a comment. In D153652#4445285 , @avl wrote: > Agree that it is safe to remove all_exec from the default permissions. There > are currently three usages of writeToOutput API: clang include cleaner, > llvm-objcopy, llvm-dwarfutil. Both llvm-o

[PATCH] D153370: [RISCV] Add support for custom instructions for Sifive S76.

garvitgupta08 updated this revision to Diff 534437. garvitgupta08 added a comment. Addressed the changes. I do not have commit access, could you please commit this differential on my behalf? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153

[PATCH] D153370: [RISCV] Add support for custom instructions for Sifive S76.

craig.topper added a comment. In D153370#4447817 , @garvitgupta08 wrote: > Addressed the changes. I do not have commit access, could you please commit > this differential on my behalf? Thanks. Yes. Can you provide the name and email address for the git

[clang] f693200 - [Clang][LoongArch] Consume and check -mabi and -mfpu even if -m*-float is present

Author: WANG Xuerui Date: 2023-06-26T15:07:22+08:00 New Revision: f6932007ab4e047e17e04ae8a024105700b7d906 URL: https://github.com/llvm/llvm-project/commit/f6932007ab4e047e17e04ae8a024105700b7d906 DIFF: https://github.com/llvm/llvm-project/commit/f6932007ab4e047e17e04ae8a024105700b7d906.diff L

[PATCH] D153707: [Clang][LoongArch] Consume and check -mabi and -mfpu even if -m*-float is present

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6932007ab4e: [Clang][LoongArch] Consume and check -mabi and -mfpu even if -m*-float is… (authored by WANG Xuerui , committed by SixWeining). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D152436: [clang][analyzer] Move checker alpha.unix.StdCLibraryFunctions out of alpha.

Szelethus added a comment. In D152436#4443858 , @balazske wrote: > In D152436#4438956 , @NoQ wrote: > >> I'm somewhat skeptical of the decision made in D151225 >> because the en

[PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

hokein created this revision. hokein added a reviewer: avl. Herald added subscribers: ormris, kadircet, arphaman, steven_wu, hiraditya. Herald added a project: All. hokein requested review of this revision. Herald added projects: clang, LLDB, LLVM, clang-tools-extra. Herald added subscribers: llvm-

[PATCH] D153510: [Clang][RISCV] Check type support for local variable declaration of RVV type

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4969 + const TargetInfo &TI = Context.getTargetInfo(); + if ((Ty->isRVVBoolType() || + Ty->isRVVType(/* Bitwidth */ 8, /* IsFloat */ false) || We don't to check exactly what t

[PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

hokein added a comment. Herald added a subscriber: JDevlieghere. Let me know what you think about it -- I considered keeping the `llvm::writeFileAtomically` and migrating its underlying implementation to `llvm::writeToOutput`, but it doesn't seem to worth, there are only 4 in-tree usages of thi

[PATCH] D153510: [Clang][RISCV] Check type support for local variable declaration of RVV type

eopXD updated this revision to Diff 534445. eopXD added a comment. Simplify check with the presumption that caller has called `isRVVType()` before calling `isRVVTypeSupport`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153510/new/ https://review

[PATCH] D153510: [Clang][RISCV] Check type support for local variable declaration of RVV type

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153510/new/ https://reviews.llvm.org/D153510 ___

[PATCH] D153370: [RISCV] Add support for custom instructions for Sifive S76.

garvitgupta08 added a comment. In D153370#4447824 , @craig.topper wrote: > In D153370#4447817 , @garvitgupta08 > wrote: > >> Addressed the changes. I do not have commit access, could you please commit >> this d

[PATCH] D153741: [Tooling][Rewriter] Remove the redundant AtomicallyMovedFile Implementation.

hokein created this revision. hokein added a reviewer: avl. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Replace it with llvm::writeToOutput. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D153741 Files: clang/lib/Rewri

[clang] 82dff24 - Reland [COFF] Support -gsplit-dwarf for COFF on Windows

Author: Haohai Wen Date: 2023-06-26T15:48:38+08:00 New Revision: 82dff24bde112984314568e7d581379fd0ea48e6 URL: https://github.com/llvm/llvm-project/commit/82dff24bde112984314568e7d581379fd0ea48e6 DIFF: https://github.com/llvm/llvm-project/commit/82dff24bde112984314568e7d581379fd0ea48e6.diff LO

[PATCH] D153491: [dataflow] Avoid copying environment

xazax.hun added a comment. In D153491#4445051 , @ymandel wrote: > In D153491#4443704 , @xazax.hun > wrote: > >> This sounds extremely error-prone to me. In case copying the analysis state >> has side effects lik

[PATCH] D153745: [clang-format] Fix bugs in annotating r_paren as C-style cast

owenpan created this revision. Herald added projects: All, clang, clang-format. Herald added a subscriber: cfe-commits. Herald added reviewers: rymiel, HazardyKnusperkeks, MyDeveloperDay. owenpan requested review of this revision. Don't annotate r_paren as TT_CastRParen if it's in a macro definiti

[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

xazax.hun accepted this revision. xazax.hun added a comment. Nice, looks like this change did catch some unintentional copies! Already paying dividends :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153674/new/ https://reviews.llvm.org/D153674

[PATCH] D152785: [COFF] Support -gsplit-dwarf for COFF on Windows

HaohaiWen added a comment. Reland 82dff24bde112984314568e7d581379fd0ea48e6 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152785/new/ https://reviews.llvm.org/D152785 __

[PATCH] D153746: [Remarks] Make sure -fdiagnostics-hotness-threshold implies -fdiagnostics-show-hotness

serge-sans-paille created this revision. serge-sans-paille added a reviewer: weiwang. Herald added a subscriber: hiraditya. Herald added a project: All. serge-sans-paille requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Whe

[PATCH] D153652: [llvm][Support] Don'tt set "all_exe" mode by default for file written by llvm::writeToOutput.

jhenderson added a comment. Is there anything that can be done to use gtest unit tests for this? The two lit tests are useful, but the problem with them is that if they switch to using a different approach to emitting their data, the lit tests won't cover the Support code you're actually changi

[PATCH] D153536: [Clang] Implement P2169 A nice placeholder with no name

cor3ntin updated this revision to Diff 534455. cor3ntin added a comment. Address ChuanqiXu's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153536/new/ https://reviews.llvm.org/D153536 Files: clang/docs/ReleaseNotes.rst clang/include/c

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

jobnoorman updated this revision to Diff 534456. jobnoorman added a comment. Herald added a subscriber: wangpc. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150549/new/ https://reviews.llvm.org/D150549 Files: clang/lib/CodeGen/BackendUti

[clang] 3b85be3 - [Clang][RISCV] Check type support for local variable declaration of RVV type

Author: eopXD Date: 2023-06-26T01:59:40-07:00 New Revision: 3b85be3df23cfb8fb4d1f0656eac3214cf400c72 URL: https://github.com/llvm/llvm-project/commit/3b85be3df23cfb8fb4d1f0656eac3214cf400c72 DIFF: https://github.com/llvm/llvm-project/commit/3b85be3df23cfb8fb4d1f0656eac3214cf400c72.diff LOG: [C

[PATCH] D153510: [Clang][RISCV] Check type support for local variable declaration of RVV type

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b85be3df23c: [Clang][RISCV] Check type support for local variable declaration of RVV type (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

PiotrZSL added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/Headers/cstddef:12 -typedef __typeof__(sizeof(0)) size_t; +#include "stddef.h" We shouldn't include this stddef.h, it's being included from system headers. Reposit

[PATCH] D153746: [Remarks] Make sure -fdiagnostics-hotness-threshold implies -fdiagnostics-show-hotness

thegameg accepted this revision. thegameg added a comment. This revision is now accepted and ready to land. Makes sense, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153746/new/ https://reviews.llvm.org/D153746 ___

[PATCH] D153691: [Driver][ARM] Warn about -mabi= for assembler input

michaelplatings added a comment. The change seems OK to me in principle, but I'd appreciate the code being more self-descriptive. Thanks. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:528 + +// Accept but warn. +if (Arg *A = Args.getLastArgNoClaim(options::OPT_m

[clang] 6e39b0d - [clang-format][NFC] Use correct test method for new tests

Author: Emilia Kond Date: 2023-06-26T12:27:57+03:00 New Revision: 6e39b0ddf08ab5cd44fed2d16e9669d64aa733ef URL: https://github.com/llvm/llvm-project/commit/6e39b0ddf08ab5cd44fed2d16e9669d64aa733ef DIFF: https://github.com/llvm/llvm-project/commit/6e39b0ddf08ab5cd44fed2d16e9669d64aa733ef.diff L

[PATCH] D150848: [clang-format] Respect ColumnLimit 0 line breaks in inline asm

rymiel marked 2 inline comments as done. rymiel added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:4626-4627 + verifyFormat(Code1, Style); + EXPECT_EQ(Code2, format(Code2, Style)); + EXPECT_EQ(Code3, format(Code3, Style)); + owenpan wrote

[clang] 8de9f2b - Move SubtargetFeature.h from MC to TargetParser

Author: Job Noorman Date: 2023-06-26T11:20:08+02:00 New Revision: 8de9f2b558a046da15cf73191da627bdd83676ca URL: https://github.com/llvm/llvm-project/commit/8de9f2b558a046da15cf73191da627bdd83676ca DIFF: https://github.com/llvm/llvm-project/commit/8de9f2b558a046da15cf73191da627bdd83676ca.diff L

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8de9f2b558a0: Move SubtargetFeature.h from MC to TargetParser (authored by jobnoorman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D153745: [clang-format] Fix bugs in annotating r_paren as C-style cast

rymiel accepted this revision. rymiel added a comment. It appears other operators aren't affected, after D153641 I would have not been surprised if && had become unary :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D152996: [RISCV][POC] Model frm control for vfadd

eopXD added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152996/new/ https://reviews.llvm.org/D152996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D153560: [Clang] Allow C++11 style initialisation of SVE types.

andrew added a comment. With this I can build the Arm Compute Library for SVE with clang Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153560/new/ https://reviews.llvm.org/D153560 ___ cfe-commits mailing

[clang-tools-extra] 6f065bf - [clangd][c++20]Consider rewritten binary operators in TargetFinder

Author: Jens Massberg Date: 2023-06-26T11:26:10+02:00 New Revision: 6f065bfd633d7ca006f62b894108d5369dc46836 URL: https://github.com/llvm/llvm-project/commit/6f065bfd633d7ca006f62b894108d5369dc46836 DIFF: https://github.com/llvm/llvm-project/commit/6f065bfd633d7ca006f62b894108d5369dc46836.diff

[PATCH] D153331: [clangd][c++20]Consider rewritten binary operators in TargetFinder

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f065bfd633d: [clangd][c++20]Consider rewritten binary operators in TargetFinder (authored by massberg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153331

[clang] 15e14f1 - [clang-format] Preserve AmpAmpTokenType in nested parentheses

Author: Emilia Kond Date: 2023-06-26T12:39:16+03:00 New Revision: 15e14f129fe24db989ed91737e96505863e20c60 URL: https://github.com/llvm/llvm-project/commit/15e14f129fe24db989ed91737e96505863e20c60 DIFF: https://github.com/llvm/llvm-project/commit/15e14f129fe24db989ed91737e96505863e20c60.diff L

[PATCH] D153641: [clang-format] Preserve AmpAmpTokenType in nested parentheses

This revision was automatically updated to reflect the committed changes. Closed by commit rG15e14f129fe2: [clang-format] Preserve AmpAmpTokenType in nested parentheses (authored by rymiel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153641/new/

[PATCH] D153652: [llvm][Support] Don'tt set "all_exe" mode by default for file written by llvm::writeToOutput.

hokein updated this revision to Diff 534473. hokein added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153652/new/ https://reviews.llvm.org/D153652 Files: llvm/lib/Support/raw_ostream.cpp llvm/test/tools/llvm-dwarf

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

PiotrZSL added a comment. Test is failing: https://lab.llvm.org/buildbot/#/builders/230/builds/14939/steps/6/logs/FAIL__Clang_Tools__use-std-print_cpp https://lab.llvm.org/buildbot/#/builders/245/builds/10266 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D153652: [Support] Don't set "all_exe" mode by default for file written by llvm::writeToOutput

hokein added a comment. Thanks for the comments. In D153652#4447976 , @jhenderson wrote: > Is there anything that can be done to use gtest unit tests for this? The two > lit tests are useful, but the problem with them is that if they switch to > using

[PATCH] D144164: [clang][Interp] Handle PtrMemOps

tbaeder added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144164/new/ https://reviews.llvm.org/D144164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D153612: [clang][analyzer] Add and change NoteTags in StdLibraryFunctionsChecker.

balazske updated this revision to Diff 534487. balazske added a comment. Add note tag always if function is not evaluated as "pure". Reformat the code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153612/new/ https://reviews.llvm.org/D153612 File

[PATCH] D153652: [Support] Don't set "all_exe" mode by default for file written by llvm::writeToOutput

avl added a comment. In D153652#4448157 , @hokein wrote: > Thanks for the comments. > > In D153652#4447976 , @jhenderson > wrote: > >> Is there anything that can be done to use gtest unit tests for this? The two

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs passed as function arguments

chill added inline comments. Comment at: clang/lib/CodeGen/TargetInfo.cpp:5813 getContext().getTypeUnadjustedAlignInChars(Ty).getQuantity(); -unsigned BaseAlign = getContext().getTypeAlignInChars(Base).getQuantity(); -Align = (Align > BaseAlign && Align >= 16) ?

[PATCH] D153652: [Support] Don't set "all_exe" mode by default for file written by llvm::writeToOutput

jhenderson added inline comments. Comment at: llvm/test/tools/llvm-dwarfutil/ELF/X86/file-permissions.test:1 +# RUN: yaml2obj %p/Inputs/common.yaml -o %t.o +# RUN: chmod a+x %t.o hokein wrote: > jhenderson wrote: > > It might make sense to reuse the test code fro

[PATCH] D153294: [clang] Do not create ExprWithCleanups while checking immediate invocation

Fznamznon added a comment. > One thing we will need to be careful about is assigning any block / compound > literal cleanups to the right ExprWithCleanups node. We can figure out where > to put them by doing a traversal of the ConstantExpr's subexpression to see > if it contains the BlockDecl /

[PATCH] D149280: [clang-tidy] Add modernize-printf-to-std-print check

mikecrowe marked an inline comment as done. mikecrowe added a comment. In D149280#4448158 , @PiotrZSL wrote: > Test is failing: > https://lab.llvm.org/buildbot/#/builders/230/builds/14939/steps/6/logs/FAIL__Clang_Tools__use-std-print_cpp > https://lab.llv

[clang] f686e4b - [Remarks] Make sure -fdiagnostics-hotness-threshold implies -fdiagnostics-show-hotness

Author: serge-sans-paille Date: 2023-06-26T13:48:10+02:00 New Revision: f686e4bbc20a837ff5230656431aec1abbd5f872 URL: https://github.com/llvm/llvm-project/commit/f686e4bbc20a837ff5230656431aec1abbd5f872 DIFF: https://github.com/llvm/llvm-project/commit/f686e4bbc20a837ff5230656431aec1abbd5f872.d

[PATCH] D153746: [Remarks] Make sure -fdiagnostics-hotness-threshold implies -fdiagnostics-show-hotness

This revision was automatically updated to reflect the committed changes. Closed by commit rGf686e4bbc20a: [Remarks] Make sure -fdiagnostics-hotness-threshold implies -fdiagnostics-show… (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

avl added a reviewer: jkorous. avl added a subscriber: jkorous. avl added a comment. added @jkorous who originally added llvm::writeFileAtomically. > Let me know what you think about it -- I considered keeping the > llvm::writeFileAtomically and migrating its underlying implementation to > llvm

[PATCH] D153652: [Support] Don't set "all_exe" mode by default for file written by llvm::writeToOutput

hokein updated this revision to Diff 534507. hokein added a comment. address comments: - add unittest for llvm::writeToOutput API - refine the llvm-dwarfutil tool lit test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153652/new/ https://reviews.l

[PATCH] D153652: [Support] Don't set "all_exe" mode by default for file written by llvm::writeToOutput

hokein added a comment. Thanks for the comment. > unit test which checks llvm::writeOutput may be added to > raw_ostream_test.cpp. Let`s this test check the case when "all_exec" is not > set. i.e. that after default usage of llvm::writeOutput the resulting file > does not have "all_exec", whic

[clang] 7ff507f - Diagnose incorrect syntax for #pragma clang diagnostic

Author: Aaron Ballman Date: 2023-06-26T08:05:47-04:00 New Revision: 7ff507f1448bfdfcaa91d177d1f655dcb17557e7 URL: https://github.com/llvm/llvm-project/commit/7ff507f1448bfdfcaa91d177d1f655dcb17557e7 DIFF: https://github.com/llvm/llvm-project/commit/7ff507f1448bfdfcaa91d177d1f655dcb17557e7.diff

[PATCH] D150860: [OpenMP] Change clang emitTargetDataCalls to use OMPIRBuilder

TIFitis added a comment. Gentle ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150860/new/ https://reviews.llvm.org/D150860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D153590: Don't use float_t and double_t with #pragma clang fp eval_method.

zahiraam added a comment. In D153590#4446358 , @mgorny wrote: > This change causes test regressions on 32-bit x86: > > FAIL: Clang :: Sema/fp-eval-pragma-with-float-double_t-3.c (14665 of 17845) > TEST 'Clang :: > Sema/fp-eval-pr

[PATCH] D152658: [InstCombine] Change SimplifyDemandedVectorElts to use PoisonElts instead of UndefElts

ManuelJBrito added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152658/new/ https://reviews.llvm.org/D152658 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D153092: [Clang][CodeGen]`vtable`, `typeinfo` et al. are globals

yaxunl added a comment. In D153092#4447445 , @AlexVlx wrote: > Fixed issue found via internal testing (thanks @yaxunl). Can we add a test to cover the regression found via internal testing? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D147218: [OpenMP][Flang][MLIR] Lowering of OpenMP requires directive from parse tree to MLIR

skatrak updated this revision to Diff 534512. skatrak added a comment. Update to integrate with changes to parent patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147218/new/ https://reviews.llvm.org/D147218 Files: flang/include/flang/Lower/

[PATCH] D147875: [clang][Diagnostics] Show line numbers when printing code snippets

hans added a comment. I noticed that at least for some cases of `-Wformat`, the line numbers on the left seem to be off: https://github.com/llvm/llvm-project/issues/63524 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147875/new/ https://reviews.ll

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe added a comment. gentle ping _cpu_dispatch/specific feature owner @erichkeane. Any comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 ___ cfe-co

[PATCH] D152989: Pre-commit test for D151696.

FreddyYe added a comment. As mentioned in https://reviews.llvm.org/D151696, ping here, too. I want to land this patch first so that I could add some new Intel CPUs in this test supported in https://reviews.llvm.org/D151696 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D151753: [Clang][Sema] Do not try to analyze dependent alignment during -Wcast-align

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. Needs a release note, else LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151753/new/ https://reviews.llvm.org/D151753 ___ cf

[PATCH] D153740: [llvm][Support] Deprecate llvm::writeFileAtomically API

hokein added a comment. In D153740#4448408 , @avl wrote: > added @jkorous who originally added llvm::writeFileAtomically. > >> Let me know what you think about it -- I considered keeping the >> llvm::writeFileAtomically and migrating its underlying imple

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

erichkeane added a comment. I think this is OK, I have a slight fear we're losing a bit of the 'tune' functionality, but it is not impossible that we've never really cared about that. One concern I have is that the list was used for the resolver function, but I don't see any test changes for t

[clang] c2bb680 - [dataflow] Disallow implicit copy of Environment, use fork() instead

Author: Sam McCall Date: 2023-06-26T15:26:02+02:00 New Revision: c2bb68078eb9ef79d8d928bc863c6ed0308b1965 URL: https://github.com/llvm/llvm-project/commit/c2bb68078eb9ef79d8d928bc863c6ed0308b1965 DIFF: https://github.com/llvm/llvm-project/commit/c2bb68078eb9ef79d8d928bc863c6ed0308b1965.diff LO

[PATCH] D153674: [dataflow] Disallow implicit copy of Environment, use fork() instead

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2bb68078eb9: [dataflow] Disallow implicit copy of Environment, use fork() instead (authored by sammccall). Changed prior to commit: https://revie

[PATCH] D153702: [Clang] Implement P2738R1 - constexpr cast from void*

erichkeane added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8920 + if (HasValidResult) +CCEDiag(E, diag::note_constexpr_invalid_void_star_cast) +<< SubExpr->getType() << Info.getLangOpts().CPlusPlus26 Does thi

[PATCH] D153296: [AST] Stop evaluate constant expression if the condition expression which in switch statement contains errors

erichkeane added a comment. In D153296#4446016 , @shafik wrote: > In D153296#612 , @erichkeane > wrote: > >> So I think I'm pretty confident that the only time we would call >> `EvaluateDependentExpr` is whe

[PATCH] D153542: [C++20][Modules] Implement P2615R1 exported specialization diagnostics.

iains added inline comments. Comment at: clang/lib/Sema/SemaModule.cpp:848-849 +if (auto *FD = dyn_cast(D)) { + if (FD->getTemplateSpecializationKind() == TSK_ExplicitSpecialization) +BadExport = true; +} else if (auto *VD = dyn_cast(D)) { Ch

[PATCH] D153702: [Clang] Implement P2738R1 - constexpr cast from void*

cor3ntin updated this revision to Diff 534524. cor3ntin added a comment. Add tests for C++23 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153702/new/ https://reviews.llvm.org/D153702 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basi

[PATCH] D153702: [Clang] Implement P2738R1 - constexpr cast from void*

cor3ntin added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:8920 + if (HasValidResult) +CCEDiag(E, diag::note_constexpr_invalid_void_star_cast) +<< SubExpr->getType() << Info.getLangOpts().CPlusPlus26 erichkeane

[PATCH] D152720: [clangd][ObjC] Support ObjC class rename from implementation decls

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks! Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:144 +const NamedDecl *pickInterestingTarget(const NamedDecl *D) { + // We only support renaming the cl

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

FreddyYe added a comment. In D151696#4448573 , @erichkeane wrote: > I think this is OK, I have a slight fear we're losing a bit of the 'tune' > functionality, but it is not impossible that we've never really cared about > that. One concern I have is t

[PATCH] D151681: [CMake][Fuchsia] Enable standalone libatomic

This revision was automatically updated to reflect the committed changes. Closed by commit rG1be27bd8ce08: [CMake][Fuchsia] Enable standalone libatomic (authored by abrachet). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] 1be27bd - [CMake][Fuchsia] Enable standalone libatomic

Author: Alex Brachet Date: 2023-06-26T13:49:22Z New Revision: 1be27bd8ce085a81090041b324fb19a4a6261724 URL: https://github.com/llvm/llvm-project/commit/1be27bd8ce085a81090041b324fb19a4a6261724 DIFF: https://github.com/llvm/llvm-project/commit/1be27bd8ce085a81090041b324fb19a4a6261724.diff LOG:

[clang] f2123af - [clang][dataflow] Perform deep copies in copy and move operations.

Author: Martin Braenne Date: 2023-06-26T13:52:56Z New Revision: f2123af1e7d7555af92b1bcff91bd5d0679a9b55 URL: https://github.com/llvm/llvm-project/commit/f2123af1e7d7555af92b1bcff91bd5d0679a9b55 DIFF: https://github.com/llvm/llvm-project/commit/f2123af1e7d7555af92b1bcff91bd5d0679a9b55.diff LOG

[PATCH] D153006: [clang][dataflow] Perform deep copies in copy and move operations.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf2123af1e7d7: [clang][dataflow] Perform deep copies in copy and move operations. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153006/

[PATCH] D153131: [clang analysis][thread-safety] Handle return-by-reference...

courbet added inline comments. Comment at: clang/include/clang/Basic/DiagnosticGroups.td:1046 def ThreadSafetyPrecise: DiagGroup<"thread-safety-precise">; def ThreadSafetyReference : DiagGroup<"thread-safety-reference">; +def ThreadSafetyReturn : DiagGroup<"thread-safe

[clang] ae54f01 - [dataflow] avoid more accidental copies of Environment

Author: Sam McCall Date: 2023-06-26T15:58:23+02:00 New Revision: ae54f01dd8c53d18c276420b23f0d0ab7afefff1 URL: https://github.com/llvm/llvm-project/commit/ae54f01dd8c53d18c276420b23f0d0ab7afefff1 DIFF: https://github.com/llvm/llvm-project/commit/ae54f01dd8c53d18c276420b23f0d0ab7afefff1.diff LO

[PATCH] D153493: [dataflow] avoid more accidental copies of Environment

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae54f01dd8c5: [dataflow] avoid more accidental copies of Environme

[PATCH] D153131: [clang analysis][thread-safety] Handle return-by-reference...

courbet updated this revision to Diff 534539. courbet added a comment. Put the new warnings in `-Wtread-safety-reference` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153131/new/ https://reviews.llvm.org/D153131 Files: clang/include/clang/Analy

[PATCH] D153582: [SystemZ][z/OS] Add required options/macro/etc for z/os compilation step

SeanP updated this revision to Diff 534545. SeanP added a comment. minor clang-format updates CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153582/new/ https://reviews.llvm.org/D153582 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/Targets/OSTargets.h clang/lib/Basi

[PATCH] D153769: [clangd] Implement the 'Organize Imports' source action. Fix include-cleaner findings in batch.

VitaNuo created this revision. Herald added subscribers: kadircet, arphaman. Herald added a project: All. VitaNuo requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo http

[PATCH] D153770: Fix test regression on 32-bit x86.

zahiraam created this revision. zahiraam added reviewers: rjmccall, mgorny. Herald added a project: All. zahiraam requested review of this revision. Herald added a project: clang. Issue found after merging of patch: https://reviews.llvm.org/D153590 Repository: rG LLVM Github Monorepo https://

[PATCH] D153493: [dataflow] avoid more accidental copies of Environment

cor3ntin added a comment. This seem to produce build failures /home/cor3ntin/dev/compilers/LLVM/llvm-project/clang/unittests/Analysis/FlowSensitive/RecordOpsTest.cpp:50:27: error: calling a private constructor of class 'clang::dataflow::Environment' Environment Env = getEnvironmentA

[PATCH] D153621: [Clang] Correctly handle $, @, and ` when represented as UCN

aaron.ballman added a comment. I'm a bit confused as to whether we're planning to support this as an extension in older language modes or whether we expect this to be a new feature only enabled in newer language modes. Also, this should update the C and CXX status pages and have a release note.

[clang] 1adc5a7 - [dataflow] fix test after conflict between ae54f01dd8c53d1 & f2123af1e7d75

Author: Sam McCall Date: 2023-06-26T16:29:47+02:00 New Revision: 1adc5a781faaa09ffb25b585fbf6599dc01f31c9 URL: https://github.com/llvm/llvm-project/commit/1adc5a781faaa09ffb25b585fbf6599dc01f31c9 DIFF: https://github.com/llvm/llvm-project/commit/1adc5a781faaa09ffb25b585fbf6599dc01f31c9.diff LO

Re: [PATCH] D153493: [dataflow] avoid more accidental copies of Environment

Sorry, this was a mid-air collision with f2123af1e7d75, fixed in 1adc5a781faa On Mon, Jun 26, 2023 at 4:23 PM Corentin Jabot via Phabricator < revi...@reviews.llvm.org> wrote: > cor3ntin added a comment. > > This seem to produce build failures > > > /home/cor3ntin/dev/compilers/LLVM/llvm-project/

[PATCH] D153493: [dataflow] avoid more accidental copies of Environment

cor3ntin added a comment. In D153493#4448851 , @sammccall wrote: > Sorry, this was a mid-air collision with f2123af1e7d75 > , fixed > in 1adc5a781faa >

[clang] f27afed - [Clang] Implement P2738R1 - constexpr cast from void*

Author: Corentin Jabot Date: 2023-06-26T16:45:07+02:00 New Revision: f27afedc6c86fd9c9dd576379f4d60d892a2ce67 URL: https://github.com/llvm/llvm-project/commit/f27afedc6c86fd9c9dd576379f4d60d892a2ce67 DIFF: https://github.com/llvm/llvm-project/commit/f27afedc6c86fd9c9dd576379f4d60d892a2ce67.diff

[PATCH] D153702: [Clang] Implement P2738R1 - constexpr cast from void*

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf27afedc6c86: [Clang] Implement P2738R1 - constexpr cast from void* (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D153621: [Clang] Correctly handle $, @, and ` when represented as UCN

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:200-207 +def warn_c2x_compat_literal_ucn_escape_basic_scs : Warning< + "specifying character '%0' with a universal character name is " + "incompatible with C standards before C2x">, + I

[PATCH] D153701: [clang] Implement P2718R0 "Lifetime extension in range-based for loops"

yronglin updated this revision to Diff 534559. yronglin added a comment. Format and rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153701/new/ https://reviews.llvm.org/D153701 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/De

[PATCH] D153493: [dataflow] avoid more accidental copies of Environment

sammccall added a comment. Sorry, I got confused between branches and landed this one without approval Going to review, review would still be appreciated Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153493/new/ https://reviews.llvm.org/D153493 _

[PATCH] D153776: [clang][analyzer] Display notes in StdLibraryFunctionsChecker only if interesting

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project:

[PATCH] D153621: [Clang] Correctly handle $, @, and ` when represented as UCN

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:200-207 +def warn_c2x_compat_literal_ucn_escape_basic_scs : Warning< + "specifying character '%0' with a universal character name is " + "incompatible with C standards before C2x">,

[clang] f3ca99a - [clang][OpenMP] Fix unused var warning

Author: David Spickett Date: 2023-06-26T15:20:35Z New Revision: f3ca99a87c566fb5e910071f4cbb474ddb4e7f37 URL: https://github.com/llvm/llvm-project/commit/f3ca99a87c566fb5e910071f4cbb474ddb4e7f37 DIFF: https://github.com/llvm/llvm-project/commit/f3ca99a87c566fb5e910071f4cbb474ddb4e7f37.diff LOG

[PATCH] D153369: [OpenMP] Always apply target declarations to canonical definitions

jhuber6 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153369/new/ https://reviews.llvm.org/D153369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

  1   2   3   >