hokein added a comment.

In D153652#4445285 <https://reviews.llvm.org/D153652#4445285>, @avl wrote:

> Agree that it is safe to remove all_exec from the default permissions. There 
> are currently three usages of writeToOutput API: clang include cleaner, 
> llvm-objcopy, llvm-dwarfutil. Both llvm-objcopy and llvm-dwarfutil use 
> FilePermissionsApplier which should apply all_exec permission if necessary. 
> Using all_exec by default looks redundant. It was introduced by 
> https://reviews.llvm.org/D98426
>
> please add the test for that case.

Many thanks for the verification. I added two relevant tests, please take 
another look.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153652/new/

https://reviews.llvm.org/D153652

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to