iains added inline comments.
================ Comment at: clang/lib/Sema/SemaModule.cpp:848-849 + if (auto *FD = dyn_cast<FunctionDecl>(D)) { + if (FD->getTemplateSpecializationKind() == TSK_ExplicitSpecialization) + BadExport = true; + } else if (auto *VD = dyn_cast<VarDecl>(D)) { ---------------- ChuanqiXu wrote: > Given P2615R1 doesn't allow explicit-instantiation in export block too. I think I must be missing something - I do not see that in the paper - please could you expand your comment? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153542/new/ https://reviews.llvm.org/D153542 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits