[PATCH] D151190: [clangd] Do not end inactiveRegions range at position 0 of line

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. thanks, looks great. Comment at: clang-tools-extra/clangd/SourceCode.h:76 +/// Get the last Position on a given line. +llvm::Expected endOfLine(llvm::StringRef Code, int Line

[PATCH] D151785: [clangd] Desugar dependent type aliases for auto type hints

nridge added a comment. Thanks, this is a nice improvement. A couple of general comments: - We have an existing heuristic here , should we move the logic into `maybeDesugar(

[PATCH] D148793: [clang-tidy] Implement an include-cleaner check.

hokein added a comment. In D148793#4393386 , @mstorsjo wrote: > In D148793#4393385 , @mgorny wrote: > >> My educated guess would be that `clangIncludeCleaner` is being linked via >> `clang_target_link_libraries`

[clang-tools-extra] 8ec4498 - [clangd] Do not end inactiveRegions range at position 0 of line

Author: Nathan Ridge Date: 2023-06-05T03:51:15-04:00 New Revision: 8ec44987e54b5366a03716237feb79e37ae0634a URL: https://github.com/llvm/llvm-project/commit/8ec44987e54b5366a03716237feb79e37ae0634a DIFF: https://github.com/llvm/llvm-project/commit/8ec44987e54b5366a03716237feb79e37ae0634a.diff

[PATCH] D151190: [clangd] Do not end inactiveRegions range at position 0 of line

This revision was automatically updated to reflect the committed changes. Closed by commit rG8ec44987e54b: [clangd] Do not end inactiveRegions range at position 0 of line (authored by nridge). Changed prior to commit: https://reviews.llvm.org/D151190?vs=528190&id=528304#toc Repository: rG LL

[clang] 225cf64 - fix failures caused by https://reviews.llvm.org/D148490

Author: Chen Zheng Date: 2023-06-05T04:00:26-04:00 New Revision: 225cf64e03b4e394c32e95fe1d6414e6e16be094 URL: https://github.com/llvm/llvm-project/commit/225cf64e03b4e394c32e95fe1d6414e6e16be094 DIFF: https://github.com/llvm/llvm-project/commit/225cf64e03b4e394c32e95fe1d6414e6e16be094.diff LO

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

hokein added a comment. thanks, looks good overall, a few more comments Comment at: clang-tools-extra/clangd/Hover.cpp:1225 - HI.Provider = spellHeader(AST, SM.getFileEntryForID(SM.getMainFileID()), H); + HI.Provider = include_cleaner::spellHeader( + {H, AST.getPreproc

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:790 + +**AlignConsecutiveShortCaseLabels** (``AlignConsecutiveStyle``) :versionbadge:`clang-format 17` :ref:`¶ ` + Style of aligning consecutive short case labels. HazardyK

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

MyDeveloperDay added a comment. Apart from the documentation this looks fine.. thats probably outside the scope of this change CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151761/new/ https://reviews.llvm.org/D151761 ___ cfe-commits mailing

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

MyDeveloperDay added inline comments. Comment at: clang/docs/ClangFormatStyleOptions.rst:798 + +case log::info: return "info:"; +case log::warning: return "warning:"; Do you think the documentation should give examples of the the other cases? CHANG

[PATCH] D151761: clang-format: Add AlignConsecutiveShortCaseStatements

MyDeveloperDay added a comment. did you consider a case where the case falls through? (i.e. no return) "case log::info :return \"info\";\n" "case log::warning :\n" "default : return \"default\";\n" CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151761/new/ https://re

[PATCH] D152126: [WebAssembly] Add tests ensuring rotates persist

pmatos created this revision. pmatos added reviewers: dschuff, tlively. Herald added subscribers: asb, wingo, sunfish, jgravelle-google, sbc100. Herald added a project: All. pmatos requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, aheejin. Herald added projects

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse updated this revision to Diff 528311. akshaykhadse added a comment. Remove logic to set BaseReg to non-zero value Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org/D151863 Files: clang/test/CodeGen/m

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 528315. VitaNuo marked 11 inline comments as done. VitaNuo added a comment. Herald added subscribers: PiotrZSL, carlosgalvezp. Herald added a reviewer: njames93. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo added a comment. Thanks for the comments! Comment at: clang-tools-extra/clangd/Hover.cpp:1225 - HI.Provider = spellHeader(AST, SM.getFileEntryForID(SM.getMainFileID()), H); + HI.Provider = include_cleaner::spellHeader( + {H, AST.getPreprocessor().getHeaderSearc

[clang] b447dc5 - use // instad of ; in c file tests, NFC

Author: Chen Zheng Date: 2023-06-05T05:02:38-04:00 New Revision: b447dc5a4704bef8ced95495aa8d9ea477a26814 URL: https://github.com/llvm/llvm-project/commit/b447dc5a4704bef8ced95495aa8d9ea477a26814 DIFF: https://github.com/llvm/llvm-project/commit/b447dc5a4704bef8ced95495aa8d9ea477a26814.diff LO

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. Thanks, looks great! Comment at: clang-tools-extra/include-cleaner/include/clang-include-cleaner/IncludeSpeller.h:22 + +class IncludeSpeller { + would be ni

[PATCH] D152132: [clang][Inter] Fix lifetime diagnostics for dead records

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This used to crash the interpreter, either becaus

[PATCH] D151863: [x86][MC] Fix movdir64b addressing

akshaykhadse updated this revision to Diff 528339. akshaykhadse added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151863/new/ https://reviews.llvm.org/D151863 Files: clang/test/CodeGen/ms-inline-asm-64.c clang/test/

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

VitaNuo updated this revision to Diff 528341. VitaNuo marked 4 inline comments as done. VitaNuo added a comment. Address the comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150185/new/ https://reviews.llvm.org/D150185 Files: clang-tools-

[clang-tools-extra] 90c5fe9 - [include-cleaner] Allow multiple strategies for spelling includes.

Author: Viktoriia Bakalova Date: 2023-06-05T09:47:12Z New Revision: 90c5fe982190b826aab90c93db9ce0f7e25d URL: https://github.com/llvm/llvm-project/commit/90c5fe982190b826aab90c93db9ce0f7e25d DIFF: https://github.com/llvm/llvm-project/commit/90c5fe982190b826aab90c93db9ce0f7e25d.diff

[PATCH] D150185: [include-cleaner] Allow multiple strategies for spelling includes.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG90c5fe98: [include-cleaner] Allow multiple strategies for spelling includes. (authored by VitaNuo). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D152134: [1/6][Clang][RISCV] Replace unit-stride (fault-first) segment load with tuple type interfaces

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, rogfer01, frasercrmck. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzhe

[PATCH] D152135: [2/6][Clang][RISCV] Replace unit-stride segment store with tuple type interfaces

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, rogfer01, frasercrmck. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzhe

[PATCH] D152136: [3/6][Clang][RISCV] Replace strided segment load with tuple type interfaces

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, rogfer01, frasercrmck. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzhe

[PATCH] D152137: [4/6][Clang][RISCV] Replace strided segment store with tuple type interfaces

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, rogfer01, frasercrmck. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edward-jones, zzhe

[PATCH] D152138: [5/6][Clang][RISCV] Replace indexed segment load with tuple type interfaces

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, rogfer01, frasercrmck. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, edward-j

[PATCH] D152139: [6/6][Clang][RISCV] Replace indexed segment store with tuple type interfaces

eopXD created this revision. eopXD added reviewers: craig.topper, kito-cheng, rogfer01, frasercrmck. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, edward-j

[PATCH] D152135: [2/6][Clang][RISCV] Replace unit-stride segment store with tuple type interfaces

eopXD updated this revision to Diff 528354. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152135/new/ https://reviews.llvm.org/D152135 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/r

[PATCH] D152135: [2/6][Clang][RISCV] Replace unit-stride segment store with tuple type interfaces

eopXD updated this revision to Diff 528355. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152135/new/ https://reviews.llvm.org/D152135 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/r

[PATCH] D152136: [3/6][Clang][RISCV] Replace strided segment load with tuple type interfaces

eopXD updated this revision to Diff 528356. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152136/new/ https://reviews.llvm.org/D152136 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/r

[PATCH] D152137: [4/6][Clang][RISCV] Replace strided segment store with tuple type interfaces

eopXD updated this revision to Diff 528357. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152137/new/ https://reviews.llvm.org/D152137 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/r

[PATCH] D152138: [5/6][Clang][RISCV] Replace indexed segment load with tuple type interfaces

eopXD updated this revision to Diff 528358. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152138/new/ https://reviews.llvm.org/D152138 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/r

[PATCH] D152139: [6/6][Clang][RISCV] Replace indexed segment store with tuple type interfaces

eopXD updated this revision to Diff 528359. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152139/new/ https://reviews.llvm.org/D152139 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/r

[PATCH] D152140: [Clang] Limit FunctionTypeExtraBitfields::NumExceptionType to 16 bits.

sdesmalen created this revision. sdesmalen added reviewers: erichkeane, aaron.ballman. Herald added a project: All. sdesmalen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In https://reviews.llvm.org/D127762#4102578 @erichkeane suggested

[PATCH] D152141: [Clang] Make __arm_streaming apply only to prototyped functions.

sdesmalen created this revision. sdesmalen added a reviewer: rsandifo-arm. Herald added subscribers: jdoerfert, kristof.beyls. Herald added a reviewer: aaron.ballman. Herald added a project: All. sdesmalen requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D152142: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen created this revision. Herald added subscribers: jdoerfert, kristof.beyls. Herald added a reviewer: aaron.ballman. Herald added a project: All. sdesmalen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch adds all the lang

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen updated this revision to Diff 528366. sdesmalen retitled this revision from "[Clang][AArch64] Add ACLE attributes for SME." to "[Clang][AArch64] Add/implement ACLE keywords for SME.". sdesmalen edited the summary of this revision. sdesmalen added a comment. - Rebased patch after patch t

[PATCH] D152142: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen abandoned this revision. sdesmalen added a comment. Accidentally created a duplicate, I was meant to update D127762 , so abandoning this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152142/new/ h

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

hans added a comment. Should there be a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152090/new/ https://reviews.llvm.org/D152090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:8824 + if (auto *Cast = dyn_cast(E)) { +if (auto *SubInit = dyn_cast(Cast->getSubExpr())) { + const Type *InnerType = SubInit->getType().getTypePtr(); erichkeane wrote: > Fznamznon

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

Fznamznon added a comment. In D147717#4393019 , @cor3ntin wrote: > I think we should make sure to land this for clang 17. The rate of consteval > bugs is no greater than that of any other feature at this point. There is https://github.com/llvm/llvm-proj

[clang] e69448b - [clang][Interp][NFC] Make Src parameter for move functions const

Author: Timm Bäder Date: 2023-06-05T13:20:18+02:00 New Revision: e69448b1ea96d83bd918fe162ce29b3dddcdf166 URL: https://github.com/llvm/llvm-project/commit/e69448b1ea96d83bd918fe162ce29b3dddcdf166 DIFF: https://github.com/llvm/llvm-project/commit/e69448b1ea96d83bd918fe162ce29b3dddcdf166.diff LO

[PATCH] D152023: [UBSan] Consider zero input to __builtin_clz/ctz to be undefined independent of the target.

tmatheson added a comment. I think this breaks the ACLE header, see https://github.com/llvm/llvm-project/issues/63113 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152023/new/ https://reviews.llvm.org/D152023 _

[PATCH] D152144: [clang][dataflow] Use a `PointerValue` for `value` property in optional checker.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The `ReferenceValue` class will be eliminated as

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen updated this revision to Diff 528376. sdesmalen marked 15 inline comments as done. sdesmalen added a comment. - Use only 6 bits for AArch64SMEAttributes to reduce the size of ExtProtoInfo. - Added test for implicit instantiation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen marked 4 inline comments as done. sdesmalen added inline comments. Comment at: clang/include/clang/AST/Type.h:3940 +/// on declarations and function pointers. +unsigned AArch64SMEAttributes : 8; + erichkeane wrote: > sdesmalen wrote: > > erichke

[clang-tools-extra] fc4a8bf - [clang-tidy] Move the misc system header dir to Inputs subdir, NFC.

Author: Haojian Wu Date: 2023-06-05T13:57:01+02:00 New Revision: fc4a8bf7da7d3837d371fda24d3f2c0f9ef54a5b URL: https://github.com/llvm/llvm-project/commit/fc4a8bf7da7d3837d371fda24d3f2c0f9ef54a5b DIFF: https://github.com/llvm/llvm-project/commit/fc4a8bf7da7d3837d371fda24d3f2c0f9ef54a5b.diff LO

[PATCH] D151349: [HIP] emit macro `__HIP_NO_IMAGE_SUPPORT`

arsenm added a comment. In D151349#4381569 , @yaxunl wrote: > In D151349#4381471 , @arsenm wrote: > >> In D151349#4377792 , @yaxunl wrote: >> >>> using ISA version to dete

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

egorzhdan added a comment. Apologies for pinging an old review. Would it be possible to land this to facilitate future work to upstream API notes support? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92797/new/ https://reviews.llvm.org/D92797 __

[PATCH] D152144: [clang][dataflow] Use a `PointerValue` for `value` property in optional checker.

mboehme added a comment. libcxx CI failure looks unrelated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152144/new/ https://reviews.llvm.org/D152144 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D152083: [clang] Warning for uninitialized elements in fixed-size arrays

Sinitax updated this revision to Diff 528387. Sinitax added a comment. Apply git-clang-format. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152083/new/ https://reviews.llvm.org/D152083 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKin

[clang] af22be3 - [clang][dataflow] Use a `PointerValue` for `value` property in optional checker.

Author: Martin Braenne Date: 2023-06-05T12:52:51Z New Revision: af22be39038a9c464474410c3a8b3cb428d8b25a URL: https://github.com/llvm/llvm-project/commit/af22be39038a9c464474410c3a8b3cb428d8b25a DIFF: https://github.com/llvm/llvm-project/commit/af22be39038a9c464474410c3a8b3cb428d8b25a.diff LOG

[PATCH] D152144: [clang][dataflow] Use a `PointerValue` for `value` property in optional checker.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf22be39038a: [clang][dataflow] Use a `PointerValue` for `value` property in optional checker. (authored by mboehme). Repository: rG LLVM Github M

[clang] 997c2f7 - [clang][Diagnostics] Split source ranges into line ranges before...

Author: Timm Bäder Date: 2023-06-05T14:56:58+02:00 New Revision: 997c2f70c1a29f911e559919f4799cd2b341796f URL: https://github.com/llvm/llvm-project/commit/997c2f70c1a29f911e559919f4799cd2b341796f DIFF: https://github.com/llvm/llvm-project/commit/997c2f70c1a29f911e559919f4799cd2b341796f.diff LO

[PATCH] D152003: [clang] Fix `static_cast` to array of unknown bound

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:8824 + if (auto *Cast = dyn_cast(E)) { +if (auto *SubInit = dyn_cast(Cast->getSubExpr())) { + const Type *InnerType = SubInit->getType().getTypePtr(); Fznamznon wrote: > erichkean

[clang] 4a27ddd - Remove 3-byte characters causing clang-tblgen to get I/O error.

Author: Zibi Sarbinowski Date: 2023-06-05T07:58:16-05:00 New Revision: 4a27ddd423337bb1088bd997d33a1f0f49f1ead4 URL: https://github.com/llvm/llvm-project/commit/4a27ddd423337bb1088bd997d33a1f0f49f1ead4 DIFF: https://github.com/llvm/llvm-project/commit/4a27ddd423337bb1088bd997d33a1f0f49f1ead4.di

[PATCH] D151730: [RISCV] Support target attribute for function

BeMg updated this revision to Diff 528390. BeMg added a comment. 1. Update testcase 2. Support - 3. Verfy extension version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151730/new/ https://reviews.llvm.org/D151730 Files: clang/include/clang/Bas

[PATCH] D152016: Remove 3-byte characters causing clang-tblgen to get I/O error.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4a27ddd42333: Remove 3-byte characters causing clang-tblgen to get I/O error. (authored by zibi). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152016/new/

[PATCH] D151128: [clangd] Show size, offset and padding for bit fields on hover

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. Sorry for the delay, I've been out on vacation. Behavior looks great and isn't too complicated :-) Let me know if you have commit access or I should land this for you (in which case: ple

[PATCH] D151461: [Clang][SVE2.1] Add builtins and intrinsics for SVBFMLSLB/T

david-arm accepted this revision. david-arm added a comment. This revision is now accepted and ready to land. LGTM! I left a nit, which you could just address before landing the patch? Comment at: clang/test/CodeGen/aarch64-sve2p1-intrinsics/acle_sve2p1_bfmlsl.c:48 +// +svfloat

[clang-tools-extra] f69110d - Check for a ‘buffer’ type instead of ‘buffer-live’.

Author: Philipp Stephani Date: 2023-06-05T15:10:31+02:00 New Revision: f69110dcc9739f9449a77f6010f8c20759d4e0a6 URL: https://github.com/llvm/llvm-project/commit/f69110dcc9739f9449a77f6010f8c20759d4e0a6 DIFF: https://github.com/llvm/llvm-project/commit/f69110dcc9739f9449a77f6010f8c20759d4e0a6.di

[PATCH] D148918: Check for a ‘buffer’ type instead of ‘buffer-live’.

This revision was automatically updated to reflect the committed changes. Closed by commit rGf69110dcc973: Check for a ‘buffer’ type instead of ‘buffer-live’. (authored by phst, committed by sammccall). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

erichkeane added a subscriber: ChuanqiXu. erichkeane added inline comments. Comment at: clang/include/clang/AST/Type.h:3940 +/// on declarations and function pointers. +unsigned AArch64SMEAttributes : 8; + sdesmalen wrote: > erichkeane wrote: > > sdesmale

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

erichkeane added a comment. We ended up getting the regular-attribute-like-keywords patch in a different form. Do we still want to do this as is? Does it need rebasing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127762/new/ https://reviews.ll

[PATCH] D152140: [Clang] Limit FunctionTypeExtraBitfields::NumExceptionType to 16 bits.

tbaeder added inline comments. Comment at: clang/include/clang/AST/Type.h:3956 /// [implimits] 8 bits would be enough here. -unsigned NumExceptionType = 0; +unsigned NumExceptionType : 16; + Isn't using a `uint16_t` preferred over a bitfield? Repos

[PATCH] D152140: [Clang] Limit FunctionTypeExtraBitfields::NumExceptionType to 16 bits.

erichkeane added inline comments. Comment at: clang/include/clang/AST/Type.h:3956 /// [implimits] 8 bits would be enough here. -unsigned NumExceptionType = 0; +unsigned NumExceptionType : 16; + tbaeder wrote: > Isn't using a `uint16_t` preferred over

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

sdesmalen marked an inline comment as done. sdesmalen added a comment. In D127762#4395509 , @erichkeane wrote: > We ended up getting the regular-attribute-like-keywords patch in a different > form. Do we still want to do this as is? Does it need rebas

[clang] e4b9b78 - [clang][Interp][NFC] Make a single-line comment a doc comment

Author: Timm Bäder Date: 2023-06-05T15:30:28+02:00 New Revision: e4b9b78a84b09ab997ab60de456a3a9ada22e592 URL: https://github.com/llvm/llvm-project/commit/e4b9b78a84b09ab997ab60de456a3a9ada22e592 DIFF: https://github.com/llvm/llvm-project/commit/e4b9b78a84b09ab997ab60de456a3a9ada22e592.diff LO

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

tbaeder added subscribers: cjdb, aaron.ballman. tbaeder added a comment. LGTM, but maybe wait for a response from @aaron.ballman or @cjdb CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 ___ cfe-commi

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH updated this revision to Diff 528407. vikramRH added a comment. Handled few more review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150427/new/ https://reviews.llvm.org/D150427 Files: clang/include/clang/Basic/TargetOptions.h

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH marked 4 inline comments as done. vikramRH added inline comments. Comment at: clang/test/CodeGenHIP/printf_nonhostcall.cpp:228 + return printf(s, 10); +} arsenm wrote: > vikramRH wrote: > > arsenm wrote: > > > Need some vector tests, especially 3 x vect

[PATCH] D134475: [Clang] Add support for [[msvc::constexpr]] C++11 attribute

erichkeane added a subscriber: tbaeder. erichkeane added a comment. In D134475#4393035 , @RIscRIpt wrote: > Added diagnostics for [[msvc::constexpr]] virtual > > Regarding [[msvc::constexpr]] constructors, unfortunatelly I cannot find a > reasonable way

[PATCH] D152140: [Clang] Limit FunctionTypeExtraBitfields::NumExceptionType to 16 bits.

sdesmalen added inline comments. Comment at: clang/include/clang/AST/Type.h:3956 /// [implimits] 8 bits would be enough here. -unsigned NumExceptionType = 0; +unsigned NumExceptionType : 16; + erichkeane wrote: > tbaeder wrote: > > Isn't using a `uin

[PATCH] D152140: [Clang] Limit FunctionTypeExtraBitfields::NumExceptionType to 16 bits.

erichkeane added inline comments. Comment at: clang/include/clang/AST/Type.h:3956 /// [implimits] 8 bits would be enough here. -unsigned NumExceptionType = 0; +unsigned NumExceptionType : 16; + sdesmalen wrote: > erichkeane wrote: > > tbaeder wrote:

[PATCH] D152140: [Clang] Limit FunctionTypeExtraBitfields::NumExceptionType to 16 bits.

sdesmalen updated this revision to Diff 528431. sdesmalen added a comment. Use uint16_t instead of unsigned bitfield. Also removed accessor methods in favour of assert at point of writing NumExceptionType. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D152140: [Clang] Limit FunctionTypeExtraBitfields::NumExceptionType to 16 bits.

sdesmalen added inline comments. Comment at: clang/include/clang/AST/Type.h:3956 /// [implimits] 8 bits would be enough here. -unsigned NumExceptionType = 0; +unsigned NumExceptionType : 16; + erichkeane wrote: > sdesmalen wrote: > > erichkeane wrote

[PATCH] D152140: [Clang] Limit FunctionTypeExtraBitfields::NumExceptionType to 16 bits.

erichkeane requested changes to this revision. erichkeane added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/AST/Type.cpp:3374 auto &ExtraBits = *getTrailingObjects(); -ExtraBits.NumExceptionType = epi.ExceptionSpec.Exceptions.siz

[PATCH] D152140: [Clang] Limit FunctionTypeExtraBitfields::NumExceptionType to 16 bits.

sdesmalen updated this revision to Diff 528433. sdesmalen added a comment. Use size_t instead of auto. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152140/new/ https://reviews.llvm.org/D152140 Files: clang/include/clang/AST/Type.h clang/lib/A

[PATCH] D152140: [Clang] Limit FunctionTypeExtraBitfields::NumExceptionType to 16 bits.

sdesmalen added inline comments. Comment at: clang/lib/AST/Type.cpp:3374 auto &ExtraBits = *getTrailingObjects(); -ExtraBits.NumExceptionType = epi.ExceptionSpec.Exceptions.size(); +auto NumExceptions = epi.ExceptionSpec.Exceptions.size(); +assert(NumExceptions <

[PATCH] D152164: [CUDA][HIP] Externalize device var in anonymous namespace

yaxunl created this revision. yaxunl added a reviewer: tra. Herald added a subscriber: mattd. Herald added a project: All. yaxunl requested review of this revision. Device variables in an anonymous namespace may be referenced by host code, therefore they need to be externalized in a similar way as

[PATCH] D151437: [NFC][Driver] Change MultilibBuilder interface

simon_tatham accepted this revision. simon_tatham added a comment. This revision is now accepted and ready to land. LGTM: I agree that the new notation is easier to understand for anyone not already used to the old one. However, please wait at least a day for other people and time zones to have

[PATCH] D152090: [clang][Driver] Add -fcaret-diagnostics-max-lines as a driver option

MaskRay added a comment. `def fcaret_diagnostics_max_lines` in `Options.td` has the `NoDriverOption` flag. Move it to other places with `BooleainFFlag` should work. Then in `Clang.cpp` you can just write `Args.AddLastArg(...)` Can you add some description that this is related to D147875

[PATCH] D127762: [Clang][AArch64] Add/implement ACLE keywords for SME.

erichkeane added a comment. I think we need a few tests to ensure that these are properly propagated on function templates (both for Sema and codegen). Also, a handful of nits (See my list). Comment at: clang/include/clang/AST/Type.h:3958 +SME_PStateZAPreservedMask = 1 <

[PATCH] D152169: [clang][analyzer] Add report of NULL stream to StreamChecker.

balazske created this revision. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, szepet, baloghadamsoftware, xazax.hun. Herald added a reviewer: Szelethus. Herald added a reviewer: NoQ. Herald added a project:

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 ___ cfe-commits mailing lis

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

aaron.ballman added a comment. Do you need someone to commit on your behalf? If so, what name and email address would you like used for patch attribution? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 ___

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

tbaeder added a comment. @charmitro do you have commit rights or do you need someone to push on your behalf? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 ___ cfe-commits mailing list cfe-commits@

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names

erichkeane added a comment. This all LGTM, but I want @tahonermann to do a pass as well, he knows more about FP than I do, so I don't want to accept without his run-through. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149573/new/ https://reviews.llvm.org/D149573

[PATCH] D152164: [CUDA][HIP] Externalize device var in anonymous namespace

yaxunl updated this revision to Diff 528447. yaxunl added a comment. add a test to make sure device var in an anonymous namespace is not externalized if used by device code only. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152164/new/ https://reviews.llvm.org/D152164 Files: clang/

[PATCH] D152169: [clang][analyzer] Add report of NULL stream to StreamChecker.

steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. Ah yes, finally this sorts itself out. We also had to revert 570bf972f5adf05438c7e08d693bf4b96bfd510a because we use t

[clang] 12728e1 - [C] Support _Generic expressions with a type operand

Author: Aaron Ballman Date: 2023-06-05T11:09:58-04:00 New Revision: 12728e144994efe84715f4e5dbb8c3104e9f0b5a URL: https://github.com/llvm/llvm-project/commit/12728e144994efe84715f4e5dbb8c3104e9f0b5a DIFF: https://github.com/llvm/llvm-project/commit/12728e144994efe84715f4e5dbb8c3104e9f0b5a.diff

[PATCH] D149904: Generic selection expressions that accept a type operand

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12728e144994: [C] Support _Generic expressions with a type operand (authored by aaron.ballman). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D152107: [NFC][CLANG] Fix nullptr dereference issue in checkSizelessVectorShift()

Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152107/new/ https://reviews.llvm.org/D152107 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] 3581e6b - [NFC][CLANG] Fix nullptr dereference issue in checkSizelessVectorShift()

Author: Manna, Soumi Date: 2023-06-05T08:12:33-07:00 New Revision: 3581e6b857f44e397f61ddb35cb420347653f3ff URL: https://github.com/llvm/llvm-project/commit/3581e6b857f44e397f61ddb35cb420347653f3ff DIFF: https://github.com/llvm/llvm-project/commit/3581e6b857f44e397f61ddb35cb420347653f3ff.diff

[PATCH] D152107: [NFC][CLANG] Fix nullptr dereference issue in checkSizelessVectorShift()

This revision was automatically updated to reflect the committed changes. Closed by commit rG3581e6b857f4: [NFC][CLANG] Fix nullptr dereference issue in checkSizelessVectorShift() (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

charmitro marked an inline comment as done. charmitro added a comment. In D151833#4395956 , @aaron.ballman wrote: > Do you need someone to commit on your behalf? If so, what name and email > address would you like used for patch attribution? In D1518

[PATCH] D151523: [ASTStructuralEquivalence] Fix crash when ObjCCategoryDecl doesn't have corresponding ObjCInterfaceDecl.

ahatanak added a comment. In D151523#4374808 , @vsapsai wrote: > Kinda a follow-up to D121176 . > > One big alternative that I've considered is to store interface name in > `ObjCCategoryDecl` because when we parse `@inte

[clang-tools-extra] cd5fcea - [clangd] Revert to older include spelling approach.

Author: Viktoriia Bakalova Date: 2023-06-05T15:18:28Z New Revision: cd5fcea6d4c70a7328ca9538c9098d9f5af69682 URL: https://github.com/llvm/llvm-project/commit/cd5fcea6d4c70a7328ca9538c9098d9f5af69682 DIFF: https://github.com/llvm/llvm-project/commit/cd5fcea6d4c70a7328ca9538c9098d9f5af69682.diff

[PATCH] D152169: [clang][analyzer] Add report of NULL stream to StreamChecker.

steakhal added inline comments. Comment at: clang/include/clang/StaticAnalyzer/Checkers/Checkers.td:553 HelpText<"Check stream handling functions">, + WeakDependencies<[NonNullParamChecker]>, Documentation; What's the purpose of this hunk? Repository:

  1   2   3   >