hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
thanks, looks great. ================ Comment at: clang-tools-extra/clangd/SourceCode.h:76 +/// Get the last Position on a given line. +llvm::Expected<Position> endOfLine(llvm::StringRef Code, int Line); + ---------------- nit: no need to expose this API, it is only used in SemanticHighlighting.cpp. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151190/new/ https://reviews.llvm.org/D151190 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
