arsenm added a comment. In D151349#4381569 <https://reviews.llvm.org/D151349#4381569>, @yaxunl wrote:
> In D151349#4381471 <https://reviews.llvm.org/D151349#4381471>, @arsenm wrote: > >> In D151349#4377792 <https://reviews.llvm.org/D151349#4377792>, @yaxunl wrote: >> >>> using ISA version to determine whether image is supported >> >> That’s backward. You can track the feature in clang separately and just not >> emit it. We do that for a few other features. You just stop the TargetParser >> parts > > Sorry, I did not quite get it. Do you mean to add a feature to > https://github.com/llvm/llvm-project/blob/85670ac86813b170c9301aa477421c56a71a7e1e/llvm/lib/TargetParser/TargetParser.cpp#L107 > ? should I add FEATURE_IMAGE or FEATURE_NO_IMAGE ? It's expressed as positive image feature. I thought there was a feature where clang tracks it per-target, but doesn't emit it in the IR in "target-features" but I can't remember which one it is. Is there a way to track the image feature without emitting it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151349/new/ https://reviews.llvm.org/D151349 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
