[PATCH] D151061: [test] Add ext_vector_type tests for C

porglezomp created this revision. porglezomp added reviewers: aaron.ballman, fhahn. Herald added a subscriber: StephenFan. Herald added a project: All. porglezomp requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Test that all vector-vs-scala

[PATCH] D151061: [test] Add ext_vector_type tests for C

porglezomp added a comment. See also: very similar baseline tests for C++: D151059 I'm interested in any feedback about the correct semantics for this. I started writing these tests while investigating the behavior of vector vs scalar operations in C++ for D15

[PATCH] D151059: [test] Add C++ ext_vector_type tests

porglezomp added a comment. See also: C versions of these test cases: D151061 I think the C versions behave correctly and that C++ should match that behavior. Interested in feedback from anyone working with ext_vector_types. Repository: rG LLVM Github Monor

[clang] 5e92298 - [2/11][POC][Clang][RISCV] Define RVV tuple types

Author: eopXD Date: 2023-05-22T00:50:40-07:00 New Revision: 5e92298f76875e1a89ad58bab042cd7abe9fc004 URL: https://github.com/llvm/llvm-project/commit/5e92298f76875e1a89ad58bab042cd7abe9fc004 DIFF: https://github.com/llvm/llvm-project/commit/5e92298f76875e1a89ad58bab042cd7abe9fc004.diff LOG: [2

[PATCH] D146873: [2/11][POC][Clang][RISCV] Define RVV tuple types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e92298f7687: [2/11][POC][Clang][RISCV] Define RVV tuple types (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D147731: [3/11][POC][Clang][RISCV] Add typedef of the tuple type and define tuple type variant of vlseg2e32

eopXD updated this revision to Diff 524182. eopXD added a comment. Bump CI. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147731/new/ https://reviews.llvm.org/D147731 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Basic/riscv_

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

daiyousei-qz updated this revision to Diff 524183. daiyousei-qz marked 19 inline comments as done. daiyousei-qz added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150635/new/ https://reviews.llvm.org/D150635 Fil

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

daiyousei-qz marked an inline comment as done. daiyousei-qz added a comment. Addressed most review comments. I'm currently using the name "BlockEnd" as suggested. Though I'm proposing a name like "DeclBlockEnd" to make it clearer. What do you think? Comment at: clang-tools-ex

[PATCH] D148489: [clangd] Implement configs to stop clangd produce a certain semantic tokens

daiyousei-qz added a comment. Yes please. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148489/new/ https://reviews.llvm.org/D148489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] 5a61920 - [Clang][RISCV] Add missing requirement in test case rvv-tuple-type.c

Author: eopXD Date: 2023-05-22T01:10:22-07:00 New Revision: 5a61920ed8b3e76d8f9bf39f2c1e18d552fcc976 URL: https://github.com/llvm/llvm-project/commit/5a61920ed8b3e76d8f9bf39f2c1e18d552fcc976 DIFF: https://github.com/llvm/llvm-project/commit/5a61920ed8b3e76d8f9bf39f2c1e18d552fcc976.diff LOG: [C

[PATCH] D147731: [3/11][POC][Clang][RISCV] Add typedef of the tuple type and define tuple type variant of vlseg2e32

eopXD updated this revision to Diff 524186. eopXD added a comment. Bump CI again due to latest fix (5a61920ed8b3e76d8f9bf39f2c1e18d552fcc976 ) for D146873 (5e92298f76875e1a89ad58bab042cd7abe9

[PATCH] D146873: [2/11][POC][Clang][RISCV] Define RVV tuple types

eopXD added a comment. Committing this patch caused build failure in non-RISC-V buildbot CI-s because of the missing `REQUIRES` line in the test case `clang/test/CodeGen/RISCV/rvv-intrinsics-handcrafted/rvv-tuple-type.c`. This is addressed in the 5a61920ed8b3e76d8f9bf39f2c1e18d552fcc976

[PATCH] D147731: [3/11][POC][Clang][RISCV] Add typedef of the tuple type and define tuple type variant of vlseg2e32

eopXD updated this revision to Diff 524187. eopXD added a comment. Bump CI again, the previous patch application failed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147731/new/ https://reviews.llvm.org/D147731 Files: clang/include/clang/AST/AS

[PATCH] D149573: [Clang][C++23] Implement core language changes from P1467R9 extended floating-point types and standard names and adapt __bf16 to be arithmetic type

stuij added a comment. In D149573#4341323 , @codemzs wrote: > @stuij, as you initially introduced `__bf16` as a storage-type, your review > on this adjustment would be greatly appreciated. Sorry for the late reaction, was on holiday. Yes, I'll have a lo

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. Thank you for the indepth explaination in https://github.com/llvm/llvm-project/issues/59178, that was really helpful for me trying to understand what the problem was. I thik y

[PATCH] D150685: [clangd] Renaming: Treat member functions like other functions

ckandeler added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:519 +if (RenameDecl.getKind() != Decl::Function && +RenameDecl.getKind() != Decl::CXXMethod) { if (auto *Conflict = lookupSiblingWithName(ASTCtx, RenameDecl, NewName)) ---

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

Fznamznon added a comment. Friendly ping. It is been a while. @cjdb , any chance for an update? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147717/new/ https://reviews.llvm.org/D147717 ___ cfe-commits

[PATCH] D146242: [ARM] Fixing ABI mismatch for packed structs and fields

tmatheson added a comment. Reverse-ping @JiruiWu Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146242/new/ https://reviews.llvm.org/D146242 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D150685: [clangd] Renaming: Treat member functions like other functions

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:519 +if (RenameDecl.getKind() != Decl::Function && +RenameDecl.getKind() != Decl::CXXMethod) { if (auto *Conflict = lookupSiblingWithName(ASTCtx, RenameDecl, NewName)) --

[PATCH] D148206: [clang] Do not crash after suggesting typo correction to constexpr if condition

zixuan-wu added inline comments. Comment at: clang/test/SemaCXX/invalid-if-constexpr.cpp:7 +} +void a() { if constexpr (__adl_swap<>) {}} // expected-error{{use of undeclared identifier '__adl_swap'; did you mean '__sync_swap'?}} \ + //

[clang] 0019226 - [3/11][POC][Clang][RISCV] Add typedef of the tuple type and define tuple type variant of vlseg2e32

Author: eopXD Date: 2023-05-22T02:51:14-07:00 New Revision: 0019226ceef779c7d9aa55f2f56b30e948cc9251 URL: https://github.com/llvm/llvm-project/commit/0019226ceef779c7d9aa55f2f56b30e948cc9251 DIFF: https://github.com/llvm/llvm-project/commit/0019226ceef779c7d9aa55f2f56b30e948cc9251.diff LOG: [3

[PATCH] D147731: [3/11][POC][Clang][RISCV] Add typedef of the tuple type and define tuple type variant of vlseg2e32

This revision was automatically updated to reflect the committed changes. Closed by commit rG0019226ceef7: [3/11][POC][Clang][RISCV] Add typedef of the tuple type and define tuple type… (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D150685: [clangd] Renaming: Treat member functions like other functions

ckandeler updated this revision to Diff 524203. ckandeler added a comment. Added test cases. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150685/new/ https://reviews.llvm.org/D150685 Files: clang-tools-extra/clangd/refactor/Rename.cpp clang-t

[clang] f4d70d6 - [4/11][POC][Clang][RISCV] Define tuple type variant of vsseg2e32

Author: eopXD Date: 2023-05-22T02:52:36-07:00 New Revision: f4d70d68e72d267afab7294918f340e232b94870 URL: https://github.com/llvm/llvm-project/commit/f4d70d68e72d267afab7294918f340e232b94870 DIFF: https://github.com/llvm/llvm-project/commit/f4d70d68e72d267afab7294918f340e232b94870.diff LOG: [4

[PATCH] D147774: [4/11][POC][Clang][RISCV] Define tuple type variant of vsseg2e32

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf4d70d68e72d: [4/11][POC][Clang][RISCV] Define tuple type variant of vsseg2e32 (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D151071: [clang][dataflow] Fix a null pointer crash in `computeBlockInputState()`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The crash was due to unconditionally calling `Bl

[PATCH] D150685: [clangd] Renaming: Treat member functions like other functions

ckandeler updated this revision to Diff 524206. ckandeler added a comment. Formatting glitch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150685/new/ https://reviews.llvm.org/D150685 Files: clang-tools-extra/clangd/refactor/Rename.cpp clang-

[PATCH] D150685: [clangd] Renaming: Treat member functions like other functions

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. nice, thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150685/new/ https://reviews.llvm.org/D150685 ___

[PATCH] D151073: [clang] Fix label (de-)serialization in ASM statements.

VitaNuo created this revision. Herald added a project: All. VitaNuo requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D151073 Files: clang/lib/Serialization/ASTReaderStmt.cpp

[PATCH] D151073: [clang] Fix label (de-)serialization in ASM statements.

VitaNuo updated this revision to Diff 524211. VitaNuo added a comment. Remove template param. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151073/new/ https://reviews.llvm.org/D151073 Files: clang/lib/Serialization/ASTReaderStmt.cpp clang/lib

[libclc] 382b56d - [libclc] Fix linking against libLLVMSupport

Author: Thomas Debesse Date: 2023-05-22T12:22:05+02:00 New Revision: 382b56d5bd0356ba53bbaf9bfb988f315a7530b5 URL: https://github.com/llvm/llvm-project/commit/382b56d5bd0356ba53bbaf9bfb988f315a7530b5 DIFF: https://github.com/llvm/llvm-project/commit/382b56d5bd0356ba53bbaf9bfb988f315a7530b5.diff

[PATCH] D150685: [clangd] Renaming: Treat member functions like other functions

ckandeler updated this revision to Diff 524214. ckandeler added a comment. Fixed clang-format complaints. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150685/new/ https://reviews.llvm.org/D150685 Files: clang-tools-extra/clangd/refactor/Rename.

[PATCH] D147731: [3/11][POC][Clang][RISCV] Add typedef of the tuple type and define tuple type variant of vlseg2e32

uabelho added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:384 Policy PolicyAttrs; + bool IsTuple = false; ``` /home/buildbots/docker-RHEL84-buildbot/SetupBot/worker_env/ppc64le-clang-rhel-test/clang-ppc64le-rhel/llvm-proj

[PATCH] D151075: [clang][Diagnostics] Simplify emitSnippet()

tbaeder created this revision. tbaeder added a reviewer: aaron.ballman. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Don't try to minimize the times we invoke operator<< on the output stream by ke

[PATCH] D151075: [clang][Diagnostics] Simplify emitSnippet()

tbaeder updated this revision to Diff 524216. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151075/new/ https://reviews.llvm.org/D151075 Files: clang/lib/Frontend/TextDiagnostic.cpp Index: clang/lib/Frontend/TextDiagnostic.cpp =

[PATCH] D148206: [clang] Do not crash after suggesting typo correction to constexpr if condition

Fznamznon added inline comments. Comment at: clang/test/SemaCXX/invalid-if-constexpr.cpp:7 +} +void a() { if constexpr (__adl_swap<>) {}} // expected-error{{use of undeclared identifier '__adl_swap'; did you mean '__sync_swap'?}} \ + //

[PATCH] D151076: [IRGen] Handle infinite cycles in findDominatingStoreToReturnValue.

fhahn created this revision. fhahn added reviewers: rjmccall, aaron.ballman, efriedma. Herald added a subscriber: StephenFan. Herald added a project: All. fhahn requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. If there is an infinite cycle i

[clang] 3814025 - [Clang][RISCV] Remove unused variable `IsTuple` for structure `RVVIntrinsic`

Author: eopXD Date: 2023-05-22T03:40:12-07:00 New Revision: 38140255113297fe3e7926d311cd45004928779e URL: https://github.com/llvm/llvm-project/commit/38140255113297fe3e7926d311cd45004928779e DIFF: https://github.com/llvm/llvm-project/commit/38140255113297fe3e7926d311cd45004928779e.diff LOG: [C

[PATCH] D151061: [test] Add ext_vector_type tests for C

fhahn added a comment. Thanks for texting the test coverage! Comment at: clang/test/Sema/ext_vector_ops.c:30 +void test_int_vector_scalar(unsigned int ua, v2u v2ua) { + // Integer vector vs integer operators. These will splat + (void)(v2ua + ua); Not sure if

[PATCH] D147731: [3/11][POC][Clang][RISCV] Add typedef of the tuple type and define tuple type variant of vlseg2e32

eopXD marked an inline comment as done. eopXD added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:384 Policy PolicyAttrs; + bool IsTuple = false; uabelho wrote: > ``` > /home/buildbots/docker-RHEL84-buildbot/SetupBot/worker

[clang-tools-extra] 008cb29 - [clangd] Renaming: Treat member functions like other functions

Author: Christian Kandeler Date: 2023-05-22T12:50:38+02:00 New Revision: 008cb29f87f3af391eb6c3747bdad16f2e386161 URL: https://github.com/llvm/llvm-project/commit/008cb29f87f3af391eb6c3747bdad16f2e386161 DIFF: https://github.com/llvm/llvm-project/commit/008cb29f87f3af391eb6c3747bdad16f2e386161.

[PATCH] D150685: [clangd] Renaming: Treat member functions like other functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG008cb29f87f3: [clangd] Renaming: Treat member functions like other functions (authored by ckandeler). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150685/ne

[PATCH] D150966: [clang] Don't define predefined macros multiple times

john.brawn added a comment. In D150966#4356779 , @barannikov88 wrote: > Check that the predefined macros don't contain anything that causes a > warning > > What is 'anything', exactly? Does it include duplicate predefined macros, or > it tests someth

[clang] deb63f4 - [5/11][POC][Clang][RISCV] Define tuple type variant of vlseg2e32ff

Author: eopXD Date: 2023-05-22T04:05:14-07:00 New Revision: deb63f4a54e66b44e81ccc249f5c9ae786b16d27 URL: https://github.com/llvm/llvm-project/commit/deb63f4a54e66b44e81ccc249f5c9ae786b16d27 DIFF: https://github.com/llvm/llvm-project/commit/deb63f4a54e66b44e81ccc249f5c9ae786b16d27.diff LOG: [5

[PATCH] D147911: [5/11][POC][Clang][RISCV] Define tuple type variant of vlseg2e32ff

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdeb63f4a54e6: [5/11][POC][Clang][RISCV] Define tuple type variant of vlseg2e32ff (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D151078: [clang][Diagnostics] Use llvm::raw_ostream::indent()

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, cjdb. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. TIL that this exists. Repository: rG LLVM Github Monorepo https://reviews

[clang] bf2511b - [6/11][POC][Clang][RISCV] Define tuple type variant of vlsseg2e32

Author: eopXD Date: 2023-05-22T04:09:22-07:00 New Revision: bf2511bdd8143f6f3d898b1d7d9f351e0eeb0f12 URL: https://github.com/llvm/llvm-project/commit/bf2511bdd8143f6f3d898b1d7d9f351e0eeb0f12 DIFF: https://github.com/llvm/llvm-project/commit/bf2511bdd8143f6f3d898b1d7d9f351e0eeb0f12.diff LOG: [6

[PATCH] D147912: [6/11][POC][Clang][RISCV] Define tuple type variant of vlsseg2e32

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbf2511bdd814: [6/11][POC][Clang][RISCV] Define tuple type variant of vlsseg2e32 (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES

[clang] f2ffdaa - [7/11][POC][Clang][RISCV] Define tuple type variant of vssseg2e32

Author: eopXD Date: 2023-05-22T04:13:51-07:00 New Revision: f2ffdaaae6bf246a8bc00b4b9924393d10835264 URL: https://github.com/llvm/llvm-project/commit/f2ffdaaae6bf246a8bc00b4b9924393d10835264 DIFF: https://github.com/llvm/llvm-project/commit/f2ffdaaae6bf246a8bc00b4b9924393d10835264.diff LOG: [7

[PATCH] D147913: [7/11][POC][Clang][RISCV] Define tuple type variant of vssseg2e32

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf2ffdaaae6bf: [7/11][POC][Clang][RISCV] Define tuple type variant of vssseg2e32 (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES

[clang] 827f439 - [8/11][POC][Clang][RISCV] Define tuple type variant of vloxseg2ei32 vluxseg2ei32

Author: eopXD Date: 2023-05-22T04:20:09-07:00 New Revision: 827f43918836fa3a2ec1abaf3592fb4a74dcaf48 URL: https://github.com/llvm/llvm-project/commit/827f43918836fa3a2ec1abaf3592fb4a74dcaf48 DIFF: https://github.com/llvm/llvm-project/commit/827f43918836fa3a2ec1abaf3592fb4a74dcaf48.diff LOG: [8

[PATCH] D147914: [8/11][POC][Clang][RISCV] Define tuple type variant of vloxseg2ei32 vluxseg2ei32

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG827f43918836: [8/11][POC][Clang][RISCV] Define tuple type variant of vloxseg2ei32 vluxseg2ei32 (authored by eopXD). Repository: rG LLVM Github Mon

[PATCH] D147915: [9/11][POC][Clang][RISCV] Define tuple type variant of vsoxseg2ei32 vsuxseg2ei32

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5eb1b1fc1f88: [9/11][POC][Clang][RISCV] Define tuple type variant of vsoxseg2ei32 vsuxseg2ei32 (authored by eopXD). Repository: rG LLVM Github Mon

[PATCH] D150446: [analyzer] Check ArraySubscriptExprs in ArrayBoundCheckerV2

donat.nagy added a comment. @steakhal What is your first impression about this commit? Is this the (or at least //a//) good direction? May I continue with creating additional improvements (e.g. better error messages) that depend on this commit? Repository: rG LLVM Github Monorepo CHANGES SI

[clang] 6a097e2 - [10/11][POC][Clang][RISCV] Define vget for tuple type

Author: eopXD Date: 2023-05-22T04:29:28-07:00 New Revision: 6a097e279c7831d12e9ed56ca5cc021e68315c12 URL: https://github.com/llvm/llvm-project/commit/6a097e279c7831d12e9ed56ca5cc021e68315c12 DIFF: https://github.com/llvm/llvm-project/commit/6a097e279c7831d12e9ed56ca5cc021e68315c12.diff LOG: [1

[PATCH] D147916: [10/11][POC][Clang][RISCV] Define vget for tuple type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6a097e279c78: [10/11][POC][Clang][RISCV] Define vget for tuple type (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D150435: [clang] Fix crash on attempt to initialize union with flexible array member

Fznamznon added a comment. @aaron.ballman , WDYT? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150435/new/ https://reviews.llvm.org/D150435 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] 61346ed - [11/11][POC][Clang][RISCV] Define vset for tuple type

Author: eopXD Date: 2023-05-22T04:32:43-07:00 New Revision: 61346ed51fdab0314694f3dbbf6563bc2cc9cde2 URL: https://github.com/llvm/llvm-project/commit/61346ed51fdab0314694f3dbbf6563bc2cc9cde2 DIFF: https://github.com/llvm/llvm-project/commit/61346ed51fdab0314694f3dbbf6563bc2cc9cde2.diff LOG: [1

[PATCH] D58346: [Sema] Change addr space diagnostics in casts to follow C++ style

jhuber6 added a comment. In D58346#4359631 , @ebevhan wrote: > In D58346#4359291 , @jhuber6 wrote: > >> should C++ really be limited by OpenCL here? > > It probably shouldn't. There's many places in the codebase whe

[PATCH] D147917: [11/11][POC][Clang][RISCV] Define vset for tuple type

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG61346ed51fda: [11/11][POC][Clang][RISCV] Define vset for tuple type (authored by eopXD). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

hans added a comment. >>> Do you have a suggestion how we can move this patch forward? >> >> IIRC, D150688 + the diff in >> https://github.com/llvm/llvm-project/issues/62719#issuecomment-1552903385 + >> upgrading the pre-merge linux bot should take care of all

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

kadircet added a comment. In D150997#4357589 , @nikic wrote: > It looks like you forgot to `git add` the new file maybe? > > This was added in https://reviews.llvm.org/D133200, maybe @kadircet can > comment on what this was intended for. It was already

[PATCH] D150997: [llvm] Split out DenseMapInfo specialization

kadircet added a comment. In D150997#4357589 , @nikic wrote: > It looks like you forgot to `git add` the new file maybe? > > This was added in https://reviews.llvm.org/D133200, maybe @kadircet can > comment on what this was intended for. It was already

[PATCH] D151078: [clang][Diagnostics] Use llvm::raw_ostream::indent()

aaron.ballman added inline comments. Comment at: clang/lib/Frontend/TextDiagnostic.cpp:1195-1197 auto indentForLineNumbers = [&] { -if (MaxLineNoDisplayWidth > 0) { - OS << ' '; - for (unsigned I = 0; I != MaxLineNoDisplayWidth; ++I) -OS << ' '; - OS

[PATCH] D151078: [clang][Diagnostics] Use llvm::raw_ostream::indent()

tbaeder added inline comments. Comment at: clang/lib/Frontend/TextDiagnostic.cpp:1195-1197 auto indentForLineNumbers = [&] { -if (MaxLineNoDisplayWidth > 0) { - OS << ' '; - for (unsigned I = 0; I != MaxLineNoDisplayWidth; ++I) -OS << ' '; - OS << "

[PATCH] D150840: [clang][NFC] Refactor emitSnippet()

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D150840#4359570 , @tbaeder wrote: > Side-note: The `ToPrint` stuff here is just useful to "cache" the output > string, isn't it? Is t

[PATCH] D151071: [clang][dataflow] Fix a null pointer crash in `computeBlockInputState()`.

ymandel accepted this revision. ymandel added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:221-223 // See `NoreturnDestructorTest` for concrete examples. -if (Block.succ_beg

[PATCH] D151073: [clang] Fix label (de-)serialization in ASM statements.

kadircet added inline comments. Comment at: clang/test/PCH/asm-label.cpp:5 +#define HEADER_H +#pragma once +void MyMethod() { you can drop `#pragma once` know, as it won't be parsed again anyways Comment at: clang/test/PCH/asm-label.cpp:6 +#pra

[clang] 09841d7 - Add WG14 N2607 to the list of backported features

Author: Aaron Ballman Date: 2023-05-22T08:16:32-04:00 New Revision: 09841d792f47310cf582156b92ffd9fa232853d6 URL: https://github.com/llvm/llvm-project/commit/09841d792f47310cf582156b92ffd9fa232853d6 DIFF: https://github.com/llvm/llvm-project/commit/09841d792f47310cf582156b92ffd9fa232853d6.diff

[PATCH] D151081: [Clang][SVE2.1] Add svpext builtins

CarolineConcatto created this revision. Herald added subscribers: kristof.beyls, tschuett. Herald added a project: All. CarolineConcatto requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As described in: https://github.com/ARM-software/acle/p

[clang] a9e90f7 - [clang][dataflow] Fix a null pointer crash in `computeBlockInputState()`.

Author: Martin Braenne Date: 2023-05-22T12:19:55Z New Revision: a9e90f7994222dde987154ed009504afbf3c2166 URL: https://github.com/llvm/llvm-project/commit/a9e90f7994222dde987154ed009504afbf3c2166 DIFF: https://github.com/llvm/llvm-project/commit/a9e90f7994222dde987154ed009504afbf3c2166.diff LOG

[PATCH] D151071: [clang][dataflow] Fix a null pointer crash in `computeBlockInputState()`.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa9e90f799422: [clang][dataflow] Fix a null pointer crash in `computeBlockInputState()`. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D151078: [clang][Diagnostics] Use llvm::raw_ostream::indent()

tbaeder updated this revision to Diff 524253. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151078/new/ https://reviews.llvm.org/D151078 Files: clang/lib/Frontend/TextDiagnostic.cpp Index: clang/lib/Frontend/TextDiagnostic.cpp =

[PATCH] D151078: [clang][Diagnostics] Use llvm::raw_ostream::indent()

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151078/new/ https://reviews.llvm.org/D151078 ___ cfe-commits mailing lis

[PATCH] D150435: [clang] Fix crash on attempt to initialize union with flexible array member

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM with a minor tweak to the test, thanks! Comment at: clang/test/Sema/flexible-array-in-union.c:1-16 +// RUN: %clang_cc1 %s -verify -fsyntax-only -DERROR +// RUN: %clang_cc1 %s -verify -fsyntax-only -x c++

[PATCH] D151087: [Clang] Permit address space casts with 'reinterpret_cast' in C++

jhuber6 created this revision. jhuber6 added reviewers: rjmccall, ebevhan, jdoerfert, JonChesterfield, aaron.ballman. Herald added subscribers: arichardson, Anastasia. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber:

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir

tblah created this revision. tblah added reviewers: awarzynski, vzakhari, jeanPerier, clementval. Herald added a reviewer: sscalpone. Herald added a subscriber: sunshaoce. Herald added projects: Flang, All. tblah requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert. H

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

tblah added inline comments. Herald added a subscriber: bviyer. Comment at: flang/include/flang/Tools/CLOptions.inc:251 +bool stackArrays = false, bool underscoring = true, bool useHLFIR = false) { + if (useHLFIR) +fir::createHLFIRToFIRPassPipeline(pm, optLevel); --

[PATCH] D150435: [clang] Fix crash on attempt to initialize union with flexible array member

Fznamznon added inline comments. Comment at: clang/test/Sema/flexible-array-in-union.c:1-16 +// RUN: %clang_cc1 %s -verify -fsyntax-only -DERROR +// RUN: %clang_cc1 %s -verify -fsyntax-only -x c++ +// RUN: %clang_cc1 %s -verify -fsyntax-only -fms-compatibility +// RUN: %clang_cc1

[PATCH] D151071: [clang][dataflow] Fix a null pointer crash in `computeBlockInputState()`.

gribozavr2 added a comment. LGTM too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151071/new/ https://reviews.llvm.org/D151071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D151040: [NFC][CLANG] Fix static code analyzer concerns

erichkeane added inline comments. Comment at: clang/lib/AST/ExprConstant.cpp:10172 Info.Ctx.getAsConstantArrayType(E->getSubExpr()->getType()); + assert(ArrayType && "unexpected type for array initializer"); I think this ends up being a regression if th

[PATCH] D151078: [clang][Diagnostics] Use llvm::raw_ostream::indent()

tbaeder updated this revision to Diff 524271. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151078/new/ https://reviews.llvm.org/D151078 Files: clang/lib/Frontend/TextDiagnostic.cpp Index: clang/lib/Frontend/TextDiagnostic.cpp =

[PATCH] D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors.

courbet created this revision. courbet added a reviewer: gnanabit. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. courbet requested review of this revision. Herald added a project: clang-tools-extra. We were only handli

[PATCH] D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors.

courbet updated this revision to Diff 524276. courbet added a comment. fix release note placemenfix release note placement Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151092/new/ https://reviews.llvm.org/D151092 Files: clang-tools-extra/clang-

[PATCH] D151093: [clang][Diagnostic] Simplify emitDiagnosticLoc

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, cjdb, clang. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We don't use the offset returned from SourceManager::getDecomposedLoc

[clang] 8f8e450 - [clang] Fix crash on attempt to initialize union with flexible array member

Author: Mariya Podchishchaeva Date: 2023-05-22T09:32:04-04:00 New Revision: 8f8e450b668219c211284b68c36ba25b3193a2b0 URL: https://github.com/llvm/llvm-project/commit/8f8e450b668219c211284b68c36ba25b3193a2b0 DIFF: https://github.com/llvm/llvm-project/commit/8f8e450b668219c211284b68c36ba25b3193a2

[PATCH] D150435: [clang] Fix crash on attempt to initialize union with flexible array member

This revision was automatically updated to reflect the committed changes. Closed by commit rG8f8e450b6682: [clang] Fix crash on attempt to initialize union with flexible array member (authored by Fznamznon). Changed prior to commit: https://reviews.llvm.org/D150435?vs=523723&id=524278#toc Repo

[PATCH] D149162: [Clang][OpenMP][IRBuilder] Move registerTargetGlobalVariable & getAddrOfDeclareTargetVar into the OMPIRBuilder

agozillon updated this revision to Diff 524279. agozillon added a comment. Rebase, squash patch history and clang-format to please the buildbot lords Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149162/new/ https://reviews.llvm.org/D149162 Files:

[PATCH] D151094: [clang][wip] Implement P2564 "consteval must propagate up"

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D151094 Files: clang/docs/ReleaseNotes.rst clang/incl

[PATCH] D151087: [Clang] Permit address space casts with 'reinterpret_cast' in C++

ebevhan added a comment. What would be the semantics of such an operation if the address spaces are disjoint? Or, if the underlying pointer widths aren't the same? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151087/new/ https://reviews.llvm.org/

[PATCH] D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors.

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/docs/ReleaseNotes.rst:385 +- Improved :doc:`performance-no-automatic-move + `: warn on `const &&` + constructors. Please use double back-ticks for `const &&`. Comment at: c

[PATCH] D151087: [Clang] Permit address space casts with 'reinterpret_cast' in C++

jhuber6 added a comment. In D151087#4360577 , @ebevhan wrote: > What would be the semantics of such an operation if the address spaces are > disjoint? Or, if the underlying pointer widths aren't the same? It would most likely invalid, but I'm not assert

[PATCH] D151092: [clang-tidy]performance-no-automatic-move: fix false negative on `const T&&` ctors.

courbet updated this revision to Diff 524288. courbet marked 2 inline comments as done. courbet added a comment. address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151092/new/ https://reviews.llvm.org/D151092 Files: clang-tool

[PATCH] D151098: [Clang][Docs] Add help test to `-march` and `-mcpu` to suggest `-mcpu=help`

jhuber6 created this revision. jhuber6 added reviewers: MaskRay, aaron.ballman. Herald added a project: All. jhuber6 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently there is no documentation for these flags, users might find it co

[PATCH] D151040: [NFC][CLANG] Fix static code analyzer concerns

Manna updated this revision to Diff 524291. Manna added a comment. Thank you @erichkeane for reviews. I have updated patch to avoid regression if the LValue doesn't evaluate right. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151040/new/ https://reviews.llvm.org/D151040 Files: clan

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

RitanyaB updated this revision to Diff 524290. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146418/new/ https://reviews.llvm.org/D146418 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaDecl.cpp clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/declare_target_messages.cpp

[PATCH] D151094: [clang][wip] Implement P2564 "consteval must propagate up"

aaron.ballman added inline comments. Comment at: clang/include/clang/AST/DeclBase.h:1695 /// Number of non-inherited bits in FunctionDeclBitfields. enum { NumFunctionDeclBits = 29 }; Need to update this as well. Comment at: clang/includ

[PATCH] D151087: [Clang] Permit address space casts with 'reinterpret_cast' in C++

arsenm added a comment. In D151087#4360606 , @jhuber6 wrote: > In D151087#4360577 , @ebevhan wrote: > >> What would be the semantics of such an operation if the address spaces are >> disjoint? Or, if the underlyi

[PATCH] D146418: Support for OpenMP 5.0 sec 2.12.7 - Declare Target initializer expressions

ABataev added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:14475-14477 + VD->hasGlobalStorage()) { +ActOnOpenMPDeclareTargetInitializer(D); + } Remove braces Comment at: clang/lib/Sema/SemaOpenMP.cpp:23091 +c

[PATCH] D151094: [clang][wip] Implement P2564 "consteval must propagate up"

tbaeder added inline comments. Comment at: clang/include/clang/AST/Decl.h:2391 + + bool isImmediateFunction() const; + Some documentation on the new API would be useful; seems like most calls to `isConsteval()` should be using `isImmediateFunction()` instead?

  1   2   3   >