[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues found by Coverity

Manna added inline comments. Comment at: clang/include/clang/Parse/Parser.h:1190 class ParseScopeFlags { Scope *CurScope; +unsigned OldFlags = 0; tahonermann wrote: > shafik wrote: > > @tahonermann I feel like we should have a default member initializ

[PATCH] D150913: [Clang][Bfloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

codemzs marked an inline comment as done. codemzs added a comment. I believe I had updated the `__bf16` documentation in `/llvm-project/clang/docs/LanguageExtensions.rst`, but it appears to have been omitted in this patch. I assure you, I'll rectify this in the next iteration. ===

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

aeubanks added a comment. `not` will set `LLVM_DISABLE_SYMBOLIZATION` if we use `not --crash` are these tests supposed to crash or gracefully fail? if they're supposed to crash then we should use `not --crash` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D150988: [clang][Darwin] Error out when missing requested libarclite library

keith created this revision. Herald added a project: All. keith requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Starting with the SDKs provided with Xcode 14.3, this library no longer exists. Before this change this results in an op

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

arsenm added a comment. I also think we need to revert or disable https://github.com/llvm/llvm-project/commit/cead4eceb01b935fae07bf4a7e91911b344d2fec The symbolizer is unusably slow with it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148851/new

[PATCH] D150988: [clang][Darwin] Error out when missing requested libarclite library

keith updated this revision to Diff 523899. keith added a comment. Improve test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150988/new/ https://reviews.llvm.org/D150988 Files: clang/include/clang/Basic/DiagnosticDriverKinds.td clang/lib/Driv

[PATCH] D150435: [clang] Fix crash on attempt to initialize union with flexible array member

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM after addressing Aaron's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150435/new/ https://reviews.llvm.org/D150435 __

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx updated this revision to Diff 523902. AlexVlx added a comment. Use `GetGlobalVarAddressSpace` everywhere. Added test, which I'm marking `XFAIL` for now since it turns out I'll need to fix the remaining vptr / vtable handling parts, yay. CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx added a comment. In D150746#4354742 , @rjmccall wrote: > Can you add a test? I think we have some in-tree targets which put globals > in a non-default address space. I've added the test (think we, i.e. AMDGPU, are the only ones doing this at th

[PATCH] D146773: [-Wunsafe-buffer-usage] Make raw (ungrouped) warnings a bit more verbose.

NoQ added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11786 + "%select{" +"unsafe operation on raw pointer in expression|" +"unsafe arithmetic on raw pointer|" NoQ wrote: > malavikasamak wrote: > > NoQ wrote: > > > The f

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

rjmccall added a comment. It's well-formed as IR, just not semantically valid, right? As long as it's not actually crashing in the verifier, please test as much as you reasonably can that's correct, like that the constructor and destructor functions take something in the right address space, a

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dblaikie added a comment. Looks like this series got approved - is it waiting on any particular feedback, or do you need someone to commit it for you? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143984/new/ https://reviews.llvm.org/D143984

[PATCH] D150996: LLVM_FALLTHROUGH => [[fallthrough]]. NFC

craig.topper created this revision. craig.topper added a reviewer: MaskRay. Herald added subscribers: ThomasRaoux, kbarton, hiraditya, nemanjai. Herald added a project: All. craig.topper requested review of this revision. Herald added a reviewer: zuban32. Herald added subscribers: lldb-commits, cfe

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

dblaikie added a comment. In D148851#4285705 , @dblaikie wrote: >> I think we probably should add LLVM_DISABLE_SYMBOLIZATION=1 to the lit >> level, not in individual tests. > > Though I'm not sure how to do that in a way that it doesn't apply to test >

[PATCH] D148387: remove Demangle/StringView.h

nickdesaulniers updated this revision to Diff 523923. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148387/new/ https://reviews.llvm.org/D148387 Files: clang/docs/tools/clang-formatted-files.txt libcxx

[PATCH] D150931: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

aaronpuchert added a comment. Can only comment on `ThreadSafetyTIL.h`. Thanks for addressing this, I agree that these expressions should not be assignable. Comment at: clang/include/clang/Analysis/Analyses/ThreadSafetyTIL.h:323-324 + // The copy assignment operator is defin

[PATCH] D150998: [OpenMP] Fix using the target ID when using the new driver

jhuber6 created this revision. jhuber6 added reviewers: JonChesterfield, carlo.bertolli, yaxunl, saiislam. Herald added subscribers: sunshaoce, kerbowa, guansong, tpr, jvesely. Herald added a project: All. jhuber6 requested review of this revision. Herald added subscribers: cfe-commits, jplehr, sst

[clang] f2492f7 - [clang][CodeGen] Break up TargetInfo.cpp [1/8]

Author: Sergei Barannikov Date: 2023-05-19T23:54:55+03:00 New Revision: f2492f7cf0b175d5d9403cbfc970a521adbde659 URL: https://github.com/llvm/llvm-project/commit/f2492f7cf0b175d5d9403cbfc970a521adbde659 DIFF: https://github.com/llvm/llvm-project/commit/f2492f7cf0b175d5d9403cbfc970a521adbde659.d

[clang] 5a646ed - [clang][CodeGen] Break up TargetInfo.cpp [2/8]

Author: Sergei Barannikov Date: 2023-05-19T23:55:02+03:00 New Revision: 5a646ed6835f2686cc0574047ce3c9bbaf323ea3 URL: https://github.com/llvm/llvm-project/commit/5a646ed6835f2686cc0574047ce3c9bbaf323ea3 DIFF: https://github.com/llvm/llvm-project/commit/5a646ed6835f2686cc0574047ce3c9bbaf323ea3.d

[clang] 0a86e05 - [clang][CodeGen] Break up TargetInfo.cpp [4/8]

Author: Sergei Barannikov Date: 2023-05-19T23:55:15+03:00 New Revision: 0a86e05d1da0f544920b1eff6656c5577fb6562f URL: https://github.com/llvm/llvm-project/commit/0a86e05d1da0f544920b1eff6656c5577fb6562f DIFF: https://github.com/llvm/llvm-project/commit/0a86e05d1da0f544920b1eff6656c5577fb6562f.d

[clang] f60cc01 - [clang][CodeGen] Break up TargetInfo.cpp [5/8]

Author: Sergei Barannikov Date: 2023-05-19T23:55:21+03:00 New Revision: f60cc01e9e75785dd2476c7e05da689be5a99839 URL: https://github.com/llvm/llvm-project/commit/f60cc01e9e75785dd2476c7e05da689be5a99839 DIFF: https://github.com/llvm/llvm-project/commit/f60cc01e9e75785dd2476c7e05da689be5a99839.d

[clang] 940b020 - [clang][CodeGen] Break up TargetInfo.cpp [3/8]

Author: Sergei Barannikov Date: 2023-05-19T23:55:08+03:00 New Revision: 940b02095bf986b5bcc365dc97667a27176c3b13 URL: https://github.com/llvm/llvm-project/commit/940b02095bf986b5bcc365dc97667a27176c3b13 DIFF: https://github.com/llvm/llvm-project/commit/940b02095bf986b5bcc365dc97667a27176c3b13.d

[PATCH] D148089: [clang][CodeGen] Break up TargetInfo.cpp [1/8]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf2492f7cf0b1: [clang][CodeGen] Break up TargetInfo.cpp [1/8] (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D148090: [clang][CodeGen] Break up TargetInfo.cpp [2/8]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a646ed6835f: [clang][CodeGen] Break up TargetInfo.cpp [2/8] (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D148091: [clang][CodeGen] Break up TargetInfo.cpp [3/8]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG940b02095bf9: [clang][CodeGen] Break up TargetInfo.cpp [3/8] (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/8]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a86e05d1da0: [clang][CodeGen] Break up TargetInfo.cpp [4/8] (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D148093: [clang][CodeGen] Break up TargetInfo.cpp [5/8]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf60cc01e9e75: [clang][CodeGen] Break up TargetInfo.cpp [5/8] (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D148851: Disable llvm-symbolizer on some of the driver tests that are timing out

dblaikie added a comment. In D148851#4357360 , @arsenm wrote: > I also think we need to revert or disable > https://github.com/llvm/llvm-project/commit/cead4eceb01b935fae07bf4a7e91911b344d2fec > > The symbolizer is unusably slow with it I believe that i

[PATCH] D145403: [Pipeline] Don't run EarlyFPM in LTO post link

nikic added a comment. Any reason why this hasn't been landed yet? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145403/new/ https://reviews.llvm.org/D145403 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D150955: [clang][AST] Propagate the value-dependent bit for VAArgExpr.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4e935240f02: [clang][AST] Propagate the value-dependent bit for VAArgExpr. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SIN

[clang] d4e9352 - [clang][AST] Propagate the value-dependent bit for VAArgExpr.

Author: Haojian Wu Date: 2023-05-19T23:43:46+02:00 New Revision: d4e935240f0223cdf2270dde587960d3d3868c6f URL: https://github.com/llvm/llvm-project/commit/d4e935240f0223cdf2270dde587960d3d3868c6f DIFF: https://github.com/llvm/llvm-project/commit/d4e935240f0223cdf2270dde587960d3d3868c6f.diff LO

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx added a comment. In D150746#4357443 , @rjmccall wrote: > It's well-formed as IR, just not semantically valid, right? As long as it's > not actually crashing in the verifier, please test as much as you reasonably > can that's correct, like that

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

rjmccall added a comment. I see. Yes, in that case I think you're right that we can't test this yet — only base-subobject ctors and dtors get VTT parameters, we only emit calls to those from other ctors and dtors, and those ctors and dtors will always have their own stores to the v-table slot

[PATCH] D150504: [AST] Construct Capture objects before use

vitalybuka added a comment. ping, any concerns regarding this patch? i want to make MSAN stricter on our bot by reducing -O level Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150504/new/ https://reviews.llvm.org/D150504 __

[PATCH] D150499: [AST] Initialized data after TypeSourceInfo

vitalybuka added a comment. ping, any concerns regarding this patch? i want to make MSAN stricter on our bot by reducing -O level Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150499/new/ https://reviews.llvm.org/D150499 __

[PATCH] D150931: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna updated this revision to Diff 523957. Manna added a comment. I have addressed review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150931/new/ https://reviews.llvm.org/D150931 Files: clang/include/clang/Analysis/Analyses/ThreadSafetyTIL.h clang/include/clang/StaticA

[PATCH] D150931: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

Manna marked 2 inline comments as done. Manna added inline comments. Comment at: clang/include/clang/Analysis/Analyses/ThreadSafetyTIL.h:323-324 + // The copy assignment operator is defined as deleted pending further + // motivation. + SExpr &operator=(const SExpr &) = delet

[PATCH] D143984: [DebugMetadata] Simplify handling subprogram's retainedNodes field. NFCI (1/7)

dzhidzhoev added a comment. In D143984#4357517 , @dblaikie wrote: > Looks like this series got approved - is it waiting on any particular > feedback, or do you need someone to commit it for you? I had been waiting for approval for the change of https:

[PATCH] D151010: [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Reported by Coverity

[clang] 34d8cd1 - [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

Author: Manna, Soumi Date: 2023-05-19T19:41:38-07:00 New Revision: 34d8cd153812c3e5e2db1a1e27f057db33b07b6e URL: https://github.com/llvm/llvm-project/commit/34d8cd153812c3e5e2db1a1e27f057db33b07b6e DIFF: https://github.com/llvm/llvm-project/commit/34d8cd153812c3e5e2db1a1e27f057db33b07b6e.diff

[PATCH] D150968: [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

This revision was automatically updated to reflect the committed changes. Closed by commit rG34d8cd153812: [NFC][CLANG] Fix issue with dereference null return value found by Coverity… (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D151010: [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

Manna updated this revision to Diff 523983. Manna added a comment. Fix Clang-format error CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151010/new/ https://reviews.llvm.org/D151010 Files: clang/lib/ARCMigrate/ObjCMT.cpp Index: clang/lib/ARCMigrate/ObjCMT.cpp ===

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

MaskRay updated this revision to Diff 523984. MaskRay marked 2 inline comments as done. MaskRay added a comment. fix a comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148785/new/ https://reviews.llvm.org/D148785 Files: clang/docs/Undefined

[PATCH] D151010: [NFC][CLANG] Fix issue with dereference null return value found by Coverity static analyzer tool

Manna updated this revision to Diff 523986. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151010/new/ https://reviews.llvm.org/D151010 Files: clang/lib/ARCMigrate/ObjCMT.cpp Index: clang/lib/ARCMigrate/ObjCMT.cpp === ---

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

MaskRay added inline comments. Comment at: clang/test/CodeGenCXX/catch-undef-behavior.cpp:408 // RTTI pointer check + // CHECK: [[CalleeTypeHashPtr:%.+]] = getelementptr <{ i32, i32 }>, <{ i32, i32 }>* [[PTR]], i32 -1, i32 1 peter.smith wrote: > MaskRay wr

[PATCH] D149612: [Sema] avoid merge error type

hokein accepted this revision. hokein added a comment. thanks, looks good to me. Comment at: clang/test/Sema/merge-decls.c:96 +char d; +char x[sizeof(d.data) == 8]; // expected-error {{member reference base type 'char' is not a structure or union}} +char x[sizeof(d.data) == 4]

[PATCH] D150913: [Clang][Bfloat16] Upgrade __bf16 to arithmetic type, change mangling, and extend excess precision support.

pengfei added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:381 HasBFloat16 = SSELevel >= SSE2; codemzs wrote: > rjmccall wrote: > > pengfei wrote: > > > I'm not sure if I understand the meaning of `HasFullBFloat16`. If it is > > > used f

[clang] a4f366d - Reland "[Driver] Support multi /guard: options"

Author: Phoebe Wang Date: 2023-05-20T14:44:05+08:00 New Revision: a4f366dcd85c440a611bbc82f1d24c2d9a735251 URL: https://github.com/llvm/llvm-project/commit/a4f366dcd85c440a611bbc82f1d24c2d9a735251 DIFF: https://github.com/llvm/llvm-project/commit/a4f366dcd85c440a611bbc82f1d24c2d9a735251.diff L

[PATCH] D150645: [Driver] Support multi /guard: options

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4f366dcd85c: Reland "[Driver] Support multi /guard: options" (authored by pengfei). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150645/new/ https://revie

[PATCH] D150685: [clangd] Renaming: Treat member functions like other functions

hokein added inline comments. Comment at: clang-tools-extra/clangd/refactor/Rename.cpp:519 +if (RenameDecl.getKind() != Decl::Function && +RenameDecl.getKind() != Decl::CXXMethod) { if (auto *Conflict = lookupSiblingWithName(ASTCtx, RenameDecl, NewName)) --

[PATCH] D150937: [clang-repl] Disable all tests on unsupported platforms

junaire created this revision. Herald added a project: All. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Jun Zhang Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D150937 Files: clang/unittest

[PATCH] D150939: [CMake] Remove BOLT from Fuchsia toolchain

phosek created this revision. phosek added a reviewer: abrachet. Herald added a subscriber: ekilmer. Herald added a project: All. phosek requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fuchsia toolchain is currently broken due to https://gi

[PATCH] D150761: [NFC][Py Reformat] Reformat python files in clang and clang-tools-extra

thieta updated this revision to Diff 523680. thieta added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150761/new/ https://reviews.llvm.org/D150761 Files: clang-tools-extra/clang-include-fixer/find-all-symbols/tool/run-find-a

[PATCH] D150887: [clang] Convert a few tests to opaque pointers

nikic accepted this revision. nikic added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CodeGenCXX/const-init-cxx11.cpp:353 }; - // CHECK: @_ZN14VirtualMembersL13sGlobalMemoryE = internal global { i8** } { i8** getelementptr inboun

[PATCH] D150646: [clang][X86] Add __cpuidex function to cpuid.h

aidengrossman updated this revision to Diff 523686. aidengrossman added a comment. Fix conflict with MS compatibility __cpuidex builtin. This update adds a preprocessor guard around the __cpuidex definition in cpuid.h that checks if _MSC_EXTENSIONS is defined. If _MSC_EXTENSIONS is defined, we can

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

jacquesguan updated this revision to Diff 523688. jacquesguan added a comment. make f16 vector type legal for Zvfhmin, add predicates to enable 2 convert pattern. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150253/new/ https://reviews.llvm.org/D

[PATCH] D150752: [bolt] Use correct output paths and passthrough necessary options

phosek updated this revision to Diff 523691. phosek marked 3 inline comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150752/new/ https://reviews.llvm.org/D150752 Files: bolt/CMakeLists.txt bolt/runtime/CMakeLists.txt clang/cmake

[PATCH] D150752: [bolt] Use correct output paths and passthrough necessary options

phosek added inline comments. Comment at: bolt/CMakeLists.txt:88 + if(CMAKE_SYSROOT) +list(APPEND extra_args -DCMAKE_SYSROOT=${CMAKE_SYSROOT}) + endif() michaelplatings wrote: > michaelplatings wrote: > > The [[ > > https://cmake.org/cmake/help/latest/vari

[PATCH] D150945: [RISCV] Add missing test for ctz_32 on RV64

Jim created this revision. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, sabuasal, si

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

jacquesguan added a comment. @michaelmaitland , I update this revision with my local branch. May you have a look and see what missed compared with you version? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150253/new/ https://reviews.llvm.org/D150

[PATCH] D150253: [RISCV] Add Zvfhmin extension.

jacquesguan updated this revision to Diff 523696. jacquesguan added a comment. Fix indention. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150253/new/ https://reviews.llvm.org/D150253 Files: clang/include/clang/Basic/riscv_vector.td clang/inc

[PATCH] D150752: [bolt] Use correct output paths and passthrough necessary options

michaelplatings accepted this revision. michaelplatings added a comment. This revision is now accepted and ready to land. LGTM Comment at: bolt/CMakeLists.txt:88 + if(CMAKE_SYSROOT) +list(APPEND extra_args -DCMAKE_SYSROOT=${CMAKE_SYSROOT}) + endif() phose

[PATCH] D150937: [clang-repl] Disable all tests on unsupported platforms

junaire updated this revision to Diff 523697. junaire added a comment. . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150937/new/ https://reviews.llvm.org/D150937 Files: clang/test/Interpreter/incremental-mode.cpp clang/unittests/Interpreter/

[PATCH] D150946: [clang][Interp] PointerToIntegral casts

tbaeder created this revision. tbaeder added reviewers: aaron.ballman, erichkeane, tahonermann, shafik. Herald added a project: All. tbaeder requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add a new opcode doing the cast and emit a diagnost

[PATCH] D150761: [NFC][Py Reformat] Reformat python files in clang and clang-tools-extra

PiotrZSL added a comment. Checked clang-tidy scripts, looks +- fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150761/new/ https://reviews.llvm.org/D150761 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D149612: [Sema] avoid merge error type

hokein added a comment. In D149612#4346068 , @sammccall wrote: > Unless I'm wildly misremembering (@hokein knows better), the type should also > be dependent in C. > > The intuition is that the code has some meaning that depends on how the error > is re

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

joshua-arch1 added a comment. Can you merge this patch since I want to suppport support __bf16 in clang which will rely on FeatureStdExtZfbfmin? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147610/new/ https://reviews.llvm.org/D147610 ___ c

[clang] c10138a - Fix MSVC "not all control paths return a value" warning. NFC.

Author: Simon Pilgrim Date: 2023-05-19T10:40:14+01:00 New Revision: c10138a54f7f50c7a4d92b79a8887c51c52e2c20 URL: https://github.com/llvm/llvm-project/commit/c10138a54f7f50c7a4d92b79a8887c51c52e2c20 DIFF: https://github.com/llvm/llvm-project/commit/c10138a54f7f50c7a4d92b79a8887c51c52e2c20.diff

[clang] b87e5a0 - Add missing llvm/Support/Compiler.h include for MSVC builds without __has_attribute

Author: Simon Pilgrim Date: 2023-05-19T10:39:31+01:00 New Revision: b87e5a046f6e3ee117c9f8cbe9ae368b30127b37 URL: https://github.com/llvm/llvm-project/commit/b87e5a046f6e3ee117c9f8cbe9ae368b30127b37 DIFF: https://github.com/llvm/llvm-project/commit/b87e5a046f6e3ee117c9f8cbe9ae368b30127b37.diff

[PATCH] D150948: [clang][RecoveryExpr] Fix a crash where a dependent type crahes on c-only code path.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. A depenent type is possible in C-only path, add a proper handling when checking the enum constant. Fixes https://github.com/llvm/

[PATCH] D150946: [clang][Interp] PointerToIntegral casts

tbaeder added a comment. Hm, this works for pointers, but not for function pointers (which we map to `FunctionPointer`). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150946/new/ https://reviews.llvm.org/D150946 __

[PATCH] D150953: [Clang][SVE2.1] Add clang support for prototypes using svcount_t

CarolineConcatto created this revision. Herald added subscribers: kristof.beyls, tschuett. Herald added a project: All. CarolineConcatto requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In this patch it is used for the prototype: - svptrue_

[PATCH] D148665: Change -fsanitize=function to place two words before the function entry

peter.smith accepted this revision. peter.smith added a comment. This revision is now accepted and ready to land. Apologies for the delay LGTM. I think there is a case for setting up the signature to be target specific, but that could in theory be done on demand when a target adds a clashing ins

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

pmatos added a comment. @nikic Thank you for the thorough suggestions above. I will have to look at this closer next week and will work on an alternative solution. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150670/new/ https://reviews.llvm.org/

[PATCH] D150955: [clang][AST] Propagate the value-dependent bit for VAArgExpr.

hokein created this revision. hokein added a reviewer: sammccall. Herald added a project: All. hokein requested review of this revision. Herald added a project: clang. Fixes https://github.com/llvm/llvm-project/issues/62711 We never set the value-dependent bit for the VAArgExpr before this patch,

[PATCH] D150435: [clang] Fix crash on attempt to initialize union with flexible array member

Fznamznon updated this revision to Diff 523723. Fznamznon added a comment. Move the test to a separate file, test C++ and MSVC compatibility mode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150435/new/ https://reviews.llvm.org/D150435 Files: c

[PATCH] D150863: [CLANG][AArch64][SVE2.1] Add UCLAMP/SCLAMP/FCLAMP function prototypes

sdesmalen accepted this revision. sdesmalen added a comment. This revision is now accepted and ready to land. LGTM with nit addressed Comment at: clang/include/clang/Basic/arm_sve.td:2113 +let TargetGuard = "sve2p1" in { + def SVSCLAMP : SInst<"svclamp[_{d}]", "", "csil",

[PATCH] D150817: Use windows baskslash on anonymous tag locations if using MSVCFormatting and it's not absolute path.

hans accepted this revision. hans added a comment. Nice! lgtm Comment at: clang/lib/AST/TypePrinter.cpp:1391 + WrittenFile = Callbacks->remapPath(File); +// The following tries to fix inconsistent path separator created by +// clang::DirectoryLookup::Lo

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin updated this revision to Diff 523729. cor3ntin added a comment. Address Aaron's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D149276 Files: clang/docs/ReleaseNotes.rst clang/include/clang

[clang] e4e6c65 - [IR] Adds Instruction::setNoSanitizeMetadata()

Author: Enna1 Date: 2023-05-19T19:18:57+08:00 New Revision: e4e6c6510b183f478df48a92feb6ef1a5e20aa0a URL: https://github.com/llvm/llvm-project/commit/e4e6c6510b183f478df48a92feb6ef1a5e20aa0a DIFF: https://github.com/llvm/llvm-project/commit/e4e6c6510b183f478df48a92feb6ef1a5e20aa0a.diff LOG: [I

[PATCH] D150632: [IR] Adds Instruction::setNoSanitizeMetadata()

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4e6c6510b18: [IR] Adds Instruction::setNoSanitizeMetadata() (authored by Enna1). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150632/new/ https://reviews.

[PATCH] D150960: [NFC] Fix uninitialized scalar variable found by Coverity static analyzer tool

Manna created this revision. Manna added a reviewer: zturner. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: LLVM. Herald added a subscriber:

[clang] d93bdd8 - [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

Author: Dominik Adamski Date: 2023-05-19T06:22:40-05:00 New Revision: d93bdd8bd52a9a28bb9553aed72866df88c6c4f4 URL: https://github.com/llvm/llvm-project/commit/d93bdd8bd52a9a28bb9553aed72866df88c6c4f4 DIFF: https://github.com/llvm/llvm-project/commit/d93bdd8bd52a9a28bb9553aed72866df88c6c4f4.dif

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rGd93bdd8bd52a: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate… (authored by domada). Changed prior to commit: https://reviews.llvm.org/D150354?vs=522999&id=523732#toc Repository:

[PATCH] D150960: [NFC] Fix uninitialized scalar variable found by Coverity static analyzer tool

Manna added a comment. I am closing this PR. The change is not correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150960/new/ https://reviews.llvm.org/D150960 ___ cfe-commits mailing list cfe-commits

[PATCH] D150960: [NFC] Fix uninitialized scalar variable found by Coverity static analyzer tool

Manna updated this revision to Diff 523735. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150960/new/ https://reviews.llvm.org/D150960 Files: llvm/include/llvm/Demangle/MicrosoftDemangle.h Index: llvm/include/llvm/Demangle/MicrosoftDemangle.h =

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D149276 ___ cfe-commits mailing list cfe-comm

[PATCH] D150961: [Clang][SVE2.1] Add svcntp prototype

CarolineConcatto created this revision. Herald added subscribers: kristof.beyls, tschuett. Herald added a project: All. CarolineConcatto requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Patch by : David Sherwood Repository: rG LLVM Gith

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos updated this revision to Diff 523741. pmatos added a comment. Remove modifications from Type.h and move them to WebAssembly files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139010/new/ https://reviews.llvm.org/D139010 Files: clang/doc

[PATCH] D139010: [clang][WebAssembly] Implement support for table types and builtins

pmatos added a comment. In D139010#4350869 , @tlively wrote: > It looks like the LLVM-side changes are generally moving Wasm type > classification functions to a more global location. Since no other backend > should care about these things, it would be

[clang] 7599381 - Use windows baskslash on anonymous tag locations if using MSVCFormatting and it's not absolute path.

Author: Zequan Wu Date: 2023-05-19T08:44:12-04:00 New Revision: 75993812d5c1f269b781c34987748f2a792a579d URL: https://github.com/llvm/llvm-project/commit/75993812d5c1f269b781c34987748f2a792a579d DIFF: https://github.com/llvm/llvm-project/commit/75993812d5c1f269b781c34987748f2a792a579d.diff LOG

[PATCH] D150817: Use windows baskslash on anonymous tag locations if using MSVCFormatting and it's not absolute path.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG75993812d5c1: Use windows baskslash on anonymous tag locations if using MSVCFormatting and… (authored by zequanwu). Changed prior to commit: https

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

erichkeane added inline comments. Comment at: clang/docs/ReleaseNotes.rst:59 +- Clang no longer allows dereferencing of a ``void*`` as an extension. Clang 16 + converted this to a warning-as-default-error as well as a SFINAE error. MaskRay wrote: > Mention `-W

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

hans added a comment. In D144509#4350052 , @Mordante wrote: > In D144509#4349921 , @thakis wrote: > >> Reverted this and follow-ups in d763c6e5e2d0a6b34097aa7dabca31e9aff9b0b6 >>

[clang] 094ab47 - Revert "Reland [clang-repl] Introduce Value to capture expression results"

Author: Jun Zhang Date: 2023-05-19T20:56:21+08:00 New Revision: 094ab4781262b6cb49d57b0ecdf84b047c879295 URL: https://github.com/llvm/llvm-project/commit/094ab4781262b6cb49d57b0ecdf84b047c879295 DIFF: https://github.com/llvm/llvm-project/commit/094ab4781262b6cb49d57b0ecdf84b047c879295.diff LOG

[PATCH] D150645: [Driver] Support multi /guard: options

pengfei updated this revision to Diff 523745. pengfei added a comment. In D150645#4353408 , @aeubanks wrote: > if you add a test for the repro, relanding lgtm Thanks, done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D148723: [clang] Enforce external linkage for inline builtin original declaration

serge-sans-paille added a comment. > So if isInlineBuiltinDeclaration() simply returns false for C++ code, > everything should just work, without messing with the linkage. Unfortunately not. See the example from `clang/test/CodeGen/inline-builtin-comdat.c` above. There's no C++ involved, the a

[PATCH] D150875: Make dereferencing a void* a hard-error instead of warn-as-error

erichkeane updated this revision to Diff 523748. erichkeane added a comment. Update release note per @MaskRay , change error message per @rsmith CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150875/new/ https://reviews.llvm.org/D150875 Files: clang/docs/ReleaseNotes.rst clang/inclu

[PATCH] D148723: [clang] Fix comdat for InlineBuiltin declarations

serge-sans-paille updated this revision to Diff 523747. serge-sans-paille retitled this revision from "[clang] Enforce external linkage for inline builtin original declaration" to "[clang] Fix comdat for InlineBuiltin declarations". serge-sans-paille edited the summary of this revision. CHANGES

[PATCH] D144999: [Clang][MC][MachO]Only emits compact-unwind format for "canonical" personality symbols. For the rest, use DWARFs.

thakis added a comment. This makes lld crash when linking a libc++ with object files built by a clang that also contains the patch. Here's a reduced (to just libc++), stand-alone repro that repros the crash in 6 seconds on my m1 mbp: https://bugs.chromium.org/p/chromium/issues/detail?id=1446967

<    1   2   3   >