nikic accepted this revision.
nikic added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: clang/test/CodeGenCXX/const-init-cxx11.cpp:353
};
- // CHECK: @_ZN14VirtualMembersL13sGlobalMemoryE = internal global { i8** } {
i8** getelementptr inbounds ({ [3 x i8*] }, { [3 x i8*] }*
@_ZTVN14VirtualMembers12nsMemoryImplE, i32 0, inrange i32 0, i32 2) }
+ // CHECK: @_ZN14VirtualMembersL13sGlobalMemoryE = internal global
%"struct.VirtualMembers::nsMemoryImpl" { ptr getelementptr inbounds ({ [3 x
ptr] }, ptr @_ZTVN14VirtualMembers12nsMemoryImplE, i32 0, inrange i32 0, i32 2)
}
__attribute__((used))
----------------
barannikov88 wrote:
> This was one suspicious change. An anonymous struct became named.
>
Not sure why exactly this happened, but should be harmless. I believe we
sometimes generate anon structs for initializaton because the types used for
initialization are not always compatible with the nominal LLVM memory type -- I
guess there previously was a mismatch in pointer types here or something.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150887/new/
https://reviews.llvm.org/D150887
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
