[PATCH] D150756: [clang][dataflow] Remove unused parameter from `diagnoseUnwrapCall()`.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://r

[PATCH] D147731: [3/11][POC][Clang][RISCV] Add typedef of the tuple type and define tuple type variant of vlseg2e32

eopXD updated this revision to Diff 522923. eopXD added a comment. Address comments from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147731/new/ https://reviews.llvm.org/D147731 Files: clang/include/clang/AST/ASTContext.h clang/includ

[PATCH] D150758: [AIX] make integrated-as as default on AIX.

Esme created this revision. Esme added reviewers: shchenz, DiggerLin, hubert.reinterpretcast, PowerPC. Herald added a subscriber: hiraditya. Herald added a project: All. Esme requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, MaskRay. Herald added projects: clan

[PATCH] D147731: [3/11][POC][Clang][RISCV] Add typedef of the tuple type and define tuple type variant of vlseg2e32

eopXD updated this revision to Diff 522924. eopXD added a comment. Update code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147731/new/ https://reviews.llvm.org/D147731 Files: clang/include/clang/AST/ASTContext.h clang/include/clang/Basic/ri

[clang] c5a80c2 - [Driver][test] fix cuda-simple.cu: -fsyntax-only -c => -c

Author: Fangrui Song Date: 2023-05-17T00:18:55-07:00 New Revision: c5a80c2128887f5509400909308fc39cc901aa61 URL: https://github.com/llvm/llvm-project/commit/c5a80c2128887f5509400909308fc39cc901aa61 DIFF: https://github.com/llvm/llvm-project/commit/c5a80c2128887f5509400909308fc39cc901aa61.diff

[clang] 43eb098 - [Driver][test] fix cuda-simple.cu: -fsyntax-only -c => -c

Author: Fangrui Song Date: 2023-05-17T00:21:03-07:00 New Revision: 43eb0982b5e1b8a48cac581906794911eb901c74 URL: https://github.com/llvm/llvm-project/commit/43eb0982b5e1b8a48cac581906794911eb901c74 DIFF: https://github.com/llvm/llvm-project/commit/43eb0982b5e1b8a48cac581906794911eb901c74.diff

[PATCH] D146873: [2/11][POC][Clang][RISCV] Define RVV tuple types

craig.topper added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:3070 + + llvm::Value *LoadedStructValue = CreateCoercedLoad(Ptr, STy, *this); + eopXD wrote: > craig.topper wrote: > > What are we loading here? > > > > Is there a test for thi

[PATCH] D147774: [4/11][POC][Clang][RISCV] Define tuple type variant of vsseg2e32

eopXD updated this revision to Diff 522928. eopXD added a comment. ddress comment from Craig. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147774/new/ https://reviews.llvm.org/D147774 Files: clang/include/clang/Basic/riscv_vector.td clang/lib

[PATCH] D142660: [AIX] supporting -X options for llvm-ranlib in AIX OS

jhenderson added a comment. I haven't looked again at the rest of this patch. I'll do so hopefully in the next couple of weeks. Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:80 + << " -U- Use actual timestamps and uids/gids\n" + << " -X {32|6

[PATCH] D147911: [5/11][POC][Clang][RISCV] Define tuple type variant of vlseg2e32ff

eopXD updated this revision to Diff 522930. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147911/new/ https://reviews.llvm.org/D147911 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rv

[clang] 6012cad - [clang][analyzer] Display buffer sizes in StdCLibraryFunctionArgs checker

Author: Balázs Kéri Date: 2023-05-17T09:34:05+02:00 New Revision: 6012cadc400f4400c97e00da268de17e94a3f5dc URL: https://github.com/llvm/llvm-project/commit/6012cadc400f4400c97e00da268de17e94a3f5dc DIFF: https://github.com/llvm/llvm-project/commit/6012cadc400f4400c97e00da268de17e94a3f5dc.diff L

[PATCH] D149321: [clang][analyzer] Display buffer sizes in StdCLibraryFunctionArgs checker

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6012cadc400f: [clang][analyzer] Display buffer sizes in StdCLibraryFunctionArgs checker (authored by balazske). Changed prior to commit: https://r

[PATCH] D147912: [6/11][POC][Clang][RISCV] Define tuple type variant of vlsseg2e32

eopXD updated this revision to Diff 522932. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147912/new/ https://reviews.llvm.org/D147912 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rv

[clang] d515b81 - [Driver][gcov] Derive .gcno .gcda file names from -o and -dumpdir

Author: Fangrui Song Date: 2023-05-17T00:43:00-07:00 New Revision: d515b8125364ef85fb100f1430b2174ed816cc18 URL: https://github.com/llvm/llvm-project/commit/d515b8125364ef85fb100f1430b2174ed816cc18 DIFF: https://github.com/llvm/llvm-project/commit/d515b8125364ef85fb100f1430b2174ed816cc18.diff

[PATCH] D147913: [7/11][POC][Clang][RISCV] Define tuple type variant of vssseg2e32

eopXD updated this revision to Diff 522933. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147913/new/ https://reviews.llvm.org/D147913 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rv

[PATCH] D147914: [8/11][POC][Clang][RISCV] Define tuple type variant of vloxseg2ei32 vluxseg2ei32

eopXD updated this revision to Diff 522934. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147914/new/ https://reviews.llvm.org/D147914 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rv

[PATCH] D147915: [9/11][POC][Clang][RISCV] Define tuple type variant of vsoxseg2ei32 vsuxseg2ei32

eopXD updated this revision to Diff 522937. eopXD added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147915/new/ https://reviews.llvm.org/D147915 Files: clang/include/clang/Basic/riscv_vector.td clang/test/CodeGen/RISCV/rv

[PATCH] D150670: [WebAssembly] Disable generation of fshl/fshr for rotates

pmatos added a comment. In D150670#4347150 , @dschuff wrote: > FWIW X86 seems to do something similar elsewhere in this file > (https://github.com/llvm/llvm-project/blob/main/clang/lib/CodeGen/CGBuiltin.cpp#L985-L986), > although it doesn't seem common

[clang] f8c9947 - [clang][Interp][NFC] Move dyn_cast check into if condition

Author: Timm Bäder Date: 2023-05-17T10:27:44+02:00 New Revision: f8c99477d4b3e8c9faf0f316178e8ab92e281602 URL: https://github.com/llvm/llvm-project/commit/f8c99477d4b3e8c9faf0f316178e8ab92e281602 DIFF: https://github.com/llvm/llvm-project/commit/f8c99477d4b3e8c9faf0f316178e8ab92e281602.diff LO

[clang] ffb4f4d - [ClangTidy] Fix markup in comments

Author: Dmitri Gribenko Date: 2023-05-17T10:29:10+02:00 New Revision: ffb4f4db73419d9eba81efe00aa0d498f01f6d27 URL: https://github.com/llvm/llvm-project/commit/ffb4f4db73419d9eba81efe00aa0d498f01f6d27 DIFF: https://github.com/llvm/llvm-project/commit/ffb4f4db73419d9eba81efe00aa0d498f01f6d27.dif

[clang] 0b3c48d - [cmake] Correct option to LLVM_FORCE_USE_OLD_TOOLCHAIN

Author: Jonas Hahnfeld Date: 2023-05-17T10:35:49+02:00 New Revision: 0b3c48d5722a30e8b052b8d08f6de5afcf2edeb1 URL: https://github.com/llvm/llvm-project/commit/0b3c48d5722a30e8b052b8d08f6de5afcf2edeb1 DIFF: https://github.com/llvm/llvm-project/commit/0b3c48d5722a30e8b052b8d08f6de5afcf2edeb1.diff

[PATCH] D147916: [10/11][POC][Clang][RISCV] Define vget for tuple type

eopXD updated this revision to Diff 522946. eopXD marked an inline comment as done. eopXD added a comment. Rebase and fix test case failure by only defining intrinsics for vint32m1x2_t. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147916/new/ http

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

dyung added a comment. I'm not really sure where else to post this, but the pre-merge linux bot still seems to be running 3.18.4. https://buildkite.com/llvm-project/premerge-checks/builds/152678#018828d2-1837-4fc2-baec-fca595969219 CMake Error at CMakeLists.txt:3 (cmake_minimum_required):

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH updated this revision to Diff 522954. vikramRH added a comment. 1. Updating D150427 : [AMDGPU] Non hostcall printf support for HIP # 2. Enter a brief description of the changes included in this update. 3. The first line is used as subject, next lines a

[PATCH] D147917: [11/11][POC][Clang][RISCV] Define vset for tuple type

eopXD updated this revision to Diff 522953. eopXD added a comment. Rebase and resolve CI failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147917/new/ https://reviews.llvm.org/D147917 Files: clang/include/clang/Basic/riscv_vector.td clang

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

hans added a comment. In D144509#4347562 , @glandium wrote: > FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c > is > causing problems on Windows compiler-rt for some reason I haven't id

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH added a comment. In D150427#4338334 , @jhuber6 wrote: > Where does the runtime implementation of this live? I'm not very familiar > with the HIP / hostcall ecosystem. Currently there is a rocclr review up internally for the runtime side support

[PATCH] D150761: [NFC][Py Reformat] Reformat python files in clang and clang-tools-extra

thieta created this revision. thieta added reviewers: jhenderson, JDevlieghere, MatzeB. Herald added subscribers: PiotrZSL, kadircet, mattd, asavonic, carlosgalvezp, abrachet, phosek, arphaman, fedor.sergeev, whisperity. Herald added a reviewer: NoQ. Herald added a reviewer: njames93. Herald added

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

vikramRH added inline comments. Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:458 +auto CreateControlDWord = M->getOrInsertFunction( +StringRef("__ockl_create_control_dword"), Builder.getInt32Ty(), +Builder.getInt32Ty(), Int1Ty, Int1Ty); -

[PATCH] D150761: [NFC][Py Reformat] Reformat python files in clang and clang-tools-extra

barannikov88 added inline comments. Herald added a subscriber: ormris. Comment at: clang-tools-extra/clang-include-fixer/find-all-symbols/tool/run-find-all-symbols.py:9 # -#======# +# ===--

[PATCH] D150653: [clang][dataflow] Add `Strict` versions of `Value` and `StorageLocation` accessors.

mboehme marked 3 inline comments as done. mboehme added a comment. Failing x64 debian build is due to a wrong CMake version, which is unrelated to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150653/new/ https://reviews.llvm.org/D1506

[PATCH] D150653: [clang][dataflow] Add `Strict` versions of `Value` and `StorageLocation` accessors.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG080ee850c639: [clang][dataflow] Add `Strict` versions of `Value` and `StorageLocation`… (authored by mboehme). Repository: rG LLVM Github Monorepo

[clang] 080ee85 - [clang][dataflow] Add `Strict` versions of `Value` and `StorageLocation` accessors.

Author: Martin Braenne Date: 2023-05-17T09:30:47Z New Revision: 080ee850c639be96b8bea8008088f2b036ff0f15 URL: https://github.com/llvm/llvm-project/commit/080ee850c639be96b8bea8008088f2b036ff0f15 DIFF: https://github.com/llvm/llvm-project/commit/080ee850c639be96b8bea8008088f2b036ff0f15.diff LOG

[PATCH] D148785: -fsanitize=function: use type hashes instead of RTTI objects

peter.smith added inline comments. Comment at: llvm/test/CodeGen/AArch64/patchable-function-entry-bti.ll:92 ; CHECK-NEXT: .Ltmp{{.*}}: ; CHECK-NEXT: nop ; CHECK-NEXT: .word 3238382334 // 0xc105cafe samitolvanen wrote: > peter.smith wrote: > > Assuming t

[clang] e22fa1d - [C++20] [Modules] Emit a warning if the we load the modules by implicit generated path

Author: Chuanqi Xu Date: 2023-05-17T17:53:36+08:00 New Revision: e22fa1d4c6152d36cf1342ab9029adc97c79a310 URL: https://github.com/llvm/llvm-project/commit/e22fa1d4c6152d36cf1342ab9029adc97c79a310 DIFF: https://github.com/llvm/llvm-project/commit/e22fa1d4c6152d36cf1342ab9029adc97c79a310.diff LO

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

zyounan added a comment. Thank you for the update. A few questions: - Can you add a test with macro expansion? Would we get two inlay hints right after the spelling location? e.g., #define Decl_Record \ struct Widget { \ [very long definition that reach `EndDefinitionCommentMinLine

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

sameerds added inline comments. Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:212 +// helper struct to package the string related data +typedef struct S { + std::string Str; you can just say "struct StringData" Comment at: llvm/li

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

kadircet added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:90 +if (Tasks) { + std::unique_lock Lock(*Barrier, std::try_to_lock); + Tasks->runAsync("task:" + Path + Version, std::move(Task)); what's the point of this semaph

[clang] 16f49ea - Revert "[Driver][gcov] Derive .gcno .gcda file names from -o and -dumpdir"

Author: Tom Weaver Date: 2023-05-17T11:19:55+01:00 New Revision: 16f49ea2a2fb20d021075337595d6eacafdf6e2b URL: https://github.com/llvm/llvm-project/commit/16f49ea2a2fb20d021075337595d6eacafdf6e2b DIFF: https://github.com/llvm/llvm-project/commit/16f49ea2a2fb20d021075337595d6eacafdf6e2b.diff LO

[PATCH] D128612: RISC-V big-endian support implementation

djtodoro added a comment. In D128612#4345912 , @asb wrote: > In D128612#4337037 , @djtodoro > wrote: > >> Hi! I am wondering if someone knows what is the status of this. > > I've not seen any further progress. I

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin updated this revision to Diff 522979. cor3ntin added a comment. - When tentative parse an abstract declarator whithout auto specifier, do not classify it as a declaration based on the presence of arrow - When tentative parse a declarion vs member access, do not annotate the token after

[PATCH] D128612: RISC-V big-endian support implementation

asb added a comment. In D128612#4349259 , @djtodoro wrote: > In D128612#4345912 , @asb wrote: > >> In D128612#4337037 , @djtodoro >> wrote: >> >>> Hi! I am wondering if s

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

arsenm added inline comments. Comment at: clang/include/clang/Basic/TargetOptions.h:99 + +/// pritnf lowering scheme involving implicit printf buffers, +Buffered = 1, Typo pritnf Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.c

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG22e3f587fd1f: [Lex] Warn when defining or undefining any builtin macro (authored by john.brawn). Changed prior to commit: https://reviews.llvm.org

[clang] 22e3f58 - [Lex] Warn when defining or undefining any builtin macro

Author: John Brawn Date: 2023-05-17T11:49:49+01:00 New Revision: 22e3f587fd1ff97185014cb1ba723579ed2150d3 URL: https://github.com/llvm/llvm-project/commit/22e3f587fd1ff97185014cb1ba723579ed2150d3 DIFF: https://github.com/llvm/llvm-project/commit/22e3f587fd1ff97185014cb1ba723579ed2150d3.diff LO

[PATCH] D128612: RISC-V big-endian support implementation

djtodoro added a comment. In D128612#4349291 , @asb wrote: > In D128612#4349259 , @djtodoro > wrote: > >> In D128612#4345912 , @asb wrote: >> >>> In D128612#4337037

[PATCH] D150740: [clang] Add `__attribute__((nooutline))`

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. The changes are missing Sema tests for diagnosing incorrect appertainment, arguments, etc. It would also be good to have a CodeGen test showing the behavior works on an

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

mstorsjo added a comment. In D144509#4349051 , @hans wrote: > In D144509#4347562 , @glandium > wrote: > >> FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c >>

[PATCH] D150740: [clang] Add `__attribute__((nooutline))`

aaron.ballman added a comment. Also, precommit CI found valid test failures that need to be addressed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150740/new/ https://reviews.llvm.org/D150740 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

aaron.ballman added reviewers: rjmccall, efriedma. aaron.ballman added a comment. Thank you for the fix! Please be sure to add test coverage for the changes and a release note for the fix. Adding the codegen code owners for review. FWIW, precommit CI is failing to build the patch. Repository:

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

domada updated this revision to Diff 522999. domada added a comment. Change the default version of OpenMP version flag to 1.1 for flang. Modify the flag description text. No changes for Clang code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150354/new/ https://reviews.llvm.org/D1503

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

domada added a comment. In D150354#4348785 , @kiranchandramohan wrote: > In D150354#4342146 , @domada wrote: > >> In D150354#4337148 , @awarzynski >> wrote: >> >>> All i

[PATCH] D150040: [clang][Interp] Call invalid destructors

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150040/new/ https://reviews.llvm.org/D150040 _

[PATCH] D144164: [clang][Interp] Handle PtrMemOps

aaron.ballman added inline comments. Comment at: clang/lib/AST/Interp/Context.cpp:122 + T->isFunctionProtoType() || + T->isSpecificBuiltinType(BuiltinType::BoundMember)) +return PT_FnPtr; Do you have test coverage for the bound member case? Reposi

[PATCH] D150427: [AMDGPU] Non hostcall printf support for HIP

sameerds added inline comments. Comment at: llvm/lib/Transforms/Utils/AMDGPUEmitPrintf.cpp:184-185 // specify a string, i.e, the "%s" specifier with optional '*' characters. -static void locateCStrings(SparseBitVector<8> &BV, Value *Fmt) { - StringRef Str; - if (!getConstantSt

[PATCH] D149677: [clang][TypePrinter] Add option to skip over elaborated types

aaron.ballman added a comment. In D149677#4320178 , @li.zhe.hua wrote: > In D149677#4319646 , @aaron.ballman > wrote: > >> Will this new printing policy be used in tree? > > Not initially, no. (I'm understanding

[PATCH] D150549: Move SubtargetFeature.h from MC to TargetParser

jobnoorman added a comment. In D150549#4347056 , @MaskRay wrote: > This seems fine, but please consider making `MC/SubtargetFeature.h` a > forwarding header temporarily. To be clear: do you want me to check-in this forwarding header or should I just do

[PATCH] D148088: [RFC][clangd] Move preamble index out of document open critical path

DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clangd/ClangdServer.cpp:90 +if (Tasks) { + std::unique_lock Lock(*Barrier, std::try_to_lock); + Tasks->runAsync("task:" + Path + Version, std::move(Task)); kadircet wrote: > what's

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

aaron.ballman added a comment. My primary concern with this is that we're calling these stable IDs -- they're not really stable IDs, they're internal implementation details that we change from time to time. So what happens when we rename `ext_foo_bar` into `warn_foo_bar` as far as SARIF is conc

[PATCH] D150773: [clang][modules] Add features for recent C++ versions

Hahnfeld created this revision. Hahnfeld added reviewers: ChuanqiXu, Bigcheese, v.g.vassilev, aaron.ballman. Herald added a project: All. Hahnfeld requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add `cplusplus20`, `cplusplus23`, and `cplusp

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

asb updated this revision to Diff 523016. asb edited the summary of this revision. asb added a comment. Now updated to reflect v0.6 of the spec and should be ready for final review and merge https://github.com/riscv/riscv-bfloat16/releases/tag/main CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D147611: [RISCV][MC] Add support for experimental Zvfbfmin extension

asb updated this revision to Diff 523017. asb edited the summary of this revision. asb added a comment. Now updated to version 0.6 of the specification (was previously blocked on a new PDF being tagged). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147611/new/ https://reviews.llvm.org

[PATCH] D147612: [RISCV][MC] Add support for experimental Zvfbfwma extension

asb updated this revision to Diff 523018. asb edited the summary of this revision. asb added a comment. Now updated to version 0.6 of the spec (was previously blocked on a new PDF being tagged and uploaded). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147612/new/ https://reviews.llvm

[PATCH] D150773: [clang][modules] Add features for recent C++ versions

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM, but please add a release note when landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150773/new/ https://reviews.llvm.o

[PATCH] D150354: [OpenMP][MLIR][Flang][bbc][Driver] Add fopenmp-version and generate corresponding MLIR attribute

kiranchandramohan accepted this revision. kiranchandramohan added a comment. This revision is now accepted and ready to land. LGTM. Target-related constructs came in as part of OpenMP 4.0. Would you want to have a different default for the device version? CHANGES SINCE LAST ACTION https://re

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx updated this revision to Diff 523019. AlexVlx added a comment. Corrected typo that was breaking the build; rewrote the AS-using branch to account for the (unsupported, but possible, I think?) case of typed pointers, which was showing up in some tests that haven't been ported to opaque po

[PATCH] D150746: [CodeGen]Translating pointer arguments can require an address space cast

AlexVlx added a comment. In D150746#4349408 , @aaron.ballman wrote: > Thank you for the fix! Please be sure to add test coverage for the changes > and a release note for the fix. > > Adding the codegen code owners for review. FWIW, precommit CI is faili

[PATCH] D150773: [clang][modules] Add features for recent C++ versions

Hahnfeld updated this revision to Diff 523021. Hahnfeld added a comment. > LGTM, but please add a release note when landing. There wasn't a category specific to modules, so I just added two entries for C++20 and C++23 - ok? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150773/new/ htt

[PATCH] D150773: [clang][modules] Add features for recent C++ versions

aaron.ballman added a comment. In D150773#4349607 , @Hahnfeld wrote: >> LGTM, but please add a release note when landing. > > There wasn't a category specific to modules, so I just added two entries for > C++20 and C++23 - ok? Sure, that works! We can r

[PATCH] D141714: Fix ast print of variables with attributes

giulianobelinassi marked 4 inline comments as done and 2 inline comments as done. giulianobelinassi added a comment. I will update the patch with the suggestions and send them again. Comment at: clang/lib/AST/DeclPrinter.cpp:270 + + // FIXME: Find a way to use the AttrLis

[PATCH] D149248: [RISCV][MC] MC layer support for the experimental zacas extension

asb updated this revision to Diff 523026. asb added a comment. Rebase and ping (also checked there have been no relevant spec changes since this patch was posted). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149248/new/ https://reviews.llvm.org/D149248 Files: clang/test/Preprocess

[clang] 53c03a3 - [clang][modules] Add features for recent C++ versions

Author: Jonas Hahnfeld Date: 2023-05-17T15:18:50+02:00 New Revision: 53c03a3db16cd9b51476ce4b4fb1adc1b58f1ff7 URL: https://github.com/llvm/llvm-project/commit/53c03a3db16cd9b51476ce4b4fb1adc1b58f1ff7 DIFF: https://github.com/llvm/llvm-project/commit/53c03a3db16cd9b51476ce4b4fb1adc1b58f1ff7.diff

[PATCH] D150773: [clang][modules] Add features for recent C++ versions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG53c03a3db16c: [clang][modules] Add features for recent C++ versions (authored by Hahnfeld). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

sammccall accepted this revision. sammccall added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:138 +static void forwardValue(const Expr &From, const Expr &To, Environment &Env) { + if (auto *Val = Env.getValueStrict(From)) mboehme

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues with Coverity

Manna updated this revision to Diff 523025. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 Files: clang/include/clang/Analysis/Analyses/Consumed.h clang/include/clang/Parse/Parser.h clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGOpe

[PATCH] D150744: [NFC][CLANG] Fix uninitialized scalar field issues with Coverity

Manna updated this revision to Diff 523030. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150744/new/ https://reviews.llvm.org/D150744 Files: clang/include/clang/Analysis/Analyses/Consumed.h clang/include/clang/Parse/Parser.h clang/lib/AST/ExprConstant.cpp clang/lib/CodeGen/CGOpe

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

mboehme updated this revision to Diff 523031. mboehme added a comment. Renamed `forward...` functions to `propagate...`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150655/new/ https://reviews.llvm.org/D150655 Files: clang/lib/Analysis/FlowSen

[PATCH] D150656: [clang][dataflow] Use `Strict` accessors in TypeErasedDataflowAnalysis.cpp.

mboehme updated this revision to Diff 523032. mboehme added a comment. Applied suggested edit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150656/new/ https://reviews.llvm.org/D150656 Files: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowA

[PATCH] D150775: [clang][dataflow] Fix a bug in handling of `operator->` for optional checker.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Prior to this patch, `operator->` was being hand

[PATCH] D150776: [clang][dataflow] Use `Strict` accessors in comma operator and no-op cast.

mboehme created this revision. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. mboehme requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch is part of the ongoing migration to s

[PATCH] D150528: [Clang] Fix the diagnoses when the argument to alignas is an incomplete type

yronglin added a comment. In D150528#4343102 , @aaron.ballman wrote: > In D150528#4342646 , @yronglin > wrote: > >> In D150528#4342600 , >> @aaron.ballman wrote: >> >>>

[PATCH] D150635: [clangd] Implement end-definition-comment inlay hints

sammccall added a comment. In D150635#4348702 , @daiyousei-qz wrote: > Regarding to **Naming**, I agree that `EndDefinitionComment` sounds so > tedious but I couldn't come up with a better name. However, I think > `EndBlock` also feel a little strange

[PATCH] D150528: [Clang] Fix the diagnoses when the argument to alignas is an incomplete type

aaron.ballman added a comment. In D150528#4349711 , @yronglin wrote: > Sorry for the late reply and thanks for your tips! @aaron.ballman I followed > your advice to update this patch, and below AST generated by clang: > > class alignas(void *) Foo {}

[clang] 86221a1 - [clang][test][RISCV] Precommit zhinx coverage in Float16-arith.c test

Author: Alex Bradbury Date: 2023-05-17T14:45:02+01:00 New Revision: 86221a1281cf640814daa928fbfc15f6e45a0bed URL: https://github.com/llvm/llvm-project/commit/86221a1281cf640814daa928fbfc15f6e45a0bed DIFF: https://github.com/llvm/llvm-project/commit/86221a1281cf640814daa928fbfc15f6e45a0bed.diff

[PATCH] D150528: [Clang] Fix the diagnoses when the argument to alignas is an incomplete type

yronglin added a comment. In D150528#4349729 , @aaron.ballman wrote: > In D150528#4349711 , @yronglin > wrote: > >> Sorry for the late reply and thanks for your tips! @aaron.ballman I >> followed your advice t

[PATCH] D150718: [CUDA] Relax restrictions on GPU-side variadic functions

yaxunl added a comment. could make the diagnostic about variadic functions a deferred diagnostic, then the diag will only be emitted if the function is really emitted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150718/new/ https://reviews.llvm.

[PATCH] D149447: [clang][analyzer] Improve documentation of StdCLibraryFunctionArgs checker (NFC)

Szelethus accepted this revision. Szelethus added inline comments. This revision is now accepted and ready to land. Comment at: clang/docs/analyzer/checkers.rst:2476-2477 +suppressed. However, the assumption about the argument is still modeled. +For instance, if the argument to a

[PATCH] D150777: [clang][RISCV] Set HasLegalHalfType to true if zhinx is enabled

asb created this revision. asb added reviewers: craig.topper, kito-cheng, realqhc. Herald added subscribers: jobnoorman, luke, wingo, pmatos, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01

[PATCH] D150655: [clang][dataflow] Use `Strict` accessors in more places in Transfer.cpp.

mboehme marked an inline comment as done. mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Transfer.cpp:717-723 +Value *SubExprVal = Env.getValueStrict(*SubExpr); +if (SubExprVal == nullptr) return; -Env.setStorageLocation(*S, *SubE

[PATCH] D150656: [clang][dataflow] Use `Strict` accessors in TypeErasedDataflowAnalysis.cpp.

mboehme marked 2 inline comments as done. mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/TypeErasedDataflowAnalysis.cpp:303 - auto *InitStmtLoc = Env.getStorageLocation(*InitStmt, SkipPast::Reference); - if (InitStmtLoc == nullptr) -return; -

[PATCH] D150775: [clang][dataflow] Fix a bug in handling of `operator->` for optional checker.

ymandel accepted this revision. ymandel added a comment. This revision is now accepted and ready to land. Nice catch! Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:789 - // of these accessors. - .CaseOfCFGStmt(valueOperatorCall(

[clang] e55d52c - [AArch64] Don't redefine _LP64 and __LP64__

Author: John Brawn Date: 2023-05-17T15:21:20+01:00 New Revision: e55d52cd34fb7a6a6617639d147b9d0abaceeeab URL: https://github.com/llvm/llvm-project/commit/e55d52cd34fb7a6a6617639d147b9d0abaceeeab DIFF: https://github.com/llvm/llvm-project/commit/e55d52cd34fb7a6a6617639d147b9d0abaceeeab.diff LO

[PATCH] D150657: [clang][dataflow] Use `Strict` accessors in SignAnalysisTest.cpp.

mboehme marked 2 inline comments as done. mboehme added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/SignAnalysisTest.cpp:240 +// Returns the `Value` associated with `E` (which may be either a prvalue or +// glvalue). Creates a `Value` or `StorageLocation

[clang] 6a81e69 - [clang][dataflow] Remove unused parameter from `diagnoseUnwrapCall()`.

Author: Martin Braenne Date: 2023-05-17T14:27:58Z New Revision: 6a81e694ab806d257e43cbc2e32c06099d70cbd8 URL: https://github.com/llvm/llvm-project/commit/6a81e694ab806d257e43cbc2e32c06099d70cbd8 DIFF: https://github.com/llvm/llvm-project/commit/6a81e694ab806d257e43cbc2e32c06099d70cbd8.diff LOG

[PATCH] D150756: [clang][dataflow] Remove unused parameter from `diagnoseUnwrapCall()`.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6a81e694ab80: [clang][dataflow] Remove unused parameter from `diagnoseUnwrapCall()`. (authored by mboehme). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150

[PATCH] D150775: [clang][dataflow] Fix a bug in handling of `operator->` for optional checker.

mboehme added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:789 - // of these accessors. - .CaseOfCFGStmt(valueOperatorCall(std::nullopt), [](const CallExpr *E, yma

[PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

hans added a comment. In D144509#4349399 , @mstorsjo wrote: > In D144509#4349051 , @hans wrote: > >> In D144509#4347562 , @glandium >> wrote: >> >>> FYI, 65429b9af6a2c99d

[PATCH] D144654: [Lex] Warn when defining or undefining any builtin macro

john.brawn added a comment. This patch caused a failure in AArch64 buildbots due to AArch64TargetInfo::getTargetDefines redefining _LP64 and __LP64__. Fixed in https://reviews.llvm.org/rGe55d52cd34fb7a6a6617639d147b9d0abaceeeab. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D150775: [clang][dataflow] Fix a bug in handling of `operator->` for optional checker.

ymandel added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/Models/UncheckedOptionalAccessModel.cpp:789 - // of these accessors. - .CaseOfCFGStmt(valueOperatorCall(std::nullopt), [](const CallExpr *E, mbo

[PATCH] D147610: [RISCV][MC] Add support for experimental Zfbfmin extension

reames accepted this revision. reames added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147610/new/ https://reviews.llvm.org/D147610 ___ cfe-commits mailing list cfe-commits@l

  1   2   3   >